Skip to contentSkip to conversation

ARM: KVM: Remove pointless void pointer cast

PATCH In review Firo Yang 2 participants 2 messages Apr 23, 2015

Subsystems (3)
Arm (32-bit) KVM Kernel janitors
lore
Share & tools
lore

Firo Yang

author
#0 lore raw

PATCH 1/1 ARM: KVM: Remove pointless void pointer cast

No need to cast the void pointer returned by kmalloc() in arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd().

Signed-off-by Firo Yang <[email protected]>
---
 arch/arm/kvm/mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/kvm/mmu.c +2 -2
index 1d5accb..ce0bce4 100644
@@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm)
 		 * work.  This is not used by the hardware and we have no
 		 * alignment requirement for this allocation.
 		 */
-		pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
-				       GFP_KERNEL | __GFP_ZERO);
+		pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
+				GFP_KERNEL | __GFP_ZERO);
 
 		if (!pgd) {
 			kvm_free_hwpgd(hwpgd);
Signature · 1 line
2.1.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Firo Yang

No need to cast the void pointer returned by kmalloc() in arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd().

Signed-off-by Firo Yang <[email protected]>
---
 arch/arm/kvm/mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/kvm/mmu.c +0 -0
index 1d5accb..ce0bce4 100644

arch/arm/kvm/mmu.c int kvm_alloc_stage2_pgd(struct kvm *kvm) · line 698

Quoted 10 lines
arch/arm/kvm/mmu.c +2 -2
@@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm)
 		 * work.  This is not used by the hardware and we have no
 		 * alignment requirement for this allocation.
 		 */
-		pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
-				       GFP_KERNEL | __GFP_ZERO);
+		pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
+				GFP_KERNEL | __GFP_ZERO);
 
 		if (!pgd) {
 			kvm_free_hwpgd(hwpgd);
Acked-by Paolo Bonzini <[email protected]>