Skip to contentSkip to conversation

scsi: storvsc: Set the SRB flags correctly when no data transfer is needed

PATCH In review K. Y. Srinivasan 2 participants 3 messages Apr 24, 2015 – Apr 25, 2015

Subsystems (3)
Stable branch SCSI Hyper-V/Azure core and drivers
lore
Share & tools
lore

K. Y. Srinivasan

author
#0 lore raw

PATCH 1/1 scsi: storvsc: Set the SRB flags correctly when no data transfer is needed

Set the SRB flags correctly when there is no data transfer.

Cc <[email protected]>
Signed-off-by K. Y. Srinivasan <[email protected]>
Reviewed-by Long Li <[email protected]>
---
 drivers/scsi/storvsc_drv.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/scsi/storvsc_drv.c +1 -2
index d9dad90..3c6584f 100644
@@ -1600,8 +1600,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 		break;
 	default:
 		vm_srb->data_in = UNKNOWN_TYPE;
-		vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN |
-						     SRB_FLAGS_DATA_OUT);
+		vm_srb->win8_extension.srb_flags |= SRB_FLAGS_NO_DATA_TRANSFER;
 		break;
 	}
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 2 lines · K. Y. Srinivasan

Set the SRB flags correctly when there is no data transfer.

What are the user visible effects of this bug? We transfer bogus data?

regards,
dan carpenter

author
#2 lore raw
Quoted 14 lines

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: Saturday, April 25, 2015 12:05 AM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/1] scsi: storvsc: Set the SRB flags correctly when no data transfer is needed

Quoted 5 lines
Quoted 2 lines · K. Y. Srinivasan

Set the SRB flags correctly when there is no data transfer.

What are the user visible effects of this bug? We transfer bogus data?

No, we don't transfer any bogus data. However, some IHV drivers will return an error on some valid commands because of these flags being set.

Regards,

K. Y

Quoted 3 lines

regards,
dan carpenter