Skip to contentSkip to conversation

serial: ns16550: Remove hard-coded baud_divisor setting

PATCH New Axel Lin 2 participants 3 messages Apr 25, 2015

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 serial: ns16550: Remove hard-coded baud_divisor setting

This was accidentally added by commit dd0b0122bacc
"serial: ns16550: Add an option to specify the debug UART register shift". Remove it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/serial/ns16550.c | 1 -
 1 file changed, 1 deletion(-)
drivers/serial/ns16550.c +0 -1
index fd110b3..3d376d7 100644
@@ -255,7 +255,6 @@ void debug_uart_init(void)
 	 */
 	baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
 				    CONFIG_BAUDRATE);
-	baud_divisor = 13;
 	serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
 			 CONFIG_SYS_NS16550_IER);
 	serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT, UART_MCRVAL);
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 serial: ns16550: Remove hard-coded baud_divisor setting

Quoted 15 lines · Axel Lin

This was accidentally added by commit dd0b0122bacc
"serial: ns16550: Add an option to specify the debug UART register shift". Remove it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/serial/ns16550.c | 1 -
 1 file changed, 1 deletion(-)
drivers/serial/ns16550.c +0 -0
index fd110b3..3d376d7 100644

drivers/serial/ns16550.c void debug_uart_init(void) · line 260

Quoted 7 lines
drivers/serial/ns16550.c +0 -1
@@ -255,7 +255,6 @@ void debug_uart_init(void)
         */
        baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
                                    CONFIG_BAUDRATE);
-       baud_divisor = 13;
        serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
                         CONFIG_SYS_NS16550_IER);
        serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT,

UART_MCRVAL);

Quoted 5 lines

--
2.1.0

Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 serial: ns16550: Remove hard-coded baud_divisor setting

Quoted 24 lines · Simon Glass
Quoted 22 lines · Axel Lin

This was accidentally added by commit dd0b0122bacc
"serial: ns16550: Add an option to specify the debug UART register shift". Remove it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/serial/ns16550.c | 1 -
 1 file changed, 1 deletion(-)
drivers/serial/ns16550.c +0 -1
index fd110b3..3d376d7 100644
@@ -255,7 +255,6 @@ void debug_uart_init(void)
         */
        baud_divisor = calc_divisor(com_port, CONFIG_DEBUG_UART_CLOCK,
                                    CONFIG_BAUDRATE);
-       baud_divisor = 13;
        serial_out_shift(&com_port->ier, CONFIG_DEBUG_UART_SHIFT,
                         CONFIG_SYS_NS16550_IER);
        serial_out_shift(&com_port->mcr, CONFIG_DEBUG_UART_SHIFT,
Quoted 8 lines
Quoted 6 lines

UART_MCRVAL);
--
2.1.0

Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm, thanks!