Skip to contentSkip to conversation

dm: i2c-gpio: Remove redundant dm_gpio_set_value() call

PATCH New Axel Lin 2 participants 3 messages Apr 26, 2015 – May 5, 2015 I2C

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 dm: i2c-gpio: Remove redundant dm_gpio_set_value() call

dm_gpio_set_dir_flags() will also set gpio output value when switching to gpio output. So it's not necessary to call dm_gpio_set_value() after dm_gpio_set_dir_flags() call.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/i2c/i2c-gpio.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/i2c/i2c-gpio.c +7 -6
index ed899d4..a8b83c5 100644
@@ -41,18 +41,19 @@ static int i2c_gpio_sda_get(struct gpio_desc *sda)
 
 static void i2c_gpio_sda_set(struct gpio_desc *sda, int bit)
 {
-	if (bit) {
+	if (bit)
 		dm_gpio_set_dir_flags(sda, GPIOD_IS_IN);
-	} else {
+	else
 		dm_gpio_set_dir_flags(sda, GPIOD_IS_OUT);
-		dm_gpio_set_value(sda, 0);
-	}
 }
 
 static void i2c_gpio_scl_set(struct gpio_desc *scl, int bit)
 {
-	dm_gpio_set_dir_flags(scl, GPIOD_IS_OUT);
-	dm_gpio_set_value(scl, bit);
+	ulong flags = GPIOD_IS_OUT;
+
+	if (bit)
+		flags |= GPIOD_IS_OUT_ACTIVE;
+	dm_gpio_set_dir_flags(scl, flags);
 }
 
 static void i2c_gpio_write_bit(struct gpio_desc *scl, struct gpio_desc *sda,
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 dm: i2c-gpio: Remove redundant dm_gpio_set_value() call

Quoted 8 lines · Axel Lin

dm_gpio_set_dir_flags() will also set gpio output value when switching to gpio output. So it's not necessary to call dm_gpio_set_value() after dm_gpio_set_dir_flags() call.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/i2c/i2c-gpio.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 dm: i2c-gpio: Remove redundant dm_gpio_set_value() call

Quoted 11 lines · Simon Glass
Quoted 8 lines · Axel Lin

dm_gpio_set_dir_flags() will also set gpio output value when switching to gpio output. So it's not necessary to call dm_gpio_set_value() after dm_gpio_set_dir_flags() call.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/i2c/i2c-gpio.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
Acked-by Simon Glass <[email protected]>

Applied to u-boot-dm, thanks!