NFC: st21nfcb: Remove inappropriate kfree on a devm_kzalloc pointer

PATCH New Firo Yang 1 participant 1 message Apr 26, 2015

Subsystems (2)

Kernel janitors NFC

lore

Share & tools

lore

Firo Yang

author

2015-04-26 08:37 UTC #0 lore raw

PATCH 1/1 NFC: st21nfcb: Remove inappropriate kfree on a devm_kzalloc pointer

Since ndev->driver_data is alloced by devm_kzalloc(), we do not need the inappropriate kfree to free it in driver's remove function. Freeing will trigger when driver unloads, so I remove it.

Signed-off-by Firo Yang <[email protected]>

---
 drivers/nfc/st21nfcb/st21nfcb.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/nfc/st21nfcb/st21nfcb.c +0 -3

index ca9871a..c7dc282 100644
@@ -131,11 +131,8 @@ EXPORT_SYMBOL_GPL(st21nfcb_nci_probe);
 
 void st21nfcb_nci_remove(struct nci_dev *ndev)
 {
-	struct st21nfcb_nci_info *info = nci_get_drvdata(ndev);
-
 	nci_unregister_device(ndev);
 	nci_free_device(ndev);
-	kfree(info);
 }
 EXPORT_SYMBOL_GPL(st21nfcb_nci_remove);

Signature · 1 line

2.1.0