Skip to contentSkip to conversation

xfrm: remove the unnecessary checking before call xfrm_pol_hold

PATCH Applied [email protected] 2 participants 2 messages Apr 30, 2015 – May 5, 2015

Subsystems (3)
Networking Network drivers Networking IPsec
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 xfrm: remove the unnecessary checking before call xfrm_pol_hold

From: Li RongQing <[email protected]>

xfrm_pol_hold will check its input with NULL

Signed-off-by Li RongQing <[email protected]>
---
 net/xfrm/xfrm_policy.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
net/xfrm/xfrm_policy.c +3 -4
index 638af06..f576217 100644
@@ -1133,8 +1133,8 @@ static struct xfrm_policy *xfrm_policy_lookup_bytype(struct net *net, u8 type,
 			break;
 		}
 	}
-	if (ret)
-		xfrm_pol_hold(ret);
+
+	xfrm_pol_hold(ret);
 fail:
 	read_unlock_bh(&net->xfrm.xfrm_policy_lock);
 

@@ -3217,8 +3217,7 @@ static struct xfrm_policy *xfrm_migrate_policy_find(const struct xfrm_selector *
 		}
 	}
 
-	if (ret)
-		xfrm_pol_hold(ret);
+	xfrm_pol_hold(ret);
 
 	read_unlock_bh(&net->xfrm.xfrm_policy_lock);
Signature · 1 line
2.1.0