Skip to contentSkip to conversation

ARM: dts: imx6sl-warp: Remove unused regulator

PATCH New Fabio Estevam 3 participants 7 messages Apr 30, 2015 – May 11, 2015

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 ARM: dts: imx6sl-warp: Remove unused regulator

From: Fabio Estevam <[email protected]>

The 'reg_1p8v' regulator is not used anywhere, so let's remove it.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6sl-warp.dts | 8 --------
 1 file changed, 8 deletions(-)
arch/arm/boot/dts/imx6sl-warp.dts +0 -8
index 64f7dec..232597a 100644
@@ -82,14 +82,6 @@
 			gpio = <&gpio4 2 0>;
 			enable-active-high;
 		};
-
-		reg_1p8v: regulator at 2 {
-			compatible = "regulator-fixed";
-			reg = <2>;
-			regulator-name = "1P8V";
-			regulator-min-microvolt = <1800000>;
-			regulator-max-microvolt = <1800000>;
-		};
 	};
 
 	usdhc3_pwrseq: usdhc3_pwrseq {
Signature · 1 line
1.9.1
author reviewer
#1 lore raw

PATCH 2/3 ARM: dts: imx6sl-warp: Remove USB regulators

From: Fabio Estevam <[email protected]>

According to the warp schematics there are no regulators for the USB OTG ports, so let's remove them.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6sl-warp.dts | 28 ----------------------------
 1 file changed, 28 deletions(-)
arch/arm/boot/dts/imx6sl-warp.dts +0 -28
index 232597a..cec189a 100644
@@ -58,32 +58,6 @@
 		reg = <0x80000000 0x20000000>;
 	};
 
-	regulators {
-		compatible = "simple-bus";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		reg_usb_otg1_vbus: regulator at 0 {
-			compatible = "regulator-fixed";
-			reg = <0>;
-			regulator-name = "usb_otg1_vbus";
-			regulator-min-microvolt = <5000000>;
-			regulator-max-microvolt = <5000000>;
-			gpio = <&gpio4 0 0>;
-			enable-active-high;
-		};
-
-		reg_usb_otg2_vbus: regulator at 1 {
-			compatible = "regulator-fixed";
-			reg = <1>;
-			regulator-name = "usb_otg2_vbus";
-			regulator-min-microvolt = <5000000>;
-			regulator-max-microvolt = <5000000>;
-			gpio = <&gpio4 2 0>;
-			enable-active-high;
-		};
-	};
-
 	usdhc3_pwrseq: usdhc3_pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>, 	/* WL_REG_ON */

@@ -113,14 +87,12 @@
 };
 
 &usbotg1 {
-	vbus-supply = <&reg_usb_otg1_vbus>;
 	dr_mode = "host";
 	disable-over-current;
 	status = "okay";
 };
 
 &usbotg2 {
-	vbus-supply = <&reg_usb_otg2_vbus>;
 	disable-over-current;
 	status = "okay";
 };
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/3 ARM: dts: imx6sl-warp: Remove USB regulators

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

According to the warp schematics there are no regulators for the USB OTG ports, so let's remove them.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
author reviewer
#3 lore raw

PATCH 3/3 ARM: dts: imx6sl-warp: Fix OTG roles

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

USBOTG1 always work on peripheral mode and USBOTG in host mode, so fix their roles accordingly.

Tested by mounting the MMC card as a storage device:

modprobe g_mass_storage file=/dev/mmcblk0p2

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6sl-warp.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx6sl-warp.dts +2 -1
index cec189a..0da906b 100644
@@ -87,12 +87,13 @@
 };
 
 &usbotg1 {
-	dr_mode = "host";
+	dr_mode = "peripheral";
 	disable-over-current;
 	status = "okay";
 };
 
 &usbotg2 {
+	dr_mode = "host";
 	disable-over-current;
 	status = "okay";
 };
Signature · 1 line
1.9.1
#4 lore raw

PATCH 3/3 ARM: dts: imx6sl-warp: Fix OTG roles

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

USBOTG1 always work on peripheral mode and USBOTG in host mode, so fix their roles accordingly.

Tested by mounting the MMC card as a storage device:

modprobe g_mass_storage file=/dev/mmcblk0p2

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw

PATCH 1/3 ARM: dts: imx6sl-warp: Remove unused regulator

In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The 'reg_1p8v' regulator is not used anywhere, so let's remove it.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750