FAILED: patch "[PATCH] compal-laptop: Fix leaking hwmon device" failed to apply to 3.14-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 3.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
ad774702f1705c04e5fa492b793d8d477a504fa6Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Thu, 12 Mar 2015 08:43:59 +0100
Subject: [PATCH] compal-laptop: Fix leaking hwmon device
The commit c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") wanted to change the registering of hwmon device to resource-managed version. It mostly did it except the main thing - it forgot to use devm-like function so the hwmon device leaked after device removal or probe failure.
drivers/platform/x86/compal-laptop.c +3 -3
@@ -1026,9 +1026,9 @@ static int compal_probe(struct platform_device *pdev)if (err)return err; - hwmon_dev =hwmon_device_register_with_groups (&pdev->dev, -"compal" , data, - compal_hwmon_groups); + hwmon_dev =devm_hwmon_device_register_with_groups (&pdev->dev, +"compal" , data, + compal_hwmon_groups);if (IS_ERR (hwmon_dev)) { err =PTR_ERR (hwmon_dev); goto remove;