Patch "staging: panel: fix lcd type" has been added to the 4.0-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: panel: fix lcd type
to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-panel-fix-lcd-type.patch
and it can be found in the queue-4.0 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
2c20d92dad5db6440cfa88d811b69fd605240ce4Mon Sep 17 00:00:00 2001
From: Sudip Mukherjee <[email protected]>
Date: Tue, 24 Mar 2015 16:29:32 +0530
Subject: staging: panel: fix lcd type
From: Sudip Mukherjee <[email protected]>
commit 2c20d92dad5db6440cfa88d811b69fd605240ce4 upstream.
the lcd type as defined in the Kconfig is not matching in the code. as a result the rs, rw and en pins were getting interchanged. Kconfig defines the value of PANEL_LCD to be 1 if we select custom configuration but in the code LCD_TYPE_CUSTOM is defined as 5.
my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it as pins of LCD_TYPE_OLD, and it was not working.
Now values are corrected with referenece to the values defined in Kconfig and it is working.
checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.
--- drivers/staging/panel/panel.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/panel/panel.c +6 -6
@@ -335,11 +335,11 @@ static unsigned char lcd_bits[LCD_PORTS]* LCD types */ #define LCD_TYPE_NONE 0 -#define LCD_TYPE_OLD 1 -#define LCD_TYPE_KS0074 2 -#define LCD_TYPE_HANTRONIX 3 -#define LCD_TYPE_NEXCOM 4 -#define LCD_TYPE_CUSTOM 5 +#define LCD_TYPE_CUSTOM 1 +#define LCD_TYPE_OLD 2 +#define LCD_TYPE_KS0074 3 +#define LCD_TYPE_HANTRONIX 4 +#define LCD_TYPE_NEXCOM 5/* * keypad types
@@ -502,7 +502,7 @@ MODULE_PARM_DESC(keypad_type,static int lcd_type =NOT_SET ;module_param (lcd_type, int,0000 );MODULE_PARM_DESC (lcd_type, -"LCD type: 0=none, 1=old //, 2=serial ks0074, 3=hantronix //, 4=nexcom //, 5=compiled-in" ); +"LCD type: 0=none, 1=compiled-in, 2=old, 3=serial ks0074, 4=hantronix, 5=nexcom" );static int lcd_height =NOT_SET ;module_param (lcd_height, int,0000 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.0/staging-panel-fix-lcd-type.patch