Skip to contentSkip to conversation

Patch "iser-target: Fix session hang in case of an rdma read DIF error" has been added to the 3.19-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iser-target: Fix session hang in case of an rdma read DIF error

to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iser-target-fix-session-hang-in-case-of-an-rdma-read-dif-error.patch
and it can be found in the queue-3.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 364189f0ada5478e4faf8a552d6071a650d757cd Mon Sep 17 00:00:00 2001

From: Sagi Grimberg <[email protected]>
Date: Sun, 29 Mar 2015 15:52:03 +0300
Subject: iser-target: Fix session hang in case of an rdma read DIF error

From: Sagi Grimberg <[email protected]>

commit 364189f0ada5478e4faf8a552d6071a650d757cd upstream.

This hang was a result of a missing command put when a DIF error occurred during a rdma read (and we sent an CHECK_CONDITION error without passing it to the backend).

---
 drivers/infiniband/ulp/isert/ib_isert.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/infiniband/ulp/isert/ib_isert.c +4 -2
@@ -1848,11 +1848,13 @@ isert_completion_rdma_read(struct iser_t
 	cmd->i_state = ISTATE_RECEIVED_LAST_DATAOUT;
 	spin_unlock_bh(&cmd->istate_lock);
 
-	if (ret)
+	if (ret) {
+		target_put_sess_cmd(se_cmd->se_sess, se_cmd);
 		transport_send_check_condition_and_sense(se_cmd,
 							 se_cmd->pi_err, 0);
-	else
+	} else {
 		target_execute_cmd(se_cmd);
+	}
 }
 
 static void

Patches currently in stable-queue which might be from [email protected] are

queue-3.19/target-file-fix-bug-when-config_debug_sg-y-and-dif-protection-enabled.patch queue-3.19/target-file-fix-unmap-with-dif-protection-support.patch queue-3.19/iser-target-fix-session-hang-in-case-of-an-rdma-read-dif-error.patch queue-3.19/sd-unregister-integrity-profile.patch queue-3.19/target-file-fix-sg-table-for-prot_buf-initialization.patch queue-3.19/iser-target-fix-possible-deadlock-in-rdma_cm-connection-error.patch queue-3.19/sd-fix-missing-ato-tag-check.patch