Skip to contentSkip to conversation

Patch "UBI: account for bitflips in both the VID header and data" has been added to the 3.19-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

UBI: account for bitflips in both the VID header and data

to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ubi-account-for-bitflips-in-both-the-vid-header-and-data.patch
and it can be found in the queue-3.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 Mon Sep 17 00:00:00 2001

From: Brian Norris <[email protected]>
Date: Sat, 28 Feb 2015 02:23:25 -0800
Subject: UBI: account for bitflips in both the VID header and data

From: Brian Norris <[email protected]>

commit 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 upstream.

We are completely discarding the earlier value of 'bitflips', which could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the bitwise OR of header and data 'bitflip' statuses instead.

Coverity CID #1226856

---
 drivers/mtd/ubi/attach.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/attach.c +1 -1
@@ -410,7 +410,7 @@ int ubi_compare_lebs(struct ubi_device *
 		second_is_newer = !second_is_newer;
 	} else {
 		dbg_bld("PEB %d CRC is OK", pnum);
-		bitflips = !!err;
+		bitflips |= !!err;
 	}
 	mutex_unlock(&ubi->buf_mutex);
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.19/ubi-initialize-leb-number-variable.patch queue-3.19/ubi-fix-out-of-bounds-write.patch queue-3.19/ubi-account-for-bitflips-in-both-the-vid-header-and-data.patch queue-3.19/ubi-fix-check-for-too-many-bytes.patch