Patch "[media] stk1160: Make sure current buffer is released" has been added to the 3.19-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
[media] stk1160: Make sure current buffer is released
to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
stk1160-make-sure-current-buffer-is-released.patch
and it can be found in the queue-3.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
aeff09276748b66072f2db2e668cec955cf41959Mon Sep 17 00:00:00 2001
From: Ezequiel Garcia <[email protected]>
Date: Tue, 10 Mar 2015 11:37:14 -0300
Subject: [media] stk1160: Make sure current buffer is released
From: Ezequiel Garcia <[email protected]>
commit aeff09276748b66072f2db2e668cec955cf41959 upstream.
The available (i.e. not used) buffers are returned by stk1160_clear_queue(), on the stop_streaming() path. However, this is insufficient and the current buffer must be released as well. Fix it.
--- drivers/media/usb/stk1160/stk1160-v4l.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/media/usb/stk1160/stk1160-v4l.c +15 -2
@@ -244,6 +244,11 @@ static int stk1160_stop_streaming(structif (mutex_lock_interruptible (&dev->v4l_lock))return -ERESTARTSYS ; +/* +* Once URBs are cancelled, the URB complete handler +* won't be running. This is required to safely release the +* current buffer (dev->isoc_ctl.buf). +*/ stk1160_cancel_isoc (dev);/*
@@ -624,8 +629,16 @@ void stk1160_clear_queue(struct stk1160stk1160_info ("buffer [%p/%d] aborted\n" , buf, buf->vb.v4l2_buf.index); } -/* It's important to clear current buffer */ - dev->isoc_ctl.buf =NULL ; + +/* It's important to release the current buffer */ +if (dev->isoc_ctl.buf) { + buf = dev->isoc_ctl.buf; + dev->isoc_ctl.buf =NULL ; + +vb2_buffer_done (&buf->vb,VB2_BUF_STATE_ERROR ); +stk1160_info ("buffer [%p/%d] aborted\n" , + buf, buf->vb.v4l2_buf.index); + }spin_unlock_irqrestore (&dev->buf_lock, flags); }
Patches currently in stable-queue which might be from [email protected] are
queue-3.19/stk1160-make-sure-current-buffer-is-released.patch