Patch "drm/exynos: Enable DP clock to fix display on Exynos5250 and other" has been added to the 4.0-stable tree
Subsystems (6)
This is a note to let you know that I've just added the patch titled
drm/exynos: Enable DP clock to fix display on Exynos5250 and other
to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-exynos-enable-dp-clock-to-fix-display-on-exynos5250-and-other.patch
and it can be found in the queue-4.0 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
1c363c7cccf64128087002b0779986ad16aff6dcMon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Tue, 7 Apr 2015 22:28:50 +0900
Subject: drm/exynos: Enable DP clock to fix display on Exynos5250 and other
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Krzysztof Kozlowski <[email protected]>
commit 1c363c7cccf64128087002b0779986ad16aff6dc upstream.
After adding display power domain for Exynos5250 in commit 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the display on Chromebook Snow and others stopped working after boot.
The reason for this suggested Andrzej Hajda: the DP clock was disabled. This clock is required by Display Port and is enabled by bootloader. However when FIMD driver probing was deferred, the display power domain was turned off. This effectively reset the value of DP clock enable register.
When exynos-dp is later probed, the clock is not enabled and display is not properly configured:
exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok exynos-dp 145b0000.dp-controller: unable to config video
--- drivers/gpu/drm/exynos/exynos_dp_core.c | 10 ++++++++++ drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++++++++++++++++++ drivers/gpu/drm/exynos/exynos_drm_fimd.h | 15 +++++++++++++++ include/video/samsung_fimd.h | 6 ++++++ 4 files changed, 50 insertions(+)
drivers/gpu/drm/exynos/exynos_dp_core.c +10 -0
@@ -32,10 +32,16 @@#include <drm/bridge/ptn3460.h> #include "exynos_dp_core.h" +#include "exynos_drm_fimd.h" #define ctx_from_connector (c) container_of(c, struct exynos_dp_device, \ connector) +static inline struct exynos_drm_crtc *dp_to_crtc (struct exynos_dp_device *dp) +{ +return to_exynos_crtc (dp->encoder->crtc); +} +static inline struct exynos_dp_device *display_to_dp (struct exynos_drm_display *d) {
@@ -1070,6 +1076,8 @@ static void exynos_dp_poweron(struct exy } } +fimd_dp_clock_enable (dp_to_crtc (dp), true); +clk_prepare_enable (dp->clock);exynos_dp_phy_init (dp);exynos_dp_init_dp (dp);
@@ -1094,6 +1102,8 @@ static void exynos_dp_poweroff(struct exexynos_dp_phy_exit (dp);clk_disable_unprepare (dp->clock); +fimd_dp_clock_enable (dp_to_crtc (dp), false); +if (dp->panel) {if (drm_panel_unprepare (dp->panel))DRM_ERROR ("failed to turnoff the panel\n" );
drivers/gpu/drm/exynos/exynos_drm_fimd.c +19 -0
@@ -32,6 +32,7 @@#include "exynos_drm_fbdev.h" #include "exynos_drm_crtc.h" #include "exynos_drm_iommu.h" +#include "exynos_drm_fimd.h" /* * FIMD stands for Fully Interactive Mobile Display and
@@ -1233,6 +1234,24 @@ static int fimd_remove(struct platform_dreturn 0 ; } +void fimd_dp_clock_enable (struct exynos_drm_crtc *crtc,bool enable) +{ +struct fimd_context *ctx = crtc->ctx; +u32 val; + +/* +* Only Exynos 5250, 5260, 5410 and 542x requires enabling DP/MIE +* clock. On these SoCs the bootloader may enable it but any +* power domain off/on will reset it to disable state. +*/ +if (ctx->driver_data != &exynos5_fimd_driver_data) +return ; + + val = enable ?DP_MIE_CLK_DP_ENABLE :DP_MIE_CLK_DISABLE ; +writel (DP_MIE_CLK_DP_ENABLE , ctx->regs +DP_MIE_CLKCON ); +} +EXPORT_SYMBOL_GPL (fimd_dp_clock_enable); +struct platform_driver fimd_driver = { .probe = fimd_probe, .remove = fimd_remove,
drivers/gpu/drm/exynos/exynos_drm_fimd.h new file +15 -0
@@ -0,0 +1,15 @@ +/* +* Copyright (c) 2015 Samsung Electronics Co., Ltd. +* +* This program is free software; you can redistribute it and/or modify it +* under the terms of the GNU General Public License as published by the +* Free Software Foundation; either version 2 of the License, or (at your +* option) any later version. +*/ + +#ifndef _EXYNOS_DRM_FIMD_H_ +#define _EXYNOS_DRM_FIMD_H_ + +extern void fimd_dp_clock_enable (struct exynos_drm_crtc *crtc,bool enable); + +#endif /* _EXYNOS_DRM_FIMD_H_ */
include/video/samsung_fimd.h +6 -0
@@ -436,6 +436,12 @@#define BLENDCON_NEW_8BIT_ALPHA_VALUE (1 << 0)#define BLENDCON_NEW_4BIT_ALPHA_VALUE (0 << 0) +/* Display port clock control */ +#define DP_MIE_CLKCON 0x27c +#define DP_MIE_CLK_DISABLE 0x0 +#define DP_MIE_CLK_DP_ENABLE 0x2 +#define DP_MIE_CLK_MIE_ENABLE 0x3 +/* Notes on per-window bpp settings * * Value Win0 Win1 Win2 Win3 Win 4
Patches currently in stable-queue which might be from [email protected] are
queue-4.0/compal-laptop-fix-leaking-hwmon-device.patch queue-4.0/compal-laptop-check-return-value-of-power_supply_register.patch queue-4.0/power_supply-twl4030_madc-check-return-value-of-power_supply_register.patch queue-4.0/clk-samsung-exynos4-disable-armclk-down-feature-on-exynos4210-soc.patch queue-4.0/power_supply-ipaq_micro_battery-fix-leaking-workqueue.patch queue-4.0/power_supply-lp8788-charger-fix-leaked-power-supply-on-probe-fail.patch queue-4.0/drm-exynos-enable-dp-clock-to-fix-display-on-exynos5250-and-other.patch queue-4.0/power_supply-ipaq_micro_battery-check-return-values-in-probe.patch