Skip to contentSkip to conversation

Patch "nfsd4: disallow SEEK with special stateids" has been added to the 3.19-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

nfsd4: disallow SEEK with special stateids

to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfsd4-disallow-seek-with-special-stateids.patch
and it can be found in the queue-3.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 980608fb50aea34993ba956b71cd4602aa42b14b Mon Sep 17 00:00:00 2001

From: "J. Bruce Fields" <[email protected]>
Date: Tue, 21 Apr 2015 15:25:39 -0400
Subject: nfsd4: disallow SEEK with special stateids

From: "J. Bruce Fields" <[email protected]>

commit 980608fb50aea34993ba956b71cd4602aa42b14b upstream.

If the client uses a special stateid then we'll pass a NULL file to vfs_llseek.

Fixes 24bab491220f " NFSD: Implement SEEK"
Cc Anna Schumaker <[email protected]>
---
 fs/nfsd/nfs4proc.c |    2 ++
 1 file changed, 2 insertions(+)
fs/nfsd/nfs4proc.c +2 -0
@@ -1069,6 +1069,8 @@ nfsd4_seek(struct svc_rqst *rqstp, struc
 		dprintk("NFSD: nfsd4_seek: couldn't process stateid!\n");
 		return status;
 	}
+	if (!file)
+		return nfserr_bad_stateid;
 
 	switch (seek->seek_whence) {
 	case NFS4_CONTENT_DATA:

Patches currently in stable-queue which might be from [email protected] are

queue-3.19/nfsd4-disallow-seek-with-special-stateids.patch queue-3.19/nfsd-eliminate-nfsd_debug.patch queue-3.19/nfsd4-fix-read-permission-checking.patch queue-3.19/nfsd4-disallow-allocate-with-special-stateids.patch