Convert some skb_<foo> functions to void
Subsystems (55)
cover Convert some skb_<foo> functions to void
unsigned char * return values are sometimes awkward to work with. Changing the return to void * is sometimes clearer.
The only uses of the return type is to do sets like
*skb_puts(skb, 1) = char;
Adding another function specifically for that purpose allows the return type to become void.
Joe Perches (8):
skb: Add skb_put_uchar
treewide: Use skb_put_uchar
skb: Add skb_push_uchar
treewide: Use skb_push_uchar
skbuff: Convert skb_put to return void *
treewide: Remove unnecessary casts from skb_puts
skbuff: Convert skb_push to return void *
treewide: Remove unnecessary casts from skb_push
drivers/atm/atmtcp.c | 4 +- drivers/atm/solos-pci.c | 14 +-- drivers/bluetooth/bfusb.c | 2 +- drivers/bluetooth/bluecard_cs.c | 4 +- drivers/bluetooth/bpa10x.c | 2 +- drivers/bluetooth/bt3c_cs.c | 4 +- drivers/bluetooth/btmrvl_main.c | 2 +- drivers/bluetooth/btuart_cs.c | 4 +- drivers/bluetooth/btusb.c | 6 +- drivers/bluetooth/btwilink.c | 2 +- drivers/bluetooth/dtl1_cs.c | 4 +- drivers/bluetooth/hci_ath.c | 2 +- drivers/bluetooth/hci_bcm.c | 2 +- drivers/bluetooth/hci_bcsp.c | 12 +- drivers/bluetooth/hci_h4.c | 2 +- drivers/bluetooth/hci_h5.c | 4 +- drivers/bluetooth/hci_ll.c | 4 +- drivers/bluetooth/hci_vhci.c | 6 +- drivers/firewire/net.c | 8 +- drivers/infiniband/hw/cxgb3/cxio_hal.c | 4 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 30 ++--- drivers/infiniband/hw/cxgb3/iwch_qp.c | 4 +- drivers/infiniband/hw/cxgb4/cm.c | 26 ++--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- drivers/isdn/act2000/capi.c | 4 +- drivers/isdn/act2000/module.c | 2 +- drivers/isdn/hisax/isar.c | 6 +- drivers/isdn/i4l/isdn_audio.c | 4 +- drivers/media/dvb-core/dvb_net.c | 2 +- drivers/media/radio/wl128x/fmdrv_common.c | 4 +- drivers/net/arcnet/arc-rawmode.c | 2 +- drivers/net/arcnet/capmode.c | 2 +- drivers/net/arcnet/rfc1051.c | 2 +- drivers/net/arcnet/rfc1201.c | 2 +- drivers/net/bonding/bond_3ad.c | 4 +- drivers/net/can/dev.c | 4 +- drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +- drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- drivers/net/ethernet/chelsio/cxgb/sge.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +- drivers/net/ethernet/davicom/dm9000.c | 2 +- drivers/net/ethernet/dnet.c | 2 +- drivers/net/ethernet/freescale/gianfar.c | 2 +- drivers/net/ethernet/hp/hp100.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 4 +- drivers/net/ethernet/micrel/ks8842.c | 4 +- drivers/net/ethernet/sfc/selftest.c | 3 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/sun/sunvnet.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +- drivers/net/hippi/rrunner.c | 2 +- drivers/net/ppp/ppp_generic.c | 2 +- drivers/net/ppp/pppoe.c | 2 +- drivers/net/usb/cdc_ncm.c | 2 +- drivers/net/usb/gl620a.c | 2 +- drivers/net/usb/lg-vl600.c | 2 +- drivers/net/usb/net1080.c | 6 +- drivers/net/usb/zaurus.c | 8 +- drivers/net/vxlan.c | 2 +- drivers/net/wan/hdlc_ppp.c | 2 +- drivers/net/wimax/i2400m/netdev.c | 2 +- drivers/net/wireless/adm8211.c | 2 +- drivers/net/wireless/airo.c | 4 +- drivers/net/wireless/ath/ar5523/ar5523.c | 4 +- drivers/net/wireless/ath/ath6kl/debug.c | 2 +- drivers/net/wireless/ath/ath6kl/htc_pipe.c | 9 +- drivers/net/wireless/ath/ath9k/channel.c | 2 +- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- drivers/net/wireless/ath/ath9k/htc_hst.c | 12 +- drivers/net/wireless/ath/ath9k/wmi.c | 4 +- drivers/net/wireless/ath/carl9170/tx.c | 2 +- drivers/net/wireless/ath/wil6210/txrx.c | 2 +- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +- drivers/net/wireless/cw1200/txrx.c | 2 +- drivers/net/wireless/hostap/hostap_80211_rx.c | 8 +- drivers/net/wireless/hostap/hostap_ap.c | 4 +- drivers/net/wireless/hostap/hostap_main.c | 3 +- drivers/net/wireless/ipw2x00/ipw2200.c | 2 +- drivers/net/wireless/ipw2x00/libipw_tx.c | 6 +- drivers/net/wireless/libertas/rx.c | 2 +- drivers/net/wireless/libertas_tf/main.c | 2 +- drivers/net/wireless/mac80211_hwsim.c | 12 +- drivers/net/wireless/mwifiex/11n_aggr.c | 2 +- drivers/net/wireless/mwifiex/tdls.c | 30 ++--- drivers/net/wireless/orinoco/main.c | 7 +- drivers/net/wireless/p54/fwio.c | 43 ++++--- drivers/net/wireless/p54/txrx.c | 4 +- drivers/net/wireless/prism54/islpci_eth.c | 5 +- drivers/net/wireless/rt2x00/rt2x00debug.c | 2 +- drivers/net/wireless/rtl818x/rtl8187/dev.c | 6 +- drivers/net/wireless/rtlwifi/base.c | 4 +- drivers/net/wireless/rtlwifi/pci.c | 2 +- drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +- drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192ee/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192se/fw.c | 5 +- drivers/net/wireless/rtlwifi/rtl8723ae/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8723be/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8821ae/fw.c | 8 +- drivers/net/wireless/ti/wl1251/tx.c | 3 +- drivers/net/wireless/ti/wlcore/cmd.c | 4 +- drivers/net/wireless/ti/wlcore/main.c | 2 +- drivers/net/wireless/ti/wlcore/tx.c | 3 +- drivers/net/wireless/zd1211rw/zd_mac.c | 3 +- drivers/nfc/microread/i2c.c | 6 +- drivers/nfc/microread/microread.c | 8 +- drivers/nfc/nfcwilink.c | 3 +- drivers/nfc/pn533.c | 30 ++--- drivers/nfc/pn544/i2c.c | 8 +- drivers/nfc/pn544/pn544.c | 8 +- drivers/nfc/port100.c | 4 +- drivers/nfc/st21nfca/i2c.c | 10 +- drivers/nfc/st21nfca/st21nfca.c | 6 +- drivers/nfc/st21nfca/st21nfca_dep.c | 30 ++--- drivers/nfc/st21nfcb/ndlc.c | 2 +- drivers/s390/net/qeth_l2_main.c | 3 +- drivers/s390/net/qeth_l3_main.c | 6 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- drivers/scsi/fcoe/fcoe.c | 2 +- drivers/scsi/fcoe/fcoe_ctlr.c | 4 +- drivers/scsi/fnic/fnic_fcs.c | 7 +- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +- drivers/staging/ozwpan/ozpd.c | 6 +- drivers/staging/ozwpan/ozproto.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 +- drivers/staging/rtl8192e/rtllib_softmac.c | 34 ++---- drivers/staging/rtl8192e/rtllib_tx.c | 3 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 21 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 8 +- drivers/staging/rtl8712/rtl8712_recv.c | 2 +- drivers/staging/wlan-ng/p80211conv.c | 14 +-- drivers/usb/gadget/function/f_ncm.c | 19 ++-- drivers/usb/gadget/function/rndis.c | 2 +- include/linux/if_vlan.h | 2 +- include/linux/skbuff.h | 6 +- lib/nlattr.c | 2 +- net/802/fc.c | 4 +- net/802/fddi.c | 2 +- net/802/hippi.c | 2 +- net/8021q/vlan_dev.c | 2 +- net/appletalk/ddp.c | 4 +- net/atm/clip.c | 2 +- net/atm/signaling.c | 2 +- net/ax25/af_ax25.c | 2 +- net/batman-adv/icmp_socket.c | 2 +- net/bluetooth/hci_request.c | 2 +- net/bluetooth/hci_sock.c | 12 +- net/bluetooth/hidp/core.c | 2 +- net/bluetooth/l2cap_core.c | 16 +-- net/bluetooth/mgmt_util.c | 10 +- net/bluetooth/rfcomm/core.c | 4 +- net/bridge/netfilter/nft_reject_bridge.c | 6 +- net/core/netpoll.c | 4 +- net/core/pktgen.c | 38 ++++--- net/core/skbuff.c | 48 ++++++++ net/dccp/options.c | 2 +- net/decnet/dn_dev.c | 6 +- net/decnet/dn_nsp_out.c | 18 +-- net/ethernet/eth.c | 2 +- net/ipv4/arp.c | 2 +- net/ipv4/igmp.c | 6 +- net/ipv4/ip_gre.c | 2 +- net/ipv4/ipconfig.c | 2 +- net/ipv4/ipmr.c | 2 +- net/ipv4/netfilter/ipt_SYNPROXY.c | 10 +- net/ipv4/netfilter/nf_reject_ipv4.c | 4 +- net/ipv6/exthdrs.c | 4 +- net/ipv6/ip6_gre.c | 2 +- net/ipv6/mcast.c | 6 +- net/ipv6/ndisc.c | 8 +- net/ipv6/netfilter/ip6t_SYNPROXY.c | 10 +- net/ipv6/netfilter/nf_reject_ipv6.c | 2 +- net/ipv6/tcp_ipv6.c | 2 +- net/irda/irlap_frame.c | 17 ++- net/iucv/af_iucv.c | 3 +- net/key/af_key.c | 124 +++++++++------------ net/mac80211/agg-rx.c | 2 +- net/mac80211/agg-tx.c | 4 +- net/mac80211/cfg.c | 4 +- net/mac80211/debugfs_netdev.c | 2 +- net/mac80211/ht.c | 4 +- net/mac80211/mesh.c | 4 +- net/mac80211/mesh_hwmp.c | 4 +- net/mac80211/mesh_plink.c | 2 +- net/mac80211/mesh_ps.c | 2 +- net/mac80211/mlme.c | 4 +- net/mac80211/rx.c | 4 +- net/mac80211/spectmgmt.c | 2 +- net/mac80211/sta_info.c | 2 +- net/mac80211/status.c | 2 +- net/mac80211/tdls.c | 14 +-- net/mac80211/tx.c | 11 +- net/mac80211/util.c | 4 +- net/mac80211/wpa.c | 6 +- net/netfilter/nfnetlink_log.c | 2 +- net/netfilter/nfnetlink_queue_core.c | 2 +- net/netlink/af_netlink.c | 2 +- net/nfc/digital_core.c | 4 +- net/nfc/digital_dep.c | 2 +- net/nfc/digital_technology.c | 20 ++-- net/nfc/hci/core.c | 4 +- net/nfc/hci/llc_shdlc.c | 12 +- net/nfc/llcp_commands.c | 2 +- net/nfc/nci/core.c | 2 +- net/nfc/nci/data.c | 2 +- net/nfc/nci/hci.c | 6 +- net/nfc/nci/spi.c | 12 +- net/phonet/datagram.c | 2 +- net/sctp/output.c | 2 +- net/sctp/sm_make_chunk.c | 2 +- net/sctp/sm_statefuns.c | 4 +- net/sctp/ulpevent.c | 29 ++--- net/wireless/util.c | 2 +- 223 files changed, 674 insertions(+), 706 deletions(-)
Signature · 1 line
2.1.4
RFC PATCH 1/8 skb: Add skb_put_uchar
skb_put currently returns an unsigned char *.
There are uses like "*skb_put(skb, 1) = <char>" that might be better represented by a new skb_put_uchar(<char>) function.
This would allow the skb_put function to be converted to return void and eliminate many casts of the unsigned char * return to some other type.
--- include/linux/skbuff.h | 1 + net/core/skbuff.c | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+)
include/linux/skbuff.h +1 -0
@@ -1679,6 +1679,7 @@ static inline void skb_set_tail_pointer(struct sk_buff *skb, const int offset)*/ unsigned char *pskb_put (struct sk_buff *skb,struct sk_buff *tail,int len);unsigned char *skb_put (struct sk_buff *skb,unsigned int len); +void *skb_put_uchar (struct sk_buff *skb,unsigned char uc);static inline unsigned char *__skb_put (struct sk_buff *skb,unsigned int len) {unsigned char *tmp =skb_tail_pointer (skb);
net/core/skbuff.c +26 -0
@@ -1410,6 +1410,32 @@ unsigned char *skb_put(struct sk_buff *skb, unsigned int len)EXPORT_SYMBOL (skb_put);/** +* skb_put_uchar - add an unsigned char to a buffer +* @skb: buffer to use +* @uc: unsigned char to add +* +* This function extends the used data area of the buffer. If this would +* exceed the total buffer size the kernel will panic. A pointer to the +* first byte of the extra data is returned. +*/ +void *skb_put_uchar (struct sk_buff *skb,unsigned char uc) +{ +unsigned char *tmp =skb_tail_pointer (skb); + +SKB_LINEAR_ASSERT (skb); + + skb->tail++; + skb->len++; +if (unlikely (skb->tail > skb->end)) +skb_over_panic (skb,1 ,__builtin_return_address (0 )); + + *tmp = uc; + +return tmp; +} +EXPORT_SYMBOL (skb_put_uchar); + +/** * skb_push - add data to the start of a buffer * @skb: buffer to use * @len: amount of data to add
Signature · 1 line
2.1.4
RFC PATCH 2/8 treewide: Use skb_put_uchar
In reply to Joe PerchesConvert the uses of
*skb_put(skb, 1) = <uchar>; and memcpy(skb_put(skb, 1), &<uchar>, 1);
to the new skb_put_uchar(skb, <uchar>);
This will allow skb_put to return void * to avoid some casts.
Done via cocci script:
@@
expression skb;
expression e1;
@@
- *skb_put(skb, 1) = e1;
+ skb_put_uchar(skb, e1);
@@
expression skb;
expression e1;
expression e2;
@@
- memcpy(skb_put(skb, 1), &e1, e2);
+ skb_put_uchar(skb, e1);
--- drivers/bluetooth/bluecard_cs.c | 2 +- drivers/bluetooth/bt3c_cs.c | 2 +- drivers/bluetooth/btuart_cs.c | 2 +- drivers/bluetooth/btusb.c | 2 +- drivers/bluetooth/dtl1_cs.c | 4 ++-- drivers/bluetooth/hci_bcsp.c | 10 +++++----- drivers/bluetooth/hci_h5.c | 4 ++-- drivers/bluetooth/hci_vhci.c | 4 ++-- drivers/net/usb/cdc_ncm.c | 2 +- drivers/net/usb/net1080.c | 2 +- drivers/net/usb/zaurus.c | 8 ++++---- drivers/nfc/microread/i2c.c | 4 ++-- drivers/nfc/microread/microread.c | 4 ++-- drivers/nfc/pn533.c | 30 +++++++++++++++--------------- drivers/nfc/pn544/i2c.c | 6 +++--- drivers/nfc/port100.c | 4 ++-- drivers/nfc/st21nfca/i2c.c | 6 +++--- net/bluetooth/hidp/core.c | 2 +- net/decnet/dn_nsp_out.c | 12 ++++++------ net/nfc/digital_core.c | 4 ++-- net/nfc/digital_dep.c | 2 +- net/nfc/digital_technology.c | 12 ++++++------ net/nfc/hci/core.c | 2 +- net/nfc/hci/llc_shdlc.c | 4 ++-- net/nfc/llcp_commands.c | 2 +- net/nfc/nci/hci.c | 2 +- net/nfc/nci/spi.c | 8 ++++---- 27 files changed, 73 insertions(+), 73 deletions(-)
drivers/bluetooth/bluecard_cs.c +1 -1
@@ -447,7 +447,7 @@ static void bluecard_receive(struct bluecard_info *info, }else { - *skb_put (info->rx_skb,1 ) = buf[i]; +skb_put_uchar (info->rx_skb, buf[i]); info->rx_count--;if (info->rx_count ==0 ) {
drivers/bluetooth/bt3c_cs.c +1 -1
@@ -285,7 +285,7 @@ static void bt3c_receive(struct bt3c_info *info)__u8 x =inb (iobase +DATA_L ); - *skb_put (info->rx_skb,1 ) = x; +skb_put_uchar (info->rx_skb, x);inb (iobase +DATA_H ); info->rx_count--;
drivers/bluetooth/btuart_cs.c +1 -1
@@ -233,7 +233,7 @@ static void btuart_receive(struct btuart_info *info) }else { - *skb_put (info->rx_skb,1 ) =inb (iobase +UART_RX ); +skb_put_uchar (info->rx_skb,inb (iobase +UART_RX )); info->rx_count--;if (info->rx_count ==0 ) {
drivers/bluetooth/btusb.c +1 -1
@@ -1726,7 +1726,7 @@ static int inject_cmd_complete(struct hci_dev *hdev, __u16 opcode) evt->ncmd =0x01 ; evt->opcode =cpu_to_le16 (opcode); - *skb_put (skb,1 ) =0x00 ; +skb_put_uchar (skb,0x00 );bt_cb (skb)->pkt_type =HCI_EVENT_PKT ;
drivers/bluetooth/dtl1_cs.c +2 -2
@@ -226,7 +226,7 @@ static void dtl1_receive(struct dtl1_info *info) } } - *skb_put (info->rx_skb,1 ) =inb (iobase +UART_RX ); +skb_put_uchar (info->rx_skb,inb (iobase +UART_RX )); nsh = (struct nsh *)info->rx_skb->data; info->rx_count--;
@@ -418,7 +418,7 @@ static int dtl1_hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)skb_reserve (s,NSHL );skb_copy_from_linear_data (skb,skb_put (s, skb->len), skb->len);if (skb->len &0x0001 ) - *skb_put (s,1 ) =0 ;/* PAD */ +skb_put_uchar (s,0 );/* PAD */ /* Prepend skb with Nokia frame header and queue */ memcpy (skb_push (s,NSHL ), &nsh,NSHL );
drivers/bluetooth/hci_bcsp.c +5 -5
@@ -125,7 +125,7 @@ static void bcsp_slip_msgdelim(struct sk_buff *skb) {const char pkt_delim =0xc0 ; -memcpy (skb_put (skb,1 ), &pkt_delim,1 ); +skb_put_uchar (skb, pkt_delim); }static void bcsp_slip_one_byte (struct sk_buff *skb,u8 c)
@@ -141,7 +141,7 @@ static void bcsp_slip_one_byte(struct sk_buff *skb, u8 c)memcpy (skb_put (skb,2 ), &esc_db,2 );break ;default : -memcpy (skb_put (skb,1 ), &c,1 ); +skb_put_uchar (skb, c); } }
@@ -435,7 +435,7 @@ static inline void bcsp_unslip_one_byte(struct bcsp_struct *bcsp, unsigned char bcsp->rx_esc_state =BCSP_ESCSTATE_ESC ;break ;default : -memcpy (skb_put (bcsp->rx_skb,1 ), &byte,1 ); +skb_put_uchar (bcsp->rx_skb, byte);if ((bcsp->rx_skb-> data[0 ] &0x40 ) !=0 && bcsp->rx_state !=BCSP_W4_CRC )bcsp_crc_update (&bcsp->message_crc, byte);
@@ -446,7 +446,7 @@ static inline void bcsp_unslip_one_byte(struct bcsp_struct *bcsp, unsigned charcase BCSP_ESCSTATE_ESC :switch (byte) {case 0xdc : -memcpy (skb_put (bcsp->rx_skb,1 ), &c0,1 ); +skb_put_uchar (bcsp->rx_skb, c0);if ((bcsp->rx_skb-> data[0 ] &0x40 ) !=0 && bcsp->rx_state !=BCSP_W4_CRC )bcsp_crc_update (&bcsp-> message_crc,0xc0 );
@@ -455,7 +455,7 @@ static inline void bcsp_unslip_one_byte(struct bcsp_struct *bcsp, unsigned charbreak ;case 0xdd : -memcpy (skb_put (bcsp->rx_skb,1 ), &db,1 ); +skb_put_uchar (bcsp->rx_skb, db);if ((bcsp->rx_skb-> data[0 ] &0x40 ) !=0 && bcsp->rx_state !=BCSP_W4_CRC )bcsp_crc_update (&bcsp-> message_crc,0xdb );
drivers/bluetooth/hci_h5.c +2 -2
@@ -585,7 +585,7 @@ static void h5_slip_delim(struct sk_buff *skb) {const char delim =SLIP_DELIMITER ; -memcpy (skb_put (skb,1 ), &delim,1 ); +skb_put_uchar (skb, delim); }static void h5_slip_one_byte (struct sk_buff *skb,u8 c)
@@ -601,7 +601,7 @@ static void h5_slip_one_byte(struct sk_buff *skb, u8 c)memcpy (skb_put (skb,2 ), &esc_esc,2 );break ;default : -memcpy (skb_put (skb,1 ), &c,1 ); +skb_put_uchar (skb, c); } }
drivers/bluetooth/hci_vhci.c +2 -2
@@ -150,8 +150,8 @@ static int vhci_create_device(struct vhci_data *data, __u8 opcode)bt_cb (skb)->pkt_type =HCI_VENDOR_PKT ; - *skb_put (skb,1 ) =0xff ; - *skb_put (skb,1 ) = opcode; +skb_put_uchar (skb,0xff ); +skb_put_uchar (skb, opcode);put_unaligned_le16 (hdev->id,skb_put (skb,2 ));skb_queue_tail (&data->readq, skb);
drivers/net/usb/cdc_ncm.c +1 -1
@@ -1164,7 +1164,7 @@ cdc_ncm_fill_tx_frame(struct usbnet *dev, struct sk_buff *skb, __le32 sign)memset (skb_put (skb_out, ctx->tx_max - skb_out->len),0 , ctx->tx_max - skb_out->len); else if (skb_out->len < ctx->tx_max && (skb_out->len % dev->maxpacket) == 0) - *skb_put(skb_out, 1) = 0; /* force short packet */ + skb_put_uchar(skb_out, 0); /* force short packet *//* set final frame length */ nth16 = (struct usb_cdc_ncm_nth16 *)skb_out->data;
drivers/net/usb/net1080.c +1 -1
@@ -482,7 +482,7 @@ encapsulate:/* maybe pad; then trailer */ if (!((skb->len +sizeof *trailer) &0x01 )) - *skb_put (skb,1 ) =PAD_BYTE ; +skb_put_uchar (skb,PAD_BYTE ); trailer = (struct nc_trailer *)skb_put (skb,sizeof *trailer);put_unaligned (header->packet_id, &trailer->packet_id);#if 0
drivers/net/usb/zaurus.c +4 -4
@@ -74,10 +74,10 @@ done: fcs =crc32_le (~0 , skb->data, skb->len); fcs = ~fcs; - *skb_put (skb,1 ) = fcs &0xff ; - *skb_put (skb,1 ) = (fcs>>8 ) &0xff ; - *skb_put (skb,1 ) = (fcs>>16 ) &0xff ; - *skb_put (skb,1 ) = (fcs>>24 ) &0xff ; +skb_put_uchar (skb, fcs); +skb_put_uchar (skb, fcs >>8 ); +skb_put_uchar (skb, fcs >>16 ); +skb_put_uchar (skb, fcs >>24 ); }return skb; }
drivers/nfc/microread/i2c.c +2 -2
@@ -77,7 +77,7 @@ static void microread_i2c_add_len_crc(struct sk_buff *skb)for (i =0 ; i < skb->len; i++) crc = crc ^ skb->data[i]; - *skb_put (skb,1 ) = crc; +skb_put_uchar (skb, crc); }static void microread_i2c_remove_len_crc (struct sk_buff *skb)
@@ -175,7 +175,7 @@ static int microread_i2c_read(struct microread_i2c_phy *phy, goto flush; } - *skb_put (*skb,1 ) = len; +skb_put_uchar (*skb, len); r =i2c_master_recv (client,skb_put (*skb, len), len);if (r != len) {
drivers/nfc/microread/microread.c +2 -2
@@ -441,8 +441,8 @@ static int microread_im_transceive(struct nfc_hci_dev *hdev, crc =crc_ccitt (0xffff , skb->data, skb->len); crc = ~crc; - *skb_put (skb,1 ) = crc &0xff ; - *skb_put (skb,1 ) = crc >>8 ; +skb_put_uchar (skb, crc &0xff ); +skb_put_uchar (skb, crc >>8 );break ;case MICROREAD_GATE_ID_MREAD_NFC_T3 : control_bits =0xDB ;
drivers/nfc/pn533.c +15 -15
@@ -1587,7 +1587,7 @@ static struct sk_buff *pn533_alloc_poll_tg_frame(struct pn533 *dev)return NULL ;/* DEP support only */ - *skb_put (skb,1 ) =PN533_INIT_TARGET_DEP ; +skb_put_uchar (skb,PN533_INIT_TARGET_DEP );/* MIFARE params */ memcpy (skb_put (skb,6 ), mifare_params,6 );
@@ -1603,13 +1603,13 @@ static struct sk_buff *pn533_alloc_poll_tg_frame(struct pn533 *dev)memcpy (nfcid3, felica,8 );/* General bytes */ - *skb_put (skb,1 ) = gbytes_len; +skb_put_uchar (skb, gbytes_len); gb =skb_put (skb, gbytes_len);memcpy (gb, gbytes, gbytes_len);/* Len Tk */ - *skb_put (skb,1 ) =0 ; +skb_put_uchar (skb,0 );return skb; }
@@ -1844,8 +1844,8 @@ static void pn533_wq_rf(struct work_struct *work)if (!skb)return ; - *skb_put (skb,1 ) =PN533_CFGITEM_RF_FIELD ; - *skb_put (skb,1 ) =PN533_CFGITEM_RF_FIELD_AUTO_RFCA ; +skb_put_uchar (skb,PN533_CFGITEM_RF_FIELD ); +skb_put_uchar (skb,PN533_CFGITEM_RF_FIELD_AUTO_RFCA ); rc =pn533_send_cmd_async (dev,PN533_CMD_RF_CONFIGURATION , skb, pn533_rf_complete,NULL );
@@ -1941,8 +1941,8 @@ static int pn533_poll_dep(struct nfc_dev *nfc_dev)if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) =0x01 ;/* Active */ - *skb_put (skb,1 ) =0x02 ;/* 424 kbps */ +skb_put_uchar (skb,0x01 );/* Active */ +skb_put_uchar (skb,0x02 );/* 424 kbps */ next =skb_put (skb,1 );/* Next */ *next =0 ;
@@ -2190,8 +2190,8 @@ static int pn533_activate_target_nfcdep(struct pn533 *dev)if (!skb)return -ENOMEM ; - *skb_put (skb,sizeof (u8)) =1 ;/* TG */ - *skb_put (skb,sizeof (u8)) =0 ;/* Next */ +skb_put_uchar (skb,1 );/* TG */ +skb_put_uchar (skb,0 );/* Next */ resp =pn533_send_cmd_sync (dev,PN533_CMD_IN_ATR , skb);if (IS_ERR (resp))
@@ -2284,7 +2284,7 @@ static void pn533_deactivate_target(struct nfc_dev *nfc_dev,if (!skb)return ; - *skb_put (skb,1 ) =1 ;/* TG*/ +skb_put_uchar (skb,1 );/* TG*/ resp =pn533_send_cmd_sync (dev,PN533_CMD_IN_RELEASE , skb);if (IS_ERR (resp))
@@ -2400,8 +2400,8 @@ static int pn533_dep_link_up(struct nfc_dev *nfc_dev, struct nfc_target *target,if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) = !comm_mode;/* ActPass */ - *skb_put (skb,1 ) =0x02 ;/* 424 kbps */ +skb_put_uchar (skb, !comm_mode);/* ActPass */ +skb_put_uchar (skb,0x02 );/* 424 kbps */ next =skb_put (skb,1 );/* Next */ *next =0 ;
@@ -2782,7 +2782,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)break ; }default : - *skb_put (skb,sizeof (u8)) =1 ;/*TG*/ +skb_put_uchar (skb,1 );/*TG*/ rc = pn533_send_cmd_direct_async(dev, PN533_CMD_IN_DATA_EXCHANGE,
@@ -2877,7 +2877,7 @@ static int pn533_set_configuration(struct pn533 *dev, u8 cfgitem, u8 *cfgdata,if (!skb)return -ENOMEM ; - *skb_put (skb,sizeof (cfgitem)) = cfgitem; +skb_put_uchar (skb, cfgitem);memcpy (skb_put (skb, cfgdata_len), cfgdata, cfgdata_len); resp =pn533_send_cmd_sync (dev,PN533_CMD_RF_CONFIGURATION , skb);
@@ -2922,7 +2922,7 @@ static int pn533_pasori_fw_reset(struct pn533 *dev)if (!skb)return -ENOMEM ; - *skb_put (skb,sizeof (u8)) =0x1 ; +skb_put_uchar (skb,0x1 ); resp =pn533_send_cmd_sync (dev,0x18 , skb);if (IS_ERR (resp))
drivers/nfc/pn544/i2c.c +3 -3
@@ -293,8 +293,8 @@ static void pn544_hci_i2c_add_len_crc(struct sk_buff *skb) crc =crc_ccitt (0xffff , skb->data, skb->len); crc = ~crc; - *skb_put (skb,1 ) = crc &0xff ; - *skb_put (skb,1 ) = crc >>8 ; +skb_put_uchar (skb, crc &0xff ); +skb_put_uchar (skb, crc >>8 ); }static void pn544_hci_i2c_remove_len_crc (struct sk_buff *skb)
@@ -397,7 +397,7 @@ static int pn544_hci_i2c_read(struct pn544_i2c_phy *phy, struct sk_buff **skb) goto flush; } - *skb_put (*skb,1 ) = len; +skb_put_uchar (*skb, len); r =i2c_master_recv (client,skb_put (*skb, len), len);if (r != len) {
drivers/nfc/port100.c +2 -2
@@ -915,7 +915,7 @@ static int port100_set_command_type(struct port100 *dev, u8 command_type)if (!skb)return -ENOMEM ; - *skb_put (skb,sizeof (u8)) = command_type; +skb_put_uchar (skb, command_type); resp =port100_send_cmd_sync (dev,PORT100_CMD_SET_COMMAND_TYPE , skb);if (IS_ERR (resp))
@@ -983,7 +983,7 @@ static int port100_switch_rf(struct nfc_digital_dev *ddev, bool on)if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) = on ?1 :0 ; +skb_put_uchar (skb, on ?1 :0 ); resp =port100_send_cmd_sync (dev,PORT100_CMD_SWITCH_RF , skb);
drivers/nfc/st21nfca/i2c.c +3 -3
@@ -183,10 +183,10 @@ static void st21nfca_hci_add_len_crc(struct sk_buff *skb) crc = ~crc; tmp = crc &0x00ff ; - *skb_put (skb,1 ) = tmp; +skb_put_uchar (skb, tmp); tmp = (crc >>8 ) &0x00ff ; - *skb_put (skb,1 ) = tmp; +skb_put_uchar (skb, tmp); }static void st21nfca_hci_remove_len_crc (struct sk_buff *skb)
@@ -221,7 +221,7 @@ static int st21nfca_hci_i2c_write(void *phy_id, struct sk_buff *skb)st21nfca_hci_add_len_crc (skb);/* add ST21NFCA_SOF_EOF on tail */ - *skb_put (skb,1 ) =ST21NFCA_SOF_EOF ; +skb_put_uchar (skb,ST21NFCA_SOF_EOF );/* add ST21NFCA_SOF_EOF on head */ *skb_push (skb,1 ) =ST21NFCA_SOF_EOF ;
net/bluetooth/hidp/core.c +1 -1
@@ -112,7 +112,7 @@ static int hidp_send_message(struct hidp_session *session, struct socket *sock,return -ENOMEM ; } - *skb_put (skb,1 ) = hdr; +skb_put_uchar (skb, hdr);if (data && size >0 )memcpy (skb_put (skb, size), data, size);
net/decnet/dn_nsp_out.c +6 -6
@@ -530,7 +530,7 @@ void dn_send_conn_conf(struct sock *sk, gfp_t gfp) msg->info = scp->info_loc; msg->segsize =cpu_to_le16 (scp->segsize_loc); - *skb_put (skb,1 ) = len; +skb_put_uchar (skb, len);if (len >0 )memcpy (skb_put (skb, len), scp->conndata_out.opt_data, len);
@@ -686,25 +686,25 @@ void dn_nsp_send_conninit(struct sock *sk, unsigned char msgflg)if (scp->peer.sdn_flags &SDF_UICPROXY ) menuver |=DN_MENUVER_UIC ; - *skb_put (skb,1 ) = menuver;/* Menu Version */ +skb_put_uchar (skb, menuver);/* Menu Version */ aux = scp->accessdata.acc_userl; - *skb_put (skb,1 ) = aux; +skb_put_uchar (skb, aux);if (aux >0 )memcpy (skb_put (skb, aux), scp->accessdata.acc_user, aux); aux = scp->accessdata.acc_passl; - *skb_put (skb,1 ) = aux; +skb_put_uchar (skb, aux);if (aux >0 )memcpy (skb_put (skb, aux), scp->accessdata.acc_pass, aux); aux = scp->accessdata.acc_accl; - *skb_put (skb,1 ) = aux; +skb_put_uchar (skb, aux);if (aux >0 )memcpy (skb_put (skb, aux), scp->accessdata.acc_acc, aux); aux = (__u8 )le16_to_cpu (scp->conndata_out.opt_optl); - *skb_put (skb,1 ) = aux; +skb_put_uchar (skb, aux);if (aux >0 )memcpy (skb_put (skb, aux), scp->conndata_out.opt_data, aux);
net/nfc/digital_core.c +2 -2
@@ -70,8 +70,8 @@ void digital_skb_add_crc(struct sk_buff *skb, crc_func_t crc_func, u16 init,if (msb_first) crc =__fswab16 (crc); - *skb_put (skb,1 ) = crc &0xFF ; - *skb_put (skb,1 ) = (crc >>8 ) &0xFF ; +skb_put_uchar (skb, crc &0xFF ); +skb_put_uchar (skb, (crc >>8 ) &0xFF ); } int digital_skb_check_crc(struct sk_buff *skb, crc_func_t crc_func,
net/nfc/digital_dep.c +1 -1
@@ -612,7 +612,7 @@ static int digital_in_send_rtox(struct nfc_digital_dev *ddev,if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) = rtox; +skb_put_uchar (skb, rtox);skb_push (skb,sizeof (struct digital_dep_req_res ));
net/nfc/digital_technology.c +6 -6
@@ -266,8 +266,8 @@ static int digital_in_send_rats(struct nfc_digital_dev *ddev,if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) =DIGITAL_RATS_BYTE1 ; - *skb_put (skb,1 ) =DIGITAL_RATS_PARAM ; +skb_put_uchar (skb,DIGITAL_RATS_BYTE1 ); +skb_put_uchar (skb,DIGITAL_RATS_PARAM ); rc =digital_in_send_cmd (ddev, skb,30 , digital_in_recv_ats, target);
@@ -470,8 +470,8 @@ static int digital_in_send_sdd_req(struct nfc_digital_dev *ddev,else sel_cmd =DIGITAL_CMD_SEL_REQ_CL3 ; - *skb_put (skb,sizeof (u8)) = sel_cmd; - *skb_put (skb,sizeof (u8)) =DIGITAL_SDD_REQ_SEL_PAR ; +skb_put_uchar (skb, sel_cmd); +skb_put_uchar (skb,DIGITAL_SDD_REQ_SEL_PAR );return digital_in_send_cmd (ddev, skb,30 , digital_in_recv_sdd_res, target);
@@ -541,7 +541,7 @@ int digital_in_send_sens_req(struct nfc_digital_dev *ddev, u8 rf_tech)if (!skb)return -ENOMEM ; - *skb_put (skb,sizeof (u8)) =DIGITAL_CMD_SENS_REQ ; +skb_put_uchar (skb,DIGITAL_CMD_SENS_REQ ); rc =digital_in_send_cmd (ddev, skb,30 , digital_in_recv_sens_res,NULL );if (rc)
@@ -939,7 +939,7 @@ static int digital_tg_send_sel_res(struct nfc_digital_dev *ddev)if (!skb)return -ENOMEM ; - *skb_put (skb,1 ) =DIGITAL_SEL_RES_NFC_DEP ; +skb_put_uchar (skb,DIGITAL_SEL_RES_NFC_DEP );if (!DIGITAL_DRV_CAPS_TG_CRC (ddev))digital_skb_add_crc_a (skb);
net/nfc/hci/core.c +1 -1
@@ -873,7 +873,7 @@ static void nfc_hci_recv_from_llc(struct nfc_hci_dev *hdev, struct sk_buff *skb)return ; } - *skb_put (hcp_skb,NFC_HCI_HCP_PACKET_HEADER_LEN ) = pipe; +skb_put_uchar (hcp_skb, pipe); skb_queue_walk(&hdev->rx_hcp_frags, frag_skb) { msg_len = frag_skb->len -NFC_HCI_HCP_PACKET_HEADER_LEN ;
net/nfc/hci/llc_shdlc.c +2 -2
@@ -382,8 +382,8 @@ static int llc_shdlc_connect_initiate(struct llc_shdlc *shdlc)if (skb ==NULL )return -ENOMEM ; - *skb_put (skb,1 ) =SHDLC_MAX_WINDOW ; - *skb_put (skb,1 ) =SHDLC_SREJ_SUPPORT ?1 :0 ; +skb_put_uchar (skb,SHDLC_MAX_WINDOW ); +skb_put_uchar (skb,SHDLC_SREJ_SUPPORT ?1 :0 );return llc_shdlc_send_u_frame (shdlc, skb,U_FRAME_RSET ); }
net/nfc/llcp_commands.c +1 -1
@@ -623,7 +623,7 @@ int nfc_llcp_send_dm(struct nfc_llcp_local *local, u8 ssap, u8 dsap, u8 reason) skb =llcp_add_header (skb, dsap, ssap,LLCP_PDU_DM ); -memcpy (skb_put (skb,1 ), &reason,1 ); +skb_put_uchar (skb, reason);skb_queue_head (&local->tx_queue, skb);
net/nfc/nci/hci.c +1 -1
@@ -431,7 +431,7 @@ void nci_hci_data_received_cb(void *context,return ; } - *skb_put (hcp_skb,NCI_HCI_HCP_PACKET_HEADER_LEN ) = pipe; +skb_put_uchar (hcp_skb, pipe); skb_queue_walk(&ndev->hci_dev->rx_hcp_frags, frag_skb) { msg_len = frag_skb->len -NCI_HCI_HCP_PACKET_HEADER_LEN ;
net/nfc/nci/spi.c +4 -4
@@ -83,8 +83,8 @@ int nci_spi_send(struct nci_spi *nspi,u16 crc; crc =crc_ccitt (CRC_INIT , skb->data, skb->len); - *skb_put (skb,1 ) = crc >>8 ; - *skb_put (skb,1 ) = crc &0xFF ; +skb_put_uchar (skb, crc >>8 ); +skb_put_uchar (skb, crc &0xFF ); }if (write_handshake_completion) {
@@ -168,8 +168,8 @@ static int send_acknowledge(struct nci_spi *nspi, u8 acknowledge) hdr[3 ] =0 ; crc =crc_ccitt (CRC_INIT , skb->data, skb->len); - *skb_put (skb,1 ) = crc >>8 ; - *skb_put (skb,1 ) = crc &0xFF ; +skb_put_uchar (skb, crc >>8 ); +skb_put_uchar (skb, crc &0xFF ); ret =__nci_spi_send (nspi, skb,0 );
Signature · 1 line
2.1.4
RFC PATCH 3/8 skb: Add skb_push_uchar
In reply to Joe Perchesskb_push currently returns an unsigned char *.
There are uses like "*skb_push(skb, 1) = <char>" that might be better represented by a new skb_push_uchar(<char>) function.
This would allow the skb_push function to be converted to return void and eliminate many casts of the unsigned char * return to some other type.
--- include/linux/skbuff.h | 1 + net/core/skbuff.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+)
include/linux/skbuff.h +1 -0
@@ -1690,6 +1690,7 @@ static inline unsigned char *__skb_put(struct sk_buff *skb, unsigned int len) }unsigned char *skb_push (struct sk_buff *skb,unsigned int len); +void *skb_push_uchar (struct sk_buff *skb,unsigned char uc);static inline unsigned char *__skb_push (struct sk_buff *skb,unsigned int len) { skb->data -= len;
net/core/skbuff.c +22 -0
@@ -1455,6 +1455,28 @@ unsigned char *skb_push(struct sk_buff *skb, unsigned int len)EXPORT_SYMBOL (skb_push);/** +* skb_push_uchar - add an unsigned char to the start of a buffer +* @skb: buffer to use +* @uc: unsigned char to add +* +* This function extends the used data area of the buffer at the buffer +* start. If this would exceed the total buffer headroom the kernel will +* panic. A pointer to the first byte of the extra data is returned. +*/ +void *skb_push_uchar (struct sk_buff *skb,unsigned char uc) +{ + skb->data--; + skb->len++; +if (unlikely (skb->data<skb->head)) +skb_under_panic (skb,1 ,__builtin_return_address (0 )); + + *skb->data = uc; + +return skb->data; +} +EXPORT_SYMBOL (skb_push_uchar); + +/** * skb_pull - remove data from the start of a buffer * @skb: buffer to use * @len: amount of data to remove
Signature · 1 line
2.1.4
RFC PATCH 4/8 treewide: Use skb_push_uchar
In reply to Joe PerchesConvert the uses of
*skb_push(skb, 1) = <uchar>;
and
memcpy(skb_push(skb, 1), &<uchar>, 1);to the new skb_push_uchar(skb, <uchar>);
This will allow skb_push to return void * to avoid some casts.
Done via cocci script:
@@
expression skb;
expression e1;
@@
- *skb_push(skb, 1) = e1;
+ skb_push_uchar(skb, e1);
@@
expression skb;
expression e1;
expression e2;
@@
- memcpy(skb_push(skb, 1), &e1, e2);
+ skb_push_uchar(skb, e1);
--- drivers/bluetooth/bfusb.c | 2 +- drivers/bluetooth/bluecard_cs.c | 2 +- drivers/bluetooth/bpa10x.c | 2 +- drivers/bluetooth/bt3c_cs.c | 2 +- drivers/bluetooth/btuart_cs.c | 2 +- drivers/bluetooth/btwilink.c | 2 +- drivers/bluetooth/hci_ath.c | 2 +- drivers/bluetooth/hci_bcm.c | 2 +- drivers/bluetooth/hci_bcsp.c | 2 +- drivers/bluetooth/hci_h4.c | 2 +- drivers/bluetooth/hci_ll.c | 2 +- drivers/bluetooth/hci_vhci.c | 2 +- drivers/media/radio/wl128x/fmdrv_common.c | 2 +- drivers/net/ppp/ppp_generic.c | 2 +- drivers/nfc/microread/i2c.c | 2 +- drivers/nfc/microread/microread.c | 4 ++-- drivers/nfc/pn544/i2c.c | 2 +- drivers/nfc/pn544/pn544.c | 8 ++++---- drivers/nfc/st21nfca/i2c.c | 4 ++-- drivers/nfc/st21nfca/st21nfca.c | 6 +++--- drivers/nfc/st21nfca/st21nfca_dep.c | 30 +++++++++++++++--------------- drivers/nfc/st21nfcb/ndlc.c | 2 +- net/ax25/af_ax25.c | 2 +- net/bluetooth/hci_sock.c | 2 +- net/dccp/options.c | 2 +- net/nfc/digital_technology.c | 2 +- net/nfc/hci/core.c | 2 +- net/nfc/hci/llc_shdlc.c | 8 ++++---- net/nfc/nci/hci.c | 4 ++-- net/nfc/nci/spi.c | 4 ++-- 30 files changed, 56 insertions(+), 56 deletions(-)
drivers/bluetooth/bfusb.c +1 -1
@@ -495,7 +495,7 @@ static int bfusb_send_frame(struct hci_dev *hdev, struct sk_buff *skb) };/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type); count = skb->len;
drivers/bluetooth/bluecard_cs.c +1 -1
@@ -679,7 +679,7 @@ static int bluecard_hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb) }/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&(info->txq), skb);bluecard_write_wakeup (info);
drivers/bluetooth/bpa10x.c +1 -1
@@ -370,7 +370,7 @@ static int bpa10x_send_frame(struct hci_dev *hdev, struct sk_buff *skb)return -ENOMEM ;/* Prepend skb with frame type */ - *skb_push (skb,1 ) =bt_cb (skb)->pkt_type; +skb_push_uchar (skb,bt_cb (skb)->pkt_type);switch (bt_cb (skb)->pkt_type) {case HCI_COMMAND_PKT :
drivers/bluetooth/bt3c_cs.c +1 -1
@@ -434,7 +434,7 @@ static int bt3c_hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb) };/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&(info->txq), skb);spin_lock_irqsave (&(info->lock), flags);
drivers/bluetooth/btuart_cs.c +1 -1
@@ -443,7 +443,7 @@ static int btuart_hci_send_frame(struct hci_dev *hdev, struct sk_buff *skb) }/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&(info->txq), skb);btuart_write_wakeup (info);
drivers/bluetooth/btwilink.c +1 -1
@@ -262,7 +262,7 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb) hst =hci_get_drvdata (hdev);/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);BT_DBG ("%s: type %d len %d" , hdev->name,bt_cb (skb)->pkt_type, skb->len);
drivers/bluetooth/hci_ath.c +1 -1
@@ -173,7 +173,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)BT_DBG ("hu %p skb %p" , hu, skb);/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&ath->txq, skb);set_bit (HCI_UART_SENDING , &hu->tx_state);
drivers/bluetooth/hci_bcm.c +1 -1
@@ -117,7 +117,7 @@ static int bcm_enqueue(struct hci_uart *hu, struct sk_buff *skb)BT_DBG ("hu %p skb %p" , hu, skb);/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&bcm->txq, skb);return 0 ;
drivers/bluetooth/hci_bcsp.c +1 -1
@@ -518,7 +518,7 @@ static void bcsp_complete_rx_pkt(struct hci_uart *hu)if (hciextn) { desc |=0xc0 ;skb_pull (bcsp->rx_skb,4 ); -memcpy (skb_push (bcsp->rx_skb,1 ), &desc,1 ); +skb_push_uchar (bcsp->rx_skb, desc); hdr.evt =0xff ; hdr.plen = bcsp->rx_skb->len;
drivers/bluetooth/hci_h4.c +1 -1
@@ -108,7 +108,7 @@ static int h4_enqueue(struct hci_uart *hu, struct sk_buff *skb)BT_DBG ("hu %p skb %p" , hu, skb);/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&h4->txq, skb);return 0 ;
drivers/bluetooth/hci_ll.c +1 -1
@@ -307,7 +307,7 @@ static int ll_enqueue(struct hci_uart *hu, struct sk_buff *skb)BT_DBG ("hu %p skb %p" , hu, skb);/* Prepend skb with frame type */ -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);/* lock hcill state */ spin_lock_irqsave (&ll->hcill_lock, flags);
drivers/bluetooth/hci_vhci.c +1 -1
@@ -88,7 +88,7 @@ static int vhci_send_frame(struct hci_dev *hdev, struct sk_buff *skb)if (!test_bit (HCI_RUNNING , &hdev->flags))return -EBUSY ; -memcpy (skb_push (skb,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb,bt_cb (skb)->pkt_type);skb_queue_tail (&data->readq, skb);wake_up_interruptible (&data->read_wait);
drivers/media/radio/wl128x/fmdrv_common.c +1 -1
@@ -1464,7 +1464,7 @@ static long fm_st_receive(void *arg, struct sk_buff *skb)return -EINVAL ; } -memcpy (skb_push (skb,1 ), &skb->cb[0 ],1 ); +skb_push_uchar (skb, skb->cb[0 ]);skb_queue_tail (&fmdev->rx_q, skb);tasklet_schedule (&fmdev->rx_task);
drivers/net/ppp/ppp_generic.c +1 -1
@@ -1972,7 +1972,7 @@ ppp_receive_mp_frame(struct ppp *ppp, struct sk_buff *skb, struct channel *pch)* Do protocol ID decompression on the first fragment of each packet. */ if ((PPP_MP_CB (skb)->BEbits &B ) && (skb->data[0 ] &1 )) - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 );/* * Expand sequence number to 32 bits, making it as close
drivers/nfc/microread/i2c.c +1 -1
@@ -72,7 +72,7 @@ static void microread_i2c_add_len_crc(struct sk_buff *skb)int len; len = skb->len; - *skb_push (skb,1 ) = len; +skb_push_uchar (skb, len);for (i =0 ; i < skb->len; i++) crc = crc ^ skb->data[i];
drivers/nfc/microread/microread.c +2 -2
@@ -419,7 +419,7 @@ static int microread_im_transceive(struct nfc_hci_dev *hdev,pr_info ("data exchange to gate 0x%x\n" , target->hci_reader_gate);if (target->hci_reader_gate ==MICROREAD_GATE_ID_P2P_INITIATOR ) { - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 ); return nfc_hci_send_event(hdev, target->hci_reader_gate, MICROREAD_EVT_P2P_INITIATOR_EXCHANGE_TO_RF,
@@ -453,7 +453,7 @@ static int microread_im_transceive(struct nfc_hci_dev *hdev,return 1 ; } - *skb_push (skb,1 ) = control_bits; +skb_push_uchar (skb, control_bits); info->async_cb_type =MICROREAD_CB_TYPE_READER_ALL ; info->async_cb = cb;
drivers/nfc/pn544/i2c.c +1 -1
@@ -289,7 +289,7 @@ static void pn544_hci_i2c_add_len_crc(struct sk_buff *skb)int len; len = skb->len +2 ; - *skb_push (skb,1 ) = len; +skb_push_uchar (skb, len); crc =crc_ccitt (0xffff , skb->data, skb->len); crc = ~crc;
drivers/nfc/pn544/pn544.c +4 -4
@@ -649,8 +649,8 @@ static int pn544_hci_im_transceive(struct nfc_hci_dev *hdev, }else return 1 ;case PN544_RF_READER_F_GATE : - *skb_push (skb,1 ) =0 ; - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 ); +skb_push_uchar (skb,0 ); info->async_cb_type =PN544_CB_TYPE_READER_F ; info->async_cb = cb;
@@ -665,7 +665,7 @@ static int pn544_hci_im_transceive(struct nfc_hci_dev *hdev,PN544_JEWEL_RAW_CMD , skb->data, skb->len, cb, cb_context);case PN544_RF_READER_NFCIP1_INITIATOR_GATE : - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 ); return nfc_hci_send_event(hdev, target->hci_reader_gate, PN544_HCI_EVT_SND_DATA, skb->data,
@@ -680,7 +680,7 @@ static int pn544_hci_tm_send(struct nfc_hci_dev *hdev, struct sk_buff *skb)int r;/* Set default false for multiple information chaining */ - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 ); r =nfc_hci_send_event (hdev,PN544_RF_READER_NFCIP1_TARGET_GATE ,PN544_HCI_EVT_SND_DATA , skb->data, skb->len);
drivers/nfc/st21nfca/i2c.c +2 -2
@@ -177,7 +177,7 @@ static void st21nfca_hci_add_len_crc(struct sk_buff *skb)u16 crc;u8 tmp; - *skb_push (skb,1 ) =0 ; +skb_push_uchar (skb,0 ); crc =crc_ccitt (0xffff , skb->data, skb->len); crc = ~crc;
@@ -223,7 +223,7 @@ static int st21nfca_hci_i2c_write(void *phy_id, struct sk_buff *skb)/* add ST21NFCA_SOF_EOF on tail */ skb_put_uchar (skb,ST21NFCA_SOF_EOF );/* add ST21NFCA_SOF_EOF on head */ - *skb_push (skb,1 ) =ST21NFCA_SOF_EOF ; +skb_push_uchar (skb,ST21NFCA_SOF_EOF );/* * Compute byte stuffing
drivers/nfc/st21nfca/st21nfca.c +3 -3
@@ -800,12 +800,12 @@ static int st21nfca_hci_im_transceive(struct nfc_hci_dev *hdev,if (target->supported_protocols ==NFC_PROTO_NFC_DEP_MASK )return st21nfca_im_send_dep_req (hdev, skb); - *skb_push (skb,1 ) =0x1a ; +skb_push_uchar (skb,0x1a );return nfc_hci_send_cmd_async (hdev, target->hci_reader_gate,ST21NFCA_WR_XCHG_DATA , skb->data, skb->len, cb, cb_context);case ST21NFCA_RF_READER_14443_3_A_GATE : - *skb_push (skb,1 ) =0x1a ;/* CTR, see spec:10.2.2.1 */ +skb_push_uchar (skb,0x1a );/* CTR, see spec:10.2.2.1 */ return nfc_hci_send_cmd_async(hdev, target->hci_reader_gate, ST21NFCA_WR_XCHG_DATA, skb->data,
@@ -815,7 +815,7 @@ static int st21nfca_hci_im_transceive(struct nfc_hci_dev *hdev, info->async_cb = cb; info->async_cb_context = cb_context; - *skb_push (skb,1 ) =0x17 ; +skb_push_uchar (skb,0x17 ); return nfc_hci_send_cmd_async(hdev, target->hci_reader_gate, ST21NFCA_WR_XCHG_DATA, skb->data,
drivers/nfc/st21nfca/st21nfca_dep.c +15 -15
@@ -316,10 +316,10 @@ int st21nfca_tm_send_dep_res(struct nfc_hci_dev *hdev, struct sk_buff *skb)int r;struct st21nfca_hci_info *info =nfc_hci_get_clientdata (hdev); - *skb_push (skb,1 ) = info->dep_info.curr_nfc_dep_pni; - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_DEP_RES ; - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_RES ; - *skb_push (skb,1 ) = skb->len; +skb_push_uchar (skb, info->dep_info.curr_nfc_dep_pni); +skb_push_uchar (skb,ST21NFCA_NFCIP1_DEP_RES ); +skb_push_uchar (skb,ST21NFCA_NFCIP1_RES ); +skb_push_uchar (skb, skb->len); r =nfc_hci_send_event (hdev,ST21NFCA_RF_CARD_F_GATE ,ST21NFCA_EVT_SEND_DATA , skb->data, skb->len);
@@ -466,7 +466,7 @@ static void st21nfca_im_send_psl_req(struct nfc_hci_dev *hdev, u8 did, u8 bsi, psl_req->brs = (0x30 & bsi <<4 ) | (bri &0x03 ); psl_req->fsl = lri; - *skb_push (skb,1 ) = info->dep_info.to |0x10 ; +skb_push_uchar (skb, info->dep_info.to |0x10 );st21nfca_im_send_pdu (info, skb); }
@@ -568,7 +568,7 @@ int st21nfca_im_send_atr_req(struct nfc_hci_dev *hdev, u8 *gb, size_t gb_len) } atr_req->length =sizeof (struct st21nfca_atr_req ) + hdev->gb_len; - *skb_push (skb,1 ) = info->dep_info.to |0x10 ;/* timeout */ +skb_push_uchar (skb, info->dep_info.to |0x10 );/* timeout */ info->async_cb_type =ST21NFCA_CB_TYPE_READER_F ; info->async_cb_context = info;
@@ -629,10 +629,10 @@ static void st21nfca_im_recv_dep_res_cb(void *context, struct sk_buff *skb,case ST21NFCA_NFC_DEP_PFB_SUPERVISOR_PDU :pr_err ("Received a SUPERVISOR PDU\n" );skb_pull (skb, size); - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_DEP_REQ ; - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_REQ ; - *skb_push (skb,1 ) = skb->len; - *skb_push (skb,1 ) = info->dep_info.to |0x10 ; +skb_push_uchar (skb,ST21NFCA_NFCIP1_DEP_REQ ); +skb_push_uchar (skb,ST21NFCA_NFCIP1_REQ ); +skb_push_uchar (skb, skb->len); +skb_push_uchar (skb, info->dep_info.to |0x10 );st21nfca_im_send_pdu (info, skb);break ;
@@ -655,12 +655,12 @@ int st21nfca_im_send_dep_req(struct nfc_hci_dev *hdev, struct sk_buff *skb) info->async_cb_context = info; info->async_cb = st21nfca_im_recv_dep_res_cb; - *skb_push (skb,1 ) = info->dep_info.curr_nfc_dep_pni; - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_DEP_REQ ; - *skb_push (skb,1 ) =ST21NFCA_NFCIP1_REQ ; - *skb_push (skb,1 ) = skb->len; +skb_push_uchar (skb, info->dep_info.curr_nfc_dep_pni); +skb_push_uchar (skb,ST21NFCA_NFCIP1_DEP_REQ ); +skb_push_uchar (skb,ST21NFCA_NFCIP1_REQ ); +skb_push_uchar (skb, skb->len); - *skb_push (skb,1 ) = info->dep_info.to |0x10 ; +skb_push_uchar (skb, info->dep_info.to |0x10 ); return nfc_hci_send_cmd_async(hdev, ST21NFCA_RF_READER_F_GATE, ST21NFCA_WR_XCHG_DATA,
drivers/nfc/st21nfcb/ndlc.c +1 -1
@@ -76,7 +76,7 @@ int ndlc_send(struct llt_ndlc *ndlc, struct sk_buff *skb)u8 pcb =PCB_TYPE_DATAFRAME |PCB_DATAFRAME_RETRANSMIT_NO |PCB_FRAME_CRC_INFO_NOTPRESENT ; - *skb_push (skb,1 ) = pcb; +skb_push_uchar (skb, pcb);skb_queue_tail (&ndlc->send_q, skb);schedule_work (&ndlc->sm_work);
net/ax25/af_ax25.c +1 -1
@@ -1558,7 +1558,7 @@ static int ax25_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)/* Add the PID if one is not supplied by the user in the skb */ if (!ax25->pidincl) - *skb_push (skb,1 ) = sk->sk_protocol; +skb_push_uchar (skb, sk->sk_protocol);if (sk->sk_type ==SOCK_SEQPACKET ) {/* Connected mode sockets go via the LAPB machine */
net/bluetooth/hci_sock.c +1 -1
@@ -194,7 +194,7 @@ void hci_send_to_sock(struct hci_dev *hdev, struct sk_buff *skb)continue ;/* Put type byte before the data */ -memcpy (skb_push (skb_copy,1 ), &bt_cb (skb)->pkt_type,1 ); +skb_push_uchar (skb_copy,bt_cb (skb)->pkt_type); } nskb =skb_clone (skb_copy,GFP_ATOMIC );
net/dccp/options.c +1 -1
@@ -484,7 +484,7 @@ int dccp_insert_option_mandatory(struct sk_buff *skb)return -1 ;DCCP_SKB_CB (skb)->dccpd_opt_len++; - *skb_push (skb,1 ) =DCCPO_MANDATORY ; +skb_push_uchar (skb,DCCPO_MANDATORY );return 0 ; }
net/nfc/digital_technology.c +1 -1
@@ -830,7 +830,7 @@ int digital_in_send_sensf_req(struct nfc_digital_dev *ddev, u8 rf_tech) sensf_req->rc =0 ; sensf_req->tsn =0 ; - *skb_push (skb,1 ) = size +1 ; +skb_push_uchar (skb, size +1 );if (!DIGITAL_DRV_CAPS_IN_CRC (ddev))digital_skb_add_crc_f (skb);
net/nfc/hci/core.c +1 -1
@@ -726,7 +726,7 @@ static int hci_transceive(struct nfc_dev *nfc_dev, struct nfc_target *target,break ; } - *skb_push (skb,1 ) =0 ;/* CTR, see spec:10.2.2.1 */ +skb_push_uchar (skb,0 );/* CTR, see spec:10.2.2.1 */ hdev->async_cb_type =HCI_CB_TYPE_TRANSCEIVE ; hdev->async_cb = cb;
net/nfc/hci/llc_shdlc.c +4 -4
@@ -160,7 +160,7 @@ static int llc_shdlc_send_s_frame(struct llc_shdlc *shdlc,if (skb ==NULL )return -ENOMEM ; - *skb_push (skb,1 ) =SHDLC_CONTROL_HEAD_S | (sframe_type <<3 ) | nr; +skb_push_uchar (skb,SHDLC_CONTROL_HEAD_S | (sframe_type <<3 ) | nr); r = shdlc->xmit_to_drv (shdlc->hdev, skb);
@@ -178,7 +178,7 @@ static int llc_shdlc_send_u_frame(struct llc_shdlc *shdlc,pr_debug ("uframe_modifier=%d\n" , uframe_modifier); - *skb_push (skb,1 ) =SHDLC_CONTROL_HEAD_U | uframe_modifier; +skb_push_uchar (skb,SHDLC_CONTROL_HEAD_U | uframe_modifier); r = shdlc->xmit_to_drv (shdlc->hdev, skb);
@@ -551,8 +551,8 @@ static void llc_shdlc_handle_send_queue(struct llc_shdlc *shdlc) skb =skb_dequeue (&shdlc->send_q); - *skb_push (skb,1 ) =SHDLC_CONTROL_HEAD_I | (shdlc->ns <<3 ) | - shdlc->nr; +skb_push_uchar (skb, +SHDLC_CONTROL_HEAD_I | (shdlc->ns <<3 ) | shdlc->nr);pr_debug ("Sending I-Frame %d, waiting to rcv %d\n" , shdlc->ns, shdlc->nr);
net/nfc/nci/hci.c +2 -2
@@ -152,7 +152,7 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe,return -ENOMEM ;skb_reserve (skb,2 +NCI_DATA_HDR_SIZE ); - *skb_push (skb,1 ) = data_type; +skb_push_uchar (skb, data_type); i =0 ; len = conn_info->max_pkt_payload_len;
@@ -167,7 +167,7 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe, len = conn_info->max_pkt_payload_len - skb->len -1 ; } - *skb_push (skb,1 ) = cb; +skb_push_uchar (skb, cb);if (len >0 )memcpy (skb_put (skb, len), data + i, len);
net/nfc/nci/spi.c +2 -2
@@ -231,8 +231,8 @@ static struct sk_buff *__nci_spi_read(struct nci_spi *nspi) goto receive_error;if (nspi->acknowledge_mode ==NCI_SPI_CRC_ENABLED ) { - *skb_push (skb,1 ) = resp_hdr[1 ]; - *skb_push (skb,1 ) = resp_hdr[0 ]; +skb_push_uchar (skb, resp_hdr[1 ]); +skb_push_uchar (skb, resp_hdr[0 ]); }return skb;
Signature · 1 line
2.1.4
RFC PATCH 5/8 skbuff: Convert skb_put to return void *
In reply to Joe PerchesThere are many casts that could be removed by this conversion. Start it.
--- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/skbuff.h +1 -1
@@ -1678,7 +1678,7 @@ static inline void skb_set_tail_pointer(struct sk_buff *skb, const int offset)* Add data to an sk_buff */ unsigned char *pskb_put (struct sk_buff *skb,struct sk_buff *tail,int len); -unsigned char *skb_put (struct sk_buff *skb,unsigned int len); +void *skb_put (struct sk_buff *skb,unsigned int len);void *skb_put_uchar (struct sk_buff *skb,unsigned char uc);static inline unsigned char *__skb_put (struct sk_buff *skb,unsigned int len) {
Signature · 1 line
2.1.4
RFC PATCH 6/8 treewide: Remove unnecessary casts from skb_puts
In reply to Joe PerchesNow that skb_puts returns a void *, remove the unnecessary casts.
--- drivers/atm/atmtcp.c | 4 +- drivers/atm/solos-pci.c | 12 +- drivers/bluetooth/btmrvl_main.c | 2 +- drivers/bluetooth/btusb.c | 4 +- drivers/bluetooth/hci_ll.c | 2 +- drivers/infiniband/hw/cxgb3/cxio_hal.c | 4 +- drivers/infiniband/hw/cxgb3/iwch_cm.c | 24 ++-- drivers/infiniband/hw/cxgb3/iwch_qp.c | 4 +- drivers/infiniband/hw/cxgb4/cm.c | 26 ++--- drivers/isdn/act2000/capi.c | 4 +- drivers/isdn/hisax/isar.c | 6 +- drivers/isdn/i4l/isdn_audio.c | 4 +- drivers/media/dvb-core/dvb_net.c | 2 +- drivers/media/radio/wl128x/fmdrv_common.c | 2 +- drivers/net/bonding/bond_3ad.c | 4 +- drivers/net/can/dev.c | 4 +- drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c | 2 +- drivers/net/ethernet/davicom/dm9000.c | 2 +- drivers/net/ethernet/dnet.c | 2 +- drivers/net/ethernet/hp/hp100.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 4 +- drivers/net/ethernet/micrel/ks8842.c | 4 +- drivers/net/ethernet/sfc/selftest.c | 3 +- drivers/net/ethernet/sun/sunvnet.c | 2 +- drivers/net/ppp/pppoe.c | 2 +- drivers/net/usb/net1080.c | 2 +- drivers/net/vxlan.c | 2 +- drivers/net/wan/hdlc_ppp.c | 2 +- drivers/net/wireless/airo.c | 4 +- drivers/net/wireless/ath/ath6kl/debug.c | 2 +- drivers/net/wireless/ath/ath6kl/htc_pipe.c | 6 +- drivers/net/wireless/ath/ath9k/channel.c | 2 +- drivers/net/wireless/ath/ath9k/htc_hst.c | 9 +- drivers/net/wireless/ath/ath9k/wmi.c | 2 +- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- drivers/net/wireless/hostap/hostap_ap.c | 4 +- drivers/net/wireless/hostap/hostap_main.c | 3 +- drivers/net/wireless/ipw2x00/ipw2200.c | 2 +- drivers/net/wireless/ipw2x00/libipw_tx.c | 6 +- drivers/net/wireless/mac80211_hwsim.c | 8 +- drivers/net/wireless/mwifiex/11n_aggr.c | 2 +- drivers/net/wireless/mwifiex/tdls.c | 30 ++--- drivers/net/wireless/p54/fwio.c | 43 ++++--- drivers/net/wireless/rt2x00/rt2x00debug.c | 2 +- drivers/net/wireless/rtlwifi/base.c | 4 +- drivers/net/wireless/rtlwifi/pci.c | 2 +- drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192ee/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8192se/fw.c | 5 +- drivers/net/wireless/rtlwifi/rtl8723ae/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8723be/fw.c | 4 +- drivers/net/wireless/rtlwifi/rtl8821ae/fw.c | 8 +- drivers/net/wireless/ti/wlcore/cmd.c | 2 +- drivers/net/wireless/ti/wlcore/main.c | 2 +- drivers/nfc/nfcwilink.c | 3 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- drivers/scsi/fcoe/fcoe.c | 2 +- drivers/scsi/fcoe/fcoe_ctlr.c | 2 +- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +- drivers/staging/ozwpan/ozpd.c | 6 +- drivers/staging/ozwpan/ozproto.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 +- drivers/staging/rtl8192e/rtllib_softmac.c | 34 ++---- drivers/staging/rtl8192e/rtllib_tx.c | 3 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 21 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 8 +- drivers/staging/rtl8712/rtl8712_recv.c | 2 +- drivers/usb/gadget/function/f_ncm.c | 19 ++-- lib/nlattr.c | 2 +- net/appletalk/ddp.c | 2 +- net/atm/clip.c | 2 +- net/atm/signaling.c | 2 +- net/batman-adv/icmp_socket.c | 2 +- net/bluetooth/hci_request.c | 2 +- net/bluetooth/hci_sock.c | 6 +- net/bluetooth/l2cap_core.c | 16 +-- net/bluetooth/mgmt_util.c | 10 +- net/bridge/netfilter/nft_reject_bridge.c | 4 +- net/core/pktgen.c | 32 +++--- net/decnet/dn_dev.c | 2 +- net/decnet/dn_nsp_out.c | 6 +- net/ipv4/arp.c | 2 +- net/ipv4/igmp.c | 6 +- net/ipv4/ipconfig.c | 2 +- net/ipv4/ipmr.c | 2 +- net/ipv4/netfilter/ipt_SYNPROXY.c | 10 +- net/ipv4/netfilter/nf_reject_ipv4.c | 4 +- net/ipv6/mcast.c | 6 +- net/ipv6/ndisc.c | 8 +- net/ipv6/netfilter/ip6t_SYNPROXY.c | 10 +- net/ipv6/netfilter/nf_reject_ipv6.c | 2 +- net/irda/irlap_frame.c | 17 ++- net/key/af_key.c | 124 +++++++++------------ net/mac80211/agg-rx.c | 2 +- net/mac80211/agg-tx.c | 4 +- net/mac80211/cfg.c | 4 +- net/mac80211/debugfs_netdev.c | 2 +- net/mac80211/ht.c | 4 +- net/mac80211/mesh.c | 4 +- net/mac80211/mesh_hwmp.c | 4 +- net/mac80211/mesh_plink.c | 2 +- net/mac80211/mesh_ps.c | 2 +- net/mac80211/mlme.c | 4 +- net/mac80211/rx.c | 2 +- net/mac80211/spectmgmt.c | 2 +- net/mac80211/sta_info.c | 2 +- net/mac80211/tdls.c | 14 +-- net/mac80211/tx.c | 9 +- net/mac80211/util.c | 4 +- net/mac80211/wpa.c | 6 +- net/netfilter/nfnetlink_log.c | 2 +- net/netfilter/nfnetlink_queue_core.c | 2 +- net/netlink/af_netlink.c | 2 +- net/nfc/digital_technology.c | 6 +- net/nfc/nci/core.c | 2 +- net/phonet/datagram.c | 2 +- net/sctp/sm_make_chunk.c | 2 +- net/sctp/ulpevent.c | 21 ++-- 128 files changed, 389 insertions(+), 445 deletions(-)
drivers/atm/atmtcp.c +2 -2
@@ -60,7 +60,7 @@ static int atmtcp_send_control(struct atm_vcc *vcc,int type,return -EUNATCH ; }atm_force_charge (out_vcc,skb->truesize); - new_msg = (struct atmtcp_control *)skb_put (skb,sizeof (*new_msg)); + new_msg =skb_put (skb,sizeof (*new_msg)); *new_msg = *msg; new_msg->hdr.length =ATMTCP_HDR_MAGIC ; new_msg->type = type;
@@ -217,7 +217,7 @@ static int atmtcp_v_send(struct atm_vcc *vcc,struct sk_buff *skb)atomic_inc (&vcc->stats->tx_err);return -ENOBUFS ; } - hdr = (void *)skb_put (new_skb,sizeof (struct atmtcp_hdr )); + hdr =skb_put (new_skb,sizeof (struct atmtcp_hdr )); hdr->vpi =htons (vcc->vpi); hdr->vci =htons (vcc->vci); hdr->length =htonl (skb->len);
drivers/atm/solos-pci.c +6 -6
@@ -205,7 +205,7 @@ static ssize_t solos_param_show(struct device *dev, struct device_attribute *attreturn -ENOMEM ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); buflen =snprintf ((void *)&header[1 ], buflen -1 ,"L%05d\n%s\n" , current->pid, attr->attr.name);
@@ -261,7 +261,7 @@ static ssize_t solos_param_store(struct device *dev, struct device_attribute *atreturn -ENOMEM ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); buflen =snprintf ((void *)&header[1 ], buflen -1 ,"L%05d\n%s\n%s\n" , current->pid, attr->attr.name, buf);
@@ -480,7 +480,7 @@ static int send_command(struct solos_card *card, int dev, const char *buf, size_return 0 ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); header->size =cpu_to_le16 (size); header->vpi =cpu_to_le16 (0 );
@@ -931,7 +931,7 @@ static int popen(struct atm_vcc *vcc)dev_warn (&card->dev->dev,"Failed to allocate sk_buff in popen()\n" );return -ENOMEM ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); header->size =cpu_to_le16 (0 ); header->vpi =cpu_to_le16 (vcc->vpi);
@@ -968,7 +968,7 @@ static void pclose(struct atm_vcc *vcc)dev_warn (&card->dev->dev,"Failed to allocate sk_buff in pclose()\n" );return ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); header->size =cpu_to_le16 (0 ); header->vpi =cpu_to_le16 (vcc->vpi);
@@ -1384,7 +1384,7 @@ static int atm_init(struct solos_card *card, struct device *parent)continue ; } - header = (void *)skb_put (skb,sizeof (*header)); + header =skb_put (skb,sizeof (*header)); header->size =cpu_to_le16 (0 ); header->vpi =cpu_to_le16 (0 );
drivers/bluetooth/btmrvl_main.c +1 -1
@@ -189,7 +189,7 @@ static int btmrvl_send_sync_cmd(struct btmrvl_private *priv, u16 opcode,return -ENOMEM ; } - hdr = (struct hci_command_hdr *)skb_put (skb,HCI_COMMAND_HDR_SIZE ); + hdr =skb_put (skb,HCI_COMMAND_HDR_SIZE ); hdr->opcode =cpu_to_le16 (opcode); hdr->plen = len;
drivers/bluetooth/btusb.c +2 -2
@@ -1718,11 +1718,11 @@ static int inject_cmd_complete(struct hci_dev *hdev, __u16 opcode)if (!skb)return -ENOMEM ; - hdr = (struct hci_event_hdr *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr)); hdr->evt =HCI_EV_CMD_COMPLETE ; hdr->plen =sizeof (*evt) +1 ; - evt = (struct hci_ev_cmd_complete *)skb_put (skb,sizeof (*evt)); + evt =skb_put (skb,sizeof (*evt)); evt->ncmd =0x01 ; evt->opcode =cpu_to_le16 (opcode);
drivers/bluetooth/hci_ll.c +1 -1
@@ -108,7 +108,7 @@ static int send_hcill_cmd(u8 cmd, struct hci_uart *hu) }/* prepare packet */ - hcill_packet = (struct hcill_cmd *)skb_put (skb,1 ); + hcill_packet =skb_put (skb,1 ); hcill_packet->cmd = cmd;/* send packet */
drivers/infiniband/hw/cxgb3/cxio_hal.c +2 -2
@@ -143,7 +143,7 @@ static int cxio_hal_clear_qp_ctx(struct cxio_rdev *rdev_p, u32 qpid)PDBG ("%s alloc_skb failed\n" , __func__);return -ENOMEM ; } - wqe = (struct t3_modify_qp_wr *)skb_put (skb,sizeof (*wqe)); + wqe =skb_put (skb,sizeof (*wqe));memset (wqe,0 ,sizeof (*wqe)); build_fw_riwrh((struct fw_riwrh *) wqe, T3_WR_QP_MOD, T3_COMPLETION_FLAG | T3_NOTIFY_FLAG, 0, qpid, 7,
@@ -562,7 +562,7 @@ static int cxio_hal_init_ctrl_qp(struct cxio_rdev *rdev_p) ctx1 |= ((u64) (V_EC_BASE_HI ((u32 ) base_addr &0xf ) |V_EC_RESPQ (0 ) |V_EC_TYPE (0 ) |V_EC_GEN (1 ) |V_EC_UP_TOKEN (T3_CTL_QP_TID ) |F_EC_VALID )) <<32 ; - wqe = (struct t3_modify_qp_wr *)skb_put (skb,sizeof (*wqe)); + wqe =skb_put (skb,sizeof (*wqe));memset (wqe,0 ,sizeof (*wqe));build_fw_riwrh ((struct fw_riwrh *) wqe,T3_WR_QP_MOD ,0 ,0 ,T3_CTL_QP_TID ,7 ,T3_SOPEOP );
drivers/infiniband/hw/cxgb3/iwch_cm.c +12 -12
@@ -175,7 +175,7 @@ static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb) skb =get_skb (skb,sizeof *req,GFP_KERNEL );if (!skb)return ; - req = (struct cpl_tid_release *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD ));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_TID_RELEASE , hwtid)); skb->priority =CPL_PRIORITY_SETUP ;
@@ -190,7 +190,7 @@ int iwch_quiesce_tid(struct iwch_ep *ep)if (!skb)return -ENOMEM ; - req = (struct cpl_set_tcb_field *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD )); req->wr.wr_lo =htonl (V_WR_TID (ep->hwtid));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_SET_TCB_FIELD , ep->hwtid));
@@ -211,7 +211,7 @@ int iwch_resume_tid(struct iwch_ep *ep)if (!skb)return -ENOMEM ; - req = (struct cpl_set_tcb_field *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD )); req->wr.wr_lo =htonl (V_WR_TID (ep->hwtid));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_SET_TCB_FIELD , ep->hwtid));
@@ -397,7 +397,7 @@ static int send_halfclose(struct iwch_ep *ep, gfp_t gfp) } skb->priority =CPL_PRIORITY_DATA ;set_arp_failure_handler (skb, arp_failure_discard); - req = (struct cpl_close_con_req *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_CLOSE_CON )); req->wr.wr_lo =htonl (V_WR_TID (ep->hwtid));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_CLOSE_CON_REQ , ep->hwtid));
@@ -417,7 +417,7 @@ static int send_abort(struct iwch_ep *ep, struct sk_buff *skb, gfp_t gfp) } skb->priority =CPL_PRIORITY_DATA ;set_arp_failure_handler (skb, abort_arp_failure); - req = (struct cpl_abort_req *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req));memset (req,0 ,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_HOST_ABORT_CON_REQ )); req->wr.wr_lo =htonl (V_WR_TID (ep->hwtid));
@@ -457,7 +457,7 @@ static int send_connect(struct iwch_ep *ep) skb->priority =CPL_PRIORITY_SETUP ;set_arp_failure_handler (skb, act_open_req_arp_failure); - req = (struct cpl_act_open_req *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD ));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_ACT_OPEN_REQ , ep->atid)); req->local_port = ep->com.local_addr.sin_port;
@@ -548,7 +548,7 @@ static int send_mpa_reject(struct iwch_ep *ep, const void *pdata, u8 plen)return -ENOMEM ; }skb_reserve (skb,sizeof (*req)); - mpa = (struct mpa_message *)skb_put (skb, mpalen); + mpa =skb_put (skb, mpalen);memset (mpa,0 ,sizeof (*mpa));memcpy (mpa->key,MPA_KEY_REP ,sizeof (mpa->key)); mpa->flags =MPA_REJECT ;
@@ -598,7 +598,7 @@ static int send_mpa_reply(struct iwch_ep *ep, const void *pdata, u8 plen) } skb->priority =CPL_PRIORITY_DATA ;skb_reserve (skb,sizeof (*req)); - mpa = (struct mpa_message *)skb_put (skb, mpalen); + mpa =skb_put (skb, mpalen);memset (mpa,0 ,sizeof (*mpa));memcpy (mpa->key,MPA_KEY_REP ,sizeof (mpa->key)); mpa->flags = (ep->mpa_attr.crc_enabled ? MPA_CRC : 0) |
@@ -802,7 +802,7 @@ static int update_rx_credits(struct iwch_ep *ep, u32 credits)return 0 ; } - req = (struct cpl_rx_data_ack *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD ));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_RX_DATA_ACK , ep->hwtid)); req->credit_dack =htonl (V_RX_CREDITS (credits) |V_RX_FORCE_ACK (1 ));
@@ -1209,7 +1209,7 @@ static int listen_start(struct iwch_listen_ep *ep)return -ENOMEM ; } - req = (struct cpl_pass_open_req *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD ));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_PASS_OPEN_REQ , ep->stid)); req->local_port = ep->com.local_addr.sin_port;
@@ -1250,7 +1250,7 @@ static int listen_stop(struct iwch_listen_ep *ep) printk(KERN_ERR MOD "%s - failed to alloc skb\n", __func__);return -ENOMEM ; } - req = (struct cpl_close_listserv_req *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD )); req->cpu_idx =0 ;OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_CLOSE_LISTSRV_REQ , ep->stid));
@@ -1626,7 +1626,7 @@ static int peer_abort(struct t3cdev *tdev, struct sk_buff *skb, void *ctx) goto out; } rpl_skb->priority =CPL_PRIORITY_DATA ; - rpl = (struct cpl_abort_rpl *)skb_put (rpl_skb,sizeof (*rpl)); + rpl =skb_put (rpl_skb,sizeof (*rpl)); rpl->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_HOST_ABORT_CON_RPL )); rpl->wr.wr_lo =htonl (V_WR_TID (ep->hwtid));OPCODE_TID (rpl) =htonl (MK_OPCODE_TID (CPL_ABORT_RPL , ep->hwtid));
drivers/infiniband/hw/cxgb3/iwch_qp.c +2 -2
@@ -751,7 +751,7 @@ int iwch_post_zb_read(struct iwch_ep *ep)printk (KERN_ERR "%s cannot send zb_read!!\n" , __func__);return -ENOMEM ; } - wqe = (union t3_wr *)skb_put (skb,sizeof (struct t3_rdma_read_wr )); + wqe =skb_put (skb,sizeof (struct t3_rdma_read_wr ));memset (wqe,0 ,sizeof (struct t3_rdma_read_wr )); wqe->read.rdmaop =T3_READ_REQ ; wqe->read.reserved[0 ] =0 ;
@@ -783,7 +783,7 @@ int iwch_post_terminate(struct iwch_qp *qhp, struct respQ_msg_t *rsp_msg)printk (KERN_ERR "%s cannot send TERMINATE!\n" , __func__);return -ENOMEM ; } - wqe = (union t3_wr *)skb_put (skb,40 ); + wqe =skb_put (skb,40 );memset (wqe,0 ,40 ); wqe->send.rdmaop =T3_TERMINATE ;
drivers/infiniband/hw/cxgb4/cm.c +12 -14
@@ -225,7 +225,7 @@ static void release_tid(struct c4iw_rdev *rdev, u32 hwtid, struct sk_buff *skb) skb =get_skb (skb,sizeof *req,GFP_KERNEL );if (!skb)return ; - req = (struct cpl_tid_release *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req));INIT_TP_WR (req, hwtid);OPCODE_TID (req) =cpu_to_be32 (MK_OPCODE_TID (CPL_TID_RELEASE , hwtid));set_wr_txq (skb,CPL_PRIORITY_SETUP ,0 );
@@ -521,7 +521,7 @@ static int send_halfclose(struct c4iw_ep *ep, gfp_t gfp) }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx);t4_set_arp_err_handler (skb,NULL , arp_failure_discard); - req = (struct cpl_close_con_req *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen);INIT_TP_WR (req, ep->hwtid); OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_CLOSE_CON_REQ,
@@ -543,7 +543,7 @@ static int send_abort(struct c4iw_ep *ep, struct sk_buff *skb, gfp_t gfp) }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx);t4_set_arp_err_handler (skb, &ep->com.dev->rdev, abort_arp_failure); - req = (struct cpl_abort_req *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen);INIT_TP_WR (req, ep->hwtid);OPCODE_TID (req) =cpu_to_be32 (MK_OPCODE_TID (CPL_ABORT_REQ , ep->hwtid));
@@ -681,7 +681,7 @@ static int send_connect(struct c4iw_ep *ep)if (is_t4 (ep->com.dev->rdev.lldi.adapter_type)) {if (ep->com.remote_addr.ss_family ==AF_INET ) { - req = (struct cpl_act_open_req *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);INIT_TP_WR (req,0 ); OPCODE_TID(req) = cpu_to_be32( MK_OPCODE_TID(CPL_ACT_OPEN_REQ,
@@ -696,7 +696,7 @@ static int send_connect(struct c4iw_ep *ep) ep->l2t)); req->opt2 =cpu_to_be32 (opt2); }else { - req6 = (struct cpl_act_open_req6 *)skb_put (skb, wrlen); + req6 =skb_put (skb, wrlen);INIT_TP_WR (req6,0 ); OPCODE_TID(req6) = cpu_to_be32(
@@ -725,8 +725,7 @@ static int send_connect(struct c4iw_ep *ep) isn +=4 ;if (ep->com.remote_addr.ss_family ==AF_INET ) { - t5_req = (struct cpl_t5_act_open_req *) -skb_put (skb, wrlen); + t5_req =skb_put (skb, wrlen);INIT_TP_WR (t5_req,0 ); OPCODE_TID(t5_req) = cpu_to_be32( MK_OPCODE_TID(CPL_ACT_OPEN_REQ,
@@ -745,8 +744,7 @@ static int send_connect(struct c4iw_ep *ep) be32_to_cpu(t5_req->rsvd)); t5_req->opt2 =cpu_to_be32 (opt2); }else { - t5_req6 = (struct cpl_t5_act_open_req6 *) -skb_put (skb, wrlen); + t5_req6 =skb_put (skb, wrlen);INIT_TP_WR (t5_req6,0 ); OPCODE_TID(t5_req6) = cpu_to_be32( MK_OPCODE_TID(CPL_ACT_OPEN_REQ6,
@@ -800,7 +798,7 @@ static void send_mpa_req(struct c4iw_ep *ep, struct sk_buff *skb, }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx); - req = (struct fw_ofld_tx_data_wr *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen); req->op_to_immdlen = cpu_to_be32( FW_WR_OP_V(FW_OFLD_TX_DATA_WR) |
@@ -894,7 +892,7 @@ static int send_mpa_reject(struct c4iw_ep *ep, const void *pdata, u8 plen) }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx); - req = (struct fw_ofld_tx_data_wr *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen); req->op_to_immdlen = cpu_to_be32( FW_WR_OP_V(FW_OFLD_TX_DATA_WR) |
@@ -974,7 +972,7 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen) }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx); - req = (struct fw_ofld_tx_data_wr *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen); req->op_to_immdlen = cpu_to_be32( FW_WR_OP_V(FW_OFLD_TX_DATA_WR) |
@@ -1252,7 +1250,7 @@ static int update_rx_credits(struct c4iw_ep *ep, u32 credits)if (ep->rcv_win >RCV_BUFSIZ_M *1024 ) credits += ep->rcv_win -RCV_BUFSIZ_M *1024 ; - req = (struct cpl_rx_data_ack *)skb_put (skb, wrlen); + req =skb_put (skb, wrlen);memset (req,0 , wrlen);INIT_TP_WR (req, ep->hwtid); OPCODE_TID(req) = cpu_to_be32(MK_OPCODE_TID(CPL_RX_DATA_ACK,
@@ -2610,7 +2608,7 @@ static int peer_abort(struct c4iw_dev *dev, struct sk_buff *skb) goto out; }set_wr_txq (skb,CPL_PRIORITY_DATA , ep->txq_idx); - rpl = (struct cpl_abort_rpl *)skb_put (rpl_skb,sizeof (*rpl)); + rpl =skb_put (rpl_skb,sizeof (*rpl));INIT_TP_WR (rpl, ep->hwtid);OPCODE_TID (rpl) =cpu_to_be32 (MK_OPCODE_TID (CPL_ABORT_RPL , ep->hwtid)); rpl->cmd =CPL_ABORT_NO_RST ;
drivers/isdn/act2000/capi.c +2 -2
@@ -107,7 +107,7 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr)#define ACTCAPI_MKHDR (l, c, s) { \ skb = alloc_skb(l + 8, GFP_ATOMIC); \ if (skb) { \ - m = (actcapi_msg *)skb_put(skb, l + 8); \ + m = skb_put(skb, l + 8); \ m->hdr.len = l + 8; \ m->hdr.applicationID = 1; \ m->hdr.cmd.cmd = c; \
@@ -567,7 +567,7 @@ actcapi_data_b3_ind(act2000_card *card, struct sk_buff *skb) {printk (KERN_WARNING "actcapi: alloc_skb failed\n" );return 1 ; } - msg = (actcapi_msg *)skb_put (skb,11 ); + msg =skb_put (skb,11 ); msg->hdr.len =11 ; msg->hdr.applicationID =1 ; msg->hdr.cmd.cmd =0x86 ;
drivers/isdn/hisax/isar.c +3 -3
@@ -510,7 +510,7 @@ isar_rcv_frame(struct IsdnCardState *cs, struct BCState *bcs)case L1_MODE_TRANS :case L1_MODE_V32 :if ((skb =dev_alloc_skb (ireg->clsb))) { -rcv_mbox (cs, ireg, (u_char *)skb_put (skb, ireg->clsb)); +rcv_mbox (cs, ireg,skb_put (skb, ireg->clsb));skb_queue_tail (&bcs->rqueue, skb);schedule_event (bcs,B_RCVBUFREADY ); }else {
@@ -575,7 +575,7 @@ isar_rcv_frame(struct IsdnCardState *cs, struct BCState *bcs)debugl1 (cs,"isar_rcv_frame: raw(%d) dle(%d)" , ireg->clsb, bcs->hw.isar.rcvidx);if ((skb =dev_alloc_skb (bcs->hw.isar.rcvidx))) { -insert_dle ((u_char *)skb_put (skb, bcs->hw.isar.rcvidx), +insert_dle (skb_put (skb, bcs->hw.isar.rcvidx), bcs->hw.isar.rcvbuf, ireg->clsb);skb_queue_tail (&bcs->rqueue, skb);schedule_event (bcs,B_RCVBUFREADY );
@@ -634,7 +634,7 @@ isar_rcv_frame(struct IsdnCardState *cs, struct BCState *bcs) }else if (!(skb =dev_alloc_skb (len))) {printk (KERN_WARNING "ISAR: receive out of memory\n" ); }else { -insert_dle ((u_char *)skb_put (skb, len), +insert_dle (skb_put (skb, len), bcs->hw.isar.rcvbuf, bcs->hw.isar.rcvidx);skb_queue_tail (&bcs->rqueue, skb);
drivers/isdn/i4l/isdn_audio.c +2 -2
@@ -462,7 +462,7 @@ isdn_audio_goertzel(int *sample, modem_info *info) info->line);return ; } - result = (int *)skb_put (skb,sizeof (int ) *NCOEFF ); + result =skb_put (skb,sizeof (int ) *NCOEFF );for (k =0 ; k <NCOEFF ; k++) { sk = sk1 = sk2 =0 ;for (n =0 ; n <DTMF_NPOINTS ; n++) {
@@ -672,7 +672,7 @@ isdn_audio_put_dle_code(modem_info *info, u_char code) info->line);return ; } - p = (char *)skb_put (skb,2 ); + p =skb_put (skb,2 ); p[0 ] =0x10 ; p[1 ] = code;ISDN_AUDIO_SKB_DLECOUNT (skb) =0 ;
drivers/media/dvb-core/dvb_net.c +1 -1
@@ -832,7 +832,7 @@ static void dvb_net_sec(struct net_device *dev, skb->dev = dev;/* copy L3 payload */ - eth = (u8 *)skb_put (skb, pkt_len -12 -4 +14 - snap); + eth =skb_put (skb, pkt_len -12 -4 +14 - snap);memcpy (eth +14 , pkt +12 + snap, pkt_len -12 -4 - snap);/* create ethernet header: */
drivers/media/radio/wl128x/fmdrv_common.c +1 -1
@@ -420,7 +420,7 @@ static int fm_send_cmd(struct fmdev *fmdev, u8 fm_op, u16 type, void *payload,if (!test_bit (FM_FW_DW_INPROGRESS , &fmdev->flag) ||test_bit (FM_INTTASK_RUNNING , &fmdev->flag)) {/* Fill command header info */ - hdr = (struct fm_cmd_msg_hdr *)skb_put (skb,FM_CMD_MSG_HDR_SIZE ); + hdr =skb_put (skb,FM_CMD_MSG_HDR_SIZE ); hdr->hdr =FM_PKT_LOGICAL_CHAN_NUMBER ;/* 0x08 */ /* 3 (fm_opcode,rd_wr,dlen) + payload len) */
drivers/net/bonding/bond_3ad.c +2 -2
@@ -782,7 +782,7 @@ static int ad_lacpdu_send(struct port *port) skb->protocol =PKT_TYPE_LACPDU ; skb->priority =TC_PRIO_CONTROL ; - lacpdu_header = (struct lacpdu_header *)skb_put (skb, length); + lacpdu_header =skb_put (skb, length);ether_addr_copy (lacpdu_header->hdr.h_dest, lacpdu_mcast_addr);/* Note: source address is set to be the member's PERMANENT address,
@@ -824,7 +824,7 @@ static int ad_marker_send(struct port *port, struct bond_marker *marker) skb->network_header = skb->mac_header +ETH_HLEN ; skb->protocol =PKT_TYPE_LACPDU ; - marker_header = (struct bond_marker_header *)skb_put (skb, length); + marker_header =skb_put (skb, length);ether_addr_copy (marker_header->hdr.h_dest, lacpdu_mcast_addr);/* Note: source address is set to be the member's PERMANENT address,
drivers/net/can/dev.c +2 -2
@@ -586,7 +586,7 @@ struct sk_buff *alloc_can_skb(struct net_device *dev, struct can_frame **cf)can_skb_reserve (skb);can_skb_prv (skb)->ifindex = dev->ifindex; - *cf = (struct can_frame *)skb_put (skb,sizeof (struct can_frame )); + *cf =skb_put (skb,sizeof (struct can_frame ));memset (*cf,0 ,sizeof (struct can_frame ));return skb;
@@ -614,7 +614,7 @@ struct sk_buff *alloc_canfd_skb(struct net_device *dev,can_skb_reserve (skb);can_skb_prv (skb)->ifindex = dev->ifindex; - *cfd = (struct canfd_frame *)skb_put (skb,sizeof (struct canfd_frame )); + *cfd =skb_put (skb,sizeof (struct canfd_frame ));memset (*cfd,0 ,sizeof (struct canfd_frame ));return skb;
drivers/net/ethernet/allwinner/sun4i-emac.c +1 -1
@@ -638,7 +638,7 @@ static void emac_rx(struct net_device *dev)if (!skb)continue ;skb_reserve (skb,2 ); - rdptr = (u8 *)skb_put (skb, rxlen -4 ); + rdptr =skb_put (skb, rxlen -4 );/* Read received packet from RX SRAM */ if (netif_msg_rx_status (db))
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +1 -1
@@ -949,7 +949,7 @@ static int send_pktsched_cmd(struct adapter *adap, int sched, int qidx, int lo,if (!skb)return -ENOMEM ; - req = (struct mngt_pktsched_wr *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr_hi =htonl (V_WR_OP (FW_WROPCODE_MNGT )); req->mngt_opcode =FW_MNGTOPCODE_PKTSCHED_SET ; req->sched = sched;
drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c +1 -1
@@ -1096,7 +1096,7 @@ static void set_l2t_ix(struct t3cdev *tdev, u32 tid, struct l2t_entry *e)return ; } skb->priority =CPL_PRIORITY_CONTROL ; - req = (struct cpl_set_tcb_field *)skb_put (skb,sizeof (*req)); + req =skb_put (skb,sizeof (*req)); req->wr.wr_hi =htonl (V_WR_OP (FW_WROPCODE_FORWARD ));OPCODE_TID (req) =htonl (MK_OPCODE_TID (CPL_SET_TCB_FIELD , tid)); req->reply =0 ;
drivers/net/ethernet/davicom/dm9000.c +1 -1
@@ -1170,7 +1170,7 @@ dm9000_rx(struct net_device *dev)if (GoodPacket && ((skb =netdev_alloc_skb (dev, RxLen +4 )) !=NULL )) {skb_reserve (skb,2 ); - rdptr = (u8 *)skb_put (skb, RxLen -4 ); + rdptr =skb_put (skb, RxLen -4 );/* Read received packet from RX SRAM */
drivers/net/ethernet/dnet.c +1 -1
@@ -416,7 +416,7 @@ static int dnet_poll(struct napi_struct *napi, int budget)* 'skb_put()' points to the start of sk_buff * data area. */ - data_ptr = (unsigned int *)skb_put (skb, pkt_len); + data_ptr =skb_put (skb, pkt_len);for (i =0 ; i < (pkt_len +3 ) >>2 ; i++) *data_ptr++ =dnet_readl (bp,RX_DATA_FIFO ); skb->protocol =eth_type_trans (skb, dev);
drivers/net/ethernet/hp/hp100.c +1 -1
@@ -1287,7 +1287,7 @@ static int hp100_build_rx_pdl(hp100_ring_t * ringptr,*/ skb_reserve (ringptr->skb,2 ); - ringptr->skb->data = (u_char *)skb_put (ringptr->skb,MAX_ETHER_SIZE ); + ringptr->skb->data =skb_put (ringptr->skb,MAX_ETHER_SIZE );/* ringptr->pdl points to the beginning of the PDL, i.e. the PDH */ /* Note: 1st Fragment is used for the 4 byte packet status
drivers/net/ethernet/intel/i40e/i40e_fcoe.c +1 -1
@@ -772,7 +772,7 @@ int i40e_fcoe_handle_offload(struct i40e_ring *rx_ring, (fh->fh_r_ctl == FC_RCTL_DD_SOL_DATA)) { struct fcoe_crc_eof *crc = NULL; - crc = (struct fcoe_crc_eof *)skb_put(skb, sizeof(*crc)); + crc = skb_put(skb, sizeof(*crc)); crc->fcoe_eof = FC_EOF_T; } else {/* otherwise, drop the header only frame */
drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c +1 -1
@@ -491,7 +491,7 @@ int ixgbe_fcoe_ddp(struct ixgbe_adapter *adapter,if ((fh->fh_r_ctl ==FC_RCTL_DD_SOL_DATA ) && (fctl &FC_FC_END_SEQ )) {skb_linearize (skb); - crc = (struct fcoe_crc_eof *)skb_put (skb,sizeof (*crc)); + crc =skb_put (skb,sizeof (*crc)); crc->fcoe_eof =FC_EOF_T ; }
drivers/net/ethernet/mellanox/mlx4/en_selftest.c +2 -2
@@ -63,8 +63,8 @@ static int mlx4_en_test_loopback_xmit(struct mlx4_en_priv *priv)skb_reserve (skb,NET_IP_ALIGN ); - ethh = (struct ethhdr *)skb_put (skb,sizeof (struct ethhdr )); - packet = (unsigned char *)skb_put (skb, packet_size); + ethh =skb_put (skb,sizeof (struct ethhdr )); + packet =skb_put (skb, packet_size);memcpy (ethh->h_dest, priv->dev->dev_addr,ETH_ALEN );eth_zero_addr (ethh->h_source); ethh->h_proto =htons (ETH_P_ARP );
drivers/net/ethernet/micrel/ks8842.c +2 -2
@@ -667,7 +667,7 @@ static void ks8842_rx_frame(struct net_device *netdev,ks8842_update_rx_counters (netdev, status, len);if (adapter->conf_flags &KS884X_16BIT ) { -u16 *data16 = (u16 *)skb_put (skb, len); +u16 *data16 =skb_put (skb, len);ks8842_select_bank (adapter,17 );while (len >0 ) { *data16++ = ioread16(adapter->hw_addr +
@@ -677,7 +677,7 @@ static void ks8842_rx_frame(struct net_device *netdev, len -=sizeof (u32); } }else { -u32 *data = (u32 *)skb_put (skb, len); +u32 *data =skb_put (skb, len);ks8842_select_bank (adapter,17 );while (len >0 ) {
drivers/net/ethernet/sfc/selftest.c +1 -2
@@ -414,8 +414,7 @@ static int efx_begin_loopback(struct efx_tx_queue *tx_queue)/* Copy the payload in, incrementing the source address to * exercise the rss vectors */ - payload = ((struct efx_loopback_payload *) -skb_put (skb,sizeof (state->payload))); + payload =skb_put (skb,sizeof (state->payload));memcpy (payload, &state->payload,sizeof (state->payload)); payload->ip.saddr =htonl (INADDR_LOOPBACK | (i <<2 ));
drivers/net/ethernet/sun/sunvnet.c +1 -1
@@ -1118,7 +1118,7 @@ static inline struct sk_buff *vnet_skb_shape(struct sk_buff *skb, int ncookies)dev_kfree_skb (skb);return NULL ; } - (void )skb_put (nskb, skb->len); +skb_put (nskb, skb->len);if (skb_is_gso (skb)) {skb_shinfo (nskb)->gso_size =skb_shinfo (skb)->gso_size;skb_shinfo (nskb)->gso_type =skb_shinfo (skb)->gso_type;
drivers/net/ppp/pppoe.c +1 -1
@@ -884,7 +884,7 @@ static int pppoe_sendmsg(struct socket *sock, struct msghdr *m, skb->priority = sk->sk_priority; skb->protocol =cpu_to_be16 (ETH_P_PPP_SES ); - ph = (struct pppoe_hdr *)skb_put (skb, total_len +sizeof (struct pppoe_hdr )); + ph =skb_put (skb, total_len +sizeof (struct pppoe_hdr )); start = (char *)&ph->tag[0 ]; error =memcpy_from_msg (start, m, total_len);
drivers/net/usb/net1080.c +1 -1
@@ -483,7 +483,7 @@ encapsulate:/* maybe pad; then trailer */ if (!((skb->len +sizeof *trailer) &0x01 ))skb_put_uchar (skb,PAD_BYTE ); - trailer = (struct nc_trailer *)skb_put (skb,sizeof *trailer); + trailer =skb_put (skb,sizeof *trailer);put_unaligned (header->packet_id, &trailer->packet_id);#if 0 netdev_dbg(dev->net, "frame >tx h %d p %d id %d\n",
drivers/net/vxlan.c +1 -1
@@ -1479,7 +1479,7 @@ static struct sk_buff *vxlan_na_create(struct sk_buff *request,skb_pull (reply,sizeof (struct ipv6hdr ));skb_set_transport_header (reply,0 ); - na = (struct nd_msg *)skb_put (reply,sizeof (*na) + na_olen); + na =skb_put (reply,sizeof (*na) + na_olen);/* Neighbor Advertisement */ memset (na,0 ,sizeof (*na)+na_olen);
drivers/net/wan/hdlc_ppp.c +1 -1
@@ -228,7 +228,7 @@ static void ppp_tx_cp(struct net_device *dev, u16 pid, u8 code, }skb_reserve (skb,sizeof (struct hdlc_header )); - cp = (struct cp_header *)skb_put (skb,sizeof (struct cp_header )); + cp =skb_put (skb,sizeof (struct cp_header )); cp->code = code; cp->id = id; cp->len =htons (sizeof (struct cp_header ) + magic_len + len);
drivers/net/wireless/airo.c +2 -2
@@ -3333,7 +3333,7 @@ static void airo_handle_rx(struct airo_info *ai) }skb_reserve (skb,2 );/* This way the IP header is aligned */ - buffer = (__le16 *)skb_put (skb, len + hdrlen); + buffer =skb_put (skb, len + hdrlen);if (test_bit (FLAG_802_11 , &ai->flags)) { buffer[0 ] = fc;bap_read (ai, buffer +1 , hdrlen -2 ,BAP0 );
@@ -3735,7 +3735,7 @@ static void mpi_receive_802_11(struct airo_info *ai) ai->dev->stats.rx_dropped++; goto badrx; } - buffer = (u16 *)skb_put (skb, len + hdrlen); + buffer =skb_put (skb, len + hdrlen);memcpy ((char *)buffer, ptr, hdrlen); ptr += hdrlen;if (hdrlen ==24 )
drivers/net/wireless/ath/ath6kl/debug.c +1 -1
@@ -321,7 +321,7 @@ void ath6kl_debug_fwlog_event(struct ath6kl *ar, const void *buf, size_t len)if (!skb)return ; - slot = (struct ath6kl_fwlog_slot *)skb_put (skb, slot_len); + slot =skb_put (skb, slot_len); slot->timestamp =cpu_to_le32 (jiffies); slot->length =cpu_to_le32 (len);memcpy (slot->payload, buf, len);
drivers/net/wireless/ath/ath6kl/htc_pipe.c +2 -4
@@ -1274,8 +1274,7 @@ static int ath6kl_htc_pipe_conn_service(struct htc_target *target, length =sizeof (struct htc_conn_service_msg );/* assemble connect service message */ - conn_msg = (struct htc_conn_service_msg *)skb_put (skb, - length); + conn_msg =skb_put (skb, length);if (conn_msg ==NULL ) {WARN_ON_ONCE (1 ); status = -EINVAL ;
@@ -1504,8 +1503,7 @@ static int ath6kl_htc_pipe_start(struct htc_target *target) skb = packet->skb;/* assemble setup complete message */ - setup = (struct htc_setup_comp_ext_msg *)skb_put (skb, -sizeof (*setup)); + setup =skb_put (skb,sizeof (*setup));memset (setup,0 ,sizeof (struct htc_setup_comp_ext_msg )); setup->msg_id =cpu_to_le16 (HTC_MSG_SETUP_COMPLETE_EX_ID );
drivers/net/wireless/ath/ath9k/channel.c +1 -1
@@ -1481,7 +1481,7 @@ void ath9k_beacon_add_noa(struct ath_softc *sc, struct ath_vif *avp, hdr[1 ] =sizeof (noa_ie_hdr) + noa_len -2 ; hdr[7 ] = noa_len; - noa = (void *)skb_put (skb, noa_len); + noa =skb_put (skb, noa_len);memset (noa,0 , noa_len); noa->index = avp->noa_index;
drivers/net/wireless/ath/ath9k/htc_hst.c +3 -6
@@ -155,8 +155,7 @@ static int htc_config_pipe_credits(struct htc_target *target) }skb_reserve (skb,sizeof (struct htc_frame_hdr )); - cp_msg = (struct htc_config_pipe_msg *) -skb_put (skb,sizeof (struct htc_config_pipe_msg )); + cp_msg =skb_put (skb,sizeof (struct htc_config_pipe_msg )); cp_msg->message_id =cpu_to_be16 (HTC_MSG_CONFIG_PIPE_ID ); cp_msg->pipe_id =USB_WLAN_TX_PIPE ;
@@ -193,8 +192,7 @@ static int htc_setup_complete(struct htc_target *target) }skb_reserve (skb,sizeof (struct htc_frame_hdr )); - comp_msg = (struct htc_comp_msg *) -skb_put (skb,sizeof (struct htc_comp_msg )); + comp_msg =skb_put (skb,sizeof (struct htc_comp_msg )); comp_msg->msg_id =cpu_to_be16 (HTC_MSG_SETUP_COMPLETE_ID ); target->htc_flags |=HTC_OP_START_WAIT ;
@@ -262,8 +260,7 @@ int htc_connect_service(struct htc_target *target,skb_reserve (skb,sizeof (struct htc_frame_hdr )); - conn_msg = (struct htc_conn_svc_msg *) -skb_put (skb,sizeof (struct htc_conn_svc_msg )); + conn_msg =skb_put (skb,sizeof (struct htc_conn_svc_msg )); conn_msg->service_id =cpu_to_be16 (service_connreq->service_id); conn_msg->msg_id =cpu_to_be16 (HTC_MSG_CONNECT_SERVICE_ID ); conn_msg->con_flags =cpu_to_be16 (service_connreq->con_flags);
drivers/net/wireless/ath/ath9k/wmi.c +1 -1
@@ -311,7 +311,7 @@ int ath9k_wmi_cmd(struct wmi *wmi, enum wmi_cmd_id cmd_id,skb_reserve (skb, headroom);if (cmd_len !=0 && cmd_buf !=NULL ) { - data = (u8 *)skb_put (skb, cmd_len); + data =skb_put (skb, cmd_len);memcpy (data, cmd_buf, cmd_len); }
drivers/net/wireless/ath/wil6210/wmi.c +1 -1
@@ -523,7 +523,7 @@ static void wmi_evt_eapol_rx(struct wil6210_priv *wil, int id,return ; } - eth = (struct ethhdr *)skb_put (skb,ETH_HLEN ); + eth =skb_put (skb,ETH_HLEN );ether_addr_copy (eth->h_dest, ndev->dev_addr);ether_addr_copy (eth->h_source, evt->src_mac); eth->h_proto =cpu_to_be16 (ETH_P_PAE );
drivers/net/wireless/hostap/hostap_ap.c +2 -2
@@ -998,7 +998,7 @@ static void prism2_send_mgmt(struct net_device *dev, fc = type_subtype; hdrlen =hostap_80211_get_hdrlen (cpu_to_le16 (type_subtype)); - hdr = (struct ieee80211_hdr *)skb_put (skb, hdrlen); + hdr =skb_put (skb, hdrlen);if (body)memcpy (skb_put (skb, body_len), body, body_len);
@@ -2364,7 +2364,7 @@ static void schedule_packet_send(local_info_t *local, struct sta_info *sta)return ; } - hdr = (struct ieee80211_hdr *)skb_put (skb,16 ); + hdr =skb_put (skb,16 );/* Generate a fake pspoll frame to start packet delivery */ hdr->frame_control = cpu_to_le16(
drivers/net/wireless/hostap/hostap_main.c +1 -2
@@ -1050,8 +1050,7 @@ int prism2_sta_send_mgmt(local_info_t *local, u8 *dst, u16 stype,if (skb ==NULL )return -ENOMEM ; - mgmt = (struct hostap_ieee80211_mgmt *) -skb_put (skb,IEEE80211_MGMT_HDR_LEN ); + mgmt =skb_put (skb,IEEE80211_MGMT_HDR_LEN );memset (mgmt,0 ,IEEE80211_MGMT_HDR_LEN ); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT | stype);memcpy (mgmt->da, dst,ETH_ALEN );
drivers/net/wireless/ipw2x00/ipw2200.c +1 -1
@@ -10373,7 +10373,7 @@ static void ipw_handle_promiscuous_tx(struct ipw_priv *priv,if (!dst)continue ; - rt_hdr = (void *)skb_put (dst,sizeof (*rt_hdr)); + rt_hdr =skb_put (dst,sizeof (*rt_hdr)); rt_hdr->it_version =PKTHDR_RADIOTAP_VERSION ; rt_hdr->it_pad =0 ;
drivers/net/wireless/ipw2x00/libipw_tx.c +2 -4
@@ -439,8 +439,7 @@ netdev_tx_t libipw_xmit(struct sk_buff *skb, struct net_device *dev)if (rts_required) { skb_frag = txb->fragments[0 ]; - frag_hdr = - (struct libipw_hdr_3addrqos *)skb_put (skb_frag, hdr_len); + frag_hdr =skb_put (skb_frag, hdr_len);/* * Set header frame_ctl to the RTS.
@@ -470,8 +469,7 @@ netdev_tx_t libipw_xmit(struct sk_buff *skb, struct net_device *dev)skb_reserve (skb_frag, crypt->ops->extra_mpdu_prefix_len); - frag_hdr = - (struct libipw_hdr_3addrqos *)skb_put (skb_frag, hdr_len); + frag_hdr =skb_put (skb_frag, hdr_len);memcpy (frag_hdr, &header, hdr_len);/* If this is not the last fragment, then add the MOREFRAGS
drivers/net/wireless/mac80211_hwsim.c +4 -4
@@ -622,7 +622,7 @@ static void hwsim_send_ps_poll(void *dat, u8 *mac, struct ieee80211_vif *vif) skb =dev_alloc_skb (sizeof (*pspoll));if (!skb)return ; - pspoll = (void *)skb_put (skb,sizeof (*pspoll)); + pspoll =skb_put (skb,sizeof (*pspoll)); pspoll->frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_PSPOLL |IEEE80211_FCTL_PM );
@@ -653,7 +653,7 @@ static void hwsim_send_nullfunc(struct mac80211_hwsim_data *data, u8 *mac, skb =dev_alloc_skb (sizeof (*hdr));if (!skb)return ; - hdr = (void *)skb_put (skb,sizeof (*hdr) -ETH_ALEN ); + hdr =skb_put (skb,sizeof (*hdr) -ETH_ALEN ); hdr->frame_control =cpu_to_le16 (IEEE80211_FTYPE_DATA |IEEE80211_STYPE_NULLFUNC | (ps ?IEEE80211_FCTL_PM :0 ));
@@ -861,7 +861,7 @@ static void mac80211_hwsim_monitor_ack(struct ieee80211_channel *chan,if (skb ==NULL )return ; - hdr = (struct hwsim_radiotap_ack_hdr *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr)); hdr->hdr.it_version =PKTHDR_RADIOTAP_VERSION ; hdr->hdr.it_pad =0 ; hdr->hdr.it_len =cpu_to_le16 (sizeof (*hdr));
@@ -873,7 +873,7 @@ static void mac80211_hwsim_monitor_ack(struct ieee80211_channel *chan, flags =IEEE80211_CHAN_2GHZ ; hdr->rt_chbitmask =cpu_to_le16 (flags); - hdr11 = (struct ieee80211_hdr *)skb_put (skb,10 ); + hdr11 =skb_put (skb,10 ); hdr11->frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_ACK ); hdr11->duration_id =cpu_to_le16 (0 );
drivers/net/wireless/mwifiex/11n_aggr.c +1 -1
@@ -62,7 +62,7 @@ mwifiex_11n_form_amsdu_pkt(struct sk_buff *skb_aggr, };struct tx_packet_hdr *tx_header; - tx_header = (void *)skb_put (skb_aggr,sizeof (*tx_header)); + tx_header =skb_put (skb_aggr,sizeof (*tx_header));/* Copy DA and SA */ dt_offset =2 *ETH_ALEN ;
drivers/net/wireless/mwifiex/tdls.c +15 -15
@@ -161,7 +161,7 @@ static void mwifiex_tdls_add_aid(struct mwifiex_private *priv,u8 *pos; assoc_rsp = (struct ieee_types_assoc_rsp *)&priv->assoc_rsp_buf; - pos = (void *)skb_put (skb,4 ); + pos =skb_put (skb,4 ); *pos++ =WLAN_EID_AID ; *pos++ =2 ; *pos++ =le16_to_cpu (assoc_rsp->a_id);
@@ -175,7 +175,7 @@ static int mwifiex_tdls_add_vht_capab(struct mwifiex_private *priv,struct ieee80211_vht_cap vht_cap;u8 *pos; - pos = (void *)skb_put (skb,sizeof (struct ieee80211_vht_cap ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_vht_cap ) +2 ); *pos++ =WLAN_EID_VHT_CAPABILITY ; *pos++ =sizeof (struct ieee80211_vht_cap );
@@ -204,7 +204,7 @@ mwifiex_tdls_add_ht_oper(struct mwifiex_private *priv, const u8 *mac,return -1 ; } - pos = (void *)skb_put (skb,sizeof (struct ieee80211_ht_operation ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_ht_operation ) +2 ); *pos++ =WLAN_EID_HT_OPERATION ; *pos++ =sizeof (struct ieee80211_ht_operation ); ht_oper = (void *)pos;
@@ -262,7 +262,7 @@ static int mwifiex_tdls_add_vht_oper(struct mwifiex_private *priv, ap_vht_cap = bss_desc->bcn_vht_cap; } - pos = (void *)skb_put (skb,sizeof (struct ieee80211_vht_operation ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_vht_operation ) +2 ); *pos++ =WLAN_EID_VHT_OPERATION ; *pos++ =sizeof (struct ieee80211_vht_operation ); vht_oper = (struct ieee80211_vht_operation *)pos;
@@ -349,7 +349,7 @@ static void mwifiex_tdls_add_ext_capab(struct mwifiex_private *priv, {struct ieee_types_extcap *extcap; - extcap = (void *)skb_put (skb,sizeof (struct ieee_types_extcap )); + extcap =skb_put (skb,sizeof (struct ieee_types_extcap )); extcap->ieee_hdr.element_id =WLAN_EID_EXT_CAPABILITY ; extcap->ieee_hdr.len =8 ;memset (extcap->ext_capab,0 ,8 );
@@ -361,7 +361,7 @@ static void mwifiex_tdls_add_ext_capab(struct mwifiex_private *priv,static void mwifiex_tdls_add_qos_capab (struct sk_buff *skb) { -u8 *pos = (void *)skb_put (skb,3 ); +u8 *pos =skb_put (skb,3 ); *pos++ =WLAN_EID_QOS_CAPA ; *pos++ =1 ;
@@ -377,7 +377,7 @@ mwifiex_tdls_add_wmm_param_ie(struct mwifiex_private *priv, struct sk_buff *skb)u8 ac_be[] = {0x03 ,0xa4 ,0x00 ,0x00 };u8 ac_bk[] = {0x27 ,0xa4 ,0x00 ,0x00 }; - wmm = (void *)skb_put (skb,sizeof (*wmm)); + wmm =skb_put (skb,sizeof (*wmm));memset (wmm,0 ,sizeof (*wmm)); wmm->element_id =WLAN_EID_VENDOR_SPECIFIC ;
@@ -403,8 +403,8 @@ mwifiex_add_wmm_info_ie(struct mwifiex_private *priv, struct sk_buff *skb, {u8 *buf; - buf = (void *)skb_put (skb,MWIFIEX_TDLS_WMM_INFO_SIZE + -sizeof (struct ieee_types_header )); + buf =skb_put (skb, +MWIFIEX_TDLS_WMM_INFO_SIZE +sizeof (struct ieee_types_header )); *buf++ =WLAN_EID_VENDOR_SPECIFIC ; *buf++ =7 ;/* len */
@@ -430,7 +430,7 @@ static int mwifiex_prep_tdls_encap_data(struct mwifiex_private *priv, capab = priv->curr_bss_params.bss_descriptor.cap_info_bitmap; - tf = (void *)skb_put (skb, offsetof(struct ieee80211_tdls_data , u)); + tf =skb_put (skb, offsetof(struct ieee80211_tdls_data , u));memcpy (tf->da, peer,ETH_ALEN );memcpy (tf->sa, priv->curr_addr,ETH_ALEN ); tf->ether_type =cpu_to_be16 (ETH_P_TDLS );
@@ -449,7 +449,7 @@ static int mwifiex_prep_tdls_encap_data(struct mwifiex_private *priv,return ret; } - pos = (void *)skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); *pos++ =WLAN_EID_HT_CAPABILITY ; *pos++ =sizeof (struct ieee80211_ht_cap ); ht_cap = (void *)pos;
@@ -487,7 +487,7 @@ static int mwifiex_prep_tdls_encap_data(struct mwifiex_private *priv,return ret; } - pos = (void *)skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); *pos++ =WLAN_EID_HT_CAPABILITY ; *pos++ =sizeof (struct ieee80211_ht_cap ); ht_cap = (void *)pos;
@@ -567,7 +567,7 @@ mwifiex_tdls_add_link_ie(struct sk_buff *skb, const u8 *src_addr, {struct ieee80211_tdls_lnkie *lnkid; - lnkid = (void *)skb_put (skb,sizeof (struct ieee80211_tdls_lnkie )); + lnkid =skb_put (skb,sizeof (struct ieee80211_tdls_lnkie )); lnkid->ie_type =WLAN_EID_LINK_ID ; lnkid->ie_len =sizeof (struct ieee80211_tdls_lnkie ) -sizeof (struct ieee_types_header );
@@ -684,7 +684,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv, capab = priv->curr_bss_params.bss_descriptor.cap_info_bitmap; - mgmt = (void *)skb_put (skb, offsetof(struct ieee80211_mgmt , u)); + mgmt =skb_put (skb, offsetof(struct ieee80211_mgmt , u));memset (mgmt,0 ,24 );memcpy (mgmt->da, peer,ETH_ALEN );
@@ -718,7 +718,7 @@ mwifiex_construct_tdls_action_frame(struct mwifiex_private *priv,return ret; } - pos = (void *)skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); + pos =skb_put (skb,sizeof (struct ieee80211_ht_cap ) +2 ); *pos++ =WLAN_EID_HT_CAPABILITY ; *pos++ =sizeof (struct ieee80211_ht_cap ); ht_cap = (void *)pos;
drivers/net/wireless/p54/fwio.c +21 -22
158 lines not on this page · raw message
drivers/net/wireless/rt2x00/rt2x00debug.c +1 -1
@@ -187,7 +187,7 @@ void rt2x00debug_dump_frame(struct rt2x00_dev *rt2x00dev,return ; } - dump_hdr = (struct rt2x00dump_hdr *)skb_put (skbcopy,sizeof (*dump_hdr)); + dump_hdr =skb_put (skbcopy,sizeof (*dump_hdr)); dump_hdr->version =cpu_to_le32 (DUMP_HEADER_VERSION ); dump_hdr->header_length =cpu_to_le32 (sizeof (*dump_hdr)); dump_hdr->desc_length =cpu_to_le32 (skbdesc->desc_len);
drivers/net/wireless/rtlwifi/base.c +2 -2
@@ -1784,7 +1784,7 @@ static struct sk_buff *rtl_make_smps_action(struct ieee80211_hw *hw,return NULL ;skb_reserve (skb, hw->extra_tx_headroom); - action_frame = (void *)skb_put (skb,27 ); + action_frame =skb_put (skb,27 );memset (action_frame,0 ,27 );memcpy (action_frame->da, da,ETH_ALEN );memcpy (action_frame->sa, rtlefuse->dev_addr,ETH_ALEN );
@@ -1915,7 +1915,7 @@ struct sk_buff *rtl_make_del_ba(struct ieee80211_hw *hw,return NULL ;skb_reserve (skb, hw->extra_tx_headroom); - action_frame = (void *)skb_put (skb,34 ); + action_frame =skb_put (skb,34 );memset (action_frame,0 ,34 );memcpy (action_frame->sa, sa,ETH_ALEN );memcpy (action_frame->da, rtlefuse->dev_addr,ETH_ALEN );
drivers/net/wireless/rtlwifi/pci.c +1 -1
@@ -743,7 +743,7 @@ static void _rtl_pci_rx_to_mac80211(struct ieee80211_hw *hw,if (likely (uskb)) {memcpy (IEEE80211_SKB_RXCB (uskb), &rx_status,sizeof (rx_status)); - pdata = (u8 *)skb_put (uskb, skb->len); + pdata =skb_put (uskb, skb->len);memcpy (pdata, skb->data, skb->len);dev_kfree_skb_any (skb);ieee80211_rx_irqsafe (hw, uskb);
drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c +2 -2
@@ -720,8 +720,8 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet, + totalpacketlen);if (cmd_send_packet) rtstatus =cmd_send_packet (hw, skb);
drivers/net/wireless/rtlwifi/rtl8192de/fw.c +2 -2
@@ -735,8 +735,8 @@ void rtl92d_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool dl_finished)if (!skb) { dlok = false; }else { -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet, + totalpacketlen); rtstatus =_rtl92d_cmd_send_packet (hw, skb);if (rtstatus)
drivers/net/wireless/rtlwifi/rtl8192ee/fw.c +2 -2
@@ -724,8 +724,8 @@ void rtl92ee_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) u1rsvdpageloc, 3); skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet, + totalpacketlen); b_dlok = true;
drivers/net/wireless/rtlwifi/rtl8192se/fw.c +2 -3
@@ -195,8 +195,7 @@ static bool _rtl92s_firmware_downloadcode(struct ieee80211_hw *hw,if (!skb)return false;skb_reserve (skb, extra_descoffset); - seg_ptr = (u8 *)skb_put (skb, (u32)(frag_length - - extra_descoffset)); + seg_ptr =skb_put (skb, (u32)(frag_length - extra_descoffset));memcpy (seg_ptr, code_virtual_address + frag_offset, (u32)(frag_length - extra_descoffset));
@@ -479,7 +478,7 @@ static u32 _rtl92s_fill_h2c_cmd(struct sk_buff *skb, u32 h2cbufferlen,break ;/* Clear content */ - ph2c_buffer = (u8 *)skb_put (skb, (u32 )len); + ph2c_buffer =skb_put (skb, (u32 )len);memset ((ph2c_buffer + totallen + tx_desclen),0 , len);/* CMD len */
drivers/net/wireless/rtlwifi/rtl8723ae/fw.c +2 -2
@@ -471,8 +471,8 @@ void rtl8723e_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, bool b_dl_finished) u1rsvdpageloc, 3); skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet, + totalpacketlen); rtstatus =rtl_cmd_send_packet (hw, skb);
drivers/net/wireless/rtlwifi/rtl8723be/fw.c +2 -2
@@ -465,8 +465,8 @@ void rtl8723be_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, u1rsvdpageloc, 3); skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet, + totalpacketlen); rtstatus =rtl_cmd_send_packet (hw, skb);
drivers/net/wireless/rtlwifi/rtl8821ae/fw.c +4 -4
@@ -1546,8 +1546,8 @@ out: &reserved_page_packet_8812[0], totalpacketlen); skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet_8812, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet_8812, + totalpacketlen); rtstatus =rtl_cmd_send_packet (hw, skb);
@@ -1671,8 +1671,8 @@ out: &reserved_page_packet_8821[0], totalpacketlen); skb =dev_alloc_skb (totalpacketlen); -memcpy ((u8 *)skb_put (skb, totalpacketlen), - &reserved_page_packet_8821, totalpacketlen); +memcpy (skb_put (skb, totalpacketlen), &reserved_page_packet_8821, + totalpacketlen); rtstatus =rtl_cmd_send_packet (hw, skb);
drivers/net/wireless/ti/wlcore/cmd.c +1 -1
@@ -1230,7 +1230,7 @@ int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif)skb_reserve (skb,sizeof (*hdr) +WL1271_EXTRA_SPACE_MAX ); - tmpl = (struct wl12xx_arp_rsp_template *)skb_put (skb,sizeof (*tmpl)); + tmpl =skb_put (skb,sizeof (*tmpl));memset (tmpl,0 ,sizeof (*tmpl));/* llc layer */
drivers/net/wireless/ti/wlcore/main.c +1 -1
@@ -1373,7 +1373,7 @@ static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl)skb_reserve (skb,sizeof (struct wl1271_tx_hw_descr )); - hdr = (struct ieee80211_hdr_3addr *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr));memset (hdr,0 ,sizeof (*hdr)); hdr->frame_control = cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_NULLFUNC |
drivers/nfc/nfcwilink.c +1 -2
@@ -153,8 +153,7 @@ static int nfcwilink_get_bts_file_name(struct nfcwilink *drv, char *file_name)return -ENOMEM ; } - cmd = (struct nci_vs_nfcc_info_cmd *) -skb_put (skb,sizeof (struct nci_vs_nfcc_info_cmd )); + cmd =skb_put (skb,sizeof (struct nci_vs_nfcc_info_cmd )); cmd->gid =NCI_VS_NFCC_INFO_CMD_GID ; cmd->oid =NCI_VS_NFCC_INFO_CMD_OID ; cmd->plen =0 ;
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
@@ -329,7 +329,7 @@ static int bnx2fc_xmit(struct fc_lport *lport, struct fc_frame *fp) frag = &skb_shinfo (skb)->frags[skb_shinfo (skb)->nr_frags -1 ]; cp =kmap_atomic (skb_frag_page (frag)) + frag->page_offset; }else { - cp = (struct fcoe_crc_eof *)skb_put (skb, tlen); + cp =skb_put (skb, tlen); }memset (cp,0 ,sizeof (*cp));
drivers/scsi/fcoe/fcoe.c +1 -1
@@ -1646,7 +1646,7 @@ static int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp) cp =kmap_atomic (skb_frag_page (frag)) + frag->page_offset; }else { - cp = (struct fcoe_crc_eof *)skb_put (skb, tlen); + cp =skb_put (skb, tlen); }memset (cp,0 ,sizeof (*cp));
drivers/scsi/fcoe/fcoe_ctlr.c +1 -1
@@ -657,7 +657,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport,if (op !=ELS_LS_RJT ) { dlen +=sizeof (*mac); - mac = (struct fip_mac_desc *)skb_put (skb,sizeof (*mac)); + mac =skb_put (skb,sizeof (*mac));memset (mac,0 ,sizeof (*mac)); mac->fd_desc.fip_dtype =FIP_DT_MAC ; mac->fd_desc.fip_dlen =sizeof (*mac) /FIP_BPW ;
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c +1 -1
@@ -1461,7 +1461,7 @@ static int ft1000_copy_up_pkt(struct net_device *dev) info->stats.rx_errors++;return FAILURE ; } - pbuffer = (u8 *)skb_put (skb, len +12 ); + pbuffer =skb_put (skb, len +12 );/* Pseudo header */ if (info->AsicID ==ELECTRABUZZ_ID ) {
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c +1 -1
@@ -848,7 +848,7 @@ static int ft1000_copy_up_pkt(struct urb *urb)return -1 ; } - pbuffer = (u8 *)skb_put (skb, len +12 ); + pbuffer =skb_put (skb, len +12 );/* subtract the number of bytes read already */ ptemp = pbuffer;
drivers/staging/ozwpan/ozpd.c +3 -3
@@ -430,7 +430,7 @@ static struct sk_buff *oz_build_frame(struct oz_pd *pd, struct oz_tx_frame *f) goto fail;/* Push the tail to the end of the area we are going to copy to. */ - oz_hdr = (struct oz_hdr *)skb_put (skb, f->total_size); + oz_hdr =skb_put (skb, f->total_size); f->hdr.last_pkt_num = pd->trigger_pkt_num &OZ_LAST_PN_MASK ;memcpy (oz_hdr, &f->hdr,sizeof (struct oz_hdr ));/* Copy the elements into the frame body.
@@ -589,7 +589,7 @@ static int oz_send_isoc_frame(struct oz_pd *pd)kfree_skb (skb);return -1 ; } - oz_hdr = (struct oz_hdr *)skb_put (skb, total_size); + oz_hdr =skb_put (skb, total_size); oz_hdr->control = (OZ_PROTOCOL_VERSION <<OZ_VERSION_SHIFT ) |OZ_F_ISOC ; oz_hdr->last_pkt_num = pd->trigger_pkt_num &OZ_LAST_PN_MASK ; elt = (struct oz_elt *)(oz_hdr+1 );
@@ -743,7 +743,7 @@ int oz_send_isoc_unit(struct oz_pd *pd, u8 ep_num, const u8 *data, int len)/* For audio packet set priority to AC_VO */ skb->priority =0x7 ; size =sizeof (struct oz_hdr ) +sizeof (struct oz_isoc_large ); - oz_hdr = (struct oz_hdr *)skb_put (skb, size); + oz_hdr =skb_put (skb, size); }memcpy (skb_put (skb, len), data, len); size += len;
drivers/staging/ozwpan/ozproto.c +1 -1
@@ -87,7 +87,7 @@ static void oz_send_conn_rsp(struct oz_pd *pd, u8 status)return ;skb_reserve (skb,LL_RESERVED_SPACE (dev));skb_reset_network_header (skb); - oz_hdr = (struct oz_hdr *)skb_put (skb, sz); + oz_hdr =skb_put (skb, sz); elt = (struct oz_elt *)(oz_hdr+1 ); body = (struct oz_elt_connect_rsp *)(elt+1 ); skb->dev = dev;
drivers/staging/rtl8188eu/core/rtw_recv.c +1 -1
@@ -1655,7 +1655,7 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) sub_skb =dev_alloc_skb (nSubframe_Length +12 );if (sub_skb) {skb_reserve (sub_skb,12 ); - data_ptr = (u8 *)skb_put (sub_skb, nSubframe_Length); + data_ptr =skb_put (sub_skb, nSubframe_Length);memcpy (data_ptr, pdata, nSubframe_Length); }else { sub_skb =skb_clone (prframe->pkt,GFP_ATOMIC );
drivers/staging/rtl8192e/rtl819x_BAProc.c +4 -6
@@ -100,8 +100,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,skb_reserve (skb, ieee->tx_headroom); - BAReq = (struct rtllib_hdr_3addr *)skb_put (skb, -sizeof (struct rtllib_hdr_3addr )); + BAReq =skb_put (skb,sizeof (struct rtllib_hdr_3addr ));memcpy (BAReq->addr1, Dst,ETH_ALEN );memcpy (BAReq->addr2, ieee->dev->dev_addr,ETH_ALEN );
@@ -109,7 +108,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,memcpy (BAReq->addr3, ieee->current_network.bssid,ETH_ALEN ); BAReq->frame_ctl =cpu_to_le16 (RTLLIB_STYPE_MANAGE_ACT ); - tag = (u8 *)skb_put (skb,9 ); + tag =skb_put (skb,9 ); *tag++ =ACT_CAT_BA ; *tag++ = type; *tag++ = pBA->DialogToken;
@@ -164,15 +163,14 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,skb_reserve (skb, ieee->tx_headroom); - Delba = (struct rtllib_hdr_3addr *)skb_put (skb, -sizeof (struct rtllib_hdr_3addr )); + Delba =skb_put (skb,sizeof (struct rtllib_hdr_3addr ));memcpy (Delba->addr1, dst,ETH_ALEN );memcpy (Delba->addr2, ieee->dev->dev_addr,ETH_ALEN );memcpy (Delba->addr3, ieee->current_network.bssid,ETH_ALEN ); Delba->frame_ctl =cpu_to_le16 (RTLLIB_STYPE_MANAGE_ACT ); - tag = (u8 *)skb_put (skb,6 ); + tag =skb_put (skb,6 ); *tag++ =ACT_CAT_BA ; *tag++ =ACT_DELBA ;
drivers/staging/rtl8192e/rtllib_rx.c +2 -2
@@ -775,7 +775,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,if (!sub_skb)return 0 ;skb_reserve (sub_skb,12 ); - data_ptr = (u8 *)skb_put (sub_skb, skb->len); + data_ptr =skb_put (sub_skb, skb->len);memcpy (data_ptr, skb->data, skb->len); sub_skb->dev = ieee->dev;
@@ -828,7 +828,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,if (!sub_skb)return 0 ;skb_reserve (sub_skb,12 ); - data_ptr = (u8 *)skb_put (sub_skb, nSubframe_Length); + data_ptr =skb_put (sub_skb, nSubframe_Length);memcpy (data_ptr, skb->data, nSubframe_Length); sub_skb->dev = ieee->dev;
drivers/staging/rtl8192e/rtllib_softmac.c +12 -22
@@ -365,8 +365,7 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)skb_reserve (skb, ieee->tx_headroom); - req = (struct rtllib_probe_request *)skb_put (skb, -sizeof (struct rtllib_probe_request )); + req =skb_put (skb,sizeof (struct rtllib_probe_request )); req->header.frame_ctl =cpu_to_le16 (RTLLIB_STYPE_PROBE_REQ ); req->header.duration_id =0 ;
@@ -374,7 +373,7 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)memcpy (req->header.addr2, ieee->dev->dev_addr,ETH_ALEN );memset (req->header.addr3,0xff ,ETH_ALEN ); - tag = (u8 *)skb_put (skb, len +2 + rate_len); + tag =skb_put (skb, len +2 + rate_len); *tag++ =MFIE_TYPE_SSID ; *tag++ = len;
@@ -806,8 +805,7 @@ inline struct sk_buff *rtllib_authentication_req(struct rtllib_network *beacon,skb_reserve (skb, ieee->tx_headroom); - auth = (struct rtllib_authentication *) -skb_put (skb,sizeof (struct rtllib_authentication )); + auth =skb_put (skb,sizeof (struct rtllib_authentication )); auth->header.frame_ctl =cpu_to_le16 (RTLLIB_STYPE_AUTH );if (challengelen)
@@ -905,8 +903,7 @@ static struct sk_buff *rtllib_probe_resp(struct rtllib_device *ieee, u8 *dest)skb_reserve (skb, ieee->tx_headroom); - beacon_buf = (struct rtllib_probe_response *)skb_put (skb, - (beacon_size - ieee->tx_headroom)); + beacon_buf =skb_put (skb, (beacon_size - ieee->tx_headroom));memcpy (beacon_buf->header.addr1, dest,ETH_ALEN );memcpy (beacon_buf->header.addr2, ieee->dev->dev_addr,ETH_ALEN );memcpy (beacon_buf->header.addr3, ieee->current_network.bssid,ETH_ALEN );
@@ -1000,8 +997,7 @@ static struct sk_buff *rtllib_assoc_resp(struct rtllib_device *ieee, u8 *dest)skb_reserve (skb, ieee->tx_headroom); - assoc = (struct rtllib_assoc_response_frame *) -skb_put (skb,sizeof (struct rtllib_assoc_response_frame )); + assoc =skb_put (skb,sizeof (struct rtllib_assoc_response_frame )); assoc->header.frame_ctl =cpu_to_le16 (RTLLIB_STYPE_ASSOC_RESP );memcpy (assoc->header.addr1, dest,ETH_ALEN );
@@ -1032,7 +1028,7 @@ static struct sk_buff *rtllib_assoc_resp(struct rtllib_device *ieee, u8 *dest)else ieee->assoc_id++; - tag = (u8 *)skb_put (skb, rate_len); + tag =skb_put (skb, rate_len);rtllib_MFIE_Brate (ieee, &tag);rtllib_MFIE_Grate (ieee, &tag);
@@ -1054,8 +1050,7 @@ static struct sk_buff *rtllib_auth_resp(struct rtllib_device *ieee, int status,skb_reserve (skb, ieee->tx_headroom); - auth = (struct rtllib_authentication *) -skb_put (skb,sizeof (struct rtllib_authentication )); + auth =skb_put (skb,sizeof (struct rtllib_authentication )); auth->status =cpu_to_le16 (status); auth->transaction =cpu_to_le16 (2 );
@@ -1081,8 +1076,7 @@ static struct sk_buff *rtllib_null_func(struct rtllib_device *ieee, short pwr)skb_reserve (skb, ieee->tx_headroom); - hdr = (struct rtllib_hdr_3addr *)skb_put (skb, -sizeof (struct rtllib_hdr_3addr )); + hdr =skb_put (skb,sizeof (struct rtllib_hdr_3addr ));memcpy (hdr->addr1, ieee->current_network.bssid,ETH_ALEN );memcpy (hdr->addr2, ieee->dev->dev_addr,ETH_ALEN );
@@ -1108,8 +1102,7 @@ static struct sk_buff *rtllib_pspoll_func(struct rtllib_device *ieee)skb_reserve (skb, ieee->tx_headroom); - hdr = (struct rtllib_pspoll_hdr *)skb_put (skb, -sizeof (struct rtllib_pspoll_hdr )); + hdr =skb_put (skb,sizeof (struct rtllib_pspoll_hdr ));memcpy (hdr->bssid, ieee->current_network.bssid,ETH_ALEN );memcpy (hdr->ta, ieee->dev->dev_addr,ETH_ALEN );
@@ -1258,8 +1251,7 @@ inline struct sk_buff *rtllib_association_req(struct rtllib_network *beacon,skb_reserve (skb, ieee->tx_headroom); - hdr = (struct rtllib_assoc_request_frame *) -skb_put (skb,sizeof (struct rtllib_assoc_request_frame ) +2 ); + hdr =skb_put (skb,sizeof (struct rtllib_assoc_request_frame ) +2 ); hdr->header.frame_ctl =RTLLIB_STYPE_ASSOC_REQ ;
@@ -3512,8 +3504,7 @@ inline struct sk_buff *rtllib_disauth_skb(struct rtllib_network *beacon,skb_reserve (skb, ieee->tx_headroom); - disauth = (struct rtllib_disauth *)skb_put (skb, -sizeof (struct rtllib_disauth )); + disauth =skb_put (skb,sizeof (struct rtllib_disauth )); disauth->header.frame_ctl =cpu_to_le16 (RTLLIB_STYPE_DEAUTH ); disauth->header.duration_id =0 ;
@@ -3539,8 +3530,7 @@ inline struct sk_buff *rtllib_disassociate_skb(struct rtllib_network *beacon,skb_reserve (skb, ieee->tx_headroom); - disass = (struct rtllib_disassoc *)skb_put (skb, -sizeof (struct rtllib_disassoc )); + disass =skb_put (skb,sizeof (struct rtllib_disassoc )); disass->header.frame_ctl =cpu_to_le16 (RTLLIB_STYPE_DISASSOC ); disass->header.duration_id =0 ;
drivers/staging/rtl8192e/rtllib_tx.c +1 -2
@@ -815,8 +815,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev) }else { tcb_desc->bHwSec =0 ; } - frag_hdr = (struct rtllib_hdr_3addrqos *) -skb_put (skb_frag, hdr_len); + frag_hdr =skb_put (skb_frag, hdr_len);memcpy (frag_hdr, &header, hdr_len);/* If this is not the last fragment, then add the
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c +1 -1
@@ -848,7 +848,7 @@ static u8 parse_subframe(struct sk_buff *skb,if (!sub_skb)return 0 ;skb_reserve (sub_skb,12 ); - data_ptr = (u8 *)skb_put (sub_skb, nSubframe_Length); + data_ptr =skb_put (sub_skb, nSubframe_Length);memcpy (data_ptr, skb->data, nSubframe_Length);#endif rxb->subframes[rxb->nr_subframes++] = sub_skb;
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c +9 -12
@@ -339,7 +339,7 @@ inline struct sk_buff *ieee80211_probe_req(struct ieee80211_device *ieee)skb_reserve (skb, ieee->tx_headroom); - req = (struct ieee80211_probe_request *)skb_put (skb,sizeof (struct ieee80211_probe_request )); + req =skb_put (skb,sizeof (struct ieee80211_probe_request )); req->header.frame_ctl =cpu_to_le16 (IEEE80211_STYPE_PROBE_REQ ); req->header.duration_id =0 ;//FIXME: is this OK ?
@@ -347,7 +347,7 @@ inline struct sk_buff *ieee80211_probe_req(struct ieee80211_device *ieee)memcpy (req->header.addr2, ieee->dev->dev_addr,ETH_ALEN );memset (req->header.addr3,0xff ,ETH_ALEN ); - tag = (u8 *)skb_put (skb,len+2 +rate_len); + tag =skb_put (skb, len +2 + rate_len); *tag++ =MFIE_TYPE_SSID ; *tag++ = len;
@@ -657,8 +657,7 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *beif (!skb)return NULL ;skb_reserve (skb, ieee->tx_headroom); - auth = (struct ieee80211_authentication *) -skb_put (skb,sizeof (struct ieee80211_authentication )); + auth =skb_put (skb,sizeof (struct ieee80211_authentication )); auth->header.frame_ctl =IEEE80211_STYPE_AUTH ;if (challengelen) auth->header.frame_ctl |=IEEE80211_FCTL_WEP ;
@@ -763,7 +762,7 @@ static struct sk_buff *ieee80211_probe_resp(struct ieee80211_device *ieee, u8 *dif (!skb)return NULL ;skb_reserve (skb, ieee->tx_headroom); - beacon_buf = (struct ieee80211_probe_response *)skb_put (skb, (beacon_size - ieee->tx_headroom)); + beacon_buf =skb_put (skb, (beacon_size - ieee->tx_headroom));memcpy (beacon_buf->header.addr1, dest,ETH_ALEN );memcpy (beacon_buf->header.addr2, ieee->dev->dev_addr,ETH_ALEN );memcpy (beacon_buf->header.addr3, ieee->current_network.bssid,ETH_ALEN );
@@ -859,8 +858,7 @@ static struct sk_buff *ieee80211_assoc_resp(struct ieee80211_device *ieee,skb_reserve (skb, ieee->tx_headroom); - assoc = (struct ieee80211_assoc_response_frame *) -skb_put (skb,sizeof (struct ieee80211_assoc_response_frame )); + assoc =skb_put (skb,sizeof (struct ieee80211_assoc_response_frame )); assoc->header.frame_ctl =cpu_to_le16 (IEEE80211_STYPE_ASSOC_RESP );memcpy (assoc->header.addr1, dest,ETH_ALEN );
@@ -887,7 +885,7 @@ static struct sk_buff *ieee80211_assoc_resp(struct ieee80211_device *ieee,if (ieee->assoc_id ==0x2007 ) ieee->assoc_id=0 ;else ieee->assoc_id++; - tag = (u8 *)skb_put (skb, rate_len); + tag =skb_put (skb, rate_len);ieee80211_MFIE_Brate (ieee, &tag);ieee80211_MFIE_Grate (ieee, &tag);
@@ -935,7 +933,7 @@ static struct sk_buff *ieee80211_null_func(struct ieee80211_device *ieee,if (!skb)return NULL ; - hdr = (struct ieee80211_hdr_3addr *)skb_put (skb,sizeof (struct ieee80211_hdr_3addr )); + hdr =skb_put (skb,sizeof (struct ieee80211_hdr_3addr ));memcpy (hdr->addr1, ieee->current_network.bssid,ETH_ALEN );memcpy (hdr->addr2, ieee->dev->dev_addr,ETH_ALEN );
@@ -1079,8 +1077,7 @@ inline struct sk_buff *ieee80211_association_req(struct ieee80211_network *beacoskb_reserve (skb, ieee->tx_headroom); - hdr = (struct ieee80211_assoc_request_frame *) -skb_put (skb,sizeof (struct ieee80211_assoc_request_frame )+2 ); + hdr =skb_put (skb,sizeof (struct ieee80211_assoc_request_frame ) +2 ); hdr->header.frame_ctl =IEEE80211_STYPE_ASSOC_REQ ;
@@ -3118,7 +3115,7 @@ inline struct sk_buff *ieee80211_disassociate_skb(if (!skb)return NULL ; - disass = (struct ieee80211_disassoc *)skb_put (skb,sizeof (struct ieee80211_disassoc )); + disass =skb_put (skb,sizeof (struct ieee80211_disassoc )); disass->header.frame_ctl =cpu_to_le16 (IEEE80211_STYPE_DISASSOC ); disass->header.duration_id =0 ;
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c +1 -1
@@ -787,7 +787,7 @@ int ieee80211_xmit(struct sk_buff *skb, struct net_device *dev) { tcb_desc->bHwSec =0 ; } - frag_hdr = (struct ieee80211_hdr_3addrqos *)skb_put (skb_frag, hdr_len); + frag_hdr =skb_put (skb_frag, hdr_len);memcpy (frag_hdr, &header, hdr_len);/* If this is not the last fragment, then add the MOREFRAGS
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +4 -4
@@ -130,7 +130,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, Pmemset (skb->data,0 ,sizeof (struct ieee80211_hdr_3addr ));//I wonder whether it's necessary. Apparently kernel will not do it when alloc a skb. skb_reserve (skb, ieee->tx_headroom); - BAReq = (struct ieee80211_hdr_3addr *)skb_put (skb,sizeof (struct ieee80211_hdr_3addr )); + BAReq =skb_put (skb,sizeof (struct ieee80211_hdr_3addr ));memcpy (BAReq->addr1, Dst,ETH_ALEN );memcpy (BAReq->addr2, ieee->dev->dev_addr,ETH_ALEN );
@@ -140,7 +140,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, P BAReq->frame_ctl =cpu_to_le16 (IEEE80211_STYPE_MANAGE_ACT );//action frame //tag += sizeof( struct ieee80211_hdr_3addr); //move to action field - tag = (u8 *)skb_put (skb,9 ); + tag =skb_put (skb,9 ); *tag ++=ACT_CAT_BA ; *tag ++= type;// Dialog Token
@@ -217,14 +217,14 @@ static struct sk_buff *ieee80211_DELBA(// memset(skb->data, 0, len+sizeof( struct ieee80211_hdr_3addr)); skb_reserve (skb, ieee->tx_headroom); - Delba = (struct ieee80211_hdr_3addr *)skb_put (skb,sizeof (struct ieee80211_hdr_3addr )); + Delba =skb_put (skb,sizeof (struct ieee80211_hdr_3addr ));memcpy (Delba->addr1, dst,ETH_ALEN );memcpy (Delba->addr2, ieee->dev->dev_addr,ETH_ALEN );memcpy (Delba->addr3, ieee->current_network.bssid,ETH_ALEN ); Delba->frame_ctl =cpu_to_le16 (IEEE80211_STYPE_MANAGE_ACT );//action frame - tag = (u8 *)skb_put (skb,6 ); + tag =skb_put (skb,6 ); *tag ++=ACT_CAT_BA ; *tag ++=ACT_DELBA ;
drivers/staging/rtl8712/rtl8712_recv.c +1 -1
@@ -362,7 +362,7 @@ static int amsdu_to_msdu(struct _adapter *padapter, union recv_frame *prframe)if (!sub_skb)break ;skb_reserve (sub_skb,12 ); - data_ptr = (u8 *)skb_put (sub_skb, nSubframe_Length); + data_ptr =skb_put (sub_skb, nSubframe_Length);memcpy (data_ptr, pdata, nSubframe_Length); subframes[nr_subframes++] = sub_skb;if (nr_subframes >=MAX_SUBFRAME_COUNT ) {
drivers/usb/gadget/function/f_ncm.c +9 -10
@@ -933,17 +933,17 @@ static struct sk_buff *package_for_tx(struct f_ncm *ncm) }/* Insert NDP alignment. */ - ntb_iter = (void *)skb_put (skb2, ndp_pad); + ntb_iter =skb_put (skb2, ndp_pad);memset (ntb_iter,0 , ndp_pad);/* Copy NTB across. */ - ntb_iter = (void *)skb_put (skb2, ncm->skb_tx_ndp->len); + ntb_iter =skb_put (skb2, ncm->skb_tx_ndp->len);memcpy (ntb_iter, ncm->skb_tx_ndp->data, ncm->skb_tx_ndp->len);dev_kfree_skb_any (ncm->skb_tx_ndp); ncm->skb_tx_ndp =NULL ;/* Insert zero'd datagram. */ - ntb_iter = (void *)skb_put (skb2, dgram_idx_len); + ntb_iter =skb_put (skb2, dgram_idx_len);memset (ntb_iter,0 , dgram_idx_len);return skb2;
@@ -978,7 +978,7 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port, crc = ~crc32_le (~0 , skb->data, skb->len); - crc_pos = (void *)skb_put (skb,sizeof (uint32_t )); + crc_pos =skb_put (skb,sizeof (uint32_t ));put_unaligned_le32 (crc, crc_pos); }
@@ -1008,7 +1008,7 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,if (!ncm->skb_tx_data) goto err; - ntb_data = (void *)skb_put (ncm->skb_tx_data, ncb_len); + ntb_data =skb_put (ncm->skb_tx_data, ncb_len);memset (ntb_data,0 , ncb_len);/* dwSignature */ put_unaligned_le32 (opts->nth_sign, ntb_data);
@@ -1026,8 +1026,7 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port, GFP_ATOMIC);if (!ncm->skb_tx_ndp) goto err; - ntb_ndp = (void *)skb_put (ncm->skb_tx_ndp, - opts->ndp_size); + ntb_ndp =skb_put (ncm->skb_tx_ndp, opts->ndp_size);memset (ntb_ndp,0 , ncb_len);/* dwSignature */ put_unaligned_le32 (ncm->ndp_sign, ntb_ndp);
@@ -1045,7 +1044,7 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port, HRTIMER_MODE_REL);/* Add the datagram position entries */ - ntb_ndp = (void *)skb_put (ncm->skb_tx_ndp, dgram_idx_len); + ntb_ndp =skb_put (ncm->skb_tx_ndp, dgram_idx_len);memset (ntb_ndp,0 , dgram_idx_len); ncb_len = ncm->skb_tx_data->len;
@@ -1059,9 +1058,9 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port, ncm->ndp_dgram_count++;/* Add the new data to the skb */ - ntb_data = (void *)skb_put (ncm->skb_tx_data, dgram_pad); + ntb_data =skb_put (ncm->skb_tx_data, dgram_pad);memset (ntb_data,0 , dgram_pad); - ntb_data = (void *)skb_put (ncm->skb_tx_data, skb->len); + ntb_data =skb_put (ncm->skb_tx_data, skb->len);memcpy (ntb_data, skb->data, skb->len);dev_kfree_skb_any (skb); skb =NULL ;
lib/nlattr.c +1 -1
@@ -344,7 +344,7 @@ struct nlattr *__nla_reserve(struct sk_buff *skb, int attrtype, int attrlen) {struct nlattr *nla; - nla = (struct nlattr *)skb_put (skb,nla_total_size (attrlen)); + nla =skb_put (skb,nla_total_size (attrlen)); nla->nla_type = attrtype; nla->nla_len =nla_attr_size (attrlen);
net/appletalk/ddp.c +1 -1
@@ -1647,7 +1647,7 @@ static int atalk_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)SOCK_DEBUG (sk,"SK %p: Begin build.\n" , sk); - ddp = (struct ddpehdr *)skb_put (skb,sizeof (struct ddpehdr )); + ddp =skb_put (skb,sizeof (struct ddpehdr )); ddp->deh_len_hops =htons (len +sizeof (*ddp)); ddp->deh_dnet = usat->sat_addr.s_net; ddp->deh_snet = at->src_net;
net/atm/clip.c +1 -1
@@ -60,7 +60,7 @@ static int to_atmarpd(enum atmarp_ctrl_type type, int itf, __be32 ip) skb =alloc_skb (sizeof (struct atmarp_ctrl ),GFP_ATOMIC );if (!skb)return -ENOMEM ; - ctrl = (struct atmarp_ctrl *)skb_put (skb,sizeof (struct atmarp_ctrl )); + ctrl =skb_put (skb,sizeof (struct atmarp_ctrl )); ctrl->type = type; ctrl->itf_num = itf; ctrl->ip = ip;
net/atm/signaling.c +1 -1
@@ -150,7 +150,7 @@ void sigd_enq2(struct atm_vcc *vcc, enum atmsvc_msg_type type,pr_debug ("%d (0x%p)\n" , (int )type, vcc);while (!(skb =alloc_skb (sizeof (struct atmsvc_msg ),GFP_KERNEL )))schedule (); - msg = (struct atmsvc_msg *)skb_put (skb,sizeof (struct atmsvc_msg )); + msg =skb_put (skb,sizeof (struct atmsvc_msg ));memset (msg,0 ,sizeof (*msg)); msg->type = type; *(struct atm_vcc **) &msg->vcc = vcc;
net/batman-adv/icmp_socket.c +1 -1
@@ -186,7 +186,7 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff, skb->priority =TC_PRIO_CONTROL ;skb_reserve (skb,ETH_HLEN ); - icmp_header = (struct batadv_icmp_header *)skb_put (skb, packet_len); + icmp_header =skb_put (skb, packet_len);if (copy_from_user (icmp_header, buff, packet_len)) { len = -EFAULT ;
net/bluetooth/hci_request.c +1 -1
@@ -89,7 +89,7 @@ struct sk_buff *hci_prepare_cmd(struct hci_dev *hdev, u16 opcode, u32 plen,if (!skb)return NULL ; - hdr = (struct hci_command_hdr *)skb_put (skb,HCI_COMMAND_HDR_SIZE ); + hdr =skb_put (skb,HCI_COMMAND_HDR_SIZE ); hdr->opcode =cpu_to_le16 (opcode); hdr->plen = plen;
net/bluetooth/hci_sock.c +3 -3
@@ -312,7 +312,7 @@ static struct sk_buff *create_monitor_event(struct hci_dev *hdev, int event)if (!skb)return NULL ; - ni = (void *)skb_put (skb,HCI_MON_NEW_INDEX_SIZE ); + ni =skb_put (skb,HCI_MON_NEW_INDEX_SIZE ); ni->type = hdev->dev_type; ni->bus = hdev->bus;bacpy (&ni->bdaddr, &hdev->bdaddr);
@@ -374,11 +374,11 @@ static void hci_si_event(struct hci_dev *hdev, int type, int dlen, void *data)if (!skb)return ; - hdr = (void *)skb_put (skb,HCI_EVENT_HDR_SIZE ); + hdr =skb_put (skb,HCI_EVENT_HDR_SIZE ); hdr->evt =HCI_EV_STACK_INTERNAL ; hdr->plen =sizeof (*ev) + dlen; - ev = (void *)skb_put (skb,sizeof (*ev) + dlen); + ev =skb_put (skb,sizeof (*ev) + dlen); ev->type = type;memcpy (ev->data, data, dlen);
net/bluetooth/l2cap_core.c +8 -8
@@ -1037,7 +1037,7 @@ static struct sk_buff *l2cap_create_sframe_pdu(struct l2cap_chan *chan,if (!skb)return ERR_PTR (-ENOMEM ); - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->len =cpu_to_le16 (hlen -L2CAP_HDR_SIZE ); lh->cid =cpu_to_le16 (chan->dcid);
@@ -2175,10 +2175,10 @@ static struct sk_buff *l2cap_create_connless_pdu(struct l2cap_chan *chan,return skb;/* Create L2CAP header */ - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->cid =cpu_to_le16 (chan->dcid); lh->len =cpu_to_le16 (len +L2CAP_PSMLEN_SIZE ); -put_unaligned (chan->psm, (__le16 *)skb_put (skb,L2CAP_PSMLEN_SIZE )); +put_unaligned (chan->psm,skb_put (skb,L2CAP_PSMLEN_SIZE )); err =l2cap_skbuff_fromiovec (chan, msg, len, count, skb);if (unlikely (err <0 )) {
@@ -2206,7 +2206,7 @@ static struct sk_buff *l2cap_create_basic_pdu(struct l2cap_chan *chan,return skb;/* Create L2CAP header */ - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->cid =cpu_to_le16 (chan->dcid); lh->len =cpu_to_le16 (len);
@@ -2248,7 +2248,7 @@ static struct sk_buff *l2cap_create_iframe_pdu(struct l2cap_chan *chan,return skb;/* Create L2CAP header */ - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->cid =cpu_to_le16 (chan->dcid); lh->len =cpu_to_le16 (len + (hlen -L2CAP_HDR_SIZE ));
@@ -2366,7 +2366,7 @@ static struct sk_buff *l2cap_create_le_flowctl_pdu(struct l2cap_chan *chan,return skb;/* Create L2CAP header */ - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->cid =cpu_to_le16 (chan->dcid); lh->len =cpu_to_le16 (len + (hlen -L2CAP_HDR_SIZE ));
@@ -2891,7 +2891,7 @@ static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn, u8 code,if (!skb)return NULL ; - lh = (struct l2cap_hdr *)skb_put (skb,L2CAP_HDR_SIZE ); + lh =skb_put (skb,L2CAP_HDR_SIZE ); lh->len =cpu_to_le16 (L2CAP_CMD_HDR_SIZE + dlen);if (conn->hcon->type ==LE_LINK )
@@ -2899,7 +2899,7 @@ static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn, u8 code,else lh->cid =cpu_to_le16 (L2CAP_CID_SIGNALING ); - cmd = (struct l2cap_cmd_hdr *)skb_put (skb,L2CAP_CMD_HDR_SIZE ); + cmd =skb_put (skb,L2CAP_CMD_HDR_SIZE ); cmd->code = code; cmd->ident = ident; cmd->len =cpu_to_le16 (dlen);
net/bluetooth/mgmt_util.c +5 -5
@@ -37,7 +37,7 @@ int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel,if (!skb)return -ENOMEM ; - hdr = (void *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr)); hdr->opcode =cpu_to_le16 (event);if (hdev) hdr->index =cpu_to_le16 (hdev->id);
@@ -70,13 +70,13 @@ int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status)if (!skb)return -ENOMEM ; - hdr = (void *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr)); hdr->opcode =cpu_to_le16 (MGMT_EV_CMD_STATUS ); hdr->index =cpu_to_le16 (index); hdr->len =cpu_to_le16 (sizeof (*ev)); - ev = (void *)skb_put (skb,sizeof (*ev)); + ev =skb_put (skb,sizeof (*ev)); ev->status = status; ev->opcode =cpu_to_le16 (cmd);
@@ -101,13 +101,13 @@ int mgmt_cmd_complete(struct sock *sk, u16 index, u16 cmd, u8 status,if (!skb)return -ENOMEM ; - hdr = (void *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr)); hdr->opcode =cpu_to_le16 (MGMT_EV_CMD_COMPLETE ); hdr->index =cpu_to_le16 (index); hdr->len =cpu_to_le16 (sizeof (*ev) + rp_len); - ev = (void *)skb_put (skb,sizeof (*ev) + rp_len); + ev =skb_put (skb,sizeof (*ev) + rp_len); ev->opcode =cpu_to_le16 (cmd); ev->status = status;
net/bridge/netfilter/nft_reject_bridge.c +2 -2
@@ -122,7 +122,7 @@ static void nft_reject_br_send_v4_unreach(struct sk_buff *oldskb, sysctl_ip_default_ttl);skb_reset_transport_header (nskb); - icmph = (struct icmphdr *)skb_put (nskb,sizeof (struct icmphdr )); + icmph =skb_put (nskb,sizeof (struct icmphdr ));memset (icmph,0 ,sizeof (*icmph)); icmph->type =ICMP_DEST_UNREACH ; icmph->code = code;
@@ -234,7 +234,7 @@ static void nft_reject_br_send_v6_unreach(struct net *net, net->ipv6.devconf_all->hop_limit);skb_reset_transport_header (nskb); - icmp6h = (struct icmp6hdr *)skb_put (nskb,sizeof (struct icmp6hdr )); + icmp6h =skb_put (nskb,sizeof (struct icmp6hdr ));memset (icmp6h,0 ,sizeof (*icmp6h)); icmp6h->icmp6_type =ICMPV6_DEST_UNREACH ; icmp6h->icmp6_code = code;
net/core/pktgen.c +17 -15
@@ -2655,7 +2655,7 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb,struct timeval timestamp;struct pktgen_hdr *pgh; - pgh = (struct pktgen_hdr *)skb_put (skb,sizeof (*pgh)); + pgh =skb_put (skb,sizeof (*pgh)); datalen -=sizeof (*pgh);if (pkt_dev->nfrags <=0 ) {
@@ -2784,33 +2784,34 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,/* Reserve for ethernet and IP header */ eth = (__u8 *)skb_push (skb,14 ); - mpls = (__be32 *)skb_put (skb, pkt_dev->nr_labels*sizeof (__u32)); + mpls =skb_put (skb, pkt_dev->nr_labels *sizeof (__u32));if (pkt_dev->nr_labels)mpls_push (mpls, pkt_dev);if (pkt_dev->vlan_id !=0xffff ) {if (pkt_dev->svlan_id !=0xffff ) { - svlan_tci = (__be16 *)skb_put (skb,sizeof (__be16)); + svlan_tci =skb_put (skb,sizeof (__be16)); *svlan_tci =build_tci (pkt_dev->svlan_id, pkt_dev->svlan_cfi, pkt_dev->svlan_p); - svlan_encapsulated_proto = (__be16 *)skb_put (skb,sizeof (__be16)); + svlan_encapsulated_proto =skb_put (skb, +sizeof (__be16)); *svlan_encapsulated_proto =htons (ETH_P_8021Q ); } - vlan_tci = (__be16 *)skb_put (skb,sizeof (__be16)); + vlan_tci =skb_put (skb,sizeof (__be16)); *vlan_tci =build_tci (pkt_dev->vlan_id, pkt_dev->vlan_cfi, pkt_dev->vlan_p); - vlan_encapsulated_proto = (__be16 *)skb_put (skb,sizeof (__be16)); + vlan_encapsulated_proto =skb_put (skb,sizeof (__be16)); *vlan_encapsulated_proto =htons (ETH_P_IP ); }skb_set_mac_header (skb,0 );skb_set_network_header (skb, skb->len); - iph = (struct iphdr *)skb_put (skb,sizeof (struct iphdr )); + iph =skb_put (skb,sizeof (struct iphdr ));skb_set_transport_header (skb, skb->len); - udph = (struct udphdr *)skb_put (skb,sizeof (struct udphdr )); + udph =skb_put (skb,sizeof (struct udphdr ));skb_set_queue_mapping (skb, queue_map); skb->priority = pkt_dev->skb_priority;
@@ -2911,33 +2912,34 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,/* Reserve for ethernet and IP header */ eth = (__u8 *)skb_push (skb,14 ); - mpls = (__be32 *)skb_put (skb, pkt_dev->nr_labels*sizeof (__u32)); + mpls =skb_put (skb, pkt_dev->nr_labels *sizeof (__u32));if (pkt_dev->nr_labels)mpls_push (mpls, pkt_dev);if (pkt_dev->vlan_id !=0xffff ) {if (pkt_dev->svlan_id !=0xffff ) { - svlan_tci = (__be16 *)skb_put (skb,sizeof (__be16)); + svlan_tci =skb_put (skb,sizeof (__be16)); *svlan_tci =build_tci (pkt_dev->svlan_id, pkt_dev->svlan_cfi, pkt_dev->svlan_p); - svlan_encapsulated_proto = (__be16 *)skb_put (skb,sizeof (__be16)); + svlan_encapsulated_proto =skb_put (skb, +sizeof (__be16)); *svlan_encapsulated_proto =htons (ETH_P_8021Q ); } - vlan_tci = (__be16 *)skb_put (skb,sizeof (__be16)); + vlan_tci =skb_put (skb,sizeof (__be16)); *vlan_tci =build_tci (pkt_dev->vlan_id, pkt_dev->vlan_cfi, pkt_dev->vlan_p); - vlan_encapsulated_proto = (__be16 *)skb_put (skb,sizeof (__be16)); + vlan_encapsulated_proto =skb_put (skb,sizeof (__be16)); *vlan_encapsulated_proto =htons (ETH_P_IPV6 ); }skb_set_mac_header (skb,0 );skb_set_network_header (skb, skb->len); - iph = (struct ipv6hdr *)skb_put (skb,sizeof (struct ipv6hdr )); + iph =skb_put (skb,sizeof (struct ipv6hdr ));skb_set_transport_header (skb, skb->len); - udph = (struct udphdr *)skb_put (skb,sizeof (struct udphdr )); + udph =skb_put (skb,sizeof (struct udphdr ));skb_set_queue_mapping (skb, queue_map); skb->priority = pkt_dev->skb_priority;
net/decnet/dn_dev.c +1 -1
@@ -842,7 +842,7 @@ static void dn_send_endnode_hello(struct net_device *dev, struct dn_ifaddr *ifa) skb->dev = dev; - msg = (struct endnode_hello_message *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); msg->msgflg =0x0D ;memcpy (msg->tiver, dn_eco_version,3 );
net/decnet/dn_nsp_out.c +3 -3
@@ -484,7 +484,7 @@ void dn_send_conn_ack (struct sock *sk)if ((skb =dn_alloc_skb (sk,3 , sk->sk_allocation)) ==NULL )return ; - msg = (struct nsp_conn_ack_msg *)skb_put (skb,3 ); + msg =skb_put (skb,3 ); msg->msgflg =0x24 ; msg->dstaddr = scp->addrrem;
@@ -522,7 +522,7 @@ void dn_send_conn_conf(struct sock *sk, gfp_t gfp)if ((skb =dn_alloc_skb (sk,50 + len, gfp)) ==NULL )return ; - msg = (struct nsp_conn_init_msg *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); msg->msgflg =0x28 ; msg->dstaddr = scp->addrrem; msg->srcaddr = scp->addrloc;
@@ -662,7 +662,7 @@ void dn_nsp_send_conninit(struct sock *sk, unsigned char msgflg)return ; cb =DN_SKB_CB (skb); - msg = (struct nsp_conn_init_msg *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); msg->msgflg = msgflg; msg->dstaddr =0x0000 ;/* Remote Node will assign it*/
net/ipv4/arp.c +1 -1
@@ -500,7 +500,7 @@ struct sk_buff *arp_create(int type, int ptype, __be32 dest_ip,skb_reserve (skb, hlen);skb_reset_network_header (skb); - arp = (struct arphdr *)skb_put (skb,arp_hdr_len (dev)); + arp =skb_put (skb,arp_hdr_len (dev)); skb->dev = dev; skb->protocol =htons (ETH_P_ARP );if (!src_hw)
net/ipv4/igmp.c +3 -3
@@ -413,7 +413,7 @@ static struct sk_buff *add_grhead(struct sk_buff *skb, struct ip_mc_list *pmc, skb =igmpv3_newpack (dev, dev->mtu);if (!skb)return NULL ; - pgr = (struct igmpv3_grec *)skb_put (skb,sizeof (struct igmpv3_grec )); + pgr =skb_put (skb,sizeof (struct igmpv3_grec )); pgr->grec_type = type; pgr->grec_auxwords =0 ; pgr->grec_nsrcs =0 ;
@@ -495,7 +495,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ip_mc_list *pmc, }if (!skb)return NULL ; - psrc = (__be32 *)skb_put (skb,sizeof (__be32)); + psrc =skb_put (skb,sizeof (__be32)); *psrc = psf->sf_inaddr; scount++; stotal++; if ((type == IGMPV3_ALLOW_NEW_SOURCES ||
@@ -720,7 +720,7 @@ static int igmp_send_report(struct in_device *in_dev, struct ip_mc_list *pmc, ((u8 *)&iph[1 ])[2 ] =0 ; ((u8 *)&iph[1 ])[3 ] =0 ; - ih = (struct igmphdr *)skb_put (skb,sizeof (struct igmphdr )); + ih =skb_put (skb,sizeof (struct igmphdr )); ih->type = type; ih->code =0 ; ih->csum =0 ;
net/ipv4/ipconfig.c +1 -1
@@ -805,7 +805,7 @@ static void __init ic_bootp_send_if(struct ic_device *d, unsigned long jiffies_dif (!skb)return ;skb_reserve (skb, hlen); - b = (struct bootp_pkt *)skb_put (skb,sizeof (struct bootp_pkt )); + b =skb_put (skb,sizeof (struct bootp_pkt ));memset (b,0 ,sizeof (struct bootp_pkt ));/* Construct IP header */
net/ipv4/ipmr.c +1 -1
@@ -1003,7 +1003,7 @@ static int ipmr_cache_report(struct mr_table *mrt,/* Add our header */ - igmp = (struct igmphdr *)skb_put (skb,sizeof (struct igmphdr )); + igmp =skb_put (skb,sizeof (struct igmphdr )); igmp->type = msg->im_msgtype = assert; igmp->code =0 ;
net/ipv4/netfilter/ipt_SYNPROXY.c +5 -5
@@ -23,7 +23,7 @@ synproxy_build_ip(struct sk_buff *skb, u32 saddr, u32 daddr)struct iphdr *iph;skb_reset_network_header (skb); - iph = (struct iphdr *)skb_put (skb,sizeof (*iph)); + iph =skb_put (skb,sizeof (*iph)); iph->version =4 ; iph->ihl =sizeof (*iph) /4 ; iph->tos =0 ;
@@ -89,7 +89,7 @@ synproxy_send_client_synack(const struct sk_buff *skb, const struct tcphdr *th, niph =synproxy_build_ip (nskb, iph->daddr, iph->saddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->dest; nth->dest = th->source; nth->seq =htonl (__cookie_v4_init_sequence (iph, th, &mss));
@@ -130,7 +130,7 @@ synproxy_send_server_syn(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, iph->saddr, iph->daddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->source; nth->dest = th->dest; nth->seq =htonl (recv_seq -1 );
@@ -175,7 +175,7 @@ synproxy_send_server_ack(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, iph->daddr, iph->saddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->dest; nth->dest = th->source; nth->seq =htonl (ntohl (th->ack_seq));
@@ -213,7 +213,7 @@ synproxy_send_client_ack(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, iph->saddr, iph->daddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->source; nth->dest = th->dest; nth->seq =htonl (ntohl (th->seq) +1 );
net/ipv4/netfilter/nf_reject_ipv4.c +2 -2
@@ -49,7 +49,7 @@ struct iphdr *nf_reject_iphdr_put(struct sk_buff *nskb,struct iphdr *niph, *oiph =ip_hdr (oldskb);skb_reset_network_header (nskb); - niph = (struct iphdr *)skb_put (nskb,sizeof (struct iphdr )); + niph =skb_put (nskb,sizeof (struct iphdr )); niph->version =4 ; niph->ihl =sizeof (struct iphdr ) /4 ; niph->tos =0 ;
@@ -74,7 +74,7 @@ void nf_reject_ip_tcphdr_put(struct sk_buff *nskb, const struct sk_buff *oldskb,struct tcphdr *tcph;skb_reset_transport_header (nskb); - tcph = (struct tcphdr *)skb_put (nskb,sizeof (struct tcphdr )); + tcph =skb_put (nskb,sizeof (struct tcphdr ));memset (tcph,0 ,sizeof (*tcph)); tcph->source = oth->dest; tcph->dest = oth->source;
net/ipv6/mcast.c +3 -3
@@ -1680,7 +1680,7 @@ static struct sk_buff *add_grhead(struct sk_buff *skb, struct ifmcaddr6 *pmc, skb =mld_newpack (pmc->idev, dev->mtu);if (!skb)return NULL ; - pgr = (struct mld2_grec *)skb_put (skb,sizeof (struct mld2_grec )); + pgr =skb_put (skb,sizeof (struct mld2_grec )); pgr->grec_type = type; pgr->grec_auxwords =0 ; pgr->grec_nsrcs =0 ;
@@ -1763,7 +1763,7 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ifmcaddr6 *pmc, }if (!skb)return NULL ; - psrc = (struct in6_addr *)skb_put (skb,sizeof (*psrc)); + psrc =skb_put (skb,sizeof (*psrc)); *psrc = psf->sf_addr; scount++; stotal++; if ((type == MLD2_ALLOW_NEW_SOURCES ||
@@ -1986,7 +1986,7 @@ static void igmp6_send(struct in6_addr *addr, struct net_device *dev, int type)memcpy (skb_put (skb,sizeof (ra)), ra,sizeof (ra)); - hdr = (struct mld_msg *)skb_put (skb,sizeof (struct mld_msg )); + hdr =skb_put (skb,sizeof (struct mld_msg ));memset (hdr,0 ,sizeof (struct mld_msg )); hdr->mld_type = type; hdr->mld_mca = *addr;
net/ipv6/ndisc.c +4 -4
@@ -511,7 +511,7 @@ void ndisc_send_na(struct net_device *dev, struct neighbour *neigh,if (!skb)return ; - msg = (struct nd_msg *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); *msg = (struct nd_msg ) { .icmph = { .icmp6_type =NDISC_NEIGHBOUR_ADVERTISEMENT ,
@@ -577,7 +577,7 @@ void ndisc_send_ns(struct net_device *dev, struct neighbour *neigh,if (!skb)return ; - msg = (struct nd_msg *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); *msg = (struct nd_msg ) { .icmph = { .icmp6_type =NDISC_NEIGHBOUR_SOLICITATION ,
@@ -629,7 +629,7 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,if (!skb)return ; - msg = (struct rs_msg *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg)); *msg = (struct rs_msg ) { .icmph = { .icmp6_type =NDISC_ROUTER_SOLICITATION ,
@@ -1543,7 +1543,7 @@ void ndisc_send_redirect(struct sk_buff *skb, const struct in6_addr *target)if (!buff) goto release; - msg = (struct rd_msg *)skb_put (buff,sizeof (*msg)); + msg =skb_put (buff,sizeof (*msg)); *msg = (struct rd_msg ) { .icmph = { .icmp6_type =NDISC_REDIRECT ,
net/ipv6/netfilter/ip6t_SYNPROXY.c +5 -5
@@ -26,7 +26,7 @@ synproxy_build_ip(struct sk_buff *skb, const struct in6_addr *saddr,struct ipv6hdr *iph;skb_reset_network_header (skb); - iph = (struct ipv6hdr *)skb_put (skb,sizeof (*iph)); + iph =skb_put (skb,sizeof (*iph));ip6_flow_hdr (iph,0 ,0 ); iph->hop_limit =64 ;//XXX iph->nexthdr =IPPROTO_TCP ;
@@ -104,7 +104,7 @@ synproxy_send_client_synack(const struct sk_buff *skb, const struct tcphdr *th, niph =synproxy_build_ip (nskb, &iph->daddr, &iph->saddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->dest; nth->dest = th->source; nth->seq =htonl (__cookie_v6_init_sequence (iph, th, &mss));
@@ -145,7 +145,7 @@ synproxy_send_server_syn(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, &iph->saddr, &iph->daddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->source; nth->dest = th->dest; nth->seq =htonl (recv_seq -1 );
@@ -190,7 +190,7 @@ synproxy_send_server_ack(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, &iph->daddr, &iph->saddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->dest; nth->dest = th->source; nth->seq =htonl (ntohl (th->ack_seq));
@@ -228,7 +228,7 @@ synproxy_send_client_ack(const struct synproxy_net *snet, niph =synproxy_build_ip (nskb, &iph->saddr, &iph->daddr);skb_reset_transport_header (nskb); - nth = (struct tcphdr *)skb_put (nskb, tcp_hdr_size); + nth =skb_put (nskb, tcp_hdr_size); nth->source = th->source; nth->dest = th->dest; nth->seq =htonl (ntohl (th->seq) +1 );
net/ipv6/netfilter/nf_reject_ipv6.c +1 -1
@@ -96,7 +96,7 @@ void nf_reject_ip6_tcphdr_put(struct sk_buff *nskb,int needs_ack;skb_reset_transport_header (nskb); - tcph = (struct tcphdr *)skb_put (nskb,sizeof (struct tcphdr )); + tcph =skb_put (nskb,sizeof (struct tcphdr ));/* Truncate to length (no data) */ tcph->doff =sizeof (struct tcphdr )/4 ; tcph->source = oth->dest;
net/irda/irlap_frame.c +8 -9
@@ -133,7 +133,7 @@ void irlap_send_snrm_frame(struct irlap_cb *self, struct qos_info *qos)if (!tx_skb)return ; - frame = (struct snrm_frame *)skb_put (tx_skb,2 ); + frame =skb_put (tx_skb,2 );/* Insert connection address field */ if (qos)
@@ -228,7 +228,7 @@ void irlap_send_ua_response_frame(struct irlap_cb *self, struct qos_info *qos)if (!tx_skb)return ; - frame = (struct ua_frame *)skb_put (tx_skb,10 ); + frame =skb_put (tx_skb,10 );/* Build UA response */ frame->caddr = self->caddr;
@@ -268,7 +268,7 @@ void irlap_send_dm_frame( struct irlap_cb *self)if (!tx_skb)return ; - frame = (struct dm_frame *)skb_put (tx_skb,2 ); + frame =skb_put (tx_skb,2 );if (self->state ==LAP_NDM ) frame->caddr =CBROADCAST ;
@@ -298,7 +298,7 @@ void irlap_send_disc_frame(struct irlap_cb *self)if (!tx_skb)return ; - frame = (struct disc_frame *)skb_put (tx_skb,2 ); + frame =skb_put (tx_skb,2 ); frame->caddr = self->caddr |CMD_FRAME ; frame->control =DISC_CMD |PF_BIT ;
@@ -588,7 +588,7 @@ void irlap_send_rr_frame(struct irlap_cb *self, int command)if (!tx_skb)return ; - frame = (struct rr_frame *)skb_put (tx_skb,2 ); + frame =skb_put (tx_skb,2 ); frame->caddr = self->caddr; frame->caddr |= (command) ?CMD_FRAME :0 ;
@@ -613,7 +613,7 @@ void irlap_send_rd_frame(struct irlap_cb *self)if (!tx_skb)return ; - frame = (struct rd_frame *)skb_put (tx_skb,2 ); + frame =skb_put (tx_skb,2 ); frame->caddr = self->caddr; frame->control =RD_RSP |PF_BIT ;
@@ -1203,14 +1203,13 @@ void irlap_send_test_frame(struct irlap_cb *self, __u8 caddr, __u32 daddr,/* Broadcast frames must include saddr and daddr fields */ if (caddr ==CBROADCAST ) { - frame = (struct test_frame *) -skb_put (tx_skb,sizeof (struct test_frame )); + frame =skb_put (tx_skb,sizeof (struct test_frame ));/* Insert the swapped addresses */ frame->saddr =cpu_to_le32 (self->saddr); frame->daddr =cpu_to_le32 (daddr); }else - frame = (struct test_frame *)skb_put (tx_skb,LAP_ADDR_HEADER +LAP_CTRL_HEADER ); + frame =skb_put (tx_skb,LAP_ADDR_HEADER +LAP_CTRL_HEADER ); frame->caddr = caddr; frame->control =TEST_RSP |PF_BIT ;
net/key/af_key.c +54 -70
425 lines not on this page · raw message
net/mac80211/agg-rx.c +1 -1
@@ -196,7 +196,7 @@ static void ieee80211_send_addba_resp(struct ieee80211_sub_if_data *sdata, u8 *dreturn ;skb_reserve (skb, local->hw.extra_tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb,24 ); + mgmt =skb_put (skb,24 );memset (mgmt,0 ,24 );memcpy (mgmt->da, da,ETH_ALEN );memcpy (mgmt->sa, sdata->vif.addr,ETH_ALEN );
net/mac80211/agg-tx.c +2 -2
@@ -75,7 +75,7 @@ static void ieee80211_send_addba_request(struct ieee80211_sub_if_data *sdata,return ;skb_reserve (skb, local->hw.extra_tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb,24 ); + mgmt =skb_put (skb,24 );memset (mgmt,0 ,24 );memcpy (mgmt->da, da,ETH_ALEN );memcpy (mgmt->sa, sdata->vif.addr,ETH_ALEN );
@@ -123,7 +123,7 @@ void ieee80211_send_bar(struct ieee80211_vif *vif, u8 *ra, u16 tid, u16 ssn)return ;skb_reserve (skb, local->hw.extra_tx_headroom); - bar = (struct ieee80211_bar *)skb_put (skb,sizeof (*bar)); + bar =skb_put (skb,sizeof (*bar));memset (bar,0 ,sizeof (*bar)); bar->frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_BACK_REQ );
net/mac80211/cfg.c +2 -2
@@ -939,7 +939,7 @@ static void ieee80211_send_layer2_update(struct sta_info *sta) skb =dev_alloc_skb (sizeof (*msg));if (!skb)return ; - msg = (struct iapp_layer2_update *)skb_put (skb,sizeof (*msg)); + msg =skb_put (skb,sizeof (*msg));/* 802.2 Type 1 Logical Link Control (LLC) Exchange Identifier (XID) * Update response frame; IEEE Std 802.2-1998, 5.4.1.2.1 */
@@ -3558,7 +3558,7 @@ static int ieee80211_probe_client(struct wiphy *wiphy, struct net_device *dev,skb_reserve (skb, local->hw.extra_tx_headroom); - nullfunc = (void *)skb_put (skb, size); + nullfunc =skb_put (skb, size); nullfunc->frame_control = fc; nullfunc->duration_id =0 ;memcpy (nullfunc->addr1, sta->sta.addr,ETH_ALEN );
net/mac80211/debugfs_netdev.c +1 -1
@@ -308,7 +308,7 @@ static ssize_t ieee80211_if_parse_tkip_mic_test(return -ENOMEM ;skb_reserve (skb, local->hw.extra_tx_headroom); - hdr = (struct ieee80211_hdr *)skb_put (skb,24 ); + hdr =skb_put (skb,24 );memset (hdr,0 ,24 ); fc =cpu_to_le16 (IEEE80211_FTYPE_DATA |IEEE80211_STYPE_DATA );
net/mac80211/ht.c +2 -2
@@ -369,7 +369,7 @@ void ieee80211_send_delba(struct ieee80211_sub_if_data *sdata,return ;skb_reserve (skb, local->hw.extra_tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb,24 ); + mgmt =skb_put (skb,24 );memset (mgmt,0 ,24 );memcpy (mgmt->da, da,ETH_ALEN );memcpy (mgmt->sa, sdata->vif.addr,ETH_ALEN );
@@ -435,7 +435,7 @@ int ieee80211_send_smps_action(struct ieee80211_sub_if_data *sdata,return -ENOMEM ;skb_reserve (skb, local->hw.extra_tx_headroom); - action_frame = (void *)skb_put (skb,27 ); + action_frame =skb_put (skb,27 );memcpy (action_frame->da, da,ETH_ALEN );memcpy (action_frame->sa, sdata->dev->dev_addr,ETH_ALEN );memcpy (action_frame->bssid, bssid,ETH_ALEN );
net/mac80211/mesh.c +2 -2
@@ -653,7 +653,7 @@ ieee80211_mesh_build_beacon(struct ieee80211_if_mesh *ifmsh) bcn->head = ((u8 *) bcn) +sizeof (*bcn);/* fill in the head */ - mgmt = (struct ieee80211_mgmt *)skb_put (skb, hdr_len); + mgmt =skb_put (skb, hdr_len);memset (mgmt,0 , hdr_len); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_BEACON );
@@ -1120,7 +1120,7 @@ static int mesh_fwd_csa_frame(struct ieee80211_sub_if_data *sdata,if (!skb)return -ENOMEM ;skb_reserve (skb, local->tx_headroom); - mgmt_fwd = (struct ieee80211_mgmt *)skb_put (skb, len); + mgmt_fwd =skb_put (skb, len);/* offset_ttl is based on whether the secondary channel * offset is available or not. Subtract 1 from the mesh TTL
net/mac80211/mesh_hwmp.c +2 -2
@@ -122,7 +122,7 @@ static int mesh_path_sel_frame_tx(enum mpath_frame_type action, u8 flags,if (!skb)return -1 ;skb_reserve (skb, local->tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb, hdr_len); + mgmt =skb_put (skb, hdr_len);memset (mgmt,0 , hdr_len); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_ACTION );
@@ -259,7 +259,7 @@ int mesh_path_error_tx(struct ieee80211_sub_if_data *sdata,if (!skb)return -1 ;skb_reserve (skb, local->tx_headroom + sdata->encrypt_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb, hdr_len); + mgmt =skb_put (skb, hdr_len);memset (mgmt,0 , hdr_len); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_ACTION );
net/mac80211/mesh_plink.c +1 -1
@@ -286,7 +286,7 @@ static int mesh_plink_frame_tx(struct ieee80211_sub_if_data *sdata,return err; info =IEEE80211_SKB_CB (skb);skb_reserve (skb, local->tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb, hdr_len); + mgmt =skb_put (skb, hdr_len);memset (mgmt,0 , hdr_len); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_ACTION );
net/mac80211/mesh_ps.c +1 -1
@@ -30,7 +30,7 @@ static struct sk_buff *mps_qos_null_get(struct sta_info *sta)return NULL ;skb_reserve (skb, local->hw.extra_tx_headroom); - nullfunc = (struct ieee80211_hdr *)skb_put (skb, size); + nullfunc =skb_put (skb, size); fc =cpu_to_le16 (IEEE80211_FTYPE_DATA |IEEE80211_STYPE_QOS_NULLFUNC );ieee80211_fill_mesh_addresses (nullfunc, &fc, sta->sta.addr, sdata->vif.addr);
net/mac80211/mlme.c +2 -2
@@ -685,7 +685,7 @@ static void ieee80211_send_assoc(struct ieee80211_sub_if_data *sdata)if (ifmgd->flags &IEEE80211_STA_ENABLE_RRM ) capab |=WLAN_CAPABILITY_RADIO_MEASURE ; - mgmt = (struct ieee80211_mgmt *)skb_put (skb,24 ); + mgmt =skb_put (skb,24 );memset (mgmt,0 ,24 );memcpy (mgmt->da, assoc_data->bss->bssid,ETH_ALEN );memcpy (mgmt->sa, sdata->vif.addr,ETH_ALEN );
@@ -954,7 +954,7 @@ static void ieee80211_send_4addr_nullfunc(struct ieee80211_local *local,skb_reserve (skb, local->hw.extra_tx_headroom); - nullfunc = (struct ieee80211_hdr *)skb_put (skb,30 ); + nullfunc =skb_put (skb,30 );memset (nullfunc,0 ,30 ); fc =cpu_to_le16 (IEEE80211_FTYPE_DATA |IEEE80211_STYPE_NULLFUNC |IEEE80211_FCTL_FROMDS |IEEE80211_FCTL_TODS );
net/mac80211/rx.c +1 -1
@@ -2512,7 +2512,7 @@ static void ieee80211_process_sa_query_req(struct ieee80211_sub_if_data *sdata,return ;skb_reserve (skb, local->hw.extra_tx_headroom); - resp = (struct ieee80211_mgmt *)skb_put (skb,24 ); + resp =skb_put (skb,24 );memset (resp,0 ,24 );memcpy (resp->da, mgmt->sa,ETH_ALEN );memcpy (resp->sa, sdata->vif.addr,ETH_ALEN );
net/mac80211/spectmgmt.c +1 -1
@@ -197,7 +197,7 @@ static void ieee80211_send_refuse_measurement_request(struct ieee80211_sub_if_dareturn ;skb_reserve (skb, local->hw.extra_tx_headroom); - msr_report = (struct ieee80211_mgmt *)skb_put (skb,24 ); + msr_report =skb_put (skb,24 );memset (msr_report,0 ,24 );memcpy (msr_report->da, da,ETH_ALEN );memcpy (msr_report->sa, sdata->vif.addr,ETH_ALEN );
net/mac80211/sta_info.c +1 -1
@@ -1233,7 +1233,7 @@ static void ieee80211_send_null_response(struct ieee80211_sub_if_data *sdata,skb_reserve (skb, local->hw.extra_tx_headroom); - nullfunc = (void *)skb_put (skb, size); + nullfunc =skb_put (skb, size); nullfunc->frame_control = fc; nullfunc->duration_id =0 ;memcpy (nullfunc->addr1, sta->sta.addr,ETH_ALEN );
net/mac80211/tdls.c +7 -7
@@ -38,7 +38,7 @@ void ieee80211_tdls_peer_del_work(struct work_struct *wk)static void ieee80211_tdls_add_ext_capab (struct ieee80211_local *local,struct sk_buff *skb) { -u8 *pos = (void *)skb_put (skb,7 ); +u8 *pos =skb_put (skb,7 );bool chan_switch = local->hw.wiphy->features &NL80211_FEATURE_TDLS_CHANNEL_SWITCH ;
@@ -156,7 +156,7 @@ static void ieee80211_tdls_add_oper_classes(struct ieee80211_sub_if_data *sdata,static void ieee80211_tdls_add_bss_coex_ie (struct sk_buff *skb) { -u8 *pos = (void *)skb_put (skb,3 ); +u8 *pos =skb_put (skb,3 ); *pos++ =WLAN_EID_BSS_COEX_2040 ; *pos++ =1 ;/* len */
@@ -201,7 +201,7 @@ static void ieee80211_tdls_add_link_ie(struct ieee80211_sub_if_data *sdata, rsp_addr = sdata->vif.addr; } - lnkid = (void *)skb_put (skb,sizeof (struct ieee80211_tdls_lnkie )); + lnkid =skb_put (skb,sizeof (struct ieee80211_tdls_lnkie )); lnkid->ie_type =WLAN_EID_LINK_ID ; lnkid->ie_len =sizeof (struct ieee80211_tdls_lnkie ) -2 ;
@@ -215,7 +215,7 @@ static void ieee80211_tdls_add_aid(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb) { struct ieee80211_if_managed *ifmgd = &sdata->u.mgd; -u8 *pos = (void *)skb_put (skb,4 ); +u8 *pos =skb_put (skb,4 ); *pos++ =WLAN_EID_AID ; *pos++ =2 ;/* len */
@@ -263,7 +263,7 @@ static void ieee80211_tdls_add_wmm_param_ie(struct ieee80211_sub_if_data *sdata,struct ieee80211_tx_queue_params *txq;int i; - wmm = (void *)skb_put (skb,sizeof (*wmm)); + wmm =skb_put (skb,sizeof (*wmm));memset (wmm,0 ,sizeof (*wmm)); wmm->element_id =WLAN_EID_VENDOR_SPECIFIC ;
@@ -675,7 +675,7 @@ ieee80211_prep_tdls_encap_data(struct wiphy *wiphy, struct net_device *dev,struct ieee80211_sub_if_data *sdata =IEEE80211_DEV_TO_SUB_IF (dev);struct ieee80211_tdls_data *tf; - tf = (void *)skb_put (skb, offsetof(struct ieee80211_tdls_data , u)); + tf =skb_put (skb, offsetof(struct ieee80211_tdls_data , u));memcpy (tf->da, peer,ETH_ALEN );memcpy (tf->sa, sdata->vif.addr,ETH_ALEN );
@@ -757,7 +757,7 @@ ieee80211_prep_tdls_direct(struct wiphy *wiphy, struct net_device *dev,struct ieee80211_sub_if_data *sdata =IEEE80211_DEV_TO_SUB_IF (dev);struct ieee80211_mgmt *mgmt; - mgmt = (void *)skb_put (skb,24 ); + mgmt =skb_put (skb,24 );memset (mgmt,0 ,24 );memcpy (mgmt->da, peer,ETH_ALEN );memcpy (mgmt->sa, sdata->vif.addr,ETH_ALEN );
net/mac80211/tx.c +4 -5
@@ -2599,7 +2599,7 @@ static void __ieee80211_beacon_add_tim(struct ieee80211_sub_if_data *sdata, ps->dtim_count--; } - tim = pos = (u8 *)skb_put (skb,6 ); + tim = pos =skb_put (skb,6 ); *pos++ =WLAN_EID_TIM ; *pos++ =4 ; *pos++ = ps->dtim_count;
@@ -3071,7 +3071,7 @@ struct sk_buff *ieee80211_pspoll_get(struct ieee80211_hw *hw,skb_reserve (skb, local->hw.extra_tx_headroom); - pspoll = (struct ieee80211_pspoll *)skb_put (skb,sizeof (*pspoll)); + pspoll =skb_put (skb,sizeof (*pspoll));memset (pspoll,0 ,sizeof (*pspoll)); pspoll->frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_PSPOLL );
@@ -3109,8 +3109,7 @@ struct sk_buff *ieee80211_nullfunc_get(struct ieee80211_hw *hw,skb_reserve (skb, local->hw.extra_tx_headroom); - nullfunc = (struct ieee80211_hdr_3addr *)skb_put (skb, -sizeof (*nullfunc)); + nullfunc =skb_put (skb,sizeof (*nullfunc));memset (nullfunc,0 ,sizeof (*nullfunc)); nullfunc->frame_control = cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_NULLFUNC |
@@ -3143,7 +3142,7 @@ struct sk_buff *ieee80211_probereq_get(struct ieee80211_hw *hw,skb_reserve (skb, local->hw.extra_tx_headroom); - hdr = (struct ieee80211_hdr_3addr *)skb_put (skb,sizeof (*hdr)); + hdr =skb_put (skb,sizeof (*hdr));memset (hdr,0 ,sizeof (*hdr)); hdr->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_PROBE_REQ );
net/mac80211/util.c +2 -2
@@ -1282,7 +1282,7 @@ void ieee80211_send_auth(struct ieee80211_sub_if_data *sdata,skb_reserve (skb, local->hw.extra_tx_headroom +IEEE80211_WEP_IV_LEN ); - mgmt = (struct ieee80211_mgmt *)skb_put (skb,24 +6 ); + mgmt =skb_put (skb,24 +6 );memset (mgmt,0 ,24 +6 ); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_AUTH );
@@ -2847,7 +2847,7 @@ int ieee80211_send_action_csa(struct ieee80211_sub_if_data *sdata,return -ENOMEM ;skb_reserve (skb, local->tx_headroom); - mgmt = (struct ieee80211_mgmt *)skb_put (skb, hdr_len); + mgmt =skb_put (skb, hdr_len);memset (mgmt,0 , hdr_len); mgmt->frame_control =cpu_to_le16 (IEEE80211_FTYPE_MGMT |IEEE80211_STYPE_ACTION );
net/mac80211/wpa.c +3 -3
@@ -934,7 +934,7 @@ ieee80211_crypto_aes_cmac_encrypt(struct ieee80211_tx_data *tx)if (WARN_ON (skb_tailroom (skb) <sizeof (*mmie)))return TX_DROP ; - mmie = (struct ieee80211_mmie *)skb_put (skb,sizeof (*mmie)); + mmie =skb_put (skb,sizeof (*mmie)); mmie->element_id =WLAN_EID_MMIE ; mmie->length =sizeof (*mmie) -2 ; mmie->key_id =cpu_to_le16 (key->conf.keyidx);
@@ -978,7 +978,7 @@ ieee80211_crypto_aes_cmac_256_encrypt(struct ieee80211_tx_data *tx)if (WARN_ON (skb_tailroom (skb) <sizeof (*mmie)))return TX_DROP ; - mmie = (struct ieee80211_mmie_16 *)skb_put (skb,sizeof (*mmie)); + mmie =skb_put (skb,sizeof (*mmie)); mmie->element_id =WLAN_EID_MMIE ; mmie->length =sizeof (*mmie) -2 ; mmie->key_id =cpu_to_le16 (key->conf.keyidx);
@@ -1123,7 +1123,7 @@ ieee80211_crypto_aes_gmac_encrypt(struct ieee80211_tx_data *tx)if (WARN_ON (skb_tailroom (skb) <sizeof (*mmie)))return TX_DROP ; - mmie = (struct ieee80211_mmie_16 *)skb_put (skb,sizeof (*mmie)); + mmie =skb_put (skb,sizeof (*mmie)); mmie->element_id =WLAN_EID_MMIE ; mmie->length =sizeof (*mmie) -2 ; mmie->key_id =cpu_to_le16 (key->conf.keyidx);
net/netfilter/nfnetlink_log.c +1 -1
@@ -582,7 +582,7 @@ __build_packet_message(struct nfnl_log_net *log,if (skb_tailroom (inst->skb) <nla_total_size (data_len)) goto nla_put_failure; - nla = (struct nlattr *)skb_put (inst->skb,nla_total_size (data_len)); + nla =skb_put (inst->skb,nla_total_size (data_len)); nla->nla_type =NFULA_PAYLOAD ; nla->nla_len = size;
net/netfilter/nfnetlink_queue_core.c +1 -1
@@ -495,7 +495,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,if (skb_tailroom (skb) <sizeof (*nla) + hlen) goto nla_put_failure; - nla = (struct nlattr *)skb_put (skb,sizeof (*nla)); + nla =skb_put (skb,sizeof (*nla)); nla->nla_type =NFQA_PAYLOAD ; nla->nla_len =nla_attr_size (data_len);
net/netlink/af_netlink.c +1 -1
@@ -2604,7 +2604,7 @@ __nlmsg_put(struct sk_buff *skb, u32 portid, u32 seq, int type, int len, int flastruct nlmsghdr *nlh;int size =nlmsg_msg_size (len); - nlh = (struct nlmsghdr *)skb_put (skb,NLMSG_ALIGN (size)); + nlh =skb_put (skb,NLMSG_ALIGN (size)); nlh->nlmsg_type = type; nlh->nlmsg_len = size; nlh->nlmsg_flags = flags;
net/nfc/digital_technology.c +2 -4
@@ -625,8 +625,7 @@ static int digital_in_send_attrib_req(struct nfc_digital_dev *ddev,if (!skb)return -ENOMEM ; - attrib_req = (struct digital_attrib_req *)skb_put (skb, -sizeof (*attrib_req)); + attrib_req =skb_put (skb,sizeof (*attrib_req)); attrib_req->cmd =DIGITAL_CMD_ATTRIB_REQ ; memcpy(attrib_req->nfcid0, sensb_res->nfcid0,
@@ -730,8 +729,7 @@ int digital_in_send_sensb_req(struct nfc_digital_dev *ddev, u8 rf_tech)if (!skb)return -ENOMEM ; - sensb_req = (struct digital_sensb_req *)skb_put (skb, -sizeof (*sensb_req)); + sensb_req =skb_put (skb,sizeof (*sensb_req)); sensb_req->cmd =DIGITAL_CMD_SENSB_REQ ; sensb_req->afi =0x00 ;/* All families and sub-families */
net/nfc/nci/core.c +1 -1
@@ -1148,7 +1148,7 @@ int nci_send_cmd(struct nci_dev *ndev, __u16 opcode, __u8 plen, void *payload)return -ENOMEM ; } - hdr = (struct nci_ctrl_hdr *)skb_put (skb,NCI_CTRL_HDR_SIZE ); + hdr =skb_put (skb,NCI_CTRL_HDR_SIZE ); hdr->gid =nci_opcode_gid (opcode); hdr->oid =nci_opcode_oid (opcode); hdr->plen = plen;
net/phonet/datagram.c +1 -1
@@ -108,7 +108,7 @@ static int pn_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)return err;skb_reserve (skb,MAX_PHONET_HEADER ); - err =memcpy_from_msg ((void *)skb_put (skb, len), msg, len); + err =memcpy_from_msg (skb_put (skb, len), msg, len);if (err <0 ) {kfree_skb (skb);return err;
net/sctp/sm_make_chunk.c +1 -1
@@ -1375,7 +1375,7 @@ static struct sctp_chunk *_sctp_make_chunk(const struct sctp_association *asoc, goto nodata;/* Make room for the chunk header. */ - chunk_hdr = (sctp_chunkhdr_t *)skb_put (skb,sizeof (sctp_chunkhdr_t)); + chunk_hdr =skb_put (skb,sizeof (sctp_chunkhdr_t)); chunk_hdr->type = type; chunk_hdr->flags = flags; chunk_hdr->length =htons (sizeof (sctp_chunkhdr_t));
net/sctp/ulpevent.c +7 -14
@@ -164,8 +164,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_assoc_change( goto fail; skb =sctp_event2skb (event); - sac = (struct sctp_assoc_change *)skb_put (skb, -sizeof (struct sctp_assoc_change )); + sac =skb_put (skb,sizeof (struct sctp_assoc_change )); }/* Socket Extensions for SCTP
@@ -267,8 +266,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_peer_addr_change( goto fail; skb =sctp_event2skb (event); - spc = (struct sctp_paddr_change *) -skb_put (skb,sizeof (struct sctp_paddr_change )); + spc =skb_put (skb,sizeof (struct sctp_paddr_change ));/* Sockets API Extensions for SCTP * Section 5.3.1.2 SCTP_PEER_ADDR_CHANGE
@@ -546,8 +544,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_shutdown_event( goto fail; skb =sctp_event2skb (event); - sse = (struct sctp_shutdown_event *) -skb_put (skb,sizeof (struct sctp_shutdown_event )); + sse =skb_put (skb,sizeof (struct sctp_shutdown_event ));/* Socket Extensions for SCTP * 5.3.1.5 SCTP_SHUTDOWN_EVENT
@@ -609,8 +606,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_adaptation_indication( goto fail; skb =sctp_event2skb (event); - sai = (struct sctp_adaptation_event *) -skb_put (skb,sizeof (struct sctp_adaptation_event )); + sai =skb_put (skb,sizeof (struct sctp_adaptation_event )); sai->sai_type =SCTP_ADAPTATION_INDICATION ; sai->sai_flags =0 ;
@@ -742,8 +738,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_pdapi( goto fail; skb =sctp_event2skb (event); - pd = (struct sctp_pdapi_event *) -skb_put (skb,sizeof (struct sctp_pdapi_event )); + pd =skb_put (skb,sizeof (struct sctp_pdapi_event ));/* pdapi_type * It should be SCTP_PARTIAL_DELIVERY_EVENT
@@ -794,8 +789,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_authkey( goto fail; skb =sctp_event2skb (event); - ak = (struct sctp_authkey_event *)
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.1.4
Part of the diff is not shown here. View the raw message.
RFC PATCH 7/8 skbuff: Convert skb_push to return void *
In reply to Joe PerchesThere are many casts that could be removed by this conversion. Start it.
--- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/skbuff.h +1 -1
@@ -1689,7 +1689,7 @@ static inline unsigned char *__skb_put(struct sk_buff *skb, unsigned int len)return tmp; } -unsigned char *skb_push (struct sk_buff *skb,unsigned int len); +void *skb_push (struct sk_buff *skb,unsigned int len);void *skb_push_uchar (struct sk_buff *skb,unsigned char uc);static inline unsigned char *__skb_push (struct sk_buff *skb,unsigned int len) {
Signature · 1 line
2.1.4
RFC PATCH 8/8 treewide: Remove unnecessary casts from skb_push
In reply to Joe PerchesNow that skb_push returns a void *, remove the unnecessary casts.
--- drivers/atm/solos-pci.c | 2 +- drivers/firewire/net.c | 8 +++----- drivers/infiniband/hw/cxgb3/iwch_cm.c | 6 +++--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- drivers/isdn/act2000/module.c | 2 +- drivers/net/arcnet/arc-rawmode.c | 2 +- drivers/net/arcnet/capmode.c | 2 +- drivers/net/arcnet/rfc1051.c | 2 +- drivers/net/arcnet/rfc1201.c | 2 +- drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- drivers/net/ethernet/chelsio/cxgb/sge.c | 2 +- drivers/net/ethernet/freescale/gianfar.c | 2 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 +- drivers/net/hippi/rrunner.c | 2 +- drivers/net/usb/gl620a.c | 2 +- drivers/net/usb/lg-vl600.c | 2 +- drivers/net/usb/net1080.c | 2 +- drivers/net/wimax/i2400m/netdev.c | 2 +- drivers/net/wireless/adm8211.c | 2 +- drivers/net/wireless/ath/ar5523/ar5523.c | 4 ++-- drivers/net/wireless/ath/ath6kl/htc_pipe.c | 3 +-- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- drivers/net/wireless/ath/ath9k/htc_hst.c | 3 +-- drivers/net/wireless/ath/ath9k/wmi.c | 2 +- drivers/net/wireless/ath/carl9170/tx.c | 2 +- drivers/net/wireless/ath/wil6210/txrx.c | 2 +- drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +- drivers/net/wireless/cw1200/txrx.c | 2 +- drivers/net/wireless/hostap/hostap_80211_rx.c | 8 +++----- drivers/net/wireless/libertas/rx.c | 2 +- drivers/net/wireless/libertas_tf/main.c | 2 +- drivers/net/wireless/mac80211_hwsim.c | 4 ++-- drivers/net/wireless/orinoco/main.c | 7 +++---- drivers/net/wireless/p54/txrx.c | 4 ++-- drivers/net/wireless/prism54/islpci_eth.c | 5 +---- drivers/net/wireless/rtl818x/rtl8187/dev.c | 6 ++---- drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +- drivers/net/wireless/ti/wl1251/tx.c | 3 +-- drivers/net/wireless/ti/wlcore/cmd.c | 2 +- drivers/net/wireless/ti/wlcore/tx.c | 3 +-- drivers/net/wireless/zd1211rw/zd_mac.c | 3 +-- drivers/s390/net/qeth_l2_main.c | 3 +-- drivers/s390/net/qeth_l3_main.c | 6 ++---- drivers/scsi/fcoe/fcoe_ctlr.c | 2 +- drivers/scsi/fnic/fnic_fcs.c | 7 +++---- drivers/staging/wlan-ng/p80211conv.c | 14 +++++--------- drivers/usb/gadget/function/rndis.c | 2 +- include/linux/if_vlan.h | 2 +- net/802/fc.c | 4 ++-- net/802/fddi.c | 2 +- net/802/hippi.c | 2 +- net/8021q/vlan_dev.c | 2 +- net/appletalk/ddp.c | 2 +- net/bluetooth/hci_sock.c | 4 ++-- net/bluetooth/rfcomm/core.c | 4 ++-- net/bridge/netfilter/nft_reject_bridge.c | 2 +- net/core/netpoll.c | 4 ++-- net/core/pktgen.c | 6 +++--- net/decnet/dn_dev.c | 4 ++-- net/ethernet/eth.c | 2 +- net/ipv4/ip_gre.c | 2 +- net/ipv6/exthdrs.c | 4 ++-- net/ipv6/ip6_gre.c | 2 +- net/ipv6/tcp_ipv6.c | 2 +- net/iucv/af_iucv.c | 3 +-- net/mac80211/rx.c | 2 +- net/mac80211/status.c | 2 +- net/mac80211/tx.c | 2 +- net/nfc/nci/data.c | 2 +- net/sctp/output.c | 2 +- net/sctp/sm_statefuns.c | 4 ++-- net/sctp/ulpevent.c | 8 +++----- net/wireless/util.c | 2 +- 74 files changed, 104 insertions(+), 130 deletions(-)
drivers/atm/solos-pci.c +1 -1
@@ -1160,7 +1160,7 @@ static int psend(struct atm_vcc *vcc, struct sk_buff *skb) } } - header = (void *)skb_push (skb,sizeof (*header)); + header =skb_push (skb,sizeof (*header));/* This does _not_ include the size of the header */ header->size =cpu_to_le16 (pktlen);
drivers/firewire/net.c +3 -5
@@ -219,7 +219,7 @@ static int fwnet_header_create(struct sk_buff *skb, struct net_device *net, {struct fwnet_header *h; - h = (struct fwnet_header *)skb_push (skb,sizeof (*h)); + h =skb_push (skb,sizeof (*h));put_unaligned_be16 (type, &h->h_proto);if (net->flags & (IFF_LOOPBACK |IFF_NOARP )) {
@@ -942,16 +942,14 @@ static int fwnet_send_packet(struct fwnet_packet_task *ptask) tx_len = ptask->max_payload;switch (fwnet_get_hdr_lf (&ptask->hdr)) {case RFC2374_HDR_UNFRAG : - bufhdr = (struct rfc2734_header *) -skb_push (ptask->skb,RFC2374_UNFRAG_HDR_SIZE ); + bufhdr =skb_push (ptask->skb,RFC2374_UNFRAG_HDR_SIZE );put_unaligned_be32 (ptask->hdr.w0, &bufhdr->w0);break ;case RFC2374_HDR_FIRSTFRAG :case RFC2374_HDR_INTFRAG :case RFC2374_HDR_LASTFRAG : - bufhdr = (struct rfc2734_header *) -skb_push (ptask->skb,RFC2374_FRAG_HDR_SIZE ); + bufhdr =skb_push (ptask->skb,RFC2374_FRAG_HDR_SIZE );put_unaligned_be32 (ptask->hdr.w0, &bufhdr->w0);put_unaligned_be32 (ptask->hdr.w1, &bufhdr->w1);break ;
drivers/infiniband/hw/cxgb3/iwch_cm.c +3 -3
@@ -515,7 +515,7 @@ static void send_mpa_req(struct iwch_ep *ep, struct sk_buff *skb)set_arp_failure_handler (skb, arp_failure_discard);skb_reset_transport_header (skb); len = skb->len; - req = (struct tx_data_wr *)skb_push (skb,sizeof (*req)); + req =skb_push (skb,sizeof (*req)); req->wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_TX_DATA )|F_WR_COMPL ); req->wr_lo =htonl (V_WR_TID (ep->hwtid)); req->len =htonl (len);
@@ -566,7 +566,7 @@ static int send_mpa_reject(struct iwch_ep *ep, const void *pdata, u8 plen) skb->priority =CPL_PRIORITY_DATA ;set_arp_failure_handler (skb, arp_failure_discard);skb_reset_transport_header (skb); - req = (struct tx_data_wr *)skb_push (skb,sizeof (*req)); + req =skb_push (skb,sizeof (*req)); req->wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_TX_DATA )|F_WR_COMPL ); req->wr_lo =htonl (V_WR_TID (ep->hwtid)); req->len =htonl (mpalen);
@@ -617,7 +617,7 @@ static int send_mpa_reply(struct iwch_ep *ep, const void *pdata, u8 plen)set_arp_failure_handler (skb, arp_failure_discard);skb_reset_transport_header (skb); len = skb->len; - req = (struct tx_data_wr *)skb_push (skb,sizeof (*req)); + req =skb_push (skb,sizeof (*req)); req->wr_hi =htonl (V_WR_OP (FW_WROPCODE_OFLD_TX_DATA )|F_WR_COMPL ); req->wr_lo =htonl (V_WR_TID (ep->hwtid)); req->len =htonl (len);
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -1
@@ -822,7 +822,7 @@ static int ipoib_hard_header(struct sk_buff *skb,struct ipoib_header *header;struct ipoib_cb *cb =ipoib_skb_cb (skb); - header = (struct ipoib_header *)skb_push (skb,sizeof *header); + header =skb_push (skb,sizeof *header); header->proto =htons (type); header->reserved =0 ;
drivers/isdn/act2000/module.c +1 -1
@@ -451,7 +451,7 @@ act2000_sendbuf(act2000_card *card, int channel, int ack, struct sk_buff *skb) } }dev_kfree_skb (skb); - msg = (actcapi_msg *)skb_push (xmit_skb,19 ); + msg =skb_push (xmit_skb,19 ); msg->hdr.len =19 + len; msg->hdr.applicationID =1 ; msg->hdr.cmd.cmd =0x86 ;
drivers/net/arcnet/arc-rawmode.c +1 -1
@@ -136,7 +136,7 @@ static int build_header(struct sk_buff *skb, struct net_device *dev, unsigned short type, uint8_t daddr) {int hdr_size =ARC_HDR_SIZE ; -struct archdr *pkt = (struct archdr *)skb_push (skb, hdr_size); +struct archdr *pkt =skb_push (skb, hdr_size);/* * Set the source hardware address.
drivers/net/arcnet/capmode.c +1 -1
@@ -101,7 +101,7 @@ static int build_header(struct sk_buff *skb, uint8_t daddr) {int hdr_size =ARC_HDR_SIZE ; -struct archdr *pkt = (struct archdr *)skb_push (skb, hdr_size); +struct archdr *pkt =skb_push (skb, hdr_size);BUGMSG (D_PROTO ,"Preparing header for cap packet %x.\n" , *((int *)&pkt->soft.cap.cookie[0 ]));
drivers/net/arcnet/rfc1051.c +1 -1
@@ -169,7 +169,7 @@ static int build_header(struct sk_buff *skb, struct net_device *dev, unsigned short type, uint8_t daddr) { int hdr_size = ARC_HDR_SIZE + RFC1051_HDR_SIZE; -struct archdr *pkt = (struct archdr *)skb_push (skb, hdr_size); +struct archdr *pkt =skb_push (skb, hdr_size);struct arc_rfc1051 *soft = &pkt->soft.rfc1051;/* set the protocol ID according to RFC1051 */
drivers/net/arcnet/rfc1201.c +1 -1
@@ -376,7 +376,7 @@ static int build_header(struct sk_buff *skb, struct net_device *dev, {struct arcnet_local *lp =netdev_priv (dev);int hdr_size =ARC_HDR_SIZE +RFC1201_HDR_SIZE ; -struct archdr *pkt = (struct archdr *)skb_push (skb, hdr_size); +struct archdr *pkt =skb_push (skb, hdr_size);struct arc_rfc1201 *soft = &pkt->soft.rfc1201;/* set the protocol ID according to RFC1201 */
drivers/net/ethernet/broadcom/bcmsysport.c +1 -1
@@ -890,7 +890,7 @@ static struct sk_buff *bcm_sysport_insert_tsb(struct sk_buff *skb, skb = nskb; } - tsb = (struct bcm_tsb *)skb_push (skb,sizeof (*tsb)); + tsb =skb_push (skb,sizeof (*tsb));/* Zero-out TSB by default */ memset (tsb,0 ,sizeof (*tsb));
drivers/net/ethernet/chelsio/cxgb/sge.c +1 -1
@@ -1802,7 +1802,7 @@ netdev_tx_t t1_start_xmit(struct sk_buff *skb, struct net_device *dev) eth_type =skb_network_offset (skb) ==ETH_HLEN ?CPL_ETH_II :CPL_ETH_II_VLAN ; - hdr = (struct cpl_tx_pkt_lso *)skb_push (skb,sizeof (*hdr)); + hdr =skb_push (skb,sizeof (*hdr)); hdr->opcode =CPL_TX_PKT_LSO ; hdr->ip_csum_dis = hdr->l4_csum_dis =0 ; hdr->ip_hdr_words =ip_hdr (skb)->ihl;
drivers/net/ethernet/freescale/gianfar.c +1 -1
@@ -2165,7 +2165,7 @@ static int gfar_enet_open(struct net_device *dev)static inline struct txfcb *gfar_add_fcb (struct sk_buff *skb) { -struct txfcb *fcb = (struct txfcb *)skb_push (skb,GMAC_FCB_LEN ); +struct txfcb *fcb =skb_push (skb,GMAC_FCB_LEN );memset (fcb,0 ,GMAC_FCB_LEN );
drivers/net/ethernet/sun/niu.c +1 -1
@@ -6671,7 +6671,7 @@ static netdev_tx_t niu_start_xmit(struct sk_buff *skb, headroom = align +sizeof (struct tx_pkt_hdr ); ehdr = (struct ethhdr *) skb->data; - tp = (struct tx_pkt_hdr *)skb_push (skb, headroom); + tp =skb_push (skb, headroom); len = skb->len -sizeof (struct tx_pkt_hdr ); tp->flags =cpu_to_le64 (niu_compute_tx_flags (skb, ehdr, align, len));
drivers/net/ethernet/toshiba/ps3_gelic_net.c +1 -1
@@ -754,7 +754,7 @@ static struct sk_buff *gelic_put_vlan_tag(struct sk_buff *skb,return NULL ;dev_kfree_skb_any (sk_tmp); } - veth = (struct vlan_ethhdr *)skb_push (skb,VLAN_HLEN ); + veth =skb_push (skb,VLAN_HLEN );/* Move the mac addresses to the top of buffer */ memmove (skb->data, skb->data +VLAN_HLEN ,2 *ETH_ALEN );
drivers/net/hippi/rrunner.c +1 -1
@@ -1422,7 +1422,7 @@ static netdev_tx_t rr_start_xmit(struct sk_buff *skb, skb = new_skb; } - ifield = (u32 *)skb_push (skb,8 ); + ifield =skb_push (skb,8 ); ifield[0 ] =0 ; ifield[1 ] = hcb->ifield;
drivers/net/usb/gl620a.c +1 -1
@@ -175,7 +175,7 @@ genelink_tx_fixup(struct usbnet *dev, struct sk_buff *skb, gfp_t flags) }// attach the packet count to the header - packet_count = (__le32 *)skb_push (skb, (4 +4 *1 )); + packet_count =skb_push (skb, (4 +4 *1 )); packet_len = packet_count +1 ; *packet_count =cpu_to_le32 (1 );
drivers/net/usb/lg-vl600.c +1 -1
@@ -304,7 +304,7 @@ encapsulate:memset (&packet->dummy,0 ,sizeof (packet->dummy)); packet->len =cpu_to_le32 (orig_len); - frame = (struct vl600_frame_hdr *)skb_push (skb,sizeof (*frame)); + frame =skb_push (skb,sizeof (*frame));memset (frame,0 ,sizeof (*frame)); frame->len =cpu_to_le32 (full_len); frame->serial =cpu_to_le32 (serial++);
drivers/net/usb/net1080.c +1 -1
@@ -475,7 +475,7 @@ net1080_tx_fixup(struct usbnet *dev, struct sk_buff *skb, gfp_t flags) encapsulate:/* header first */ - header = (struct nc_header *)skb_push (skb,sizeof *header); + header =skb_push (skb,sizeof *header); header->hdr_len =cpu_to_le16 (sizeof (*header)); header->packet_len =cpu_to_le16 (len); header->packet_id =cpu_to_le16 ((u16 )dev->xid++);
drivers/net/wimax/i2400m/netdev.c +1 -1
@@ -221,7 +221,7 @@ void i2400m_tx_prep_header(struct sk_buff *skb) {struct i2400m_pl_data_hdr *pl_hdr;skb_pull (skb,ETH_HLEN ); - pl_hdr = (struct i2400m_pl_data_hdr *)skb_push (skb,sizeof (*pl_hdr)); + pl_hdr =skb_push (skb,sizeof (*pl_hdr)); pl_hdr->reserved =0 ; }
drivers/net/wireless/adm8211.c +1 -1
@@ -1684,7 +1684,7 @@ static void adm8211_tx(struct ieee80211_hw *dev,skb_pull (skb, hdrlen); payload_len = skb->len; - txhdr = (struct adm8211_tx_hdr *)skb_push (skb,sizeof (*txhdr)); + txhdr =skb_push (skb,sizeof (*txhdr));memset (txhdr,0 ,sizeof (*txhdr));memcpy (txhdr->da,ieee80211_get_DA (hdr),ETH_ALEN ); txhdr->signal = plcp_signal;
drivers/net/wireless/ath/ar5523/ar5523.c +2 -2
@@ -832,8 +832,8 @@ static void ar5523_tx_work_locked(struct ar5523 *ar) data->ar = ar; data->urb = urb; - desc = (struct ar5523_tx_desc *)skb_push (skb,sizeof (*desc)); - chunk = (struct ar5523_chunk *)skb_push (skb,sizeof (*chunk)); + desc =skb_push (skb,sizeof (*desc)); + chunk =skb_push (skb,sizeof (*chunk)); chunk->seqnum =0 ; chunk->flags =UATH_CFLAGS_FINAL ;
drivers/net/wireless/ath/ath6kl/htc_pipe.c +1 -2
@@ -228,8 +228,7 @@ static int htc_issue_packets(struct htc_target *target, payload_len = packet->act_len;/* setup HTC frame header */ - htc_hdr = (struct htc_frame_hdr *)skb_push (skb, -sizeof (*htc_hdr)); + htc_hdr =skb_push (skb,sizeof (*htc_hdr));if (!htc_hdr) {WARN_ON_ONCE (1 ); status = -EINVAL ;
drivers/net/wireless/ath/ath9k/hif_usb.c +1 -1
@@ -200,7 +200,7 @@ static int hif_usb_send_mgmt(struct hif_device_usb *hif_dev, cmd->skb = skb; cmd->hif_dev = hif_dev; - hdr = (__le16 *)skb_push (skb,4 ); + hdr =skb_push (skb,4 ); *hdr++ =cpu_to_le16 (skb->len -4 ); *hdr++ =cpu_to_le16 (ATH_USB_TX_STREAM_MODE_TAG );
drivers/net/wireless/ath/ath9k/htc_hst.c +1 -2
@@ -26,8 +26,7 @@ static int htc_issue_send(struct htc_target *target, struct sk_buff* skb,struct htc_endpoint *endpoint = &target->endpoint[epid];int status; - hdr = (struct htc_frame_hdr *) -skb_push (skb,sizeof (struct htc_frame_hdr )); + hdr =skb_push (skb,sizeof (struct htc_frame_hdr )); hdr->endpoint_id = epid; hdr->flags = flags; hdr->payload_len =cpu_to_be16 (len);
drivers/net/wireless/ath/ath9k/wmi.c +1 -1
@@ -277,7 +277,7 @@ static int ath9k_wmi_cmd_issue(struct wmi *wmi,struct wmi_cmd_hdr *hdr;unsigned long flags; - hdr = (struct wmi_cmd_hdr *)skb_push (skb,sizeof (struct wmi_cmd_hdr )); + hdr =skb_push (skb,sizeof (struct wmi_cmd_hdr )); hdr->command_id =cpu_to_be16 (cmd); hdr->seq_no =cpu_to_be16 (++wmi->tx_seq_id);
drivers/net/wireless/ath/carl9170/tx.c +1 -1
@@ -991,7 +991,7 @@ static int carl9170_tx_prepare(struct ar9170 *ar,else cvif =NULL ; - txc = (void *)skb_push (skb,sizeof (*txc)); + txc =skb_push (skb,sizeof (*txc));memset (txc,0 ,sizeof (*txc));SET_VAL (CARL9170_TX_SUPER_MISC_QUEUE , txc->s.misc, hw_queue);
drivers/net/wireless/ath/wil6210/txrx.c +1 -1
@@ -322,7 +322,7 @@ static void wil_rx_add_radiotap_header(struct wil6210_priv *wil,return ; } - rtap_vendor = (void *)skb_push (skb, rtap_len); + rtap_vendor =skb_push (skb, rtap_len);memset (rtap_vendor,0 , rtap_len); rtap_vendor->rtap.rthdr.it_version =PKTHDR_RADIOTAP_VERSION ;
drivers/net/wireless/brcm80211/brcmsmac/main.c +1 -1
@@ -6269,7 +6269,7 @@ brcms_c_d11hdrs_mac80211(struct brcms_c_info *wlc, struct ieee80211_hw *hw, plcp =skb_push (p,D11_PHY_HDR_LEN );/* add Broadcom tx descriptor header */ - txh = (struct d11txh *)skb_push (p,D11_TXH_LEN ); + txh =skb_push (p,D11_TXH_LEN );memset (txh,0 ,D11_TXH_LEN );/* setup frameid */
drivers/net/wireless/cw1200/txrx.c +1 -1
@@ -574,7 +574,7 @@ cw1200_tx_h_wsm(struct cw1200_common *priv,return NULL ; } - wsm = (struct wsm_tx *)skb_push (t->skb,sizeof (struct wsm_tx )); + wsm =skb_push (t->skb,sizeof (struct wsm_tx )); t->txpriv.offset +=sizeof (struct wsm_tx );memset (wsm,0 ,sizeof (*wsm)); wsm->hdr.len =__cpu_to_le16 (t->skb->len);
drivers/net/wireless/hostap/hostap_80211_rx.c +3 -5
@@ -131,8 +131,7 @@ int prism2_rx_80211(struct net_device *dev, struct sk_buff *skb,if (prism_header ==1 ) {struct linux_wlan_ng_prism_hdr *hdr; - hdr = (struct linux_wlan_ng_prism_hdr *) -skb_push (skb, phdrlen); + hdr =skb_push (skb, phdrlen);memset (hdr,0 , phdrlen); hdr->msgcode =LWNG_CAP_DID_BASE ; hdr->msglen =sizeof (*hdr);
@@ -153,8 +152,7 @@ hdr->f.status = s; hdr->f.len = l; hdr->f.data = d#undef LWNG_SETVAL }else if (prism_header ==2 ) {struct linux_wlan_ng_cap_hdr *hdr; - hdr = (struct linux_wlan_ng_cap_hdr *) -skb_push (skb, phdrlen); + hdr =skb_push (skb, phdrlen);memset (hdr,0 , phdrlen); hdr->version =htonl (LWNG_CAPHDR_VERSION ); hdr->length =htonl (phdrlen);
@@ -172,7 +170,7 @@ hdr->f.status = s; hdr->f.len = l; hdr->f.data = d hdr->encoding =htonl (1 );/* cck */ }else if (prism_header ==3 ) {struct hostap_radiotap_rx *hdr; - hdr = (struct hostap_radiotap_rx *)skb_push (skb, phdrlen); + hdr =skb_push (skb, phdrlen);memset (hdr,0 , phdrlen); hdr->hdr.it_len =cpu_to_le16 (phdrlen); hdr->hdr.it_present =
drivers/net/wireless/libertas/rx.c +1 -1
@@ -262,7 +262,7 @@ static int process_rxed_802_11_packet(struct lbs_private *priv, goto done; } - pradiotap_hdr = (void *)skb_push (skb,sizeof (struct rx_radiotap_hdr )); + pradiotap_hdr =skb_push (skb,sizeof (struct rx_radiotap_hdr ));memcpy (pradiotap_hdr, &radiotap_hdr,sizeof (struct rx_radiotap_hdr )); priv->cur_rate =lbs_fw_index_to_data_rate (prxpd->rx_rate);
drivers/net/wireless/libertas_tf/main.c +1 -1
@@ -267,7 +267,7 @@ static void lbtf_tx_work(struct work_struct *work) len = skb->len; info =IEEE80211_SKB_CB (skb); - txpd = (struct txpd *)skb_push (skb,sizeof (struct txpd )); + txpd =skb_push (skb,sizeof (struct txpd ));if (priv->surpriseremoved) {dev_kfree_skb_any (skb);
drivers/net/wireless/mac80211_hwsim.c +2 -2
@@ -817,7 +817,7 @@ static void mac80211_hwsim_monitor_rx(struct ieee80211_hw *hw,if (skb ==NULL )return ; - hdr = (struct hwsim_radiotap_hdr *)skb_push (skb,sizeof (*hdr)); + hdr =skb_push (skb,sizeof (*hdr)); hdr->hdr.it_version =PKTHDR_RADIOTAP_VERSION ; hdr->hdr.it_pad =0 ; hdr->hdr.it_len =cpu_to_le16 (sizeof (*hdr));
@@ -1087,7 +1087,7 @@ static void mac80211_hwsim_add_vendor_rtap(struct sk_buff *skb)* Note that this code requires the headroom in the SKB * that was allocated earlier. */ - rtap = (void *)skb_push (skb,sizeof (*rtap) +8 +4 ); + rtap =skb_push (skb,sizeof (*rtap) +8 +4 ); rtap->oui[0 ] =HWSIM_RADIOTAP_OUI [0 ]; rtap->oui[1 ] =HWSIM_RADIOTAP_OUI [1 ]; rtap->oui[2 ] =HWSIM_RADIOTAP_OUI [2 ];
drivers/net/wireless/orinoco/main.c +3 -4
@@ -407,7 +407,7 @@ int orinoco_process_xmit_skb(struct sk_buff *skb,memcpy (hdr.encap, encaps_hdr,sizeof (encaps_hdr));/* Make room for the new header, and copy it in */ - eh = (struct ethhdr *)skb_push (skb,ENCAPS_OVERHEAD ); + eh =skb_push (skb,ENCAPS_OVERHEAD );memcpy (eh, &hdr,sizeof (hdr)); }
@@ -1044,11 +1044,10 @@ static void orinoco_rx(struct net_device *dev,/* These indicate a SNAP within 802.2 LLC within 802.11 frame which we'll need to de-encapsulate to the original EthernetII frame. */ - hdr = (struct ethhdr *)skb_push (skb, -ETH_HLEN -ENCAPS_OVERHEAD ); + hdr =skb_push (skb,ETH_HLEN -ENCAPS_OVERHEAD ); }else {/* 802.3 frame - prepend 802.3 header as is */ - hdr = (struct ethhdr *)skb_push (skb,ETH_HLEN ); + hdr =skb_push (skb,ETH_HLEN ); hdr->h_proto =htons (length); }memcpy (hdr->h_dest, desc->addr1,ETH_ALEN );
drivers/net/wireless/p54/txrx.c +2 -2
@@ -815,8 +815,8 @@ void p54_tx_80211(struct ieee80211_hw *dev, } } - txhdr = (struct p54_tx_data *)skb_push (skb,sizeof (*txhdr) + padding); - hdr = (struct p54_hdr *)skb_push (skb,sizeof (*hdr)); + txhdr =skb_push (skb,sizeof (*txhdr) + padding); + hdr =skb_push (skb,sizeof (*hdr));if (padding) hdr_flags |=P54_HDR_FLAG_DATA_ALIGN ;
drivers/net/wireless/prism54/islpci_eth.c +1 -4
@@ -276,10 +276,7 @@ islpci_monitor_rx(islpci_private *priv, struct sk_buff **skb) }/* make room for the new header and fill it. */ - avs = - (struct avs_80211_1_header *)skb_push (*skb, -sizeof (struct -avs_80211_1_header )); + avs =skb_push (*skb,sizeof (struct avs_80211_1_header )); avs->version =cpu_to_be32 (P80211CAPTURE_VERSION ); avs->length =cpu_to_be32 (sizeof (struct avs_80211_1_header ));
drivers/net/wireless/rtl818x/rtl8187/dev.c +2 -4
@@ -278,8 +278,7 @@ static void rtl8187_tx(struct ieee80211_hw *dev, }if (!priv->is_rtl8187b) { -struct rtl8187_tx_hdr *hdr = - (struct rtl8187_tx_hdr *)skb_push (skb,sizeof (*hdr)); +struct rtl8187_tx_hdr *hdr =skb_push (skb,sizeof (*hdr)); hdr->flags =cpu_to_le32 (flags); hdr->len =0 ; hdr->rts_duration = rts_dur;
@@ -292,8 +291,7 @@ static void rtl8187_tx(struct ieee80211_hw *dev,unsigned int epmap[4 ] = {6 ,7 ,5 ,4 };u16 fc =le16_to_cpu (tx_hdr->frame_control); -struct rtl8187b_tx_hdr *hdr = - (struct rtl8187b_tx_hdr *)skb_push (skb,sizeof (*hdr)); +struct rtl8187b_tx_hdr *hdr =skb_push (skb,sizeof (*hdr));struct ieee80211_rate *txrate =ieee80211_get_tx_rate (dev, info);memset (hdr,0 ,sizeof (*hdr));
drivers/net/wireless/rtlwifi/rtl8192cu/trx.c +1 -1
@@ -516,7 +516,7 @@ void rtl92cu_tx_fill_desc(struct ieee80211_hw *hw, seq_number = (le16_to_cpu (hdr->seq_ctrl) &IEEE80211_SCTL_SEQ ) >>4 ;rtl_get_tcb_desc (hw, info, sta, skb, tcb_desc); - txdesc = (u8 *)skb_push (skb,RTL_TX_HEADER_SIZE ); + txdesc =skb_push (skb,RTL_TX_HEADER_SIZE );memset (txdesc,0 ,RTL_TX_HEADER_SIZE );SET_TX_DESC_PKT_SIZE (txdesc, pktlen);SET_TX_DESC_LINIP (txdesc,0 );
drivers/net/wireless/ti/wl1251/tx.c +1 -2
@@ -161,8 +161,7 @@ static int wl1251_tx_fill_hdr(struct wl1251 *wl, struct sk_buff *skb,return id; fc = *(u16 *)skb->data; - tx_hdr = (struct tx_double_buffer_desc *)skb_push (skb, -sizeof (*tx_hdr)); + tx_hdr =skb_push (skb,sizeof (*tx_hdr)); tx_hdr->length =cpu_to_le16 (skb->len -sizeof (*tx_hdr)); rate =ieee80211_get_tx_rate (wl->hw, control);
drivers/net/wireless/ti/wlcore/cmd.c +1 -1
@@ -1280,7 +1280,7 @@ int wl1271_cmd_build_arp_rsp(struct wl1271 *wl, struct wl12xx_vif *wlvif)memset (skb_push (skb,sizeof (__le16)),0 ,sizeof (__le16));/* mac80211 header */ - hdr = (struct ieee80211_hdr_3addr *)skb_push (skb,sizeof (*hdr)); + hdr =skb_push (skb,sizeof (*hdr));memset (hdr,0 ,sizeof (*hdr)); fc =IEEE80211_FTYPE_DATA |IEEE80211_FCTL_TODS ;if (wlvif->sta.qos)
drivers/net/wireless/ti/wlcore/tx.c +1 -2
@@ -223,8 +223,7 @@ static int wl1271_tx_allocate(struct wl1271 *wl, struct wl12xx_vif *wlvif, total_blocks =wlcore_hw_calc_tx_blocks (wl, total_len, spare_blocks);if (total_blocks <= wl->tx_blocks_available) { - desc = (struct wl1271_tx_hw_descr *)skb_push ( - skb, total_len - skb->len); + desc =skb_push (skb, total_len - skb->len);wlcore_hw_set_tx_desc_blocks (wl, desc, total_blocks, spare_blocks);
drivers/net/wireless/zd1211rw/zd_mac.c +1 -2
@@ -868,8 +868,7 @@ static int fill_ctrlset(struct zd_mac *mac,unsigned int frag_len = skb->len +FCS_LEN ;unsigned int packet_length;struct ieee80211_rate *txrate; -struct zd_ctrlset *cs = (struct zd_ctrlset *) -skb_push (skb,sizeof (struct zd_ctrlset )); +struct zd_ctrlset *cs =skb_push (skb,sizeof (struct zd_ctrlset ));struct ieee80211_tx_info *info =IEEE80211_SKB_CB (skb);ZD_ASSERT (frag_len <=0xffff );
drivers/s390/net/qeth_l2_main.c +1 -2
@@ -768,8 +768,7 @@ static int qeth_l2_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) sizeof(struct qeth_hdr));if (!new_skb) goto tx_drop; - hdr = (struct qeth_hdr *)skb_push (new_skb, -sizeof (struct qeth_hdr )); + hdr =skb_push (new_skb,sizeof (struct qeth_hdr ));skb_set_mac_header (new_skb,sizeof (struct qeth_hdr ));qeth_l2_fill_header (card, hdr, new_skb, cast_type); }
drivers/s390/net/qeth_l3_main.c +2 -4
@@ -3035,16 +3035,14 @@ static int qeth_l3_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) }if (large_send && (cast_type ==RTN_UNSPEC )) { - hdr = (struct qeth_hdr *)skb_push (new_skb, -sizeof (struct qeth_hdr_tso )); + hdr =skb_push (new_skb,sizeof (struct qeth_hdr_tso ));memset (hdr,0 ,sizeof (struct qeth_hdr_tso ));qeth_l3_fill_header (card, hdr, new_skb, ipv, cast_type);qeth_tso_fill_header (card, hdr, new_skb); elements_needed++; }else {if (data_offset <0 ) { - hdr = (struct qeth_hdr *)skb_push (new_skb, -sizeof (struct qeth_hdr )); + hdr =skb_push (new_skb,sizeof (struct qeth_hdr ));qeth_l3_fill_header (card, hdr, new_skb, ipv, cast_type); }else {
drivers/scsi/fcoe/fcoe_ctlr.c +1 -1
@@ -623,7 +623,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport, fh = (struct fc_frame_header *)skb->data; op = *(u8 *)(fh +1 ); dlen =sizeof (struct fip_encaps ) + skb->len;/* len before push */ - cap = (struct fip_encaps_head *)skb_push (skb,sizeof (*cap)); + cap =skb_push (skb,sizeof (*cap));memset (cap,0 ,sizeof (*cap));if (lport->point_to_multipoint) {
drivers/scsi/fnic/fnic_fcs.c +3 -4
@@ -984,8 +984,7 @@ void fnic_eth_send(struct fcoe_ctlr *fip, struct sk_buff *skb)if (!fnic->vlan_hw_insert) { eth_hdr = (struct ethhdr *)skb_mac_header (skb); - vlan_hdr = (struct vlan_ethhdr *)skb_push (skb, -sizeof (*vlan_hdr) -sizeof (*eth_hdr)); + vlan_hdr =skb_push (skb,sizeof (*vlan_hdr) -sizeof (*eth_hdr));memcpy (vlan_hdr, eth_hdr,2 *ETH_ALEN ); vlan_hdr->h_vlan_proto =htons (ETH_P_8021Q ); vlan_hdr->h_vlan_encapsulated_proto = eth_hdr->h_proto;
@@ -1042,7 +1041,7 @@ static int fnic_send_frame(struct fnic *fnic, struct fc_frame *fp)if (!fnic->vlan_hw_insert) { eth_hdr_len =sizeof (*vlan_hdr) +sizeof (*fcoe_hdr); - vlan_hdr = (struct vlan_ethhdr *)skb_push (skb, eth_hdr_len); + vlan_hdr =skb_push (skb, eth_hdr_len); eth_hdr = (struct ethhdr *)vlan_hdr; vlan_hdr->h_vlan_proto =htons (ETH_P_8021Q ); vlan_hdr->h_vlan_encapsulated_proto =htons (ETH_P_FCOE );
@@ -1050,7 +1049,7 @@ static int fnic_send_frame(struct fnic *fnic, struct fc_frame *fp) fcoe_hdr = (struct fcoe_hdr *)(vlan_hdr +1 ); }else { eth_hdr_len =sizeof (*eth_hdr) +sizeof (*fcoe_hdr); - eth_hdr = (struct ethhdr *)skb_push (skb, eth_hdr_len); + eth_hdr =skb_push (skb, eth_hdr_len); eth_hdr->h_proto =htons (ETH_P_FCOE ); fcoe_hdr = (struct fcoe_hdr *)(eth_hdr +1 ); }
drivers/staging/wlan-ng/p80211conv.c +5 -9
@@ -147,9 +147,7 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,skb_pull (skb,WLAN_ETHHDR_LEN );/* tack on SNAP */ - e_snap = - (struct wlan_snap *)skb_push (skb, -sizeof (struct wlan_snap )); + e_snap =skb_push (skb,sizeof (struct wlan_snap )); e_snap->type =htons (proto);if (ethconv == WLAN_ETHCONV_8021h &&p80211_stt_findproto (proto)) {
@@ -161,9 +159,7 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv, }/* tack on llc */ - e_llc = - (struct wlan_llc *)skb_push (skb, -sizeof (struct wlan_llc )); + e_llc =skb_push (skb,sizeof (struct wlan_llc )); e_llc->dsap =0xAA ;/* SNAP, see IEEE 802 */ e_llc->ssap =0xAA ; e_llc->ctl =0x03 ;
@@ -404,7 +400,7 @@ int skb_p80211_to_ether(wlandevice_t *wlandev, u32 ethconv,skb_pull (skb, payload_offset);/* create 802.3 header at beginning of skb. */ - e_hdr = (struct wlan_ethhdr *)skb_push (skb,WLAN_ETHHDR_LEN ); + e_hdr =skb_push (skb,WLAN_ETHHDR_LEN );memcpy (e_hdr->daddr, daddr,WLAN_ETHADDR_LEN );memcpy (e_hdr->saddr, saddr,WLAN_ETHADDR_LEN ); e_hdr->type =htons (payload_length);
@@ -444,7 +440,7 @@ int skb_p80211_to_ether(wlandevice_t *wlandev, u32 ethconv,skb_pull (skb,sizeof (struct wlan_snap ));/* create 802.3 header at beginning of skb. */ - e_hdr = (struct wlan_ethhdr *)skb_push (skb,WLAN_ETHHDR_LEN ); + e_hdr =skb_push (skb,WLAN_ETHHDR_LEN ); e_hdr->type = e_snap->type;memcpy (e_hdr->daddr, daddr,WLAN_ETHADDR_LEN );memcpy (e_hdr->saddr, saddr,WLAN_ETHADDR_LEN );
@@ -471,7 +467,7 @@ int skb_p80211_to_ether(wlandevice_t *wlandev, u32 ethconv,skb_pull (skb, payload_offset);/* create 802.3 header at beginning of skb. */ - e_hdr = (struct wlan_ethhdr *)skb_push (skb,WLAN_ETHHDR_LEN ); + e_hdr =skb_push (skb,WLAN_ETHHDR_LEN );memcpy (e_hdr->daddr, daddr,WLAN_ETHADDR_LEN );memcpy (e_hdr->saddr, saddr,WLAN_ETHADDR_LEN ); e_hdr->type =htons (payload_length);
drivers/usb/gadget/function/rndis.c +1 -1
@@ -952,7 +952,7 @@ void rndis_add_hdr(struct sk_buff *skb)if (!skb)return ; - header = (void *)skb_push (skb,sizeof (*header)); + header =skb_push (skb,sizeof (*header));memset (header,0 ,sizeof *header); header->MessageType =cpu_to_le32 (RNDIS_MSG_PACKET ); header->MessageLength =cpu_to_le32 (skb->len);
include/linux/if_vlan.h +1 -1
@@ -300,7 +300,7 @@ static inline int __vlan_insert_tag(struct sk_buff *skb,if (skb_cow_head (skb,VLAN_HLEN ) <0 )return -ENOMEM ; - veth = (struct vlan_ethhdr *)skb_push (skb,VLAN_HLEN ); + veth =skb_push (skb,VLAN_HLEN );/* Move the mac addresses to the beginning of the new header. */ memmove (skb->data, skb->data +VLAN_HLEN ,2 *ETH_ALEN );
net/802/fc.c +2 -2
@@ -49,7 +49,7 @@ static int fc_header(struct sk_buff *skb, struct net_device *dev,struct fcllc *fcllc; hdr_len =sizeof (struct fch_hdr ) +sizeof (struct fcllc ); - fch = (struct fch_hdr *)skb_push (skb, hdr_len); + fch =skb_push (skb, hdr_len); fcllc = (struct fcllc *)(fch+1 ); fcllc->dsap = fcllc->ssap =EXTENDED_SAP ; fcllc->llc =UI_CMD ;
@@ -59,7 +59,7 @@ static int fc_header(struct sk_buff *skb, struct net_device *dev,else { hdr_len =sizeof (struct fch_hdr ); - fch = (struct fch_hdr *)skb_push (skb, hdr_len); + fch =skb_push (skb, hdr_len); }if (saddr)
net/802/fddi.c +1 -1
@@ -58,7 +58,7 @@ static int fddi_header(struct sk_buff *skb, struct net_device *dev,if (type !=ETH_P_IP && type !=ETH_P_IPV6 && type !=ETH_P_ARP ) hl=FDDI_K_8022_HLEN -3 ; - fddi = (struct fddihdr *)skb_push (skb, hl); + fddi =skb_push (skb, hl); fddi->fc =FDDI_FC_K_ASYNC_LLC_DEF ;if (type ==ETH_P_IP || type ==ETH_P_IPV6 || type ==ETH_P_ARP ) {
net/802/hippi.c +1 -1
@@ -47,7 +47,7 @@ static int hippi_header(struct sk_buff *skb, struct net_device *dev,unsigned short type, const void *daddr, const void *saddr, unsigned int len) { - struct hippi_hdr *hip = (struct hippi_hdr *)skb_push(skb, HIPPI_HLEN); + struct hippi_hdr *hip = skb_push(skb, HIPPI_HLEN);struct hippi_cb *hcb = (struct hippi_cb *) skb->cb;if (!len){
net/8021q/vlan_dev.c +1 -1
@@ -57,7 +57,7 @@ static int vlan_dev_hard_header(struct sk_buff *skb, struct net_device *dev,int rc;if (!(vlan->flags &VLAN_FLAG_REORDER_HDR )) { - vhdr = (struct vlan_hdr *)skb_push (skb,VLAN_HLEN ); + vhdr =skb_push (skb,VLAN_HLEN ); vlan_tci = vlan->vlan_id; vlan_tci |=vlan_dev_get_egress_qos_mask (dev, skb->priority);
net/appletalk/ddp.c +1 -1
@@ -1529,7 +1529,7 @@ static int ltalk_rcv(struct sk_buff *skb, struct net_device *dev,* The push leaves us with a ddephdr not an shdr, and * handily the port bytes in the right place preset. */ - ddp = (struct ddpehdr *)skb_push (skb,sizeof (*ddp) -4 ); + ddp =skb_push (skb,sizeof (*ddp) -4 );/* Now fill in the long header */
net/bluetooth/hci_sock.c +2 -2
@@ -289,7 +289,7 @@ void hci_send_to_monitor(struct hci_dev *hdev, struct sk_buff *skb)return ;/* Put header before the data */ - hdr = (void *)skb_push (skb_copy,HCI_MON_HDR_SIZE ); + hdr =skb_push (skb_copy,HCI_MON_HDR_SIZE ); hdr->opcode = opcode; hdr->index =cpu_to_le16 (hdev->id); hdr->len =cpu_to_le16 (skb->len);
@@ -335,7 +335,7 @@ static struct sk_buff *create_monitor_event(struct hci_dev *hdev, int event)__net_timestamp (skb); - hdr = (void *)skb_push (skb,HCI_MON_HDR_SIZE ); + hdr =skb_push (skb,HCI_MON_HDR_SIZE ); hdr->opcode = opcode; hdr->index =cpu_to_le16 (hdev->id); hdr->len =cpu_to_le16 (skb->len -HCI_MON_HDR_SIZE );
net/bluetooth/rfcomm/core.c +2 -2
@@ -1153,10 +1153,10 @@ static void rfcomm_make_uih(struct sk_buff *skb, u8 addr)u8 *crc;if (len >127 ) { - hdr = (void *)skb_push (skb,4 ); + hdr =skb_push (skb,4 );put_unaligned (cpu_to_le16 (__len16 (len)), (__le16 *) &hdr->len); }else { - hdr = (void *)skb_push (skb,3 ); + hdr =skb_push (skb,3 ); hdr->len =__len8 (len); } hdr->addr = addr;
net/bridge/netfilter/nft_reject_bridge.c +1 -1
@@ -29,7 +29,7 @@ static void nft_reject_br_push_etherhdr(struct sk_buff *oldskb, {struct ethhdr *eth; - eth = (struct ethhdr *)skb_push (nskb,ETH_HLEN ); + eth =skb_push (nskb,ETH_HLEN );skb_reset_mac_header (nskb);ether_addr_copy (eth->h_source,eth_hdr (oldskb)->h_dest);ether_addr_copy (eth->h_dest,eth_hdr (oldskb)->h_source);
net/core/netpoll.c +2 -2
@@ -428,7 +428,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) ip6h->saddr = np->local_ip.in6; ip6h->daddr = np->remote_ip.in6; - eth = (struct ethhdr *)skb_push (skb,ETH_HLEN ); + eth =skb_push (skb,ETH_HLEN );skb_reset_mac_header (skb); skb->protocol = eth->h_proto =htons (ETH_P_IPV6 ); }else {
@@ -457,7 +457,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len)put_unaligned (np->remote_ip.ip, &(iph->daddr)); iph->check =ip_fast_csum ((unsigned char *)iph, iph->ihl); - eth = (struct ethhdr *)skb_push (skb,ETH_HLEN ); + eth =skb_push (skb,ETH_HLEN );skb_reset_mac_header (skb); skb->protocol = eth->h_proto =htons (ETH_P_IP ); }
net/core/pktgen.c +3 -3
@@ -2616,7 +2616,7 @@ static int process_ipsec(struct pktgen_dev *pkt_dev, goto err; }/* restore ll */ - eth = (__u8 *)skb_push (skb,ETH_HLEN ); + eth =skb_push (skb,ETH_HLEN );memcpy (eth, pkt_dev->hh,12 ); *(u16 *) ð[12 ] = protocol;
@@ -2783,7 +2783,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,skb_reserve (skb, datalen);/* Reserve for ethernet and IP header */ - eth = (__u8 *)skb_push (skb,14 ); + eth =skb_push (skb,14 ); mpls =skb_put (skb, pkt_dev->nr_labels *sizeof (__u32));if (pkt_dev->nr_labels)mpls_push (mpls, pkt_dev);
@@ -2911,7 +2911,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,skb_reserve (skb,16 );/* Reserve for ethernet and IP header */ - eth = (__u8 *)skb_push (skb,14 ); + eth =skb_push (skb,14 ); mpls =skb_put (skb, pkt_dev->nr_labels *sizeof (__u32));if (pkt_dev->nr_labels)mpls_push (mpls, pkt_dev);
net/decnet/dn_dev.c +2 -2
@@ -863,7 +863,7 @@ static void dn_send_endnode_hello(struct net_device *dev, struct dn_ifaddr *ifa) msg->datalen =0x02 ;memset (msg->data,0xAA ,2 ); - pktlen = (__le16 *)skb_push (skb,2 ); + pktlen =skb_push (skb,2 ); *pktlen =cpu_to_le16 (skb->len -2 );skb_reset_network_header (skb);
@@ -955,7 +955,7 @@ static void dn_send_router_hello(struct net_device *dev, struct dn_ifaddr *ifa)skb_trim (skb, (27 + *i2)); - pktlen = (__le16 *)skb_push (skb,2 ); + pktlen =skb_push (skb,2 ); *pktlen =cpu_to_le16 (skb->len -2 );skb_reset_network_header (skb);
net/ethernet/eth.c +1 -1
@@ -79,7 +79,7 @@ int eth_header(struct sk_buff *skb, struct net_device *dev,unsigned short type, const void *daddr, const void *saddr, unsigned int len) { - struct ethhdr *eth = (struct ethhdr *)skb_push(skb, ETH_HLEN); + struct ethhdr *eth = skb_push(skb, ETH_HLEN);if (type !=ETH_P_802_3 && type !=ETH_P_802_2 ) eth->h_proto =htons (type);
net/ipv4/ip_gre.c +1 -1
@@ -374,7 +374,7 @@ static int ipgre_header(struct sk_buff *skb, struct net_device *dev,struct iphdr *iph;struct gre_base_hdr *greh; - iph = (struct iphdr *)skb_push (skb, t->hlen +sizeof (*iph)); + iph =skb_push (skb, t->hlen +sizeof (*iph)); greh = (struct gre_base_hdr *)(iph+1 ); greh->flags =tnl_flags_to_gre_flags (t->parms.o_flags); greh->protocol =htons (type);
net/ipv6/exthdrs.c +2 -2
@@ -661,7 +661,7 @@ static void ipv6_push_rthdr(struct sk_buff *skb, u8 *proto, ihdr = (struct rt0_hdr *) opt; - phdr = (struct rt0_hdr *)skb_push (skb, (ihdr->rt_hdr.hdrlen +1 ) <<3 ); + phdr =skb_push (skb, (ihdr->rt_hdr.hdrlen +1 ) <<3 );memcpy (phdr, ihdr,sizeof (struct rt0_hdr )); hops = ihdr->rt_hdr.hdrlen >>1 ;
@@ -679,7 +679,7 @@ static void ipv6_push_rthdr(struct sk_buff *skb, u8 *proto,static void ipv6_push_exthdr (struct sk_buff *skb,u8 *proto,u8 type,struct ipv6_opt_hdr *opt) { -struct ipv6_opt_hdr *h = (struct ipv6_opt_hdr *)skb_push (skb,ipv6_optlen (opt)); +struct ipv6_opt_hdr *h =skb_push (skb,ipv6_optlen (opt));memcpy (h, opt,ipv6_optlen (opt)); h->nexthdr = *proto;
net/ipv6/ip6_gre.c +1 -1
@@ -1177,7 +1177,7 @@ static int ip6gre_header(struct sk_buff *skb, struct net_device *dev, const void *daddr, const void *saddr, unsigned int len) { struct ip6_tnl *t = netdev_priv(dev); -struct ipv6hdr *ipv6h = (struct ipv6hdr *)skb_push (skb, t->hlen); +struct ipv6hdr *ipv6h =skb_push (skb, t->hlen);__be16 *p = (__be16 *)(ipv6h+1 ); ip6_flow_hdr(ipv6h, 0,
net/ipv6/tcp_ipv6.c +1 -1
@@ -755,7 +755,7 @@ static void tcp_v6_send_response(struct sock *sk, struct sk_buff *skb, u32 seq,skb_reserve (buff,MAX_HEADER +sizeof (struct ipv6hdr ) + tot_len); - t1 = (struct tcphdr *)skb_push (buff, tot_len); + t1 =skb_push (buff, tot_len);skb_reset_transport_header (buff);/* Swap the send and the receive. */
net/iucv/af_iucv.c +1 -2
@@ -322,8 +322,7 @@ static int afiucv_hs_send(struct iucv_message *imsg, struct sock *sock,int err, confirm_recv =0 ;memset (skb->head,0 ,ETH_HLEN ); - phs_hdr = (struct af_iucv_trans_hdr *)skb_push (skb, -sizeof (struct af_iucv_trans_hdr )); + phs_hdr =skb_push (skb,sizeof (struct af_iucv_trans_hdr ));skb_reset_mac_header (skb);skb_reset_network_header (skb);skb_push (skb,ETH_HLEN );
net/mac80211/rx.c +1 -1
@@ -178,7 +178,7 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,if (!(has_fcs && (local->hw.flags &IEEE80211_HW_RX_INCLUDES_FCS ))) mpdulen +=FCS_LEN ; - rthdr = (struct ieee80211_radiotap_header *)skb_push (skb, rtap_len); + rthdr =skb_push (skb, rtap_len);memset (rthdr,0 , rtap_len - rtap.len - rtap.pad); it_present = &rthdr->it_present;
net/mac80211/status.c +1 -1
@@ -280,7 +280,7 @@ ieee80211_add_tx_radiotap_header(struct ieee80211_local *local,unsigned char *pos;u16 txflags; - rthdr = (struct ieee80211_radiotap_header *)skb_push (skb, rtap_len); + rthdr =skb_push (skb, rtap_len);memset (rthdr,0 , rtap_len); rthdr->it_len =cpu_to_le16 (rtap_len);
net/mac80211/tx.c +1 -1
@@ -2354,7 +2354,7 @@ static struct sk_buff *ieee80211_build_hdr(struct ieee80211_sub_if_data *sdata,if (ieee80211_is_data_qos (fc)) {__le16 *qos_control; - qos_control = (__le16 *)skb_push (skb,2 ); + qos_control =skb_push (skb,2 );memcpy (skb_push (skb, hdrlen -2 ), &hdr, hdrlen -2 );/* * Maybe we could actually set some fields here, for now just
net/nfc/nci/data.c +1 -1
@@ -81,7 +81,7 @@ static inline void nci_push_data_hdr(struct nci_dev *ndev,struct nci_data_hdr *hdr;int plen = skb->len; - hdr = (struct nci_data_hdr *)skb_push (skb,NCI_DATA_HDR_SIZE ); + hdr =skb_push (skb,NCI_DATA_HDR_SIZE ); hdr->conn_id = conn_id; hdr->rfu =0 ; hdr->plen = plen;
net/sctp/output.c +1 -1
@@ -425,7 +425,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)skb_dst_set (nskb, dst);/* Build the SCTP header. */ - sh = (struct sctphdr *)skb_push (nskb,sizeof (struct sctphdr )); + sh =skb_push (nskb,sizeof (struct sctphdr ));skb_reset_transport_header (nskb); sh->source =htons (packet->source_port); sh->dest =htons (packet->destination_port);
net/sctp/sm_statefuns.c +2 -2
@@ -771,8 +771,8 @@ sctp_disposition_t sctp_sf_do_5_1D_ce(struct net *net, auth.skb = chunk->auth_chunk; auth.asoc = chunk->asoc; auth.sctp_hdr = chunk->sctp_hdr; - auth.chunk_hdr = (sctp_chunkhdr_t *)skb_push (chunk->auth_chunk, -sizeof (sctp_chunkhdr_t)); + auth.chunk_hdr =skb_push (chunk->auth_chunk, +sizeof (sctp_chunkhdr_t));skb_pull (chunk->auth_chunk,sizeof (sctp_chunkhdr_t)); auth.transport = chunk->transport;
net/sctp/ulpevent.c +3 -5
@@ -150,8 +150,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_assoc_change(sctp_ulpevent_init (event,MSG_NOTIFICATION , skb->truesize);/* Include the notification structure */ - sac = (struct sctp_assoc_change *) -skb_push (skb,sizeof (struct sctp_assoc_change )); + sac =skb_push (skb,sizeof (struct sctp_assoc_change ));/* Trim the buffer to the right length. */ skb_trim(skb, sizeof(struct sctp_assoc_change) +
@@ -397,7 +396,7 @@ sctp_ulpevent_make_remote_error(const struct sctp_association *asoc, event =sctp_skb2event (skb);sctp_ulpevent_init (event,MSG_NOTIFICATION , skb->truesize); - sre = (struct sctp_remote_error *)skb_push (skb,sizeof (*sre)); + sre =skb_push (skb,sizeof (*sre));/* Trim the buffer to the right length. */ skb_trim (skb,sizeof (*sre) + elen);
@@ -448,8 +447,7 @@ struct sctp_ulpevent *sctp_ulpevent_make_send_failed( event =sctp_skb2event (skb);sctp_ulpevent_init (event,MSG_NOTIFICATION , skb->truesize); - ssf = (struct sctp_send_failed *) -skb_push (skb,sizeof (struct sctp_send_failed )); + ssf =skb_push (skb,sizeof (struct sctp_send_failed ));/* Socket Extensions for SCTP * 5.3.1.4 SCTP_SEND_FAILED
net/wireless/util.c +1 -1
@@ -518,7 +518,7 @@ int ieee80211_data_to_8023(struct sk_buff *skb, const u8 *addr,skb_pull (skb, hdrlen); len =htons (skb->len); - ehdr = (struct ethhdr *)skb_push (skb,sizeof (struct ethhdr )); + ehdr =skb_push (skb,sizeof (struct ethhdr ));memcpy (ehdr->h_dest, dst,ETH_ALEN );memcpy (ehdr->h_source, src,ETH_ALEN ); ehdr->h_proto = len;
Signature · 1 line
2.1.4
Quoted 8 lines · Joe Perches
unsigned char * return values are sometimes awkward to work with. Changing the return to void * is sometimes clearer.
The only uses of the return type is to do sets like
*skb_puts(skb, 1) = char;Adding another function specifically for that purpose allows the return type to become void.
Obviously, this shouldn't be applied as-is.
It spans too many subsystems and can be done
more incrementally.
Also, there are some missing conversions so
this won't compile properly (sorry 'bout that)
These will also need conversions:
drivers/isdn/i4l/isdn_ppp.c:1311: *skb_push(skb, 4) = 1; /* indicate outbound */drivers/net/ppp/ppp_generic.c:1208: *skb_push(skb, 2) = 1;
drivers/net/ppp/ppp_generic.c:1843: *skb_push(skb, 2) = 0; drivers/nfc/pn533.c:2601: *skb_push(frag, sizeof(u8)) = drivers/nfc/pn533.c:2604: *skb_push(frag, sizeof(u8)) = 1; /* TG */
drivers/nfc/pn533.c:2671: *skb_push(skb, sizeof(u8)) = 1; /* TG */net/nfc/digital_dep.c:152: *skb_push(skb, sizeof(u8)) = DIGITAL_NFC_DEP_NFCA_SOD_SB;net/nfc/digital_technology.c:1164: *skb_push(skb, sizeof(u8)) = size + 1;net/nfc/rawsock.c:145: *skb_push(skb, NFC_HEADER_SIZE) = 0;
The isdn and ppp_generic uses maybe should be
2 lines each for a little better clarity.
David Miller
maintainerFrom: Joe Perches <[email protected]>
Date: Mon, 04 May 2015 13:32:30 -0700
Quoted 10 lines · Joe Perches
Quoted 8 lines
unsigned char * return values are sometimes awkward to work with. Changing the return to void * is sometimes clearer.
The only uses of the return type is to do sets like
*skb_puts(skb, 1) = char;Adding another function specifically for that purpose allows the return type to become void.
Quoted 7 lines
Obviously, this shouldn't be applied as-is.
It spans too many subsystems and can be done
more incrementally.Also, there are some missing conversions so
this won't compile properly (sorry 'bout that)
I have no fundamental issues with this series once you fix up those issues.
Quoted 13 lines · David Miller
From: Joe Perches <[email protected]> Date: Mon, 04 May 2015 13:32:30 -0700
Quoted 12 lines · Joe Perches
Quoted 8 lines
unsigned char * return values are sometimes awkward to work with. Changing the return to void * is sometimes clearer.
The only uses of the return type is to do sets like
*skb_puts(skb, 1) = char;Adding another function specifically for that purpose allows the return type to become void.
Obviously, this shouldn't be applied as-is.
Quoted 8 lines
Quoted 5 lines
It spans too many subsystems and can be done
more incrementally.Also, there are some missing conversions so
this won't compile properly (sorry 'bout that)I have no fundamental issues with this series once you fix up those issues.
OK, good.
Another thing that's fairly common is an skb_put followed by a memcpy or memset.
Adding a couple of functions for those like:
void *skb_put_memcpy(struct sk_buff *skb, void *from, size_t size); void *skb_put_memset(struct sk_buff *skb, int c, size_t size);
would reduce code size and improve performance a little.
Are you OK with that too?
Quoted 4 lines · Joe Perches
Another thing that's fairly common is an
skb_putfollowed by a memcpy or memset.
Quoted 8 lines
Adding a couple of functions for those like:
void *skb_put_memcpy(struct
sk_buff*skb, void *from,size_tsize); void *skb_put_memset(structsk_buff*skb, int c,size_tsize);would reduce code size and improve performance a little.
Are you OK with that too?
Could we stop the API inflation and code churn, please.
You have little idea of the hassle this means for people like us doing backports and code maintenance, preventing us from doing useful work, like fixing real bugs and issues.
You know, even something very simple as the 'extern' removal in include files had consumed days of work for us because of merge conflicts, and reviewer time.
( commit 5c9f30236f53f3fbee170e2452dfa0e5dce4727b for example)
We understand the code as is, with regular memcpy() and memset()
These functions are fine. They were fine 20 years ago, nothing changed.
Thanks.
Quoted 7 lines · Eric Dumazet
Quoted 6 lines · Joe Perches
Another thing that's fairly common is an
skb_putfollowed by a memcpy or memset.
Adding a couple of functions for those like:
void *skb_put_memcpy(structsk_buff*skb, void *from,size_tsize); void *skb_put_memset(structsk_buff*skb, int c,size_tsize); would reduce code size and improve performance a little.
[]
Quoted 2 lines
We understand the code as is, with regular
memcpy()andmemset()These functions are fine. They were fine 20 years ago, nothing changed.
Prefer speed and size improvements over stasis.
alloc+memset works, zalloc exists.
Using these functions would reduce a non-modular defconfig x86-64 net/built-in.o by a couple kb.
Probably double that for a kernel.
These functions would be used in the packet processing path for wireless too.