Skip to contentSkip to conversation

adm8211: fix checkpatch errors for indentation and new line around switch-case

PATCH In review Okash Khawaja 3 participants 4 messages May 5, 2015

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Okash Khawaja

author
#0 lore raw

PATCH 1/1 adm8211: fix checkpatch errors for indentation and new line around switch-case

This patch fixes these checkpatch.pl errors around a single switch-case block:

ERROR: switch and case should be at the same indent
ERROR: trailing statements should be on next line

More specifically, the fix has been applied to the five occurances of the errors listed below.

ERROR: switch and case should be at the same indent #1100: FILE: adm8211.c:1100:
+ switch (cline) {
[...]
+ default: reg |= (0x0 << 14);

ERROR: trailing statements should be on next line
#1101: FILE: adm8211.c:1101:
+ case 0x8: reg |= (0x1 << 14);

ERROR: trailing statements should be on next line
#1103: FILE: adm8211.c:1103:
+ case 0x16: reg |= (0x2 << 14);

ERROR: trailing statements should be on next line
#1105: FILE: adm8211.c:1105:
+ case 0x32: reg |= (0x3 << 14);

ERROR: trailing statements should be on next line
#1107: FILE: adm8211.c:1107:
+ default: reg |= (0x0 << 14);

Signed-off-by Okash Khawaja <[email protected]>
---
 drivers/net/wireless/adm8211.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
drivers/net/wireless/adm8211.c +12 -8
index f07a618..058fb4b 100644
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
 		pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
 		switch (cline) {
-		case  0x8: reg |= (0x1 << 14);
-			   break;
-		case 0x16: reg |= (0x2 << 14);
-			   break;
-		case 0x32: reg |= (0x3 << 14);
-			   break;
-		  default: reg |= (0x0 << 14);
-			   break;
+		case  0x8:
+			reg |= (0x1 << 14);
+			break;
+		case 0x16:
+			reg |= (0x2 << 14);
+			break;
+		case 0x32:
+			reg |= (0x3 << 14);
+			break;
+		default:
+			reg |= (0x0 << 14);
+			break;
 		}
 	}
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 21 lines
drivers/net/wireless/adm8211.c +5 -8
index f07a618..058fb4b 100644
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
 		pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
 		switch (cline) {
-		case  0x8: reg |= (0x1 << 14);
-			   break;
-		case 0x16: reg |= (0x2 << 14);
-			   break;
-		case 0x32: reg |= (0x3 << 14);
-			   break;
-		  default: reg |= (0x0 << 14);
-			   break;
+		case  0x8:
+			reg |= (0x1 << 14);
+			break;
+		case 0x16:
+			reg |= (0x2 << 14);

drivers/net/wireless/adm8211.c static void adm8211_hw_init(struct ieee80211_hw *dev) · line 1115

Quoted 10 lines
drivers/net/wireless/adm8211.c +7 -0
+			break;
+		case 0x32:
+			reg |= (0x3 << 14);
+			break;
+		default:
+			reg |= (0x0 << 14);
+			break;
 		}
 	}

Those 0x16/0x32 hexadecimal case-selectors looking suspiciously like decimal bits need a comment if they are in fact correct, which I doubt.

Cheers,
Peter

#2 lore raw
Quoted 1 line · Peter Rosin

drivers/net/wireless/adm8211.c

Quoted 1 line
drivers/net/wireless/adm8211.c +0 -0

[]

Quoted 4 lines

drivers/net/wireless/adm8211.c static void adm8211_hw_init(struct ieee80211_hw *dev) · line 1100

Quoted 4 lines
drivers/net/wireless/adm8211.c +0 -0
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
 		pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
 		switch (cline) {

[]

Quoted 10 lines
Quoted 10 lines
drivers/net/wireless/adm8211.c +10 -0
+		case  0x8:
+			reg |= (0x1 << 14);
+			break;
+		case 0x16:
+			reg |= (0x2 << 14);
+			break;
+		case 0x32:
+			reg |= (0x3 << 14);
+			break;
+		default:
Quoted 8 lines

drivers/net/wireless/adm8211.c static void adm8211_hw_init(struct ieee80211_hw *dev) · line 1115

Quoted 5 lines
drivers/net/wireless/adm8211.c +2 -0
+			reg |= (0x0 << 14);
+			break;
 		}
 	}

Those 0x16/0x32 hexadecimal case-selectors looking suspiciously like decimal bits need a comment if they are in fact correct, which I doubt.

Good spot.

As it's testing PCI_CACHE_LINE_SIZE,
they seem very much broken.

author
#3 lore raw
Quoted 25 lines · Joe Perches
Quoted 1 line · Peter Rosin

drivers/net/wireless/adm8211.c

Quoted 1 line
drivers/net/wireless/adm8211.c +0 -0

[]

Quoted 4 lines

drivers/net/wireless/adm8211.c static void adm8211_hw_init(struct ieee80211_hw *dev) · line 1100

Quoted 4 lines
drivers/net/wireless/adm8211.c +0 -0
@@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
       pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
 
       switch (cline) {

[]

Quoted 15 lines
Quoted 14 lines
drivers/net/wireless/adm8211.c +12 -0
+        case  0x8:
+            reg |= (0x1 << 14);
+            break;
+        case 0x16:
+            reg |= (0x2 << 14);
+            break;
+        case 0x32:
+            reg |= (0x3 << 14);
+            break;
+        default:
+            reg |= (0x0 << 14);
+            break;
       }
   }
Quoted 9 lines
Quoted 2 lines

Those 0x16/0x32 hexadecimal case-selectors looking suspiciously like decimal bits need a comment if they are in fact correct, which I doubt.

Good spot.

As it's testing PCI_CACHE_LINE_SIZE,
they seem very much broken.

Interesting. I'll be happy to fix that bit if someone could guide me on it. Looks like these values should be 0x10, 0x20 instead of 0x16, 0x32 respectively. But I am unable to understand their meaning in this code. Thanks