drm/i915: Add missing POSTING_READ()s to BXT dbuf enable sequence
Subsystems (2)
PATCH 1/1 drm/i915: Add missing POSTING_READ()s to BXT dbuf enable sequence
From: Ville Syrjälä <[email protected]>
Do a POSTING_READ() between the DBUF_CTL register write and the udelay() to make sure we really wait after the register write has happened.
Spotted while reviewing Damien's SKL cdclk patch which had the POSTING_READ()s.
--- drivers/gpu/drm/i915/intel_display.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/intel_display.c +4 -0
@@ -5482,6 +5482,8 @@ void broxton_init_cdclk(struct drm_device *dev)broxton_set_cdclk (dev,624000 );I915_WRITE (DBUF_CTL ,I915_READ (DBUF_CTL ) |DBUF_POWER_REQUEST ); +POSTING_READ (DBUF_CTL ); +udelay (10 );if (!(I915_READ (DBUF_CTL ) &DBUF_POWER_STATE ))
@@ -5493,6 +5495,8 @@ void broxton_uninit_cdclk(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;I915_WRITE (DBUF_CTL ,I915_READ (DBUF_CTL ) & ~DBUF_POWER_REQUEST ); +POSTING_READ (DBUF_CTL ); +udelay (10 );if (I915_READ (DBUF_CTL ) &DBUF_POWER_STATE )
Signature · 6 lines
2.0.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · On ke, 2015-05-06 at 14:28 +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
Do a
POSTING_READ()between theDBUF_CTLregister write and theudelay()to make sure we really wait after the register write has happened.Spotted while reviewing Damien's SKL cdclk patch which had the POSTING_READ()s.
Cc Imre Deak <[email protected]>Signed-off-by Ville Syrjälä <[email protected]>
Yep, makes sense:
Quoted 18 lines
--- drivers/gpu/drm/i915/intel_display.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/intel_display.c +2
-0@@ -5482,6 +5482,8 @@ void broxton_init_cdclk(struct drm_device *dev)broxton_set_cdclk (dev,624000 );I915_WRITE (DBUF_CTL ,I915_READ (DBUF_CTL ) |DBUF_POWER_REQUEST ); +POSTING_READ (DBUF_CTL ); +udelay (10 );if (!(I915_READ (DBUF_CTL ) &DBUF_POWER_STATE ))
drivers/gpu/drm/i915/intel_display.c void broxton_uninit_cdclk(struct drm_device *dev) · line 5502
Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +2
-0@@ -5493,6 +5495,8 @@ void broxton_uninit_cdclk(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;I915_WRITE (DBUF_CTL ,I915_READ (DBUF_CTL ) & ~DBUF_POWER_REQUEST ); +POSTING_READ (DBUF_CTL ); +udelay (10 );if (I915_READ (DBUF_CTL ) &DBUF_POWER_STATE )
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 7 lines · Imre Deak
Quoted 6 lines · On ke, 2015-05-06 at 14:28 +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
Do a
POSTING_READ()between theDBUF_CTLregister write and theudelay()to make sure we really wait after the register write has happened.
Quoted 8 lines
Quoted 5 lines
Spotted while reviewing Damien's SKL cdclk patch which had the POSTING_READ()s.
Cc Imre Deak <[email protected]>Signed-off-by Ville Syrjälä <[email protected]>Yep, makes sense:
Reviewed-by Imre Deak <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6328 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276
ILK -1 302/302 301/302
SNB 316/316 316/316 IVB 342/342 342/342 BYT 286/286 286/286 BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*ILK igt@kms_pipe_crc_basic@bad-source PASS(3) DMESG_WARN(1)PASS(1)
(dmesg patch applied)drm:drm_edid_block_valid[drm]]*ERROR*EDID_checksum_is_invalid,remainder_is@EDID checksum is .* remainder is
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx