Skip to contentSkip to conversation

Detecting that a battery is inside a dock?

DISCUSSION Bastien Nocera 2 participants 5 messages Apr 29, 2015 – May 7, 2015 ACPI

lore
Share & tools
lore
#0 lore raw

Hey,

I have access to a convertible Toshiba machine where the 2nd battery is in detachable keyboard. This is the decompiled DSDT:
https://hadess.fedorapeople.org/toshiba.dsl

There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard.

BAT2 can be ejected (it has an _EJD method), but the dock code doesn't see it as having a battery:

$ pwd
/sys/devices/platform/dock.0
$ cat flags
16
$ cat type
dock_station

Any ideas what might be missing here?

I'd eventually like to be able to say that, if I can detect that the battery is inside the dock, to mark it as such in the UI[1] (even better would be to say it's "in the keyboard" but I'm not sure we can easily detect that).

[1]: https://bugzilla.gnome.org/show_bug.cgi?id=748592

#1 lore raw
Quoted 18 lines · Bastien Nocera

Hey,

I have access to a convertible Toshiba machine where the 2nd battery is in detachable keyboard. This is the decompiled DSDT:
https://hadess.fedorapeople.org/toshiba.dsl

There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard.

BAT2 can be ejected (it has an _EJD method), but the dock code doesn't
see it as having a battery:

$ pwd
/sys/devices/platform/dock.0
$ cat flags
16
$ cat type
dock_station
Quoted 7 lines

Any ideas what might be missing here?

I'd eventually like to be able to say that, if I can detect that the battery is inside the dock, to mark it as such in the UI[1] (even better would be to say it's "in the keyboard" but I'm not sure we can
easily detect that).

Anyone?

Quoted 1 line

[1]: https://bugzilla.gnome.org/show_bug.cgi?id=748592

#2 lore raw
Quoted 21 lines · Bastien Nocera
Quoted 20 lines · Bastien Nocera

Hey,

I have access to a convertible Toshiba machine where the 2nd battery is in detachable keyboard. This is the decompiled DSDT:
https://hadess.fedorapeople.org/toshiba.dsl

There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard.

BAT2 can be ejected (it has an _EJD method), but the dock code doesn't
see it as having a battery:

$ pwd
/sys/devices/platform/dock.0
$ cat flags
16
$ cat type
dock_station

Any ideas what might be missing here?

Quoted 7 lines
Quoted 5 lines

I'd eventually like to be able to say that, if I can detect that the battery is inside the dock, to mark it as such in the UI[1] (even better would be to say it's "in the keyboard" but I'm not sure we can
easily detect that).

Anyone?

Not now, sorry. Too many things are going on in parallel and this one is not the most urgent of them.

Please file a bug for it at bugzilla.kernel.org in the ACPI category, so it's not forgotten. Those bugs are looked at on a regular basis, so we'll get to it at one point.

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
#3 lore raw
Quoted 33 lines · Rafael J. Wysocki
Quoted 32 lines · Bastien Nocera
Quoted 30 lines · Bastien Nocera

Hey,

I have access to a convertible Toshiba machine where the 2nd battery
is in detachable keyboard. This is the decompiled DSDT:
https://hadess.fedorapeople.org/toshiba.dsl

There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard.

BAT2 can be ejected (it has an _EJD method), but the dock code doesn't
see it as having a battery:

$ pwd
/sys/devices/platform/dock.0
$ cat flags
16
$ cat type
dock_station

Any ideas what might be missing here?

I'd eventually like to be able to say that, if I can detect that the
battery is inside the dock, to mark it as such in the UI[1] (even
better would be to say it's "in the keyboard" but I'm not sure we
can
easily detect that).

Quoted 5 lines
Quoted 1 line

Anyone?

Not now, sorry. Too many things are going on in parallel and this one is
not the most urgent of them.

Sure. I didn't expect a bug fix straight away, I just wanted to know whether I was missing something.

Quoted 6 lines

Please file a bug for it at bugzilla.kernel.org in the ACPI category, so it's
not forgotten. Those bugs are looked at on a regular basis, so we'll get to
it at one point.

Filed as:
https://bugzilla.kernel.org/show_bug.cgi?id=97841

Cheers

#4 lore raw
Quoted 50 lines · Bastien Nocera
Quoted 33 lines · Rafael J. Wysocki
Quoted 32 lines · Bastien Nocera
Quoted 30 lines · Bastien Nocera

Hey,

I have access to a convertible Toshiba machine where the 2nd battery
is in detachable keyboard. This is the decompiled DSDT:
https://hadess.fedorapeople.org/toshiba.dsl

There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard.

BAT2 can be ejected (it has an _EJD method), but the dock code doesn't
see it as having a battery:

$ pwd
/sys/devices/platform/dock.0
$ cat flags
16
$ cat type
dock_station

Any ideas what might be missing here?

I'd eventually like to be able to say that, if I can detect that the
battery is inside the dock, to mark it as such in the UI[1] (even
better would be to say it's "in the keyboard" but I'm not sure we
can
easily detect that).

Quoted 5 lines
Quoted 1 line

Anyone?

Not now, sorry. Too many things are going on in parallel and this one is
not the most urgent of them.

Sure. I didn't expect a bug fix straight away, I just wanted to know whether I was missing something.

Quoted 6 lines

Please file a bug for it at bugzilla.kernel.org in the ACPI category, so it's
not forgotten. Those bugs are looked at on a regular basis, so we'll get to
it at one point.

Quoted 2 lines

Filed as:
https://bugzilla.kernel.org/show_bug.cgi?id=97841

Thanks!