perf: Add basic Skylake PMU support
Subsystems (2)
This patchkit adds support for the Intel Skylake core PMU to perf, documented in the recently released SDM 054[1] Vol3, 17.9 and 18.12.
The main user visible feature is timed branch records, which allows to get cycle counts for individual basic blocks, and a time stamp for PEBS records which improves multi-record PEBS. The LBRs (branch records) also have been extended to 32, which allows more accurate branch sampling and deeper call stacks.
-Andi
[1] http://www.cps.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html
PATCH 1/9 x86: Add a native_perf_sched_clock_from_tsc
From: Andi Kleen <[email protected]>
PEBSv3 has a raw TSC time stamp in its memory buffer that later needs to to be converted to perf_clock. Add a native_sched_clock_from_tsc() that works the same as native_sched_clock, but starts with an already given TSC value.
Right now I ignore paravirt for this. It will just get the native clock. But there isn't para virtualized PEBS anyways.
--- arch/x86/include/asm/tsc.h | 1 + arch/x86/kernel/tsc.c | 8 ++++++++ 2 files changed, 9 insertions(+)
arch/x86/include/asm/tsc.h +1 -0
@@ -51,6 +51,7 @@ extern int unsynchronized_tsc(void);extern int check_tsc_unstable (void );extern int check_tsc_disabled (void );extern unsigned long native_calibrate_tsc (void ); +extern unsigned long long native_sched_clock_from_tsc (u64 tsc);extern int tsc_clocksource_reliable;
arch/x86/kernel/tsc.c +8 -0
@@ -296,6 +296,14 @@ u64 native_sched_clock(void)return cycles_2_ns (tsc_now); } +/* +* Generate a sched_clock if you already have a TSC value. +*/ +u64 native_sched_clock_from_tsc (u64 tsc) +{ +return cycles_2_ns (tsc); +} +/* We need to define a real function for sched_clock, to override the weak default version */ #ifdef CONFIG_PARAVIRT
Signature · 1 line
1.9.3
PATCH 2/9 x86, perf: Add support for PEBSv3 profiling
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
PEBSv3 is the same as the existing PEBSv2 used on Haswell, but it adds a new TSC field. Add support to the generic PEBS handler to handle the new format, and overwrite the perf time stamp using the new native_sched_clock_from_tsc() Right now the time stamp is just slightly more accurate, as it is nearer the actual event trigger point. With the PEBS threshold > 1 patchkit it will be much more accurate, avoid the problems with MMAP mismatches earlier.
--- arch/x86/kernel/cpu/perf_event_intel_ds.c | 32 ++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_ds.c +29 -3
@@ -224,6 +224,19 @@ union hsw_tsx_tuning {#define PEBS_HSW_TSX_FLAGS 0xff00000000ULL +/* Same as HSW, plus TSC */ + +struct pebs_record_v3 { +u64 flags, ip; +u64 ax, bx, cx, dx; +u64 si, di, bp, sp; +u64 r8, r9, r10, r11; +u64 r12, r13, r14, r15; +u64 status, dla, dse, lat; +u64 real_ip, tsx_tuning; +u64 tsc; +}; +void init_debug_store_on_cpu (int cpu) {struct debug_store *ds =per_cpu (cpu_hw_events, cpu).ds;
@@ -827,7 +840,7 @@ static int intel_pmu_pebs_fixup_ip(struct pt_regs *regs)return 0 ; } -static inline u64 intel_hsw_weight (struct pebs_record_hsw *pebs) +static inline u64 intel_hsw_weight (struct pebs_record_v3 *pebs) {if (pebs->tsx_tuning) {union hsw_tsx_tuning tsx = { .value = pebs->tsx_tuning };
@@ -836,7 +849,7 @@ static inline u64 intel_hsw_weight(struct pebs_record_hsw *pebs)return 0 ; } -static inline u64 intel_hsw_transaction (struct pebs_record_hsw *pebs) +static inline u64 intel_hsw_transaction (struct pebs_record_v3 *pebs) {u64 txn = (pebs->tsx_tuning &PEBS_HSW_TSX_FLAGS ) >>32 ;
@@ -858,7 +871,7 @@ static void __intel_pmu_pebs_event(struct perf_event *event,* unconditionally access the 'extra' entries. */ struct cpu_hw_events *cpuc =this_cpu_ptr (&cpu_hw_events); -struct pebs_record_hsw *pebs = __pebs; +struct pebs_record_v3 *pebs = __pebs;struct perf_sample_data data;struct pt_regs regs;u64 sample_type;
@@ -958,6 +971,13 @@ static void __intel_pmu_pebs_event(struct perf_event *event, data.txn =intel_hsw_transaction (pebs); } +/* +* v3 supplies an accurate time stamp, so we use that +* for the time stamp. +*/ +if (x86_pmu.intel_cap.pebs_format >=3 ) + data.time =native_sched_clock_from_tsc (pebs->tsc); +if (has_branch_stack (event)) data.br_stack = &cpuc->lbr_stack;
@@ -1098,6 +1118,12 @@ void __init intel_ds_init(void) x86_pmu.drain_pebs = intel_pmu_drain_pebs_nhm;break ; +case 3 : +pr_cont ("PEBS fmt3%c, " , pebs_type); + x86_pmu.pebs_record_size =sizeof (struct pebs_record_v3 ); + x86_pmu.drain_pebs = intel_pmu_drain_pebs_nhm; +break ; +default :printk (KERN_CONT "no PEBS fmt%d%c, " , format, pebs_type); x86_pmu.pebs =0 ;
Signature · 1 line
1.9.3
Peter Zijlstra
maintainerRe: [PATCH 2/9] x86, perf: Add support for PEBSv3 profiling
arch/x86/kernel/cpu/perf_event_intel_ds.c union hsw_tsx_tuning { · line 229
Quoted 3 lines · Andi Kleen
arch/x86/kernel/cpu/perf_event_intel_ds.c +3
-0+/* Same as HSW, plus TSC */ + +struct pebs_record_v3 {
This is inconsistently named.
Quoted 10 lines
arch/x86/kernel/cpu/perf_event_intel_ds.c +9
-0+u64 flags, ip; +u64 ax, bx, cx, dx; +u64 si, di, bp, sp; +u64 r8, r9, r10, r11; +u64 r12, r13, r14, r15; +u64 status, dla, dse, lat; +u64 real_ip, tsx_tuning; +u64 tsc; +};
arch/x86/kernel/cpu/perf_event_intel_ds.c static void __intel_pmu_pebs_event(struct perf_event *event, · line 979
Quoted 9 lines
arch/x86/kernel/cpu/perf_event_intel_ds.c +6
-0@@ -958,6 +971,13 @@ static void __intel_pmu_pebs_event(struct perf_event *event, data.txn =intel_hsw_transaction (pebs); } +/* +* v3 supplies an accurate time stamp, so we use that +* for the time stamp. +*/ +if (x86_pmu.intel_cap.pebs_format >=3 ) + data.time =native_sched_clock_from_tsc (pebs->tsc);
That's wrong. It does not respect perf_event_attr::clock_id.
Re: [PATCH 2/9] x86, perf: Add support for PEBSv3 profiling
Quoted 1 line
That's wrong. It does not respect
perf_event_attr::clock_id.
Ok.
Are we really defaulting to real time now? (CLOCK_REALTIME == 0) What happens when ntpd is active and lets the time drift? That sounds very bad for event accuracy.
The clockid patch looks broken to me. At least it should default to MONOTONIC time, not just the time that happens to be 0 by accident.
Also I question we really need that many different kinds of time stamps.
-Andi
Signature · 1 line
[email protected] -- Speaking for myself only.
Peter Zijlstra
maintainerRe: [PATCH 2/9] x86, perf: Add support for PEBSv3 profiling
Quoted 5 lines · Andi Kleen
Quoted 1 line
That's wrong. It does not respect
perf_event_attr::clock_id.Ok.
Are we really defaulting to real time now?
No, we still default to the thing you implemented.
However, when the event is configured differently, you'll write the wrong stamps in. This code needs to consider that.
Quoted 3 lines
(
CLOCK_REALTIME== 0)
What happens when ntpd is active and lets the time drift? That sounds very bad for event accuracy.
NTP slew rate adjustment should still keep the thing monotonic, so its still useful to order events.
But as is, CLOCK_REALTIME is not supported for hardware events, only CLOCK_MONOTONIC and CLOCK_MONOTONIC_RAW are.
Quoted 3 lines
The clockid patch looks broken to me. At least it should default to MONOTONIC time, not just the time that happens to be 0 by accident.
You've not looked good enough, the Changelog states and the code matches that the default is unchanged.
Quoted 2 lines
Also I question we really need that many different kinds of time stamps.
CLOCK_MONOTONIC is useful for cluster wide timestamps, CLOCK_MONOTONIC_RAW is useful for things that need/want to correlate to fixed rate clocks.
Most of the other clocks are just a side effect of using the generic clockid API for selecting clocks.
PATCH 3/9 x86: Add new MSRs and MSR bits used for Skylake perfmon
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add new MSRs (LBR_INFO) and some new MSR bits used by the Skylake PMU driver.
--- arch/x86/include/asm/perf_event.h | 7 +++++++ arch/x86/include/uapi/asm/msr-index.h | 6 ++++++ 2 files changed, 13 insertions(+)
arch/x86/include/asm/perf_event.h +7 -0
@@ -159,6 +159,13 @@ struct x86_pmu_capability {*/ #define INTEL_PMC_IDX_FIXED_BTS (INTEL_PMC_IDX_FIXED + 16) +#define GLOBAL_STATUS_COND_CHG BIT_ULL(63) +#define GLOBAL_STATUS_BUFFER_OVF BIT_ULL(62) +#define GLOBAL_STATUS_UNC_OVF BIT_ULL(61) +#define GLOBAL_STATUS_ASIF BIT_ULL(60) +#define GLOBAL_STATUS_COUNTERS_FROZEN BIT_ULL(59) +#define GLOBAL_STATUS_LBRS_FROZEN BIT_ULL(58) +/* * IBS cpuid feature detection */
arch/x86/include/uapi/asm/msr-index.h +6 -0
@@ -72,6 +72,12 @@#define MSR_LBR_CORE_FROM 0x00000040#define MSR_LBR_CORE_TO 0x00000060 +#define MSR_LBR_INFO_0 0x00000dc0/* ... 0xddf for _31 */ +#define LBR_INFO_MISPRED (1UL << 63) +#define LBR_INFO_IN_TX (1UL << 62) +#define LBR_INFO_ABORT (1UL << 61) +#define LBR_INFO_CYCLES 0xffff +#define MSR_IA32_PEBS_ENABLE 0x000003f1#define MSR_IA32_DS_AREA 0x00000600#define MSR_IA32_PERF_CAPABILITIES 0x00000345
Signature · 1 line
1.9.3
PATCH 4/9 perf: Add cycles to branch_info
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Skylake supports reporting the time in cycles a branch in the LBR took, to give a rough indication of the basic block performance.
Export the cycle information in the branch_info structure. This can be done by just reusing some currently zero padding.
This is just the generic header change. The architecture still needs to fill it in.
There's no attempt to convert to real time, as we really want cycles here.
--- include/uapi/linux/perf_event.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
include/uapi/linux/perf_event.h +3 -1
@@ -904,6 +904,7 @@ union perf_mem_data_src {* * in_tx: running in a hardware transaction * abort: aborting a hardware transaction +* cycles: cycles from last branch (or 0 if not supported) */ struct perf_branch_entry {__u64 from;
@@ -912,7 +913,8 @@ struct perf_branch_entry { predicted:1,/* target predicted */ in_tx:1, /* in transaction */ abort:1, /* transaction abort */ - reserved:60; + cycles:16, /* cycle count to last branch */ + reserved:44; };#endif /* _UAPI_LINUX_PERF_EVENT_H */
Signature · 1 line
1.9.3
PATCH 5/9 x86, perf: Add support for LBRv5
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add support for the new LBRv5 format used on Skylake.
The flags for mispredict, abort, in_tx etc. moved to range of separate LBR_INFO_* MSRs. Teach the LBR code to read those. The original LBR registers stay the same, except they have full sign extension now.
LBR_INFO also reports a cycle count to the last branch. Report the cycle information using the new "cycles" branch_info output field.
In addition we have to context switch and clear the new INFO MSRs to avoid any information leaks.
--- arch/x86/kernel/cpu/perf_event.h | 1 + arch/x86/kernel/cpu/perf_event_intel_lbr.c | 21 ++++++++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/perf_event.h +1 -0
@@ -595,6 +595,7 @@ struct x86_pmu {struct x86_perf_task_context {u64 lbr_from[MAX_LBR_ENTRIES ];u64 lbr_to[MAX_LBR_ENTRIES ]; +u64 lbr_info[MAX_LBR_ENTRIES ];int lbr_callstack_users;int lbr_stack_state; };
arch/x86/kernel/cpu/perf_event_intel_lbr.c +20 -1
@@ -13,7 +13,8 @@ enum {LBR_FORMAT_EIP =0x02 ,LBR_FORMAT_EIP_FLAGS =0x03 ,LBR_FORMAT_EIP_FLAGS2 =0x04 , - LBR_FORMAT_MAX_KNOWN = LBR_FORMAT_EIP_FLAGS2, +LBR_FORMAT_INFO =0x05 , + LBR_FORMAT_MAX_KNOWN = LBR_FORMAT_INFO, }; static enum {
@@ -184,6 +185,8 @@ static void intel_pmu_lbr_reset_64(void)for (i =0 ; i < x86_pmu.lbr_nr; i++) {wrmsrl (x86_pmu.lbr_from + i,0 );wrmsrl (x86_pmu.lbr_to + i,0 ); +if (x86_pmu.intel_cap.lbr_format ==LBR_FORMAT_INFO ) +wrmsrl (MSR_LBR_INFO_0 + i,0 ); } }
@@ -232,6 +235,8 @@ static void __intel_pmu_lbr_restore(struct x86_perf_task_context *task_ctx) lbr_idx = (tos - i) & mask;wrmsrl (x86_pmu.lbr_from + lbr_idx, task_ctx->lbr_from[i]);wrmsrl (x86_pmu.lbr_to + lbr_idx, task_ctx->lbr_to[i]); +if (x86_pmu.intel_cap.lbr_format ==LBR_FORMAT_INFO ) +wrmsrl (MSR_LBR_INFO_0 + i, task_ctx->lbr_info[i]); } task_ctx->lbr_stack_state =LBR_NONE ; }
@@ -253,6 +258,8 @@ static void __intel_pmu_lbr_save(struct x86_perf_task_context *task_ctx) lbr_idx = (tos - i) & mask;rdmsrl (x86_pmu.lbr_from + lbr_idx, task_ctx->lbr_from[i]);rdmsrl (x86_pmu.lbr_to + lbr_idx, task_ctx->lbr_to[i]); +if (x86_pmu.intel_cap.lbr_format ==LBR_FORMAT_INFO ) +rdmsrl (MSR_LBR_INFO_0 + i, task_ctx->lbr_info[i]); } task_ctx->lbr_stack_state =LBR_VALID ; }
@@ -417,11 +424,22 @@ static void intel_pmu_lbr_read_64(struct cpu_hw_events *cpuc)unsigned long lbr_idx = (tos - i) & mask;u64 from, to, mis =0 , pred =0 , in_tx =0 , abort =0 ;int skip =0 ; +u16 cycles =0 ;int lbr_flags = lbr_desc[lbr_format];rdmsrl (x86_pmu.lbr_from + lbr_idx, from);rdmsrl (x86_pmu.lbr_to + lbr_idx, to); +if (lbr_format ==LBR_FORMAT_INFO ) { +u64 info; + +rdmsrl (MSR_LBR_INFO_0 + lbr_idx, info); + mis = !!(info &LBR_INFO_MISPRED ); + pred = !mis; + in_tx = !!(info &LBR_INFO_IN_TX ); + abort = !!(info &LBR_INFO_ABORT ); + cycles = (info &LBR_INFO_CYCLES ); + }if (lbr_flags &LBR_EIP_FLAGS ) { mis = !!(from &LBR_FROM_FLAG_MISPRED ); pred = !mis;
@@ -451,6 +469,7 @@ static void intel_pmu_lbr_read_64(struct cpu_hw_events *cpuc) cpuc->lbr_entries[out].predicted = pred; cpuc->lbr_entries[out].in_tx = in_tx; cpuc->lbr_entries[out].abort = abort; + cpuc->lbr_entries[out].cycles = cycles; cpuc->lbr_entries[out].reserved =0 ; out++; }
Signature · 1 line
1.9.3
PATCH 6/9 x86, perf: Add Skylake support
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add perf core PMU support for future Intel Skylake CPU cores.
The code is based on Haswell/Broadwell.
There is a new cache event list, based on the updated Haswell event list.
Skylake has removed most counter constraints on basic events, so the basic constraints table now only has a single entry (plus the fixed counters)
TSX support and various other setups are all shared with Haswell.
Skylake has 32 LBR entries. Add a new LBR init function to set this up. The filters are all the same as Haswell.
It also has a new LBR format with a separate LBR_INFO_* MSR, but that has been already added earlier.
--- arch/x86/kernel/cpu/perf_event.h | 6 +- arch/x86/kernel/cpu/perf_event_intel.c | 232 +++++++++++++++++++++++++++++ arch/x86/kernel/cpu/perf_event_intel_ds.c | 22 +++ arch/x86/kernel/cpu/perf_event_intel_lbr.c | 20 +++ 4 files changed, 279 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/perf_event.h +5 -1
@@ -138,7 +138,7 @@ struct intel_excl_cntrs {unsigned core_id;/* per-core: core id */ }; -#define MAX_LBR_ENTRIES 16 +#define MAX_LBR_ENTRIES 32enum {X86_PERF_KFREE_SHARED =0 ,
@@ -841,6 +841,8 @@ extern struct event_constraint intel_ivb_pebs_event_constraints[];extern struct event_constraint intel_hsw_pebs_event_constraints[]; +extern struct event_constraint intel_skl_pebs_event_constraints[]; +struct event_constraint *intel_pebs_constraints (struct perf_event *event);void intel_pmu_pebs_enable (struct perf_event *event);
@@ -877,6 +879,8 @@ void intel_pmu_lbr_init_snb(void);void intel_pmu_lbr_init_hsw (void ); +void intel_pmu_lbr_init_skl (void ); +int intel_pmu_setup_lbr_filter (struct perf_event *event);void intel_pt_interrupt (void );
arch/x86/kernel/cpu/perf_event_intel.c +232 -0
256 lines not on this page · raw message
arch/x86/kernel/cpu/perf_event_intel_ds.c +22 -0
@@ -678,6 +678,28 @@ struct event_constraint intel_hsw_pebs_event_constraints[] = {EVENT_CONSTRAINT_END }; +struct event_constraint intel_skl_pebs_event_constraints[] = { +INTEL_FLAGS_UEVENT_CONSTRAINT (0x1c0 ,0x2 ),/* INST_RETIRED.PREC_DIST */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_NA (0x01c2 ,0xf ),/* UOPS_RETIRED.ALL */ +/* UOPS_RETIRED.ALL, inv=1, cmask=16 (cycles:p). */ +INTEL_FLAGS_EVENT_CONSTRAINT (0x108001c2 ,0xf ), +INTEL_PLD_CONSTRAINT (0x1cd ,0xf ),/* MEM_TRANS_RETIRED.* */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD (0x11d0 ,0xf ),/* MEM_INST_RETIRED.STLB_MISS_LOADS */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST (0x12d0 ,0xf ),/* MEM_INST_RETIRED.STLB_MISS_STORES */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD (0x21d0 ,0xf ),/* MEM_INST_RETIRED.LOCK_LOADS */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST (0x22d0 ,0xf ),/* MEM_INST_RETIRED.LOCK_STORES */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD (0x41d0 ,0xf ),/* MEM_INST_RETIRED.SPLIT_LOADS */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST (0x42d0 ,0xf ),/* MEM_INST_RETIRED.SPLIT_STORES */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD (0x81d0 ,0xf ),/* MEM_INST_RETIRED.ALL_LOADS */ +INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST (0x82d0 ,0xf ),/* MEM_INST_RETIRED.ALL_STORES */ +INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_LD (0xd1 ,0xf ),/* MEM_LOAD_RETIRED.* */ +INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_LD (0xd2 ,0xf ),/* MEM_LOAD_L3_HIT_RETIRED.* */ +INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_LD (0xd3 ,0xf ),/* MEM_LOAD_L3_MISS_RETIRED.* */ +/* Allow all events as PEBS with no flags */ +INTEL_ALL_EVENT_CONSTRAINT (0 ,0xf ), +EVENT_CONSTRAINT_END +}; +struct event_constraint *intel_pebs_constraints (struct perf_event *event) {struct event_constraint *c;
arch/x86/kernel/cpu/perf_event_intel_lbr.c +20 -0
@@ -961,6 +961,26 @@ void intel_pmu_lbr_init_hsw(void)pr_cont ("16-deep LBR, " ); } +/* skylake */ +__init void intel_pmu_lbr_init_skl (void ) +{ + x86_pmu.lbr_nr =32 ; + x86_pmu.lbr_tos =MSR_LBR_TOS ; + x86_pmu.lbr_from =MSR_LBR_NHM_FROM ; + x86_pmu.lbr_to =MSR_LBR_NHM_TO ; + + x86_pmu.lbr_sel_mask =LBR_SEL_MASK ; + x86_pmu.lbr_sel_map = hsw_lbr_sel_map; + +/* +* SW branch filter usage: +* - support syscall, sysret capture. +* That requires LBR_FAR but that means far +* jmp need to be filtered out +*/ +pr_cont ("32-deep LBR, " ); +} +/* atom */ void __init intel_pmu_lbr_init_atom (void ) {
Signature · 1 line
1.9.3
PATCH 7/9 perf, x86: Handle new status bits
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
ArchPerfmon v4 has some new status bits in GLOBAL_STATUS. These need to be ignored when deciding whether a NMI was a NMI to avoid eating all NMIs when they stay set (see b292d7a104)
This patch ignores the new ASIF bit, which indicates that SGX interfered with the PMU, and also the new LBR freezing bits, which are set when the LBRs get frozen.
--- arch/x86/kernel/cpu/perf_event_intel.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
arch/x86/kernel/cpu/perf_event_intel.c +7 -6
@@ -1821,13 +1821,14 @@ again:intel_pmu_lbr_read ();/* -* CondChgd bit 63 doesn't mean any overflow status. Ignore -* and clear the bit. +* Ignore a range of extra bits in status that do not indicate +* overflow by themselves. */ -if (__test_and_clear_bit (63 , (unsigned long *)&status)) { -if (!status) - goto done; - } + status &= ~(GLOBAL_STATUS_COND_CHG | +GLOBAL_STATUS_ASIF | +GLOBAL_STATUS_LBRS_FROZEN ); +if (!status) + goto done;/* * PEBS overflow sets bit 62 in the global status register
Signature · 1 line
1.9.3
PATCH 8/9 perf, x86: Optimize v4 LBR unfreezing
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
In Arch perfmon v4 the GLOBAL_STATUS reset automatically unfreezes LBRs. So no need to do it manually in the LBR code. Add a check to skip it.
--- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 7 +++++++ 1 file changed, 7 insertions(+)
arch/x86/kernel/cpu/perf_event_intel_lbr.c +7 -0
@@ -147,6 +147,13 @@ static void __intel_pmu_lbr_enable(bool pmi)wrmsrl (MSR_LBR_SELECT , lbr_select); } +/* +* No need to unfreeze manually, as v4 can do that as part +* of the GLOBAL_STATUS ack. +*/ +if (pmi && x86_pmu.version >=4 ) +return ; +rdmsrl (MSR_IA32_DEBUGCTLMSR , debugctl); orig_debugctl = debugctl; debugctl |=DEBUGCTLMSR_LBR ;
Signature · 1 line
1.9.3
Peter Zijlstra
maintainerRe: [PATCH 8/9] perf, x86: Optimize v4 LBR unfreezing
Quoted 16 lines · Andi Kleen
From: Andi Kleen <[email protected]>
In Arch perfmon v4 the
GLOBAL_STATUSreset automatically unfreezes LBRs. So no need to do it manually in the LBR code. Add a check to skip it.Signed-off-by Andi Kleen <[email protected]>--- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 7 +++++++ 1 file changed, 7 insertions(+)arch/x86/kernel/cpu/perf_event_intel_lbr.c +0
-0
arch/x86/kernel/cpu/perf_event_intel_lbr.c static void __intel_pmu_lbr_enable(bool pmi) · line 156
Quoted 10 lines
arch/x86/kernel/cpu/perf_event_intel_lbr.c +7
-0@@ -147,6 +147,13 @@ static void __intel_pmu_lbr_enable(bool pmi)wrmsrl (MSR_LBR_SELECT , lbr_select); } +/* +* No need to unfreeze manually, as v4 can do that as part +* of the GLOBAL_STATUS ack. +*/ +if (pmi && x86_pmu.version >=4 ) +return ; +
But that block above is !pmi, so strictly exclusive with this condition. So why not put this at the start?
Quoted 3 lines
arch/x86/kernel/cpu/perf_event_intel_lbr.c +0
-0rdmsrl (MSR_IA32_DEBUGCTLMSR , debugctl); orig_debugctl = debugctl; debugctl |=DEBUGCTLMSR_LBR ;
PATCH 9/9 perf, tools: Add tools support for cycles, weight branch_info field
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
cycles is a new branch_info field available on some CPUs that indicates the time deltas between branches in the LBR.
Add a sort key and output code for the cycles
to allow to display the basic block cycles individually in perf report.
We also pass in the cycles for weight when LBRs are processed, which allows to get global and local weight to get averages.
And also print the cycles information for perf report -D. I also added printing for the previously missing LBR flags (mispredict etc.)
--- tools/perf/Documentation/perf-report.txt | 1 + tools/perf/util/event.h | 3 ++- tools/perf/util/hist.c | 3 ++- tools/perf/util/hist.h | 1 + tools/perf/util/session.c | 16 ++++++++++++---- tools/perf/util/sort.c | 24 ++++++++++++++++++++++++ tools/perf/util/sort.h | 1 + 7 files changed, 43 insertions(+), 6 deletions(-)
tools/perf/Documentation/perf-report.txt +1 -0
@@ -108,6 +108,7 @@ OPTIONS - mispredict: "N" for predicted branch, "Y" for mispredicted branch - in_tx: branch in TSX transaction - abort: TSX transaction abort. + - cycles: Cycles in basic block And default sort keys are changed to comm, dso_from, symbol_from, dso_to and symbol_to, see '--branch-stack'.
tools/perf/util/event.h +2 -1
@@ -129,7 +129,8 @@ struct branch_flags { u64 predicted:1; u64 in_tx:1; u64 abort:1; - u64 reserved:60; + u64 cycles:16; + u64 reserved:44; };struct branch_entry {
tools/perf/util/hist.c +2 -1
@@ -623,7 +623,8 @@ iter_add_next_branch_entry(struct hist_entry_iter *iter, struct addr_location *a* and not events sampled. Thus we use a pseudo period of 1. */ he =__hists__add_entry (hists, al, iter->parent, &bi[i],NULL , -1 ,1 ,0 , true); +1 , bi->flags.cycles ? bi->flags.cycles :1 , +0 , true);if (he ==NULL )return -ENOMEM ;
tools/perf/util/hist.h +1 -0
@@ -47,6 +47,7 @@ enum hist_column {HISTC_MEM_SNOOP ,HISTC_MEM_DCACHELINE ,HISTC_TRANSACTION , +HISTC_CYCLES , HISTC_NR_COLS, /* Last entry */ };
tools/perf/util/session.c +12 -4
@@ -738,10 +738,18 @@ static void branch_stack__printf(struct perf_sample *sample)printf ("... branch stack: nr:%" PRIu64"\n" , sample->branch_stack->nr); -for (i =0 ; i < sample->branch_stack->nr; i++) -printf ("..... %2" PRIu64": %016" PRIx64" -> %016" PRIx64"\n" , - i, sample->branch_stack->entries[i].from, - sample->branch_stack->entries[i].to); +for (i =0 ; i < sample->branch_stack->nr; i++) { +struct branch_entry *e = &sample->branch_stack->entries[i]; + +printf ("..... %2" PRIu64": %016" PRIx64" -> %016" PRIx64" %hu cycles %s%s%s%s %x\n" , + i, e->from, e->to, + e->flags.cycles, + e->flags.mispred ?"M" :" " , + e->flags.predicted ?"P" :" " , + e->flags.abort ?"A" :" " , + e->flags.in_tx ?"T" :" " , + (unsigned )e->flags.reserved); + } }static void regs_dump__printf (u64 mask,u64 *regs)
tools/perf/util/sort.c +24 -0
@@ -528,6 +528,29 @@ static int hist_entry__mispredict_snprintf(struct hist_entry *he, char *bf,return repsep_snprintf (bf, size,"%-*.*s" , width, width, out); } +static int64_t +sort__cycles_cmp (struct hist_entry *left,struct hist_entry *right) +{ +return left->branch_info->flags.cycles - + right->branch_info->flags.cycles; +} + +static int hist_entry__cycles_snprintf (struct hist_entry *he,char *bf, +size_t size,unsigned int width) +{ +if (he->branch_info->flags.cycles ==0 ) +return repsep_snprintf (bf, size,"%-*s" , width,"-" ); +return repsep_snprintf (bf, size,"%-*hd" , width, + he->branch_info->flags.cycles); +} + +struct sort_entry sort_cycles = { + .se_header ="Basic Block Cycles" , + .se_cmp = sort__cycles_cmp, + .se_snprintf = hist_entry__cycles_snprintf, + .se_width_idx =HISTC_CYCLES , +}; +/* --sort daddr_sym */ static int64_t sort__daddr_cmp (struct hist_entry *left,struct hist_entry *right)
@@ -1192,6 +1215,7 @@ static struct sort_dimension bstack_sort_dimensions[] = {DIM (SORT_MISPREDICT ,"mispredict" , sort_mispredict),DIM (SORT_IN_TX ,"in_tx" , sort_in_tx),DIM (SORT_ABORT ,"abort" , sort_abort), + DIM(SORT_CYCLES, "cycles", sort_cycles), };#undef DIM
tools/perf/util/sort.h +1 -0
@@ -185,6 +185,7 @@ enum sort_type {SORT_MISPREDICT ,SORT_ABORT ,SORT_IN_TX , +SORT_CYCLES ,/* memory mode specific sort keys */ __SORT_MEMORY_MODE,
Signature · 1 line
1.9.3