clk: bindings: Fix assigned-clock-rates property name
Subsystems (2)
PATCH 1/1 clk: bindings: Fix assigned-clock-rates property name
In documentation the "assigned-clock-parents" name was used when describing the "assigned-clock-rates" property.
--- Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/clock-bindings.txt +1 -1
@@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks and clock frequencies. Such a configuration can be specified in a device tree node through assigned-clocks, assigned-clock-parents and assigned-clock-rates properties. The assigned-clock-parents property should contain a list of parent -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates property the list of assigned clock frequency values - corresponding to clocks listed in the assigned-clocks property.
Signature · 1 line
1.9.1
Quoted 5 lines · Krzysztof Kozlowski
In documentation the "assigned-clock-parents" name was used when describing the "assigned-clock-rates" property.
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Looks right. The whole sentence could use some work though.
Quoted 8 lines
Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/clock/clock-bindings.txt +0
-0
Documentation/devicetree/bindings/clock/clock-bindings.txt Some platforms may require initial configuration of default parent clocks · line 142
Quoted 6 lines
Documentation/devicetree/bindings/clock/clock-bindings.txt +1
-1@@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks and clock frequencies. Such a configuration can be specified in a device tree node through assigned-clocks, assigned-clock-parents and assigned-clock-rates properties. The assigned-clock-parents property should contain a list of parent -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates property the list of assigned clock frequency values - corresponding to clocks
This half-sentence:
The assigned-clock-ratse property the list of assigned clock frequency values
doesn't read correctly. Maybe the whole thing should be rewritten as:
The assigned-clock-parents property should contain a list of parent clocks in the form of a phandle and clock specifier pair and the assigned-clock-rates property should contain a list of frequencies in Hz. Both these properties should correspond to the clocks listed in the assigned-clocks property.
Quoted 2 lines
Documentation/devicetree/bindings/clock/clock-bindings.txt +0
-0listed in the assigned-clocks property.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 32 lines · Stephen Boyd
Quoted 5 lines · Krzysztof Kozlowski
In documentation the "assigned-clock-parents" name was used when describing the "assigned-clock-rates" property.
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Looks right. The whole sentence could use some work though.
Quoted 8 lines
Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/clock/clock-bindings.txt +0
-0Documentation/devicetree/bindings/clock/clock-bindings.txt Some platforms may require initial configuration of default parent clocks · line 142
Quoted 6 lines
Documentation/devicetree/bindings/clock/clock-bindings.txt +1
-1@@ -138,7 +138,7 @@ Some platforms may require initial configuration of default parent clocks and clock frequencies. Such a configuration can be specified in a device tree node through assigned-clocks, assigned-clock-parents and assigned-clock-rates properties. The assigned-clock-parents property should contain a list of parent -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents +clocks in form of phandle and clock specifier pairs, the assigned-clock-rates property the list of assigned clock frequency values - corresponding to clocksThis half-sentence:
The assigned-clock-ratse property the list of assigned clock frequency values
doesn't read correctly. Maybe the whole thing should be rewritten as:
Quoted 6 lines
The assigned-clock-parents property should contain a list of parent clocks in the form of a phandle and clock specifier pair and the assigned-clock-rates property should contain a list of frequencies in Hz. Both these properties should correspond to the clocks listed in the assigned-clocks property.
Looks much better. So actually this should be yours patch now, you can add my Reported-by :).
Best regards,
Krzysztof
PATCH 1/1 clk: bindings: Fix assigned-clock-rates description
The binding uses assigned-clock-parents when it should use assigned-clock-rates. Furthermore, the part that describes how they relate to the assigned-clocks property is not clear about what is related. Correct and clarify this part of the binding.
---
Quoted 2 lines · Krzysztof Kozlowski
Looks much better. So actually this should be yours patch now, you can add my Reported-by :).
Ok. I'll queue up this patch unless there are any other objections.
Documentation/devicetree/bindings/clock/clock-bindings.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/clock/clock-bindings.txt +4 -3
@@ -138,9 +138,10 @@ Some platforms may require initial configuration of default parent clocks and clock frequencies. Such a configuration can be specified in a device tree node through assigned-clocks, assigned-clock-parents and assigned-clock-rates properties. The assigned-clock-parents property should contain a list of parent -clocks in form of phandle and clock specifier pairs, the assigned-clock-parents -property the list of assigned clock frequency values - corresponding to clocks -listed in the assigned-clocks property. +clocks in the form of a phandle and clock specifier pair and the +assigned-clock-rates property should contain a list of frequencies in Hz. Both +these properties should correspond to the clocks listed in the assigned-clocks +property. To skip setting parent or rate of a clock its corresponding entry should be set to 0, or can be omitted if it is not followed by any non-zero entry.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Stephen Boyd
AppliedRe: [PATCH] clk: bindings: Fix assigned-clock-rates description
Quoted 7 lines · Stephen Boyd
The binding uses assigned-clock-parents when it should use assigned-clock-rates. Furthermore, the part that describes how they relate to the assigned-clocks property is not clear about what is related. Correct and clarify this part of the binding.
Reported-by Krzysztof Kozlowski <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 8 lines
---
Quoted 2 lines · Krzysztof Kozlowski
Looks much better. So actually this should be yours patch now, you can add my Reported-by :).
Ok. I'll queue up this patch unless there are any other objections.
Applied to clk-next.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project