scripts/coccinelle/misc/semicolon.cocci: Use imperative mood
PATCH 1/2 scripts/coccinelle/misc/semicolon.cocci: Use imperative mood
From: Fabio Estevam <[email protected]>
According to Documentation/SubmittingPatches:
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
So do as recommended.
--- scripts/coccinelle/misc/semicolon.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/semicolon.cocci +1 -1
@@ -1,5 +1,5 @@ /// -/// Removes unneeded semicolon. +/// Remove unneeded semicolon. /// // Confidence: Moderate // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.
Signature · 1 line
1.9.1
PATCH 2/2 scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar
From: Fabio Estevam <[email protected]>
Correct form is 'always requested'.
--- scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/irqf_oneshot.cocci +1 -1
@@ -1,4 +1,4 @@ -/// Make sure threaded IRQs without a primary handler are always request with +/// Make sure threaded IRQs without a primary handler are always requested with /// IRQF_ONESHOT /// //
Signature · 1 line
1.9.1
PATCH 2/2 scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Correct form is 'always requested'.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 18 lines
--- scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/coccinelle/misc/irqf_oneshot.cocci +1
-1@@ -1,4 +1,4 @@ -/// Make sure threaded IRQs without a primary handler are always request with +/// Make sure threaded IRQs without a primary handler are always requested with /// IRQF_ONESHOT /// //Signature · 1 line
1.9.1
PATCH 1/2 scripts/coccinelle/misc/semicolon.cocci: Use imperative mood
In reply to Fabio EstevamQuoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/SubmittingPatches:
Quoted 8 lines
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
So do as recommended.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 19 lines
--- scripts/coccinelle/misc/semicolon.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/coccinelle/misc/semicolon.cocci +1
-1@@ -1,5 +1,5 @@ /// -/// Removes unneeded semicolon. +/// Remove unneeded semicolon. /// // Confidence: Moderate // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.Signature · 1 line
1.9.1
PATCH 1/2 scripts/coccinelle/misc/semicolon.cocci: Use imperative mood
Dne 10.5.2015 v 00:44 Julia Lawall napsal(a):
Quoted 13 lines · Fabio Estevam
Quoted 10 lines
From: Fabio Estevam <[email protected]>
According to
Documentation/SubmittingPatches:"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
Quoted 5 lines
Quoted 3 lines
So do as recommended.
Signed-off-by Fabio Estevam <[email protected]>Acked-by Julia Lawall <[email protected]>
Fabio, could you please resend me these two patches? It seems I wasn't on CC (or I accidentally dropped them :)).
Michal