Skip to contentSkip to conversation

coccinelle: pm_runtime: Insert blank line

PATCH New Fabio Estevam 3 participants 6 messages May 9, 2015 – May 20, 2015 Coccinelle/Semantic Patches (SmPL)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/4 coccinelle: pm_runtime: Insert blank line

From: Fabio Estevam <[email protected]>

Insert a blank line in order to improve the readability of the generated patch and also make it consistent with the other .cocci files.

---
Changes since v1:
- Replace // with /// as suggested by Julia

 scripts/coccinelle/api/pm_runtime.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/api/pm_runtime.cocci +1 -1
index f01789e..b7042d0 100644
@@ -1,5 +1,5 @@
 /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE
-//
+///
 // Keywords: pm_runtime
 // Confidence: Medium
 // Copyright (C) 2013 Texas Instruments Incorporated - GPLv2.
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 2/4 coccinelle: returnvar: Use imperative mood

From: Fabio Estevam <[email protected]>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."

So do as recommended.

---
Changes since v1:
- None

 scripts/coccinelle/misc/returnvar.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/returnvar.cocci +1 -1
index 605955a..d8286ef 100644
@@ -1,5 +1,5 @@
 ///
-/// Removes unneeded variable used to store return value.
+/// Remove unneeded variable used to store return value.
 ///
 // Confidence: Moderate
 // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
Signature · 1 line
1.9.1
#2 lore raw

PATCH v2 3/4 coccinelle: ifaddr: Fix the sentence

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Make the sentence sensible.

---
Changes since v1:
- None

 scripts/coccinelle/misc/ifaddr.cocci | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
scripts/coccinelle/misc/ifaddr.cocci +1 -2
index 8aebd18..c2663c6 100644
@@ -1,5 +1,4 @@
-/// the address of a variable or field is non-zero is likely always to bo
-/// non-zero
+/// The address of a variable or field is likely always to be non-zero.
 ///
 // Confidence: High
 // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6.  GPLv2.
Signature · 1 line
1.9.1
#3 lore raw

PATCH v2 4/4 coccinelle: simple_open: Use imperative mood

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour."

So do as recommended.

---
Changes since v1:
- None

 scripts/coccinelle/api/simple_open.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/coccinelle/api/simple_open.cocci +2 -2
index b67e174..bd1a2a4 100644
@@ -1,5 +1,5 @@
-/// This removes an open coded simple_open() function
-/// and replaces file operations references to the function
+/// Remove an open coded simple_open() function
+/// and replace file operations references to the function
 /// with simple_open() instead.
 ///
 // Confidence: High
Signature · 1 line
1.9.1
#4 lore raw

PATCH v2 1/4 coccinelle: pm_runtime: Insert blank line

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Insert a blank line in order to improve the readability of the generated patch and also make it consistent with the other .cocci files.

Quoted 22 lines

---
Changes since v1:
- Replace // with /// as suggested by Julia

 scripts/coccinelle/api/pm_runtime.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/api/pm_runtime.cocci +1 -1
index f01789e..b7042d0 100644
@@ -1,5 +1,5 @@
 /// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE
-//
+///
 // Keywords: pm_runtime
 // Confidence: Medium
 // Copyright (C) 2013 Texas Instruments Incorporated - GPLv2.
Signature · 1 line
1.9.1
#5 lore raw

PATCH v2 1/4 coccinelle: pm_runtime: Insert blank line

Dne 10.5.2015 v 04:15 Julia Lawall napsal(a):

Quoted 11 lines · Fabio Estevam
Quoted 8 lines

From: Fabio Estevam <[email protected]>

Insert a blank line in order to improve the readability of the generated patch and also make it consistent with the other .cocci files.

Applied all four to kbuild.git#misc.

Michal