Patch "compal-laptop: Fix leaking hwmon device" has been added to the 3.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
compal-laptop: Fix leaking hwmon device
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
compal-laptop-fix-leaking-hwmon-device.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ad774702f1705c04e5fa492b793d8d477a504fa6Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Thu, 12 Mar 2015 08:43:59 +0100
Subject: compal-laptop: Fix leaking hwmon device
From: Krzysztof Kozlowski <[email protected]>
commit ad774702f1705c04e5fa492b793d8d477a504fa6 upstream.
The commit c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups") wanted to change the registering of hwmon device to resource-managed version. It mostly did it except the main thing - it forgot to use devm-like function so the hwmon device leaked after device removal or probe failure.
--- drivers/platform/x86/compal-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/x86/compal-laptop.c +3 -3
@@ -1027,9 +1027,9 @@ static int compal_probe(struct platform_if (err)return err; - hwmon_dev =hwmon_device_register_with_groups (&pdev->dev, -DRIVER_NAME , data, - compal_hwmon_groups); + hwmon_dev =devm_hwmon_device_register_with_groups (&pdev->dev, +DRIVER_NAME , data, + compal_hwmon_groups);if (IS_ERR (hwmon_dev)) { err =PTR_ERR (hwmon_dev); goto remove;
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/compal-laptop-fix-leaking-hwmon-device.patch