mips:Fix build error for ip32_defconfig configuration
PATCH RESEND 1/1 mips:Fix build error for ip32_defconfig configuration
This fixes the make error when building the ip32_defconfig configuration due to using sgio2_cmos_devinit rather then the correct function,sgio2_rtc_devinit in a device_initcall below this function's definition.
--- arch/mips/sgi-ip32/ip32-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/sgi-ip32/ip32-platform.c +2 -2
@@ -130,9 +130,9 @@ struct platform_device ip32_rtc_device = { .resource = ip32_rtc_resources, }; -+static int __init sgio2_rtc_devinit(void) +static __init int sgio2_rtc_devinit (void ) {return platform_device_register (&ip32_rtc_device); } -device_initcall (sgio2_cmos_devinit); +device_initcall (sgio2_rtc_devinit);
Signature · 1 line
2.1.4
Quoted 4 lines · Nicholas Krause
This fixes the make error when building the
ip32_defconfigconfiguration due to usingsgio2_cmos_devinitrather then the correct function,sgio2_rtc_devinit in adevice_initcallbelow this function's definition.
I've already applied Joshua Kinard's
https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic touchup.
Ralf
Quoted 7 lines · Ralf Baechle
Quoted 4 lines · Nicholas Krause
This fixes the make error when building the
ip32_defconfigconfiguration due to usingsgio2_cmos_devinitrather then the correct function,sgio2_rtc_devinit in adevice_initcallbelow this function's definition.
Quoted 6 lines
I've already applied Joshua Kinard's
https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic touchup.Ralf
Ralf,
As you may already known my rep with the other kernel developers is pretty bad. Based off this work can you try(time permitting) to put it a good word that I am improving.
Thanks Nick
Quoted 12 lines · nick
Quoted 11 lines · Ralf Baechle
Quoted 4 lines · Nicholas Krause
This fixes the make error when building the
ip32_defconfigconfiguration due to usingsgio2_cmos_devinitrather then the correct function,sgio2_rtc_devinit in adevice_initcallbelow this function's definition.I've already applied Joshua Kinard's
https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic touchup.
Quoted 6 lines
Quoted 2 lines
Ralf
Ralf,
As you may already known my rep with the other kernel developers is pretty bad. Based off this work can you try(time permitting) to put it a good word that I am improving.
The kernel world is a meritocracy. Which means your status will depend on the value of your contributions. So I think there's not much I could or should do but to let your merrits aka patches speak for themselves.
Ralf
Quoted 21 lines · Ralf Baechle
Quoted 8 lines · nick
Quoted 7 lines · Ralf Baechle
Quoted 4 lines · Nicholas Krause
This fixes the make error when building the
ip32_defconfigconfiguration due to usingsgio2_cmos_devinitrather then the correct function,sgio2_rtc_devinit in adevice_initcallbelow this function's definition.Quoted 8 lines
Quoted 6 lines
I've already applied Joshua Kinard's
https://patchwork.linux-mips.org/patch/9787/ with a minor cosmetic touchup.Ralf
Ralf,
As you may already known my rep with the other kernel developers ispretty bad.
Quoted 1 line
Based off this work can you try(time permitting) to put it a good
word that I am
Quoted 8 lines
Quoted 1 line
improving.
The kernel world is a meritocracy. Which means your status will depend on the value of your contributions. So I think there's not much I could
or should do but to let your merrits aka patches speak for themselves.Ralf
Very well then thanks anyway.
Nick
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.