usb: dwc3: Fix incorrect DEPCMD and DGCMD status macros
Subsystems (2)
PATCH 1/2 usb: dwc3: Fix incorrect DEPCMD and DGCMD status macros
Modified DEPCMD and DGCMD status checking macros as per databook.
Signed-off-by Subbaraya Sundeep Bhatta <[email protected]>
--- drivers/usb/dwc3/core.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/core.h +2 -2
@@ -339,7 +339,7 @@#define DWC3_DGCMD_SET_ENDPOINT_NRDY 0x0c#define DWC3_DGCMD_RUN_SOC_BUS_LOOPBACK 0x10 -#define DWC3_DGCMD_STATUS (n) (((n) >> 15) & 1) +#define DWC3_DGCMD_STATUS (n) (((n) >> 12) & 1)#define DWC3_DGCMD_CMDACT (1 << 10)#define DWC3_DGCMD_CMDIOC (1 << 8)
@@ -355,7 +355,7 @@#define DWC3_DEPCMD_PARAM_SHIFT 16#define DWC3_DEPCMD_PARAM (x) ((x) << DWC3_DEPCMD_PARAM_SHIFT)#define DWC3_DEPCMD_GET_RSC_IDX (x) (((x) >> DWC3_DEPCMD_PARAM_SHIFT) & 0x7f) -#define DWC3_DEPCMD_STATUS (x) (((x) >> 15) & 1) +#define DWC3_DEPCMD_STATUS (x) (((x) >> 12) & 0x0F)#define DWC3_DEPCMD_HIPRI_FORCERM (1 << 11)#define DWC3_DEPCMD_CMDACT (1 << 10)#define DWC3_DEPCMD_CMDIOC (1 << 8)
Signature · 1 line
1.7.4
Quoted 3 lines · Subbaraya Sundeep Bhatta
Modified DEPCMD and DGCMD status checking macros as per databook.
Signed-off-by Subbaraya Sundeep Bhatta <[email protected]>
please resend with proper Fixes and Cc stable. Should be something like:
Fixes b09bb64239c8 (usb: dwc3: gadget: implement Global Command support)
Cc <[email protected]> # v3.5+
Signature · 1 line
balbi
PATCH 2/2 usb: dwc3: gadget: return error when DEPCMD or DGCMD fails
In reply to Subbaraya Sundeep BhattaWhen sending DEPCMD or DGCMD command fails return error to caller.
Signed-off-by Subbaraya Sundeep Bhatta <[email protected]>
--- drivers/usb/dwc3/gadget.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/usb/dwc3/gadget.c +4 -0
@@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param)dwc3_trace (trace_dwc3_gadget,"Command Complete --> %d" ,DWC3_DGCMD_STATUS (reg)); +if (DWC3_DGCMD_STATUS (reg)) +return -EINVAL ;return 0 ; }
@@ -328,6 +330,8 @@ int dwc3_send_gadget_ep_cmd(struct dwc3 *dwc, unsigned ep,dwc3_trace (trace_dwc3_gadget,"Command Complete --> %d" ,DWC3_DEPCMD_STATUS (reg)); +if (DWC3_DEPCMD_STATUS (reg)) +return -EINVAL ;return 0 ; }
Signature · 1 line
1.7.4