mfd: arizona: Add missing parenthesis

PATCH Superseded Charles Keepax 1 participant 1 message May 15, 2015

Subsystems (2)

Multifunction devices (MFD) Wolfson microelectronics drivers

lore

Share & tools

lore

Charles Keepax

author

2015-05-15 15:15 UTC #0 lore raw

PATCH 1/1 mfd: arizona: Add missing parenthesis

Some parenthesis were missing from commit 67f0b1133d55 ("mfd: arizona:
Add better support for system suspend"). This will cause the error check to run even if the register write didn't happen (although ret will always be zero so it is harmless). This patch adds the missing parenthesis.

Reported-by Dan Carpenter <[email protected]>

Signed-off-by Charles Keepax <[email protected]>

---
 drivers/mfd/arizona-core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

drivers/mfd/arizona-core.c +2 -1

index 5caf579..bebf58a 100644
@@ -626,7 +626,7 @@ static int arizona_runtime_suspend(struct device *dev)
 		}
 		break;
 	case WM5102:
-		if (!(val & ARIZONA_JD1_ENA))
+		if (!(val & ARIZONA_JD1_ENA)) {
 			ret = regmap_write(arizona->regmap,
 					   ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0);
 			if (ret) {

@@ -635,6 +635,7 @@ static int arizona_runtime_suspend(struct device *dev)
 					ret);
 				return ret;
 			}
+		}
 		break;
 	default:
 		break;

Signature · 1 line

1.7.2.5