Skip to contentSkip to conversation

fix DEBUG_LL on Cortex-A7.

PATCH In review Tarek Dakhran 2 participants 4 messages May 17, 2015 – May 18, 2015

Subsystems (2)
Arm (32-bit) Arm Samsung Exynos
lore
Share & tools
lore

Tarek Dakhran

author
#0 lore raw

cover fix DEBUG_LL on Cortex-A7.

When system boots from Cortex-A7 addruart loads wrong base UART address. This patch fixex problem.

Patch tested on Hardkernel Odroid-XU3 board
on linux kernel v4.0.

Tarek Dakhran (1):
ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.

 arch/arm/include/debug/exynos.S | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.

Cortex-A7 has EXYNOS5_PA_UART base address for UART. If system boots from Cortex-A7 CPU addruart loads wrong address. This patch fixex this.

Signed-off-by Tarek Dakhran <[email protected]>
---
 arch/arm/include/debug/exynos.S | 1 +
 1 file changed, 1 insertion(+)
arch/arm/include/debug/exynos.S +1 -0
index b17fdb7..a61b3ea 100644
@@ -24,6 +24,7 @@
 		mrc	p15, 0, \tmp, c0, c0, 0
 		and	\tmp, \tmp, #0xf0
 		teq	\tmp, #0xf0		@@ A15
+		teqne	\tmp, #0x70		@@ A7
 		ldreq	\rp, =EXYNOS5_PA_UART
 		movne	\rp, #EXYNOS4_PA_UART	@@ EXYNOS4
 		ldr	\rv, =S3C_VA_UART
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.

Hi Tarek,

Quoted 22 lines · Tarek Dakhran

Cortex-A7 has EXYNOS5_PA_UART base address for UART. If system boots from Cortex-A7 CPU addruart loads wrong address. This patch fixex this.

Signed-off-by Tarek Dakhran <[email protected]>
---
 arch/arm/include/debug/exynos.S | 1 +
 1 file changed, 1 insertion(+)
arch/arm/include/debug/exynos.S +1 -1
index b17fdb7..a61b3ea 100644
@@ -24,6 +24,7 @@
                mrc     p15, 0, \tmp, c0, c0, 0
                and     \tmp, \tmp, #0xf0
                teq     \tmp, #0xf0             @@ A15
+               teqne   \tmp, #0x70             @@ A7
                ldreq   \rp, =EXYNOS5_PA_UART
                movne   \rp, #EXYNOS4_PA_UART   @@ EXYNOS4
                ldr     \rv, =S3C_VA_UART
--
Quoted 2 lines

1.9.1

Please see previous Joonyoung's patch. Your patch could break exynos3250 because it has not only two cortex-a7 cpus but also uses EXYOS4_PA_UART.

http://www.spinics.net/lists/linux-samsung-soc/msg37318.html

Signature · 2 lines
Best Regards,
Chanho Park
author
#3 lore raw

Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.

Hi Chanho,

Quoted 7 lines · Chanho Park

Please see previous Joonyoung's patch. Your patch could break exynos3250 because it has not only two cortex-a7 cpus but also uses EXYOS4_PA_UART.

http://www.spinics.net/lists/linux-samsung-soc/msg37318.html

Thanks, Joonyoung's patch works for me and it seems really reasonable to check cluster id.

Best regards,
Tarek