Skip to contentSkip to conversation

ia64: Return -ENOMEM in ia64_mmap_check() error case

PATCH In review Joerg Roedel 2 participants 2 messages May 18, 2015 – Jun 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: Return -ENOMEM in ia64_mmap_check() error case

From: Joerg Roedel <[email protected]>

The value -ENOMEM is the expected return code for mmap when the address range verification failes on a MAP_FIXED request, as stated in the specification:

[ENOMEM]
MAP_FIXED was specified, and the range [addr,addr+len) exceeds that allowed for the address space of a process;

The ia64_mmap_check() function is part of that verification and should return -ENOMEM too.

---
 arch/ia64/kernel/sys_ia64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/sys_ia64.c +1 -1
index 41e33f8..e927023 100644
@@ -124,7 +124,7 @@ int ia64_mmap_check(unsigned long addr, unsigned long len,
 	 */
 	roff = REGION_OFFSET(addr);
 	if ((len > RGN_MAP_LIMIT) || (roff > (RGN_MAP_LIMIT - len)))
-		return -EINVAL;
+		return -ENOMEM;
 	return 0;
 }
 
Signature · 1 line
1.8.4.5
#1 lore raw

Ping. Tony, Fenghua, any opinion on this?

Quoted 34 lines · Joerg Roedel

From: Joerg Roedel <[email protected]>

The value -ENOMEM is the expected return code for mmap when the address range verification failes on a MAP_FIXED request, as stated in the specification:

[ENOMEM]
MAP_FIXED was specified, and the range [addr,addr+len) exceeds that allowed for the address space of a process;

The ia64_mmap_check() function is part of that verification and should return -ENOMEM too.

---
 arch/ia64/kernel/sys_ia64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/sys_ia64.c +1 -1
index 41e33f8..e927023 100644
@@ -124,7 +124,7 @@ int ia64_mmap_check(unsigned long addr, unsigned long len,
 	 */
 	roff = REGION_OFFSET(addr);
 	if ((len > RGN_MAP_LIMIT) || (roff > (RGN_MAP_LIMIT - len)))
-		return -EINVAL;
+		return -ENOMEM;
 	return 0;
 }
 
Signature · 1 line
1.8.4.5