drm: some qemu driver unload fixes.
Subsystems (4)
Gerd Hoffmann
maintainercover drm: some qemu driver unload fixes.
Gerd Hoffmann (3):
drm/virtio: add missing drm_atomic_helper_shutdown() call. drm/bochs: add missing drm_atomic_helper_shutdown() call. drm/cirrus: add missing drm_helper_force_disable_all() call.
drivers/gpu/drm/bochs/bochs_kms.c | 1 + drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 3 files changed, 3 insertions(+)
Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann
maintainerPATCH 1/3 drm/virtio: add missing drm_atomic_helper_shutdown() call.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -0
@@ -385,5 +385,6 @@ void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)for (i =0 ; i < vgdev->num_scanouts; ++i)kfree (vgdev->outputs[i].edid); +drm_atomic_helper_shutdown (vgdev->ddev);drm_mode_config_cleanup (vgdev->ddev); }
Signature · 1 line
2.18.1
Re: [PATCH 1/3] drm/virtio: add missing drm_atomic_helper_shutdown() call.
Please atleast mention here why it is required?
-Mukesh
Quoted 16 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/virtio/virtgpu_display.c +1
-0@@ -385,5 +385,6 @@ void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)for (i =0 ; i < vgdev->num_scanouts; ++i)kfree (vgdev->outputs[i].edid); +drm_atomic_helper_shutdown (vgdev->ddev);drm_mode_config_cleanup (vgdev->ddev); }
Re: [PATCH 1/3] drm/virtio: add missing drm_atomic_helper_shutdown() call.
In reply to Gerd HoffmannPlease atleast mention here why it is required?
-Mukesh
Quoted 16 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/virtio/virtgpu_display.c +1
-0@@ -385,5 +385,6 @@ void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)for (i =0 ; i < vgdev->num_scanouts; ++i)kfree (vgdev->outputs[i].edid); +drm_atomic_helper_shutdown (vgdev->ddev);drm_mode_config_cleanup (vgdev->ddev); }
Gerd Hoffmann
maintainerPATCH 1/3 drm/virtio: add missing drm_atomic_helper_shutdown() call.
In reply to Gerd Hoffmann--- drivers/gpu/drm/virtio/virtgpu_display.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -0
@@ -385,5 +385,6 @@ void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)for (i =0 ; i < vgdev->num_scanouts; ++i)kfree (vgdev->outputs[i].edid); +drm_atomic_helper_shutdown (vgdev->ddev);drm_mode_config_cleanup (vgdev->ddev); }
Signature · 1 line
2.18.1
Gerd Hoffmann
maintainerPATCH 2/3 drm/bochs: add missing drm_atomic_helper_shutdown() call.
In reply to Gerd Hoffmann--- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bochs/bochs_kms.c +1 -0
@@ -293,6 +293,7 @@ int bochs_kms_init(struct bochs_device *bochs)void bochs_kms_fini (struct bochs_device *bochs) {if (bochs->mode_config_initialized) { +drm_atomic_helper_shutdown (bochs->dev);drm_mode_config_cleanup (bochs->dev); bochs->mode_config_initialized = false; }
Signature · 1 line
2.18.1
Re: [PATCH 2/3] drm/bochs: add missing drm_atomic_helper_shutdown() call.
drivers/gpu/drm/bochs/bochs_kms.c int bochs_kms_init(struct bochs_device *bochs) · line 295
Quoted 13 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/bochs/bochs_kms.c +0
-0@@ -293,6 +293,7 @@ int bochs_kms_init(struct bochs_device *bochs)void bochs_kms_fini (struct bochs_device *bochs) {if (bochs->mode_config_initialized) {
This mode_config_initialized is hilarious. I think (from looking at git history and all) this started in radeon, back when kms was an add-on, and radeon.ko still supported ums. Then it was dutifully copypasted into cirrus, bochs, mgag200, hisilicon and also amdgpu.
Afaict none of these drivers need this (but I didn't bother to review amdgpu and radeon fully). Would be nice little cleanup to follow up with.
Anyway, on your 3 patches here:
Quoted 7 lines
drivers/gpu/drm/bochs/bochs_kms.c +1
-0+drm_atomic_helper_shutdown (bochs->dev);drm_mode_config_cleanup (bochs->dev); bochs->mode_config_initialized = false; }Signature · 1 line
2.18.1
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH 2/3] drm/bochs: add missing drm_atomic_helper_shutdown() call.
In reply to Gerd Hoffmanndrivers/gpu/drm/bochs/bochs_kms.c int bochs_kms_init(struct bochs_device *bochs) · line 295
Quoted 13 lines · Gerd Hoffmann
Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/bochs/bochs_kms.c +0
-0@@ -293,6 +293,7 @@ int bochs_kms_init(struct bochs_device *bochs)void bochs_kms_fini (struct bochs_device *bochs) {if (bochs->mode_config_initialized) {
This mode_config_initialized is hilarious. I think (from looking at git history and all) this started in radeon, back when kms was an add-on, and radeon.ko still supported ums. Then it was dutifully copypasted into cirrus, bochs, mgag200, hisilicon and also amdgpu.
Afaict none of these drivers need this (but I didn't bother to review amdgpu and radeon fully). Would be nice little cleanup to follow up with.
Anyway, on your 3 patches here:
Quoted 7 lines
drivers/gpu/drm/bochs/bochs_kms.c +1
-0+drm_atomic_helper_shutdown (bochs->dev);drm_mode_config_cleanup (bochs->dev); bochs->mode_config_initialized = false; }Signature · 1 line
2.18.1
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann
maintainerPATCH 2/3 drm/bochs: add missing drm_atomic_helper_shutdown() call.
In reply to Gerd Hoffmann--- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bochs/bochs_kms.c +1 -0
@@ -293,6 +293,7 @@ int bochs_kms_init(struct bochs_device *bochs)void bochs_kms_fini (struct bochs_device *bochs) {if (bochs->mode_config_initialized) { +drm_atomic_helper_shutdown (bochs->dev);drm_mode_config_cleanup (bochs->dev); bochs->mode_config_initialized = false; }
Signature · 1 line
2.18.1
Gerd Hoffmann
maintainerPATCH 3/3 drm/cirrus: add missing drm_helper_force_disable_all() call.
In reply to Gerd Hoffmann--- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/cirrus/cirrus_mode.c +1 -0
@@ -615,6 +615,7 @@ void cirrus_modeset_fini(struct cirrus_device *cdev)cirrus_fbdev_fini (cdev);if (cdev->mode_info.mode_config_initialized) { +drm_helper_force_disable_all (cdev->dev);drm_mode_config_cleanup (cdev->dev); cdev->mode_info.mode_config_initialized = false; }
Signature · 1 line
2.18.1
Gerd Hoffmann
maintainerPATCH 3/3 drm/cirrus: add missing drm_helper_force_disable_all() call.
In reply to Gerd Hoffmann--- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/cirrus/cirrus_mode.c +1 -0
@@ -615,6 +615,7 @@ void cirrus_modeset_fini(struct cirrus_device *cdev)cirrus_fbdev_fini (cdev);if (cdev->mode_info.mode_config_initialized) { +drm_helper_force_disable_all (cdev->dev);drm_mode_config_cleanup (cdev->dev); cdev->mode_info.mode_config_initialized = false; }
Signature · 1 line
2.18.1