Skip to contentSkip to conversation

scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

PATCH RESEND New Fabio Estevam 2 participants 3 messages May 20, 2015 – May 21, 2015 Coccinelle/Semantic Patches (SmPL)

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/2 scripts/coccinelle/misc/semicolon.cocci: Use imperative mood

From: Fabio Estevam <[email protected]>

According to Documentation/SubmittingPatches:

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.

So do as recommended.

---
 scripts/coccinelle/misc/semicolon.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/semicolon.cocci +1 -1
index a47eba2..6740c65 100644
@@ -1,5 +1,5 @@
 ///
-/// Removes unneeded semicolon.
+/// Remove unneeded semicolon.
 ///
 // Confidence: Moderate
 // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6.  GPLv2.
Signature · 1 line
1.9.1
#1 lore raw

PATCH RESEND 2/2 scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar

From: Fabio Estevam <[email protected]>

Correct form is 'always requested'.

---
 scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/coccinelle/misc/irqf_oneshot.cocci +1 -1
index a24a754..b17ac8b 100644
@@ -1,4 +1,4 @@
-/// Make sure threaded IRQs without a primary handler are always request with
+/// Make sure threaded IRQs without a primary handler are always requested with
 /// IRQF_ONESHOT
 ///
 //
Signature · 1 line
1.9.1