clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
Subsystems (2)
PATCH 1/1 clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
Remove a previously registered clock provider when unload the module.
--- drivers/clk/clk-cdce706.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/clk-cdce706.c +1 -0
@@ -666,6 +666,7 @@ static int cdce706_probe(struct i2c_client *client,static int cdce706_remove (struct i2c_client *client) { +of_clk_del_provider (client->dev.of_node);return 0 ; }
Signature · 1 line
2.1.0
Quoted 4 lines · Axel Lin
Remove a previously registered clock provider when unload the module.
Signed-off-by Axel Lin <[email protected]>---
What about all the clocks that are registered? Don't those need to be unregistered as well?
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Max Filippov
maintainerQuoted 8 lines · Stephen Boyd
Quoted 4 lines · Axel Lin
Remove a previously registered clock provider when unload the module.
Signed-off-by Axel Lin <[email protected]>---
What about all the clocks that are registered? Don't those need to be unregistered as well?
They're registered with devm_clk_register, should be managed automatically.
Signature · 2 lines
Thanks. -- Max
Quoted 10 lines · Max Filippov
Quoted 7 lines · Stephen Boyd
Quoted 4 lines · Axel Lin
Remove a previously registered clock provider when unload the module.
Signed-off-by Axel Lin <[email protected]>---
What about all the clocks that are registered? Don't those need to be unregistered as well?
They're registered with
devm_clk_register, should be managed automatically.
Ah good. Applied.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Axel Lin
Remove a previously registered clock provider when unload the module.
Signed-off-by Axel Lin <[email protected]>--- drivers/clk/clk-cdce706.c | 1 + 1 file changed, 1 insertion(+)
Good catch, thank you!