Skip to contentSkip to conversation

libata: Update Crucial/Micron blacklist

PATCH In review Ben Hutchings 3 participants 5 messages May 21, 2015 – May 26, 2015 Stable branch

lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 1/2 libata: Update Crucial/Micron blacklist

From: "Martin K. Petersen" <[email protected]>
Date: Fri, 27 Mar 2015 15:17:20 -0400

commit ff7f53fb82a7801a778e5902bdbbc5e195ab0de0 upstream.

Micron has released an updated firmware (MU02) for M510/M550/MX100 drives to fix the issues with queued TRIM. Queued TRIM remains broken on M500 but is working fine on later drives such as M600 and MX200.

Tweak our blacklist to reflect the above.

Link https://bugzilla.kernel.org/show_bug.cgi?id=71371
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
[bwh: Backported to 3.16: adjust context and drop ZERO_AFTER_TRIM flags]

Signed-off-by; Ben Hutchings <[email protected]>
---
This appears to be needed for 3.12-3.18 stable branches, although 3.12.y already has the following patch and will therefore need further context changes.

Ben.

 drivers/ata/libata-core.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/ata/libata-core.c +4 -3
@@ -4225,9 +4225,10 @@ static const struct ata_blacklist_entry
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT???M500SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Micron_M550*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT*M550SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Micron_M5[15]0*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*M550*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*MX100*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link
Signature · 2 lines
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
author
#1 lore raw

PATCH 2/2 libata: Blacklist queued TRIM on Samsung SSD 850 Pro

From: "Martin K. Petersen" <[email protected]>
Date: Fri, 27 Mar 2015 15:17:21 -0400

commit 6fc4d97a4987c5d247655a157a9377996626221a upstream.

Blacklist queued TRIM on this drive for now.

Reported-by Stefan Keller <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
[bwh: Backported to 3.16: adjust context and drop ZERO_AFTER_TRIM flag]

Signed-off-by; Ben Hutchings <[email protected]>
---
This appears to be needed for 3.13-3.18 stable branches.

Ben.

 drivers/ata/libata-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ata/libata-core.c +1 -0
@@ -4229,6 +4229,7 @@ static const struct ata_blacklist_entry
 	{ "Micron_M5[15]0*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
 	{ "Crucial_CT*M550*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
 	{ "Crucial_CT*MX100*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Samsung SSD 850 PRO*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link
Signature · 2 lines
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
#2 lore raw

Re: [PATCH stable 2/2] libata: Blacklist queued TRIM on Samsung SSD 850 Pro

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Quoted 16 lines · Ben Hutchings

From: "Martin K. Petersen" <[email protected]> Date: Fri, 27 Mar 2015 15:17:21 -0400

commit 6fc4d97a4987c5d247655a157a9377996626221a upstream.

Blacklist queued TRIM on this drive for now.

Reported-by Stefan Keller <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Tejun Heo <[email protected]> [bwh: Backported to 3.16:

adjust context and drop ZERO_AFTER_TRIM flag] Signed-off-by; Ben Hutchings <[email protected]> --- This appears to be needed for 3.13-3.18 stable branches.

Ben.

Quoted 8 lines

drivers/ata/libata-core.c | 2 ++ 1 file changed, 2 insertions(+)

--- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4229,6 +4229,7 @@ static const struct ata_blacklist_entry {
"Micron_M5[15]0*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, {
"Crucial_CT*M550*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, {
"Crucial_CT*MX100*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM, }, + {
"Samsung SSD 850 PRO*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },

To 3.12, I added also:
commit 9a9324d3969678d44b330e1230ad2c8ae67acf81

Author: Martin K. Petersen <[email protected]>
Date:   Mon May 4 12:20:29 2015 -0400

libata: Blacklist queued TRIM on all Samsung 800-series

which turns the above into "Samsung SSD 8*".

thanks,
- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVZCw/AAoJEL0lsQQGtHBJQcAQAKkbo0AVHtnH28fDSQLg2vP3 djg21W6Oa1Yu/rD2Api41HdBI70muhMqHSuzNwDTZH8jt7Te56tIQLOZO8F7V1SJ PD6kd+W5YY4/ehox5bWRfKCTF8Mi9ypin+Vc8Gua4LFVAgXvJGWZWknHXW44EV+R GllZON8LranMHCVrZ+NBbzvS9z3kXPKmgb4mmQ+fcN3oUX5qdGf3x1Z3gPoAwOo/ 7Vx2I6RLi0DSVEl6WPj2BZO/f+mAYyNeIy6NwaqB4vAvlk3/PNxI1iUn3qsRHBLm vLtjMgbdzv5fDxw1HBNIyq59uAAq+c0bCDVgi0wR0w2NXwdu4ULbruhuuynfLcrT sXPN+lVXOISsg94yRrcArIF2qUraNuRMqVacFth7uT6PTtvfxRVYiFdK1IoQ2ZAo 6dE0BV8nQkGazHfHUiGYyo3y9R707b6vp521G1cNkfbJt6UNvSNfZ7HJp4nxDXH/ 5DrXRfah12aVnJiVxMbMLYu/qZYeGNwqZnSNFkQwVp1Uh5BBX/zouSqzmmxhyQOY pQckkq9mBACagO1F7w2xdPPURub4kbiQ5GOzt8GH0dyiNhghueBBVhlYHxBFkNos PtdQ2T4qVzicdkE8S2JhOIKCdprWBGjNHMoNOLVqVIJBATs5Vwa01xRXKgCK9wOQ jRFiTbPSQKswz5KXIuII
=8mCQ
-----END PGP SIGNATURE-----

#3 lore raw
In reply to Ben Hutchings
Quoted 15 lines · Ben Hutchings

From: "Martin K. Petersen" <[email protected]>
Date: Fri, 27 Mar 2015 15:17:20 -0400

commit ff7f53fb82a7801a778e5902bdbbc5e195ab0de0 upstream.

Micron has released an updated firmware (MU02) for M510/M550/MX100 drives to fix the issues with queued TRIM. Queued TRIM remains broken on M500 but is working fine on later drives such as M600 and MX200.

Tweak our blacklist to reflect the above.

Link https://bugzilla.kernel.org/show_bug.cgi?id=71371
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
[bwh: Backported to 3.16: adjust context and drop ZERO_AFTER_TRIM flags]
Quoted 6 lines

Signed-off-by; Ben Hutchings <[email protected]>
---
This appears to be needed for 3.12-3.18 stable branches, although 3.12.y already has the following patch and will therefore need further context changes.

Thank you, Ben. I'll queue these 2 patches along with another backport of commit 9a9324d39696 ("libata: Blacklist queued TRIM on all Samsung 800-series").

Cheers,
--
Lu�s

Quoted 25 lines

Ben.

 drivers/ata/libata-core.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/ata/libata-core.c +4 -3
@@ -4225,9 +4225,10 @@ static const struct ata_blacklist_entry
 
 	/* devices that don't properly handle queued TRIM commands */
 	{ "Micron_M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT???M500SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Micron_M550*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
-	{ "Crucial_CT*M550SSD*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Micron_M5[15]0*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*M550*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
+	{ "Crucial_CT*MX100*",		"MU01",	ATA_HORKAGE_NO_NCQ_TRIM, },
 
 	/*
 	 * Some WD SATA-I drives spin up and down erratically when the link
Signature · 3 lines
-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
#4 lore raw
In reply to Ben Hutchings

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Quoted 12 lines · Ben Hutchings

From: "Martin K. Petersen" <[email protected]> Date: Fri, 27 Mar 2015 15:17:20 -0400

commit ff7f53fb82a7801a778e5902bdbbc5e195ab0de0 upstream.

Micron has released an updated firmware (MU02) for M510/M550/MX100 drives to fix the issues with queued TRIM. Queued TRIM remains broken on M500 but is working fine on later drives such as M600 and MX200.

Tweak our blacklist to reflect the above.

Quoted 7 lines
Link https://bugzilla.kernel.org/show_bug.cgi?id=71371
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Tejun Heo <[email protected]> [bwh: Backported to 3.16:

adjust context and drop ZERO_AFTER_TRIM flags] Signed-off-by; Ben Hutchings <[email protected]> --- This appears to be needed for 3.12-3.18 stable branches, although 3.12.y already has the following patch and will therefore need further context changes.

Yes, tuned and pushed to 3.12. Thanks.

- --
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVZCxyAAoJEL0lsQQGtHBJxZ4P/itrDyljIfo5Z2R4RfiViB2D C/qL4IRymU8zBFg6kcFXhEhx0dfw2AxwYq+FqX8al90kXz9QmuG/sSJxCpeeomHv lzIZjxWsILLrybiP1Vh0fnuzi85rfvzLHXEA+o1AGfOx99RBz4LKAP3qRilwQWt1 ONwX+ZyT+W1ngX+mu3bvxgYwVn4+EH9JLEMcaABrHhcLaaJmv9Tcotegz5aV7uML 19uBsl/9Z2jpX1mVpbgECjXHa59jzGB7jN5tczmWc9SNYnWK5TInXthAPMy9THF7 KjApE0A+bg0IjaHlM/9MNUM1vsfk0W4ytxWMsN0jMZTvuKINMXD57MUBfdrJlJjG DzFw6rofdnUtId3DUWg9Q7K63E/j2GqF9LWWiqTfbhGskSP4dXfwqaTjw0vjGeIQ zfsDjYuEHbOR45hIhmH8hsV834VZajMLrv6YwCaarvvmm28aSjYJef2JZkOTzHIE fK1lUrMA/SwmxKYXVRRAQKzgUJDscsU6a6eJjmTPYqZIGb4layyGaLyJThkiZLSb vWJilnJPvNMlIl8HYTi6VUrxQc5Rjd2lM8mLvpNGQxFNQSTbyw/GrCrFMqmd3Enc c0xBqyYrPwmh9AnPpc0dlPwdWy7o0h63NmQrh3UISaaxxjrg8ihyPOv3pkrDdRwE fZI4Ji9QotOqD/jRUsq6
=Rpsm
-----END PGP SIGNATURE-----