atusb: add support for at86rf230
Subsystems (3)
Alexander Aring
maintainerRFC 1/1 atusb: add support for at86rf230
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
--- drivers/net/ieee802154/atusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ieee802154/atusb.c +1 -1
@@ -515,7 +515,7 @@ static int atusb_get_and_show_chip(struct atusb *atusb) man_id_1, man_id_0); goto fail; } -if (part_num !=3 ) { +if (part_num !=3 && part_num !=2 ) {dev_err (&usb_dev->dev,"unexpected transceiver, part 0x%02x version 0x%02x\n" , part_num, version_num);
Signature · 1 line
2.4.1
Alexander Aring
maintainerStefan,
Quoted 3 lines · Alexander Aring
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
is it okay to apply this patch for mainline for now? Then it's only a question to make _better_ patches for the atusb firmware. Werner told me that I should remove the a lot of ifdefs or we landing in a ifdef hell which is like a well known IoT-OS and that's true. Was a dirty hack.
If it's okay then I will send a patch again.
- Alex
Hello.
Quoted 7 lines · Alexander Aring
Stefan,
Quoted 3 lines · Alexander Aring
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
is it okay to apply this patch for mainline for now?
Yes, just send my reviewed-by for it. (You already want acked-by for this driver for me? I guess I wait until I send a patch to the maintainers file)
Quoted 4 lines
Then it's only a
question to make _better_ patches for the atusb firmware. Werner told me that I should remove the a lot of ifdefs or we landing in a ifdef hell which is like a well known IoT-OS and that's true. Was a dirty hack.
I have yet to look at the firmware patches but if Werner already suggested some changes they should be taken into account. Especially if this would let us to ifdef hell. :)
I was really happy to see the raven avr stick patches. This will extend the potential userbase for atusb and ieee802154 quite a bit. Thanks for working on this.
regards
Stefan Schmidt
Hello.
Quoted 14 lines · Alexander Aring
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
Signed-off-by Alexander Aring <[email protected]>Cc Stefan Schmidt <[email protected]>--- drivers/net/ieee802154/atusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ieee802154/atusb.c +0
-0
drivers/net/ieee802154/atusb.c static int atusb_get_and_show_chip(struct atusb *atusb) · line 521
Quoted 8 lines
drivers/net/ieee802154/atusb.c +1
-1@@ -515,7 +515,7 @@ static int atusb_get_and_show_chip(struct atusb *atusb) man_id_1, man_id_0); goto fail; } -if (part_num !=3 ) { +if (part_num !=3 && part_num !=2 ) {dev_err (&usb_dev->dev,"unexpected transceiver, part 0x%02x version 0x%02x\n" , part_num, version_num);
regards
Stefan Schmidt
Alexander Aring
maintainerHi Stefan,
Quoted 12 lines · Stefan Schmidt
Hello.
Quoted 9 lines · Alexander Aring
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
Signed-off-by Alexander Aring <[email protected]>Cc Stefan Schmidt <[email protected]>--- drivers/net/ieee802154/atusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
drivers/net/ieee802154/atusb.c static int atusb_get_and_show_chip(struct atusb *atusb) · line 521
Quoted 13 lines
drivers/net/ieee802154/atusb.c +1
-1@@ -515,7 +515,7 @@ static int atusb_get_and_show_chip(struct atusb *atusb) man_id_1, man_id_0); goto fail; } -if (part_num !=3 ) { +if (part_num !=3 && part_num !=2 ) {dev_err (&usb_dev->dev,"unexpected transceiver, part 0x%02x version 0x%02x\n" , part_num, version_num);Reviewed-by Stefan Schmidt <[email protected]>
is this patch okay, even when it's the same product id? Possible "stronger" test would be to check if atusb then part_num != 3, if rzusb then != 2. Or can we add support for this later?
- Alex
Hello.
Quoted 30 lines · Alexander Aring
Hi Stefan,
Quoted 12 lines · Stefan Schmidt
Hello.
Quoted 9 lines · Alexander Aring
This patch adds support for the at86rf230 version check which is used by the rzusb stick.
Signed-off-by Alexander Aring <[email protected]>Cc Stefan Schmidt <[email protected]>--- drivers/net/ieee802154/atusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 15 lines
drivers/net/ieee802154/atusb.c static int atusb_get_and_show_chip(struct atusb *atusb) · line 521
Quoted 13 lines
drivers/net/ieee802154/atusb.c +1
-1@@ -515,7 +515,7 @@ static int atusb_get_and_show_chip(struct atusb *atusb) man_id_1, man_id_0); goto fail; } -if (part_num !=3 ) { +if (part_num !=3 && part_num !=2 ) {dev_err (&usb_dev->dev,"unexpected transceiver, part 0x%02x version 0x%02x\n" , part_num, version_num);Reviewed-by Stefan Schmidt <[email protected]>
Quoted 3 lines
is this patch okay, even when it's the same product id? Possible "stronger" test would be to check if atusb then
part_num!= 3, if rzusb then != 2. Or can we add support for this later?
Yes, we can get this in like it is right now. That enables you and maybe others to work with it.
Once we have a separate product id for rzusb we can adjust the checking here and also print out on what hardware (atusb or rzusb) we are running on. But that can wait until we have the firmware things sorted out for it.
regards
Stefan Schmidt
Quoted 1 line
- Alex