Skip to contentSkip to conversation

staging: comedi/drivers/pcl.* coding style fixes

PATCH In review Matthew Needes 2 participants 4 messages May 25, 2015 – May 26, 2015 Staging

lore
Share & tools
lore

Matthew Needes

author
#0 lore raw

PATCH 1/2 staging: comedi/drivers/pcl.* coding style fixes

pcl812.c / pcl816.c (resend of earlier patch)
Fixed indentation problems.

Signed-off-by Matthew Needes <[email protected]>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 drivers/staging/comedi/drivers/pcl816.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
index 03a3fd6..7474ef9 100644
@@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 
 	/* we need an IRQ to do DMA on channel 3 or 1 */
 	if (dev->irq && board->has_dma)
-		 pcl812_alloc_dma(dev, it->options[2]);
+		pcl812_alloc_dma(dev, it->options[2]);
 
 	/* differential analog inputs? */
 	switch (board->board_type) {
drivers/staging/comedi/drivers/pcl816.c +1 -1
index 1ccb2f1..781b321 100644
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
 
 		/*  check whole chanlist */
 		for (i = 0, segpos = 0; i < chanlen; i++) {
-			    if (chanlist[i] != chansegment[i % seglen]) {
+			if (chanlist[i] != chansegment[i % seglen]) {
 				dev_dbg(dev->class_dev,
 					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
 					i, CR_CHAN(chansegment[i]),
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 staging: comedi/drivers/pcl.* coding style fixes

pcl812.c (resend of earlier patch)
Fixed lines exceeding 80 columns, correcting some spelling in process

Signed-off-by Matthew Needes <[email protected]>
---
 drivers/staging/comedi/drivers/pcl812.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/pcl812.c +4 -4
index 7474ef9..48f6cdf 100644
@@ -507,11 +507,11 @@ static const struct pcl812_board boardtypes[] = {
 
 struct pcl812_private {
 	struct comedi_isadma *dma;
-	unsigned char range_correction;	/*  =1 we must add 1 to range number */
+	unsigned char range_correction;	/* =1 we must add 1 to range number */
 	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
-	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
-	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
+	unsigned char mode_reg_int; /* stored INT number for some cards */
+	unsigned int ai_poll_ptr; /* how many samples transfer poll */
+	unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
 	unsigned int use_diff:1;
 	unsigned int use_mpc508:1;
 	unsigned int use_ext_trg:1;
Signature · 1 line
1.9.1
Reviewed-by on v1 2/2
#2 lore raw
Quoted 19 lines · Matthew Needes

pcl812.c (resend of earlier patch)
Fixed lines exceeding 80 columns, correcting some spelling in process

Signed-off-by Matthew Needes <[email protected]>
---
  drivers/staging/comedi/drivers/pcl812.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
index 7474ef9..48f6cdf 100644
@@ -507,11 +507,11 @@ static const struct pcl812_board boardtypes[] = {
 
  struct pcl812_private {
  	struct comedi_isadma *dma;
-	unsigned char range_correction;	/*  =1 we must add 1 to range number */
+	unsigned char range_correction;	/* =1 we must add 1 to range number */

drivers/staging/comedi/drivers/pcl812.c static const struct pcl812_board boardtypes[] = { · line 517

Quoted 10 lines
drivers/staging/comedi/drivers/pcl812.c +3 -3
  	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
-	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
-	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
+	unsigned char mode_reg_int; /* stored INT number for some cards */
+	unsigned int ai_poll_ptr; /* how many samples transfer poll */
+	unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
  	unsigned int use_diff:1;
  	unsigned int use_mpc508:1;
  	unsigned int use_ext_trg:1;
Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
Reviewed-by on v1 1/2
#3 lore raw
In reply to Matthew Needes
Quoted 29 lines · Matthew Needes

pcl812.c / pcl816.c (resend of earlier patch)
Fixed indentation problems.

Signed-off-by Matthew Needes <[email protected]>
---
  drivers/staging/comedi/drivers/pcl812.c | 2 +-
  drivers/staging/comedi/drivers/pcl816.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
index 03a3fd6..7474ef9 100644
@@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 
  	/* we need an IRQ to do DMA on channel 3 or 1 */
  	if (dev->irq && board->has_dma)
-		 pcl812_alloc_dma(dev, it->options[2]);
+		pcl812_alloc_dma(dev, it->options[2]);
 
  	/* differential analog inputs? */
  	switch (board->board_type) {
drivers/staging/comedi/drivers/pcl816.c +0 -0
index 1ccb2f1..781b321 100644

drivers/staging/comedi/drivers/pcl816.c static int check_channel_list(struct comedi_device *dev, · line 329

Quoted 8 lines
drivers/staging/comedi/drivers/pcl816.c +1 -1
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
 
  		/*  check whole chanlist */
  		for (i = 0, segpos = 0; i < chanlen; i++) {
-			    if (chanlist[i] != chansegment[i % seglen]) {
+			if (chanlist[i] != chansegment[i % seglen]) {
  				dev_dbg(dev->class_dev,
  					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
  					i, CR_CHAN(chansegment[i]),
Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-