Skip to contentSkip to conversation

ARM: lpc18xx: remove DEBUG_LL_UART_8250 from defconfig

PATCH New Joachim Eastwood 2 participants 2 messages May 26, 2015 – May 29, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: lpc18xx: remove DEBUG_LL_UART_8250 from defconfig

Remove the generic 8250 config option so that the LPC18xx specific option gets picked instead.

---
Hi Arnd,

Please apply this to the next/defconfig branch.

After LPC18XX was converted to use the DEBUG_LPC18XX_UART0 config symbol there is now a mismatch in defconfig for this platform.

On a clean defconfig the following warnings appear. .config:2073:warning: symbol value '' invalid for DEBUG_UART_PHYS .config:2074:warning: symbol value '' invalid for DEBUG_UART_VIRT

Since the default value now depends on DEBUG_LPC18XX_UART0 and not ARCH_LPC18XX.

 arch/arm/configs/lpc18xx_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/lpc18xx_defconfig +0 -1
index d4320a7e433f..1c47f86c3970 100644
@@ -146,7 +146,6 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_RCU_CPU_STALL_INFO is not set
 # CONFIG_FTRACE is not set
 CONFIG_DEBUG_LL=y
-CONFIG_DEBUG_LL_UART_8250=y
 CONFIG_EARLY_PRINTK=y
 CONFIG_CRC_ITU_T=y
 CONFIG_CRC7=y
Signature · 1 line
1.8.0
#1 lore raw

PATCH 1/1 ARM: lpc18xx: remove DEBUG_LL_UART_8250 from defconfig

Quoted 5 lines · On Tuesday 26 May 2015 19:39:46 Joachim Eastwood wrote:

Please apply this to the next/defconfig branch.

After LPC18XX was converted to use the DEBUG_LPC18XX_UART0 config symbol there is now a mismatch in defconfig for this platform.

Quoted 7 lines

On a clean defconfig the following warnings appear. .config:2073:warning: symbol value '' invalid for DEBUG_UART_PHYS .config:2074:warning: symbol value '' invalid for DEBUG_UART_VIRT

Since the default value now depends on DEBUG_LPC18XX_UART0 and not ARCH_LPC18XX.

Applied now, thanks a lot!

I missed this problem because I'm mainly testing with a branch that has a workaround for the general problem of DEBUG_UART_PHYS being empty.

Arnd