ConfHandler: Fix bogus dependency problems

PATCH New Richard Purdie 1 participant 1 message May 27, 2015

Share & tools

Richard Purdie

author

2015-05-27 16:29 UTC #0 lore raw

PATCH 1/1 ConfHandler: Fix bogus dependency problems

Adding a dependency when errors occur accessing a file when calling handle() is not the correct thing to do. THe handle() code calls resolve_file() which can raise an exception without ever touching "fn" itself, it has also already marked all the dependencies correctly.

This leads to bogus files being resolved to the local cwd and hence triggers reparses for no good reason.

The solution is to simply remove the bogus dependency.

Signed-off-by Richard Purdie <[email protected]>

bitbake/lib/bb/parse/parse_py/ConfHandler.py +0 -1

index 861faf0..8d7a0d5 100644
@@ -97,7 +97,6 @@ def include(parentfn, fn, lineno, data, error_out):
         if error_out:
             raise ParseError("Could not %(error_out)s file %(fn)s" % vars(), parentfn, lineno)
         logger.debug(2, "CONF file '%s' not found", fn)
-        bb.parse.mark_dependency(data, fn)
 
 # We have an issue where a UI might want to enforce particular settings such as
 # an empty DISTRO variable. If configuration files do something like assigning