Skip to contentSkip to conversation

gpio: tb10x: Drop unneeded free_irq() call

PATCH In review Axel Lin 3 participants 3 messages May 28, 2015 – Jun 2, 2015 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: tb10x: Drop unneeded free_irq() call

Current code uses devm_request_irq() in .probe, so drop the unneeded free_irq() call in .remove.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/gpio-tb10x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-tb10x.c +0 -1
index 46b8961..12c99d9 100644
@@ -292,7 +292,6 @@ static int tb10x_gpio_remove(struct platform_device *pdev)
 					BIT(tb10x_gpio->gc.ngpio) - 1, 0, 0);
 		kfree(tb10x_gpio->domain->gc);
 		irq_domain_remove(tb10x_gpio->domain);
-		free_irq(tb10x_gpio->irq, tb10x_gpio);
 	}
 	gpiochip_remove(&tb10x_gpio->gc);
Signature · 1 line
2.1.0
Acked-by on v1 1/1
#1 lore raw

Axel Lin <[email protected]> wrote on 05/28/2015 11:26:10 AM:

Quoted 5 lines

Current code uses devm_request_irq() in .probe, so drop the unneeded free_irq() call in .remove.

Signed-off-by Axel Lin <[email protected]>
Acked-by Christian Ruppert <[email protected]>

drivers/gpio/gpio-tb10x.c static int tb10x_gpio_remove(struct platform_device

Quoted 9 lines
---
 drivers/gpio/gpio-tb10x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpio-tb10x.c +0 -0
index 46b8961..12c99d9 100644
@@ -292,7 +292,6 @@ static int tb10x_gpio_remove(struct platform_device

*pdev)

Quoted 12 lines
drivers/gpio/gpio-tb10x.c +0 -1
                BIT(tb10x_gpio->gc.ngpio) - 1, 0, 0);
       kfree(tb10x_gpio->domain->gc);
       irq_domain_remove(tb10x_gpio->domain);
-      free_irq(tb10x_gpio->irq, tb10x_gpio);
    }
    gpiochip_remove(&tb10x_gpio->gc);
Signature · 1 line
2.1.0