Skip to contentSkip to conversation

perf: fix MIPS build

PATCH In review Rabin Vincent 2 participants 4 messages May 28, 2015 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: fix MIPS build

5e8c0fb6a ("perf build: Add arch x86 objects building") added empty Build files to several architectures, but MIPS got left out. This leads to a build of perf for MIPS failing with the following errors:

tools/build/Makefile.build:40: arch/mips/Build: No such file or directory make[4]: *** No rule to make target `arch/mips/Build'. Stop.

Add an empty Build file to fix this.

---

 0 files changed
 create mode 100644 tools/perf/arch/mips/Build
tools/perf/arch/mips/Build new file +0 -0
new file mode 100644
index 0000000..e69de29
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 20 lines · Rabin Vincent

5e8c0fb6a ("perf build: Add arch x86 objects building") added empty Build files to several architectures, but MIPS got left out. This leads to a build of perf for MIPS failing with the following errors:

tools/build/Makefile.build:40: arch/mips/Build: No such file or directory make[4]: *** No rule to make target `arch/mips/Build'. Stop.

Add an empty Build file to fix this.

---

 0 files changed
 create mode 100644 tools/perf/arch/mips/Build
tools/perf/arch/mips/Build new file +0 -0
new file mode 100644
index 0000000..e69de29
Signature · 1 line
1.7.10.4

hum, haven't realized we're so strict ;-)

I haven't checked this deeply (and we'll probably take your change) but could you please try attached patch if it solves the issue?

thanks,
jirka

---

tools/build/Makefile.build +1 -1
index 10df57237a66..69c35cf09cad 100644
@@ -37,7 +37,7 @@ subdir-obj-y :=
 
 # Build definitions
 build-file := $(dir)/Build
-include $(build-file)
+-include $(build-file)
 
 quiet_cmd_flex  = FLEX     $@
 quiet_cmd_bison = BISON    $@
#2 lore raw
Quoted 2 lines · Jiri Olsa

I haven't checked this deeply (and we'll probably take your change) but could you please try attached patch if it solves the issue?

Yes, that works too. Thanks.

#3 lore raw
Quoted 5 lines · Rabin Vincent
Quoted 2 lines · Jiri Olsa

I haven't checked this deeply (and we'll probably take your change) but could you please try attached patch if it solves the issue?

Yes, that works too. Thanks.

cool, I'll double check if thats ok with the rest of the code and post it.. or will take your change if not ;-)

thanks,
jirka