Current patch statuses
* Ira's 3 patch const cleanup: generally approved, waiting latest version
* Ira's 14 patch OPA set: I haven't reviewed yet, waiting for next version
* Matan's 14 patch RoCE GID set: Changes were requested, awaiting next version
* Or's 11 patch timestamp set: The general idea is OK, creating an extension is OK, but I think the actual uAPI needs nailed down a little more. Right now it's too vendor/model/driver specific for a general uAPI.
* Haggai's 12 patch cma namespace set: Serious concerns over the suitability of creating more than one link per unique guid/pkey. Requesting that Haggai investigate using alias GUIDs for containers instead.
* Or's 3 patch SRIOV set: both changes and coordination with netdev/iproute2 folks requested, awaiting results of that interaction and update for 8byte GUID management
* Yishai's 3 patch hot removal set: changes in locking requested
* Alex's Verbs RSS RFC: I read through the proposal, but I didn't research it in enough detail to provide high quality feedback. But I will give a little low quality feedback. First the good: I'm generally receptive to anything that improves our NUMA operation. While I didn't see that the RSS necessarily took NUMA into consideration, the overall framework looked like a good starting point for doing exactly that. The ability to have RSS via hashed receives and multiple flows is a start, now you just need to add pinning the flows to specific sockets that are adjacent to the PCI bus the controller is on and populating the number of threads to use for RSS based upon the number of cores/threads per socket. Next the questionable: I'm not sure I like the specific implementation. It puts a lot of new, complex configuration on the application. But the benefits of this could have a default setting without requiring application interaction. I'm not sure I wouldn't prefer something that, by default, creates all new QPs and CQs so that they go through a default hashing and redirection without any user interaction at all. Or maybe the user simply sets a flag to signal that they are OK with multithread completion handling and they get it. Or something like that. On other words, I would like to see an application get the benefit of this without having to be recoded. Maybe they only get a default benefit and not an optimized benefit, and maybe the user has to set an environment variable for libibverbs before it gets enabled by default, but I would still like to see a non-recompiled app benefit from this. The proposal I see here might be able to do that if the changes to libibverbs are done properly. And if the implementation is right it might be able to help the kernel consumers too. So, please keep these things in mind as you continue to work on this.
And with that, I've got to do some Red Hat work for a bit. I won't be as responsive the early part of next week as a result.
Signature · 2 lines
Doug Ledford <[email protected]> GPG KeyID: 0E572FDD
A message that is not in the archive (sent off-list or not yet received): 1432936645.114391.156.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
SGkgRG91ZywNCg0KVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suDQoNCj4+VGhlIGFiaWxpdHkgdG8g aGF2ZSBSU1MgdmlhIGhhc2hlZCByZWNlaXZlcyBhbmQgbXVsdGlwbGUgZmxvd3MgaXMgYSBzdGFy dCwNCj4+bm93IHlvdSBqdXN0IG5lZWQgdG8gYWRkIHBpbm5pbmcgdGhlIGZsb3dzIHRvIHNwZWNp ZmljIHNvY2tldHMgdGhhdCBhcmUNCj4+YWRqYWNlbnQgdG8gdGhlIFBDSSBidXMgdGhlIGNvbnRy b2xsZXIgaXMgb24gYW5kIHBvcHVsYXRpbmcgdGhlIG51bWJlcg0KPj5vZiB0aHJlYWRzIHRvIHVz ZSBmb3IgUlNTIGJhc2VkIHVwb24gdGhlIG51bWJlciBvZiBjb3Jlcy90aHJlYWRzIHBlcg0KPj5z b2NrZXQuDQpJIHRoaW5rIHRoYXQgdGhlIHByb3Bvc2VkIEFQSSBhbmQgdGhlIG92ZXJhbGwgc29s dXRpb24gYWxsb3dzIHRoYXQuDQoNCj4+SSdtIG5vdCBzdXJlIEkgbGlrZSB0aGUgc3BlY2lmaWMN Cj4+aW1wbGVtZW50YXRpb24uICBJdCBwdXRzIGEgbG90IG9mIG5ldywgY29tcGxleCBjb25maWd1 cmF0aW9uIG9uIHRoZQ0KPj5hcHBsaWNhdGlvbi4gIA0KSSB0aGluayB0aGF0IGl0IGlzIGltcG9y dGFudCB0aGF0IHZlcmJzIEFQSSwgdGhhdCBjb21lcyB0byBwcm92aWRlIGRpcmVjdCANCmFjY2Vz cyB0byBIVyB3aWxsIGV4cGxpY2l0bHkgZXhwb3NlIFJTUyBzZXR0aW5ncyBhbmQgYWxsb3cgdmVy YnMgYXBwbGljYXRpb25zIA0KdG8gYWRqdXN0IFJTUyBjb25maWd1cmF0aW9uIHRvIHRoZWlyIG5l ZWRzIGluIG9yZGVyIHRvIGdldCB0aGUgMTAwJSBwZXJmb3JtYW5jZQ0KYmVuZWZpdCBmcm9tIHRo ZSBIVyBjYXBhYmlsaXRpZXMuDQpUaGUgYWJpbGl0eSB0byBjb250cm9sIFJTUyBoYXNoIGZ1bmN0 aW9uIGFuZCB0aGUgSW5kaXJlY3Rpb24gdGFibGUgcHJvcGVydGllcw0KY2FuIGJlIGltcG9ydGFu dCBmb3IgZGlmZmVyZW50IGZhc3QgcGFja2V0IHByb2Nlc3Npbmcgc29sdXRpb25zOg0KLSBGb3Ig ZXhhbXBsZSBidW1wIGluIHRoZSB3aXJlIGFwcGxpY2F0aW9ucyBjYW4gcHJlZmVyIHN5bW1ldHJp YyANCiAgUlNTIHNvIGV4cG9zaW5nIGludGVyZmFjZSB0aGF0IGFsbG93cyB0byBjb25maWd1cmUg dGhlIGhhc2ggZnVuY3Rpb24gaXMNCiAgdmFsdWFibGUuDQotVGhlIGFwcGxpY2F0aW9ucyBjYW4g a25vdyB3aGljaCB0cmFmZmljIHR5cGUgaXQgd2lsbCBoYW5kbGUgYW5kIGFkanVzdCANCiAgd2hp Y2ggcGFja2V0cyBmaWVsZHMgc2hvdWxkIHBhcnRpY2lwYXRlIGluIHRoZSBSU1MgaGFzaCB0byBi ZXR0ZXIgDQogIGRpc3RyaWJ1dGUgdGhlIHRyYWZmaWMuDQotRXhwb3NpbmcgQVBJIHRoYXQgYWxs b3dzIHRvIHNldCBSU1MgaGFzaCBwcm9wZXJ0aWVzIGFuZCBSU1MgSW5kaXJlY3Rpb24gVGFibGUN CiBhbGxvd3MgYmV0dGVyIHZlcmJzIGludGVncmF0aW9uIHdpdGggc3VjaCBmcmFtZXdvcmtzIGFz IERQREsuIA0KDQpOb3RpY2UgdGhhdCB3ZSBkbyB0aGluayB0aGF0IG1vcmUgImhpZ2ggbGV2ZWwi IFJTUyBBUEkgdGhhdCByZXF1aXJlcyBsZXNzIGNoYW5nZXMNCmluIGFwcGxpY2F0aW9uIGxldmVs IHNob3VsZCBiZSBzdXBwb3J0ZWQgYnkgcmRtYV9jbS4NCg0KPj5PbiBvdGhlciB3b3JkcywgSSB3 b3VsZCBsaWtlIHRvIHNlZSBhbiBhcHBsaWNhdGlvbg0KPj5nZXQgdGhlIGJlbmVmaXQgb2YgdGhp cyB3aXRob3V0IGhhdmluZyB0byBiZSByZWNvZGVkLiAgTWF5YmUgdGhleSBvbmx5DQo+PmdldCBh IGRlZmF1bHQgYmVuZWZpdCBhbmQgbm90IGFuIG9wdGltaXplZCBiZW5lZml0LCBhbmQgbWF5YmUg dGhlIHVzZXINCj4+aGFzIHRvIHNldCBhbiBlbnZpcm9ubWVudCB2YXJpYWJsZSBmb3IgbGliaWJ2 ZXJicyBiZWZvcmUgaXQgZ2V0cyBlbmFibGVkDQo+PmJ5IGRlZmF1bHQsIGJ1dCBJIHdvdWxkIHN0 aWxsIGxpa2UgdG8gc2VlIGEgbm9uLXJlY29tcGlsZWQgYXBwIGJlbmVmaXQNCj4+ZnJvbSB0aGlz Lg0KSSBhbSBub3Qgc3VyZSB0aGF0IEkgdW5kZXJzdGFuZCBob3cgZG9lcyB0aGUg4oCcbm8gcmVj b2RpbmfigJ0gDQphcHByb2FjaCBjYW4gd29yazoNCndoYXQg4oCcZGVmYXVsdOKAnSBiZW5lZml0 IGNhbiBnZXQgYXBwbGljYXRpb24gdGhhdCB3b3JrcyBpbiBwb2xsaW5nIG1vZGU/IA0KSW4gcG9s bGluZyBtb2RlIGFwcGxpY2F0aW9uIHRocmVhZHMgYWZmaW5pdGllcyBkZWZpbmUgd2hpY2ggQ1BV IGNvcmUgYXJlIA0KdXRpbGl6ZWQgZm9yIGNvbXBsZXRpb25zIGFuZCBwYWNrZXQgcHJvY2Vzc2lu Zy4gDQpGb3IgZXhhbXBsZSBpZiBhcHBsaWNhdGlvbiBkZWNpZGVzIHRvIG9wZW4gYSBzaW5nbGUg dGhyZWFkIHRoYXQgcG9sbHMgQ1ENCmFuZCBwcm9jZXNzIGNvbXBsZXRpb25zIEkgZG9u4oCZdCBz ZWUgaG93IGlzIGl0IHBvc3NpYmxlIHRvIGJldHRlciBkaXN0cmlidXRlDQp0aGUgcHJvY2Vzc2lu ZyBiZXR3ZWVuIENQVSBjb3JlIHdpdGhvdXQgY2hhbmdpbmcgdGhlIGFwcGxpY2F0aW9uLg0KRm9y IEludGVycnVwdCBkcml2ZW4gYXBwbGljYXRpb25zIHdlIGNhbiBnZXQgc29tZSBwYXJ0aWFsIOKA nGRlZmF1bHTigJ0gYmVuZWZpdDoNCndlIGNhbiBsb2FkIGJhbGFuY2UgSW50ZXJydXB0IGhhbmRs ZXIgYW5kIOKAnGJvdHRvbSBoYWxm4oCdIHBhcnQgb2YgDQpwYWNrZXQgcHJvY2Vzc2luZyBidXQg bm90IHRoZSBwcm9jZXNzaW5nIHRoYXQgaXMgZG9uZSBpbiB1c2VyIHNwYWNlLiANClN0aWxsIHRo aXMgcmVxdWlyZXMgQVBJIGNoYW5nZXMgb3IgbWF5YmUgYWRkaW5nIHNvbWUgbmV3IGVudmlyb25t ZW50DQpwYXJhbWV0ZXIsIGFzIHlvdSBoYXZlIG1lbnRpb25lZCwgc2luY2UgYXBwbGljYXRpb24g b24gQ1EgY3JlYXRpb24gcHJvdmlkZXMNCmNvbXBfdmVjdG9yIGFuZCBydW5uaW5nIGNvbXBsZXRp b24gZXZlbnQgaGFuZGxlciBvbiBkaWZmZXJlbnQgY29yZXMgDQooYXMgdGhlIHJlc3VsdCBvZiBS U1MpIGFjdHVhbGx5IGJyZWFrcyB0aGlzIEFQSS4NCg0KVG8gc3VtbWFyaXplLCBpbiBteSBvcGlu aW9uIHZlcmJzIGlzIHRoZSByaWdodCBwbGFjZSB0byBleHBvc2UgUlNTIGludGVyZmFjZSANCnRo YXQgZ2l2ZXMgdmVyYnMgYXBwbGljYXRpb24gZnVsbCBjb250cm9sIG92ZXIgZGlmZmVyZW50IFJT UyBwcm9wZXJ0aWVzIA0KYW5kIG1vcmUgImhpZ2ggbGV2ZWwiIGFuZCBzaW1wbGUgUlNTIEFQSSBj YW4gYmUgZXhwb3NlZCB2aWEgcmRtYV9jbS4NClRoaXMgd2lsbCBhbGxvdyBmcm9tIG9uZSBzaWRl IHRvIGFuc3dlciB0aGUgbmVlZHMgb2Ygc29sdXRpb25zIHRoYXQgcmVxdWlyZXMNCnRoZSBhYmls aXR5IHRvIGRpcmVjdGx5IGFjY2VzcyBhbmQgY29uZmlndXJlIHRoZSBIVywgDQphcyB1c2VyIHNw YWNlIE5JQ3Mgc29sdXRpb25zLCBhbmQgb24gb3RoZXIgc2lkZSB0aGlzIGFuc3dlciB0aGUgbmVl ZHMgDQpvZiBhcHBsaWNhdGlvbnMgdGhhdCBsb29rIGZvciBtb3JlICJoaWdoIGxldmVsIiBBUEku DQoNClRoYW5rcywNCkFsZXhWDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBE b3VnIExlZGZvcmQgW21haWx0bzpkbGVkZm9yZEByZWRoYXQuY29tXSANClNlbnQ6IFNhdHVyZGF5 LCBNYXkgMzAsIDIwMTUgMTI6NTcgQU0NClRvOiBSRE1BIG1haWxpbmcgbGlzdA0KQ2M6IFdlaW55 LCBJcmE7IE1hdGFuIEJhcmFrOyBPciBHZXJsaXR6OyBIYWdnYWkgRXJhbjsgWWlzaGFpIEhhZGFz OyBBbGV4IFZhaW5tYW4NClN1YmplY3Q6IEN1cnJlbnQgcGF0Y2ggc3RhdHVzZXMNCg0KKiBJcmEn cyAzIHBhdGNoIGNvbnN0IGNsZWFudXA6IGdlbmVyYWxseSBhcHByb3ZlZCwgd2FpdGluZyBsYXRl c3QNCnZlcnNpb24NCiogSXJhJ3MgMTQgcGF0Y2ggT1BBIHNldDogSSBoYXZlbid0IHJldmlld2Vk IHlldCwgd2FpdGluZyBmb3IgbmV4dA0KdmVyc2lvbg0KKiBNYXRhbidzIDE0IHBhdGNoIFJvQ0Ug R0lEIHNldDogQ2hhbmdlcyB3ZXJlIHJlcXVlc3RlZCwgYXdhaXRpbmcgbmV4dA0KdmVyc2lvbg0K KiBPcidzIDExIHBhdGNoIHRpbWVzdGFtcCBzZXQ6IFRoZSBnZW5lcmFsIGlkZWEgaXMgT0ssIGNy ZWF0aW5nIGFuDQpleHRlbnNpb24gaXMgT0ssIGJ1dCBJIHRoaW5rIHRoZSBhY3R1YWwgdUFQSSBu ZWVkcyBuYWlsZWQgZG93biBhIGxpdHRsZQ0KbW9yZS4gIFJpZ2h0IG5vdyBpdCdzIHRvbyB2ZW5k b3IvbW9kZWwvZHJpdmVyIHNwZWNpZmljIGZvciBhIGdlbmVyYWwNCnVBUEkuDQoqIEhhZ2dhaSdz IDEyIHBhdGNoIGNtYSBuYW1lc3BhY2Ugc2V0OiBTZXJpb3VzIGNvbmNlcm5zIG92ZXIgdGhlDQpz dWl0YWJpbGl0eSBvZiBjcmVhdGluZyBtb3JlIHRoYW4gb25lIGxpbmsgcGVyIHVuaXF1ZSBndWlk L3BrZXkuDQpSZXF1ZXN0aW5nIHRoYXQgSGFnZ2FpIGludmVzdGlnYXRlIHVzaW5nIGFsaWFzIEdV SURzIGZvciBjb250YWluZXJzDQppbnN0ZWFkLg0KKiBPcidzIDMgcGF0Y2ggU1JJT1Ygc2V0OiBi b3RoIGNoYW5nZXMgYW5kIGNvb3JkaW5hdGlvbiB3aXRoDQpuZXRkZXYvaXByb3V0ZTIgZm9sa3Mg cmVxdWVzdGVkLCBhd2FpdGluZyByZXN1bHRzIG9mIHRoYXQgaW50ZXJhY3Rpb24NCmFuZCB1cGRh dGUgZm9yIDhieXRlIEdVSUQgbWFuYWdlbWVudA0KKiBZaXNoYWkncyAzIHBhdGNoIGhvdCByZW1v dmFsIHNldDogY2hhbmdlcyBpbiBsb2NraW5nIHJlcXVlc3RlZA0KKiBBbGV4J3MgVmVyYnMgUlNT IFJGQzogSSByZWFkIHRocm91Z2ggdGhlIHByb3Bvc2FsLCBidXQgSSBkaWRuJ3QNCnJlc2VhcmNo IGl0IGluIGVub3VnaCBkZXRhaWwgdG8gcHJvdmlkZSBoaWdoIHF1YWxpdHkgZmVlZGJhY2suICBC dXQgSQ0Kd2lsbCBnaXZlIGEgbGl0dGxlIGxvdyBxdWFsaXR5IGZlZWRiYWNrLiAgRmlyc3QgdGhl IGdvb2Q6IEknbSBnZW5lcmFsbHkNCnJlY2VwdGl2ZSB0byBhbnl0aGluZyB0aGF0IGltcHJvdmVz IG91ciBOVU1BIG9wZXJhdGlvbi4gIFdoaWxlIEkgZGlkbid0DQpzZWUgdGhhdCB0aGUgUlNTIG5l Y2Vzc2FyaWx5IHRvb2sgTlVNQSBpbnRvIGNvbnNpZGVyYXRpb24sIHRoZSBvdmVyYWxsDQpmcmFt ZXdvcmsgbG9va2VkIGxpa2UgYSBnb29kIHN0YXJ0aW5nIHBvaW50IGZvciBkb2luZyBleGFjdGx5 IHRoYXQuICBUaGUNCmFiaWxpdHkgdG8gaGF2ZSBSU1MgdmlhIGhhc2hlZCByZWNlaXZlcyBhbmQg bXVsdGlwbGUgZmxvd3MgaXMgYSBzdGFydCwNCm5vdyB5b3UganVzdCBuZWVkIHRvIGFkZCBwaW5u aW5nIHRoZSBmbG93cyB0byBzcGVjaWZpYyBzb2NrZXRzIHRoYXQgYXJlDQphZGphY2VudCB0byB0 aGUgUENJIGJ1cyB0aGUgY29udHJvbGxlciBpcyBvbiBhbmQgcG9wdWxhdGluZyB0aGUgbnVtYmVy DQpvZiB0aHJlYWRzIHRvIHVzZSBmb3IgUlNTIGJhc2VkIHVwb24gdGhlIG51bWJlciBvZiBjb3Jl cy90aHJlYWRzIHBlcg0Kc29ja2V0LiAgTmV4dCB0aGUgcXVlc3Rpb25hYmxlOiBJJ20gbm90IHN1 cmUgSSBsaWtlIHRoZSBzcGVjaWZpYw0KaW1wbGVtZW50YXRpb24uICBJdCBwdXRzIGEgbG90IG9m IG5ldywgY29tcGxleCBjb25maWd1cmF0aW9uIG9uIHRoZQ0KYXBwbGljYXRpb24uICBCdXQgdGhl IGJlbmVmaXRzIG9mIHRoaXMgY291bGQgaGF2ZSBhIGRlZmF1bHQgc2V0dGluZw0Kd2l0aG91dCBy ZXF1aXJpbmcgYXBwbGljYXRpb24gaW50ZXJhY3Rpb24uICBJJ20gbm90IHN1cmUgSSB3b3VsZG4n dA0KcHJlZmVyIHNvbWV0aGluZyB0aGF0LCBieSBkZWZhdWx0LCBjcmVhdGVzIGFsbCBuZXcgUVBz IGFuZCBDUXMgc28gdGhhdA0KdGhleSBnbyB0aHJvdWdoIGEgZGVmYXVsdCBoYXNoaW5nIGFuZCBy ZWRpcmVjdGlvbiB3aXRob3V0IGFueSB1c2VyDQppbnRlcmFjdGlvbiBhdCBhbGwuICBPciBtYXli ZSB0aGUgdXNlciBzaW1wbHkgc2V0cyBhIGZsYWcgdG8gc2lnbmFsIHRoYXQNCnRoZXkgYXJlIE9L IHdpdGggbXVsdGl0aHJlYWQgY29tcGxldGlvbiBoYW5kbGluZyBhbmQgdGhleSBnZXQgaXQuICBP cg0Kc29tZXRoaW5nIGxpa2UgdGhhdC4gIE9uIG90aGVyIHdvcmRzLCBJIHdvdWxkIGxpa2UgdG8g c2VlIGFuIGFwcGxpY2F0aW9uDQpnZXQgdGhlIGJlbmVmaXQgb2YgdGhpcyB3aXRob3V0IGhhdmlu ZyB0byBiZSByZWNvZGVkLiAgTWF5YmUgdGhleSBvbmx5DQpnZXQgYSBkZWZhdWx0IGJlbmVmaXQg YW5kIG5vdCBhbiBvcHRpbWl6ZWQgYmVuZWZpdCwgYW5kIG1heWJlIHRoZSB1c2VyDQpoYXMgdG8g c2V0IGFuIGVudmlyb25tZW50IHZhcmlhYmxlIGZvciBsaWJpYnZlcmJzIGJlZm9yZSBpdCBnZXRz IGVuYWJsZWQNCmJ5IGRlZmF1bHQsIGJ1dCBJIHdvdWxkIHN0aWxsIGxpa2UgdG8gc2VlIGEgbm9u LXJlY29tcGlsZWQgYXBwIGJlbmVmaXQNCmZyb20gdGhpcy4gIFRoZSBwcm9wb3NhbCBJIHNlZSBo ZXJlIG1pZ2h0IGJlIGFibGUgdG8gZG8gdGhhdCBpZiB0aGUNCmNoYW5nZXMgdG8gbGliaWJ2ZXJi cyBhcmUgZG9uZSBwcm9wZXJseS4gIEFuZCBpZiB0aGUgaW1wbGVtZW50YXRpb24gaXMNCnJpZ2h0 IGl0IG1pZ2h0IGJlIGFibGUgdG8gaGVscCB0aGUga2VybmVsIGNvbnN1bWVycyB0b28uICBTbywg cGxlYXNlDQprZWVwIHRoZXNlIHRoaW5ncyBpbiBtaW5kIGFzIHlvdSBjb250aW51ZSB0byB3b3Jr IG9uIHRoaXMuDQoNCkFuZCB3aXRoIHRoYXQsIEkndmUgZ290IHRvIGRvIHNvbWUgUmVkIEhhdCB3 b3JrIGZvciBhIGJpdC4gIEkgd29uJ3QgYmUNCmFzIHJlc3BvbnNpdmUgdGhlIGVhcmx5IHBhcnQg b2YgbmV4dCB3ZWVrIGFzIGEgcmVzdWx0Lg0KDQotLSANCkRvdWcgTGVkZm9yZCA8ZGxlZGZvcmRA cmVkaGF0LmNvbT4NCiAgICAgICAgICAgICAgR1BHIEtleUlEOiAwRTU3MkZERA0KDQo= --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html