patch "usb: dwc3: gadget: don't clear EP_BUSY too early" added to usb-next
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: dwc3: gadget: don't clear EP_BUSY too early
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will also be merged in the next major kernel release during the merge window.
If you have any questions about this process, please let me know.
Quoted 1 line
From
e18b7975c885bc3a938b9a76daf32957ea0235faMon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Fri, 29 May 2015 10:06:38 -0500
Subject: usb: dwc3: gadget: don't clear EP_BUSY too early
In case of non-Isochronous transfers, we don't want to clear DWC3_EP_BUSY flag until XferComplete event. That's because XferInProgress was only enabled so we can recycle TRBs and usb_requests quicker, but there are still other pending requests being transferred.
In order to make sure we don't allow for another StartTransfer command while the HW is still processing other transfers, we must keep DWC3_EP_BUSY flag set and this what this patch does.
bulk/interrupt transfers)
--- drivers/usb/dwc3/gadget.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/usb/dwc3/gadget.c +5 -1
@@ -1906,12 +1906,16 @@ static void dwc3_endpoint_transfer_complete(struct dwc3 *dwc, {unsigned status =0 ;int clean_busy; +u32 is_xfer_complete; + + is_xfer_complete = (event->endpoint_event ==DWC3_DEPEVT_XFERCOMPLETE );if (event->status &DEPEVT_STATUS_BUSERR ) status = -ECONNRESET ; clean_busy =dwc3_cleanup_done_reqs (dwc, dep, event, status); -if (clean_busy) +if (clean_busy && (is_xfer_complete || +usb_endpoint_xfer_isoc (dep->endpoint.desc))) dep->flags &= ~DWC3_EP_BUSY ;/*
Signature · 1 line
2.4.2