Skip to contentSkip to conversation

Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree

PATCH [email protected] 2 participants 3 messages Jun 3, 2015

Subsystems (2)
Stable branch XFS filesystem
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

xfs: xfs_iozero can return positive errno

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-xfs_iozero-can-return-positive-errno.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001

From: Dave Chinner <[email protected]>
Date: Fri, 29 May 2015 07:40:32 +1000
Subject: xfs: xfs_iozero can return positive errno

From: Dave Chinner <[email protected]>

commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.

It was missed when we converted everything in XFs to use negative error numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global error sign conversion"), and should go back to stable kernels.

Thanks to Brian Foster for noticing it.

Signed-off-by Dave Chinner <[email protected]>
Reviewed-by Brian Foster <[email protected]>
Signed-off-by Dave Chinner <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 fs/xfs/xfs_file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_file.c +1 -1
@@ -126,7 +126,7 @@ xfs_iozero(
 		status = 0;
 	} while (count);
 
-	return (-status);
+	return status;
 }
 
 /*

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/xfs-xfs_iozero-can-return-positive-errno.patch

#1 lore raw
Quoted 5 lines · On Wed, Jun 03, 2015 at 10:12:55AM +0900, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

xfs: xfs_iozero can return positive errno

Quoted 8 lines

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-xfs_iozero-can-return-positive-errno.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,

No, it shouldn't be applied to 3.14, because:

Quoted 11 lines

From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001
From: Dave Chinner <[email protected]>
Date: Fri, 29 May 2015 07:40:32 +1000
Subject: xfs: xfs_iozero can return positive errno

From: Dave Chinner <[email protected]>

commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.

It was missed when we converted everything in XFs to use negative error numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global

                          ^^^^^^^^^^^^^^^^^^^^^^

The upstream commit also had an indication of what stable kernels it needed to be applied to. i.e:

cc <[email protected]> # 3.17, 3.18, 3.19, 4.0

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
author maintainer
#2 lore raw
Quoted 26 lines · Dave Chinner
Quoted 5 lines · On Wed, Jun 03, 2015 at 10:12:55AM +0900, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

xfs: xfs_iozero can return positive errno

Quoted 8 lines

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-xfs_iozero-can-return-positive-errno.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,

No, it shouldn't be applied to 3.14, because:

Quoted 9 lines

From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001
From: Dave Chinner <[email protected]>
Date: Fri, 29 May 2015 07:40:32 +1000
Subject: xfs: xfs_iozero can return positive errno

From: Dave Chinner <[email protected]>

commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.

Quoted 8 lines
Quoted 2 lines

It was missed when we converted everything in XFs to use negative error numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global

                          ^^^^^^^^^^^^^^^^^^^^^^

The upstream commit also had an indication of what stable kernels it needed to be applied to. i.e:

cc <[email protected]> # 3.17, 3.18, 3.19, 4.0

{sigh} I even read that and for some reason thought it said 3.14...

jet lag sucks, sorry for the noise.

greg k-h