Skip to contentSkip to conversation

Patch "iio: adc: xilinx: Fix VREFN sign" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jun 3, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: xilinx: Fix VREFN sign

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-adc-xilinx-fix-vrefn-sign.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 97ffae1d30c3f6ceee67d5b0d3e540c08c13c744 Mon Sep 17 00:00:00 2001

From: Thomas Betker <[email protected]>
Date: Wed, 15 Apr 2015 21:11:50 +0200
Subject: iio: adc: xilinx: Fix VREFN sign

From: Thomas Betker <[email protected]>

commit 97ffae1d30c3f6ceee67d5b0d3e540c08c13c744 upstream.

The VREFN channel is bipolar, not unipolar. Small negative values do occur (e.g., -1mV), and unsigned conversion maps them incorrectly to large positive values (about +1V), so fix this.

---
 drivers/iio/adc/xilinx-xadc-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/xilinx-xadc-core.c +1 -1
@@ -997,7 +997,7 @@ static const struct iio_event_spec xadc_
 	.num_event_specs = (_alarm) ? ARRAY_SIZE(xadc_voltage_events) : 0, \
 	.scan_index = (_scan_index), \
 	.scan_type = { \
-		.sign = 'u', \
+		.sign = ((_addr) == XADC_REG_VREFN) ? 's' : 'u', \
 		.realbits = 12, \
 		.storagebits = 16, \
 		.shift = 4, \

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/iio-adc-xilinx-fix-register-addresses.patch queue-4.0/iio-adc-xilinx-fix-vccaux-channel-.address.patch queue-4.0/iio-adc-xilinx-fix-vrefp-scale.patch queue-4.0/iio-adc-xilinx-fix-vrefn-sign.patch