Skip to contentSkip to conversation

ltp: vma03 fix the alginment of page size

LTP cdong 2 participants 2 messages Jun 3, 2015

lore
Share & tools
lore

cdong

author
#0 lore raw

Hi,
There is a patch to fix vma03 test case,the below information is
detail it:

the offset the parameter of mmap2() doesn't align the page
size,but,this parameter
allow must be a multiple of the page size as returned by
sysconf(_SC_PAGE_SIZE).
meanwhile offset * 4096 must be a multiple of the system page
size,so modify

       the input param of offset pgoff = (ULONG_MAX - 1)&(~((pgsz-1)>>12));

    Regards,
    Apollo

From 6e60e9d4f27d36cdd369e7d7a046da49e3f17fd6 Mon Sep 17 00:00:00 2001
From: Chuang Dong <[email protected]>
Date: Wed, 3 Jun 2015 13:27:53 +0800
Subject: [PATCH] ltp: vma03 fix the alginment of page size

the offset the param of mmap2() doesn't align the page size,but, this param allow must be a multiple of the page size as returned by sysconf(_SC_PAGE_SIZE).meanwhile offset * 4096 must be a multiple of the system page size,so modify the input param of offset pgoff = (ULONG_MAX - 1)&(~((pgsz-1)>>12));

Upstream-Status: Submitted

---
 testcases/kernel/mem/vma/vma03.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/mem/vma/vma03.c +1 -1
index ad8a7b4..a539233 100644
@@ -85,7 +85,7 @@ int main(int argc, char *argv[])
 		if (fd == -1)
 			tst_brkm(TBROK | TERRNO, NULL, "open %s", TESTFILE);
 
-		pgoff = ULONG_MAX - 1;
+		pgoff = (ULONG_MAX - 1)&(~((pgsz-1)>>12));
 		map = mmap2(NULL, pgsz, PROT_READ | PROT_WRITE, MAP_PRIVATE,
 			    fd, pgoff);
 		if (map == MAP_FAILED)
Signature · 1 line
1.8.5.2.233.g932f7e4

------------------------------------------------------------------------------

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

Hi,
Maybe you had to fix your typo in commit message. You can using 'set spell' to check it before pushing it.

Regards,
Wei

Quoted 14 lines · cdong

Hi,
There is a patch to fix vma03 test case,the below information is
detail it:

the offset the parameter of mmap2() doesn't align the page
size,but,this parameter
allow must be a multiple of the page size as returned by
sysconf(_SC_PAGE_SIZE).
meanwhile offset * 4096 must be a multiple of the system page
size,so modify

        the input param of offset pgoff = (ULONG_MAX - 1)&(~((pgsz-1)>>12));

     Regards,
     Apollo
Quoted 5 lines

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list