drm/i915/bxt: fix DDI PHY vswing scale value setting
Subsystems (2)
PATCH 1/1 drm/i915/bxt: fix DDI PHY vswing scale value setting
According to bspec the DDI PHY vswing scale value is "don't care" in case the scale enable bit [27] is clear. But this doesn't seem to be correct. The scale value seems to also matter if the scale mode bit
[26] is set. So both bit 26 and 27 depend on the value. Setting the scale value to 0 while either bit is set results in a failed modeset on HDMI (sink reports no signal).
After reset the scale value is 0x98, but according to the spec we have to program it to 0x9a. So for consistency program it always to 0x9a regardless of the scale enable bit.
--- drivers/gpu/drm/i915/intel_ddi.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +18 -18
@@ -181,15 +181,15 @@ struct bxt_ddi_buf_trans {*/ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {/* Idx NT mV diff db */ - {52 ,0 ,0 ,128 , true },/* 0: 400 0 */ - {78 ,0 ,0 ,85 , false },/* 1: 400 3.5 */ - {104 ,0 ,0 ,64 , false },/* 2: 400 6 */ - {154 ,0 ,0 ,43 , false },/* 3: 400 9.5 */ - {77 ,0 ,0 ,128 , false },/* 4: 600 0 */ - {116 ,0 ,0 ,85 , false },/* 5: 600 3.5 */ - {154 ,0 ,0 ,64 , false },/* 6: 600 6 */ - {102 ,0 ,0 ,128 , false },/* 7: 800 0 */ - {154 ,0 ,0 ,85 , false },/* 8: 800 3.5 */ + {52 ,0x9A ,0 ,128 , true },/* 0: 400 0 */ + {78 ,0x9A ,0 ,85 , false },/* 1: 400 3.5 */ + {104 ,0x9A ,0 ,64 , false },/* 2: 400 6 */ + {154 ,0x9A ,0 ,43 , false },/* 3: 400 9.5 */ + {77 ,0x9A ,0 ,128 , false },/* 4: 600 0 */ + {116 ,0x9A ,0 ,85 , false },/* 5: 600 3.5 */ + {154 ,0x9A ,0 ,64 , false },/* 6: 600 6 */ + {102 ,0x9A ,0 ,128 , false },/* 7: 800 0 */ + {154 ,0x9A ,0 ,85 , false },/* 8: 800 3.5 */ {154 ,0x9A ,1 ,128 , false },/* 9: 1200 0 */ };
@@ -198,15 +198,15 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {*/ static const struct bxt_ddi_buf_trans bxt_ddi_translations_hdmi[] = {/* Idx NT mV diff db */ - {52 ,0 ,0 ,128 , false },/* 0: 400 0 */ - {52 ,0 ,0 ,85 , false },/* 1: 400 3.5 */ - {52 ,0 ,0 ,64 , false },/* 2: 400 6 */ - {42 ,0 ,0 ,43 , false },/* 3: 400 9.5 */ - {77 ,0 ,0 ,128 , false },/* 4: 600 0 */ - {77 ,0 ,0 ,85 , false },/* 5: 600 3.5 */ - {77 ,0 ,0 ,64 , false },/* 6: 600 6 */ - {102 ,0 ,0 ,128 , false },/* 7: 800 0 */ - {102 ,0 ,0 ,85 , false },/* 8: 800 3.5 */ + {52 ,0x9A ,0 ,128 , false },/* 0: 400 0 */ + {52 ,0x9A ,0 ,85 , false },/* 1: 400 3.5 */ + {52 ,0x9A ,0 ,64 , false },/* 2: 400 6 */ + {42 ,0x9A ,0 ,43 , false },/* 3: 400 9.5 */ + {77 ,0x9A ,0 ,128 , false },/* 4: 600 0 */ + {77 ,0x9A ,0 ,85 , false },/* 5: 600 3.5 */ + {77 ,0x9A ,0 ,64 , false },/* 6: 600 6 */ + {102 ,0x9A ,0 ,128 , false },/* 7: 800 0 */ + {102 ,0x9A ,0 ,85 , false },/* 8: 800 3.5 */ {154 ,0x9A ,1 ,128 , true },/* 9: 1200 0 */ };
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6535 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 270/270 270/270 ILK 303/303 303/303 SNB 312/312 312/312 IVB 343/343 343/343 BYT 287/287 287/287 BDW 318/318 318/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Imre Deak
According to bspec the DDI PHY vswing scale value is "don't care" in case the scale enable bit [27] is clear. But this doesn't seem to be correct. The scale value seems to also matter if the scale mode bit
[26] is set. So both bit 26 and 27 depend on the value. Setting the scale value to 0 while either bit is set results in a failed modeset on HDMI (sink reports no signal).
Quoted 5 lines
After reset the scale value is
0x98, but according to the spec we have to program it to0x9a. So for consistency program it always to0x9aregardless of the scale enable bit.Signed-off-by Imre Deak <[email protected]>
This patch successfully enables HDMI display for my team.
Quoted 65 lines
--- drivers/gpu/drm/i915/intel_ddi.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +18
-18@@ -181,15 +181,15 @@ struct bxt_ddi_buf_trans {*/ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {/* Idx NT mV diff db */ - {52 ,0 ,0 ,128 , true },/* 0: 400 0 */ - {78 ,0 ,0 ,85 , false },/* 1: 400 3.5 */ - {104 ,0 ,0 ,64 , false },/* 2: 400 6 */ - {154 ,0 ,0 ,43 , false },/* 3: 400 9.5 */ - {77 ,0 ,0 ,128 , false },/* 4: 600 0 */ - {116 ,0 ,0 ,85 , false },/* 5: 600 3.5 */ - {154 ,0 ,0 ,64 , false },/* 6: 600 6 */ - {102 ,0 ,0 ,128 , false },/* 7: 800 0 */ - {154 ,0 ,0 ,85 , false },/* 8: 800 3.5 */ + {52 ,0x9A ,0 ,128 , true },/* 0: 400 0 */ + {78 ,0x9A ,0 ,85 , false },/* 1: 400 3.5 */ + {104 ,0x9A ,0 ,64 , false },/* 2: 400 6 */ + {154 ,0x9A ,0 ,43 , false },/* 3: 400 9.5 */ + {77 ,0x9A ,0 ,128 , false },/* 4: 600 0 */ + {116 ,0x9A ,0 ,85 , false },/* 5: 600 3.5 */ + {154 ,0x9A ,0 ,64 , false },/* 6: 600 6 */ + {102 ,0x9A ,0 ,128 , false },/* 7: 800 0 */ + {154 ,0x9A ,0 ,85 , false },/* 8: 800 3.5 */ {154 ,0x9A ,1 ,128 , false },/* 9: 1200 0 */ };@@ -198,15 +198,15 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {*/ static const struct bxt_ddi_buf_trans bxt_ddi_translations_hdmi[] = {/* Idx NT mV diff db */ - {52 ,0 ,0 ,128 , false },/* 0: 400 0 */ - {52 ,0 ,0 ,85 , false },/* 1: 400 3.5 */ - {52 ,0 ,0 ,64 , false },/* 2: 400 6 */ - {42 ,0 ,0 ,43 , false },/* 3: 400 9.5 */ - {77 ,0 ,0 ,128 , false },/* 4: 600 0 */ - {77 ,0 ,0 ,85 , false },/* 5: 600 3.5 */ - {77 ,0 ,0 ,64 , false },/* 6: 600 6 */ - {102 ,0 ,0 ,128 , false },/* 7: 800 0 */ - {102 ,0 ,0 ,85 , false },/* 8: 800 3.5 */ + {52 ,0x9A ,0 ,128 , false },/* 0: 400 0 */ + {52 ,0x9A ,0 ,85 , false },/* 1: 400 3.5 */ + {52 ,0x9A ,0 ,64 , false },/* 2: 400 6 */ + {42 ,0x9A ,0 ,43 , false },/* 3: 400 9.5 */ + {77 ,0x9A ,0 ,128 , false },/* 4: 600 0 */ + {77 ,0x9A ,0 ,85 , false },/* 5: 600 3.5 */ + {77 ,0x9A ,0 ,64 , false },/* 6: 600 6 */ + {102 ,0x9A ,0 ,128 , false },/* 7: 800 0 */ + {102 ,0x9A ,0 ,85 , false },/* 8: 800 3.5 */ {154 ,0x9A ,1 ,128 , true },/* 9: 1200 0 */ };Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Damien Lespiau
Acked-byQuoted 12 lines · Matt Roper
Quoted 11 lines · Imre Deak
According to bspec the DDI PHY vswing scale value is "don't care" in case the scale enable bit [27] is clear. But this doesn't seem to be correct. The scale value seems to also matter if the scale mode bit
[26] is set. So both bit 26 and 27 depend on the value. Setting the scale value to 0 while either bit is set results in a failed modeset on HDMI (sink reports no signal).After reset the scale value is
0x98, but according to the spec we have to program it to0x9a. So for consistency program it always to0x9aregardless of the scale enable bit.
Quoted 5 lines
Quoted 1 line
Signed-off-by Imre Deak <[email protected]>This patch successfully enables HDMI display for my team.
Tested-by Matt Roper <[email protected]>
I believe this should be enough of a good reason for merging at this stage.
Signature · 5 lines
Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 15 lines · Damien Lespiau
Quoted 14 lines · Matt Roper
Quoted 12 lines · Imre Deak
According to bspec the DDI PHY vswing scale value is "don't care" in case the scale enable bit [27] is clear. But this doesn't seem to be correct. The scale value seems to also matter if the scale mode bit
[26] is set. So both bit 26 and 27 depend on the value. Setting the scale value to 0 while either bit is set results in a failed modeset on HDMI (sink reports no signal).After reset the scale value is
0x98, but according to the spec we have to program it to0x9a. So for consistency program it always to0x9aregardless of the scale enable bit.Signed-off-by Imre Deak <[email protected]>
Quoted 8 lines
Quoted 3 lines
This patch successfully enables HDMI display for my team.
Tested-by Matt Roper <[email protected]>I believe this should be enough of a good reason for merging at this stage.
Acked-by Damien Lespiau <[email protected]>
Pushed to drm-intel-next-queued, thanks for the patch and testing/ack.
BR,
Jani.
Quoted 7 lines
Signature · 6 lines
-- Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx