wic: Move validation of --ptable option to wks parser

PATCH New Ed Bartosh 1 participant 1 message Jun 5, 2015

Share & tools

Ed Bartosh

author

2015-06-05 11:47 UTC #0 lore raw

PATCH 1/1 wic: Move validation of --ptable option to wks parser

bootloader --ptable option has two valid choices: gpt and msdos Moved this check to wks parser by changing option type to 'choice'.

Removed similar checks from 5 other places.

Signed-off-by Ed Bartosh <[email protected]>

---
 scripts/lib/wic/kickstart/custom_commands/micboot.py |  3 ++-
 scripts/lib/wic/plugins/source/bootimg-efi.py        | 15 ++-------------
 scripts/lib/wic/plugins/source/bootimg-pcbios.py     |  8 ++------
 scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py  |  8 ++------
 scripts/lib/wic/utils/partitionedfs.py               |  4 ----
 5 files changed, 8 insertions(+), 30 deletions(-)

scripts/lib/wic/kickstart/custom_commands/micboot.py +2 -1

index d162142..358b0ea 100644
@@ -44,6 +44,7 @@ class Mic_Bootloader(F8_Bootloader):
     def _getParser(self):
         op = F8_Bootloader._getParser(self)
         op.add_option("--menus", dest="menus")
-        op.add_option("--ptable", dest="ptable", type="string")
+        op.add_option("--ptable", dest="ptable", choices=("msdos", "gpt"),
+                      default="msdos")
         return op

scripts/lib/wic/plugins/source/bootimg-efi.py +2 ~~-13~~

index 39ce9f3..d3b8468 100644
@@ -60,13 +60,8 @@ class BootimgEFIPlugin(SourcePlugin):
 
         kernel = "/bzImage"
 
-        if cr.ptable_format in ('msdos', 'gpt'):
-            rootstr = cr.rootdev
-        else:
-            raise ImageError("Unsupported partition table format found")
-
         grubefi_conf += "linux %s root=%s rootwait %s\n" \
-            % (kernel, rootstr, options)
+            % (kernel, cr.rootdev, options)
         grubefi_conf += "}\n"
 
         msger.debug("Writing grubefi config %s/hdd/boot/EFI/BOOT/grub.cfg" \

@@ -104,16 +99,10 @@ class BootimgEFIPlugin(SourcePlugin):
 
         kernel = "/bzImage"
 
-        if cr.ptable_format in ('msdos', 'gpt'):
-            rootstr = cr.rootdev
-        else:
-            raise ImageError("Unsupported partition table format found")
-
         boot_conf = ""
         boot_conf += "title boot\n"
         boot_conf += "linux %s\n" % kernel
-        boot_conf += "options LABEL=Boot root=%s %s\n" \
-            % (rootstr, options)
+        boot_conf += "options LABEL=Boot root=%s %s\n" % (cr.rootdev, options)
 
         msger.debug("Writing gummiboot config %s/hdd/boot/loader/entries/boot.conf" \
                         % cr_workdir)

scripts/lib/wic/plugins/source/bootimg-pcbios.py +2 -6

index dd49480..5caffbc 100644
@@ -103,12 +103,8 @@ class BootimgPcbiosPlugin(SourcePlugin):
         kernel = "/vmlinuz"
         syslinux_conf += "KERNEL " + kernel + "\n"
 
-        if cr.ptable_format in ('msdos', 'gpt'):
-            rootstr = cr.rootdev
-        else:
-            raise ImageError("Unsupported partition table format found")
-
-        syslinux_conf += "APPEND label=boot root=%s %s\n" % (rootstr, options)
+        syslinux_conf += "APPEND label=boot root=%s %s\n" % \
+                             (cr.rootdev, options)
 
         msger.debug("Writing syslinux config %s/hdd/boot/syslinux.cfg" \
                     % cr_workdir)

scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py +2 -6

index 90dac05..533eaa7 100644
@@ -100,12 +100,8 @@ class RootfsPlugin(SourcePlugin):
         syslinux_conf += "LABEL linux\n"
         syslinux_conf += "  KERNEL /boot/bzImage\n"
 
-        if image_creator.ptable_format in ('msdos', 'gpt'):
-            rootstr = image_creator.rootdev
-        else:
-            raise ImageError("Unsupported partition table format found")
-
-        syslinux_conf += "  APPEND label=boot root=%s %s\n" % (rootstr, options)
+        syslinux_conf += "  APPEND label=boot root=%s %s\n" % \
+                             (image_creator.rootdev, options)
 
         syslinux_cfg = os.path.join(image_creator.rootfs_dir['ROOTFS_DIR'], "boot", "syslinux.cfg")
         msger.debug("Writing syslinux config %s" % syslinux_cfg)

scripts/lib/wic/utils/partitionedfs.py +0 -4

index 1eb1f01..e093ec5 100644
@@ -122,10 +122,6 @@ class Image(object):
 
         msger.debug("Assigning %s partitions to disks" % ptable_format)
 
-        if ptable_format not in ('msdos', 'gpt'):
-            raise ImageError("Unknown partition table format '%s', supported " \
-                             "formats are: 'msdos'" % ptable_format)
-
         if self._partitions_layed_out:
             return

Signature · 1 line

2.1.4