Skip to contentSkip to conversation

tile: add init.h to usb.c to avoid compile failure

PATCH In review Paul Gortmaker 2 participants 3 messages Jun 5, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tile: add init.h to usb.c to avoid compile failure

Pending header cleanups will reveal this file is using the init.h content implicitly with the following fail:

arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall' arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used

Explicitly add init.h to get arch_initcall and avoid this.

---

[adding this to the header move series of commits; see
https://lkml.kernel.org/r/[email protected]
for original series posting. ]

 arch/tile/kernel/usb.c | 1 +
 1 file changed, 1 insertion(+)
arch/tile/kernel/usb.c +1 -0
index 5af8debc6a71..f0da5a237e94 100644
@@ -21,6 +21,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/platform_device.h>
 #include <linux/usb/tilegx.h>
+#include <linux/init.h>
 #include <linux/types.h>
 
 static u64 ehci_dmamask = DMA_BIT_MASK(32);
Signature · 1 line
2.2.1
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Paul Gortmaker

Pending header cleanups will reveal this file is using the init.h content implicitly with the following fail:

arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall' arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used

Explicitly add init.h to get arch_initcall and avoid this.

Quoted 8 lines

---

[adding this to the header move series of commits; see
https://lkml.kernel.org/r/[email protected]
for original series posting. ]

  arch/tile/kernel/usb.c | 1 +
  1 file changed, 1 insertion(+)

or I'm happy to take it into the tile tree if you'd rather I did.

Signature · 2 lines
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
#2 lore raw
Quoted 20 lines · Chris Metcalf
Quoted 19 lines · Paul Gortmaker

Pending header cleanups will reveal this file is using the init.h content implicitly with the following fail:

arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default] arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall' arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default] arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used

Explicitly add init.h to get arch_initcall and avoid this.

---

[adding this to the header move series of commits; see
https://lkml.kernel.org/r/[email protected]
for original series posting. ]

Quoted 6 lines
Quoted 2 lines
  arch/tile/kernel/usb.c | 1 +
  1 file changed, 1 insertion(+)

or I'm happy to take it into the tile tree if you'd rather I did.

Thanks, I'll carry it since I'd risk introducing bisection failures if my header changes go in without this being present 1st.

Paul.