Skip to contentSkip to conversation

Bananapi: Fix ethernet device initialization

PATCH New Maxin B. John 2 participants 3 messages Jun 7, 2015

Subsystems (2)
Arm (32-bit) Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Maxin B. John

author
#0 lore raw

PATCH 1/1 Bananapi: Fix ethernet device initialization

Ethernet device initialization fails with the following message:
Net: PH: dir_output: error: gpio PH23 not reserved
Phy 1 not found
PHY reset timed out
eth0: ethernet at 01c50000

Tested on Banana Pi board.

Signed-off-by Maxin B. John <[email protected]>
---
 arch/arm/cpu/armv7/sunxi/board.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/sunxi/board.c +1 -0
index a82c8b9..030a711 100644
@@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
 	__maybe_unused int rc;
 
 #ifdef CONFIG_MACPWR
+	gpio_request(CONFIG_MACPWR, "MAC Power");
 	gpio_direction_output(CONFIG_MACPWR, 1);
 	mdelay(200);
 #endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Bananapi: Fix ethernet device initialization

Hi,

Quoted 18 lines

Ethernet device initialization fails with the following message:
Net: PH: dir_output: error: gpio PH23 not reserved
Phy 1 not found
PHY reset timed out
eth0: ethernet at 01c50000

Tested on Banana Pi board.

Signed-off-by Maxin B. John <[email protected]>
---
 arch/arm/cpu/armv7/sunxi/board.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/sunxi/board.c +0 -0
index a82c8b9..030a711 100644

arch/arm/cpu/armv7/sunxi/board.c int cpu_eth_init(bd_t *bis) · line 226

Quoted 4 lines
arch/arm/cpu/armv7/sunxi/board.c +1 -0
@@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
 	__maybe_unused int rc;
 
 #ifdef CONFIG_MACPWR
+	gpio_request(CONFIG_MACPWR, "MAC Power");

I suggest using the string "macpwr" instead to be consistent with:
board/sunxi/ahci.c: gpio_request(CONFIG_SATAPWR, "satapwr");

Good find otherwise!

arch/arm/cpu/armv7/sunxi/board.c int cpu_eth_init(bd_t *bis) · line 229

Quoted 3 lines
arch/arm/cpu/armv7/sunxi/board.c +0 -0
 	gpio_direction_output(CONFIG_MACPWR, 1);
 	mdelay(200);
 #endif

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150607/1198ba0c/attachment.sig>

author
#2 lore raw

PATCH 1/1 Bananapi: Fix ethernet device initialization

Hi Paul,

Quoted 22 lines · Paul Kocialkowski

Hi,

Quoted 20 lines

Ethernet device initialization fails with the following message:
Net: PH: dir_output: error: gpio PH23 not reserved
Phy 1 not found
PHY reset timed out
eth0: ethernet at 01c50000

Tested on Banana Pi board.

Signed-off-by Maxin B. John <[email protected]>
---
 arch/arm/cpu/armv7/sunxi/board.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/cpu/armv7/sunxi/board.c +0 -0
index a82c8b9..030a711 100644
@@ -223,6 +223,7 @@ int cpu_eth_init(bd_t *bis)
 	__maybe_unused int rc;
Quoted 7 lines

arch/arm/cpu/armv7/sunxi/board.c int cpu_eth_init(bd_t *bis) · line 226

Quoted 2 lines
arch/arm/cpu/armv7/sunxi/board.c +1 -0
 #ifdef CONFIG_MACPWR
+	gpio_request(CONFIG_MACPWR, "MAC Power");

I suggest using the string "macpwr" instead to be consistent with:
board/sunxi/ahci.c: gpio_request(CONFIG_SATAPWR, "satapwr");

Good find otherwise!

Thanks for the comments. Will send a v2 soon.

Quoted 3 lines

arch/arm/cpu/armv7/sunxi/board.c int cpu_eth_init(bd_t *bis) · line 229

Quoted 3 lines
arch/arm/cpu/armv7/sunxi/board.c +0 -0
 	gpio_direction_output(CONFIG_MACPWR, 1);
 	mdelay(200);
 #endif

Best Regards,
Maxin