Skip to contentSkip to conversation

drm/panel: add lg4573 driver

PATCH In review Heiko Schocher 2 participants 3 messages Jun 9, 2015 – Aug 14, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/panel: add lg4573 driver

Add support for LG LG4573 480x800 4,3" panel. the LG4573 is used on the LG LCD LB043WV2-SD01, an industrial 4.3" TFT panel with SPI control interface.

---

Changes in v2:
- add comments from Thierry Reding:
- fix some spelling issues
- remove "power-on-delay"
- remove display timings usage from DT, instead specify the timing in the driver.
- change config symbol to DRM_PANEL_LG_LG4573
- change filename to panel-lg-lg4573.c
- get rid of power_on_delay
- use cpu_to_be16()
- rework lg4573_spi_write_u16_array()
- introduce lg4573_spi_write_dcs()
- reworked error reporting

 .../devicetree/bindings/panel/lg,lg4573.txt        |  19 +
 drivers/gpu/drm/panel/Kconfig                      |   8 +
 drivers/gpu/drm/panel/Makefile                     |   1 +
 drivers/gpu/drm/panel/panel-lg-lg4573.c            | 382 +++++++++++++++++++++
 4 files changed, 410 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/panel/lg,lg4573.txt
 create mode 100644 drivers/gpu/drm/panel/panel-lg-lg4573.c
Documentation/devicetree/bindings/panel/lg,lg4573.txt new file +19 -0
new file mode 100644
index 0000000..824441f
@@ -0,0 +1,19 @@
+LG LG4573 TFT Liquid Crystal Display with SPI control bus
+
+Required properties:
+  - compatible: "lg,lg4573"
+  - reg: address of the panel on the SPI bus
+
+The panel must obey rules for SPI slave device specified in document [1].
+
+[1]: Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+
+	lcd_panel: display@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "lg,lg4573";
+		spi-max-frequency = <10000000>;
+		reg = <0>;
+	};
drivers/gpu/drm/panel/Kconfig +8 -0
index 6d64c7b..e7a4d16 100644
@@ -23,6 +23,14 @@ config DRM_PANEL_LD9040
 	depends on OF && SPI
 	select VIDEOMODE_HELPERS
 
+config DRM_PANEL_LG_LG4573
+	tristate "LG4573 RGB/SPI panel"
+	depends on OF && SPI
+	select VIDEOMODE_HELPERS
+	help
+	  Say Y here if you want to enable support for LG4573 RGB panel.
+	  To compile this driver as a module, choose M here.
+
 config DRM_PANEL_S6E8AA0
 	tristate "S6E8AA0 DSI video mode panel"
 	depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
index 4b2a043..437e8bf 100644
@@ -1,4 +1,5 @@
 obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
 obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o
+obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
 obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o
 obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o
drivers/gpu/drm/panel/panel-lg-lg4573.c new file +382 -0

382 lines not on this page · raw message

Signature · 6 lines
2.1.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 22 lines · Heiko Schocher

Add support for LG LG4573 480x800 4,3" panel. the LG4573 is used on the LG LCD LB043WV2-SD01, an industrial 4.3" TFT panel with SPI control interface.

---

Changes in v2:
- add comments from Thierry Reding:
- fix some spelling issues
- remove "power-on-delay"
- remove display timings usage from DT, instead specify the timing in the driver.
- change config symbol to DRM_PANEL_LG_LG4573
- change filename to panel-lg-lg4573.c
- get rid of power_on_delay
- use cpu_to_be16()
- rework lg4573_spi_write_u16_array()
- introduce lg4573_spi_write_dcs()
- reworked error reporting

Quoted 7 lines
 .../devicetree/bindings/panel/lg,lg4573.txt        |  19 +
 drivers/gpu/drm/panel/Kconfig                      |   8 +
 drivers/gpu/drm/panel/Makefile                     |   1 +
 drivers/gpu/drm/panel/panel-lg-lg4573.c            | 382 +++++++++++++++++++++
 4 files changed, 410 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/panel/lg,lg4573.txt
 create mode 100644 drivers/gpu/drm/panel/panel-lg-lg4573.c

There were a couple of review comments that you missed, but I've addressed them while applying. Might be good to give it[0] a spin just to make sure I didn't accidentally break anything.

Thierry

[0]: git://anongit.freedesktop.org/tegra/linux#drm/panel/for-next

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Hello Thierry,

Am 13.08.2015 um 14:59 schrieb Thierry Reding:

Quoted 31 lines · Heiko Schocher
Quoted 22 lines

Add support for LG LG4573 480x800 4,3" panel. the LG4573 is used on the LG LCD LB043WV2-SD01, an industrial 4.3" TFT panel with SPI control interface.

---

Changes in v2:
- add comments from Thierry Reding:
- fix some spelling issues
- remove "power-on-delay"
- remove display timings usage from DT, instead specify the timing in the driver.
- change config symbol to DRM_PANEL_LG_LG4573
- change filename to panel-lg-lg4573.c
- get rid of power_on_delay
- use cpu_to_be16()
- rework lg4573_spi_write_u16_array()
- introduce lg4573_spi_write_dcs()
- reworked error reporting

Quoted 7 lines
  .../devicetree/bindings/panel/lg,lg4573.txt        |  19 +
  drivers/gpu/drm/panel/Kconfig                      |   8 +
  drivers/gpu/drm/panel/Makefile                     |   1 +
  drivers/gpu/drm/panel/panel-lg-lg4573.c            | 382 +++++++++++++++++++++
  4 files changed, 410 insertions(+)

create mode 100644 Documentation/devicetree/bindings/panel/lg,lg4573.txt create mode 100644 drivers/gpu/drm/panel/panel-lg-lg4573.c

Quoted 1 line

There were a couple of review comments that you missed, but I've

Hups ... It seems I missed them :-(

Quoted 2 lines

addressed them while applying. Might be good to give it[0] a spin just to make sure I didn't accidentally break anything.

Uh, thank you! Just tested it on the aristainetos2 board, works fine.

bye,
Heiko

Quoted 5 lines

Thierry

[0]: git://anongit.freedesktop.org/tegra/linux#drm/panel/for-next

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany