Skip to contentSkip to conversation

ARM: Fix build if CLKDEV_LOOKUP is not configured

PATCH Superseded Guenter Roeck 2 participants 2 messages Jun 14, 2015 – Jun 15, 2015 Clocksource, clockevent drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Fix build if CLKDEV_LOOKUP is not configured

mips:allmodconfig fails to build with

drivers/clocksource/timer-sp804.c:
In function '__sp804_clocksource_and_sched_clock_init':
drivers/clocksource/timer-sp804.c:88:3: error:
implicit declaration of function 'clk_get_sys'

because CLKDEV_LOOKUP is not configured and the driver depends on it.

Fixes 0b7402dce445 ("ARM: 8366/1: move Dual-Timer SP804 driver to

drivers/clocksource")

---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/Kconfig +1 -1
index 60d7d3d204d3..d2a26f1f30e9 100644
@@ -144,7 +144,7 @@ config ARM_GLOBAL_TIMER
 
 config ARM_TIMER_SP804
 	bool "Support for Dual Timer SP804 module"
-	depends on GENERIC_SCHED_CLOCK
+	depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
 	select CLKSRC_MMIO
 	select CLKSRC_OF if OF
 
Signature · 1 line
2.1.0
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Guenter Roeck

mips:allmodconfig fails to build with

drivers/clocksource/timer-sp804.c:
In function '__sp804_clocksource_and_sched_clock_init':
drivers/clocksource/timer-sp804.c:88:3: error:
implicit declaration of function 'clk_get_sys'

because CLKDEV_LOOKUP is not configured and the driver depends on it.

Thanks for the fix and sorry for missing this.

Quoted 3 lines
Fixes 0b7402dce445 ("ARM: 8366/1: move Dual-Timer SP804 driver to

drivers/clocksource")
Cc: Sudeep Holla <[email protected]>

Looks good to me, but I think it should go via RMK tree as other changes are going through that.

Regards,
Sudeep