checkpatch: Emit "NOTE: <types>" message only once after multiple files

PATCH New Joe Perches 1 participant 1 message Jun 17, 2015 Checkpatch

Share & tools

Joe Perches

author maintainer

2015-06-17 17:08 UTC #0 lore raw

PATCH 1/1 checkpatch: Emit "NOTE: <types>" message only once after multiple files

Make this message similar to the "false positives" message and emit it only once when scanning multiple files instead of after each file scanned.

Signed-off-by Joe Perches <[email protected]>

---
 scripts/checkpatch.pl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

scripts/checkpatch.pl +4 -4

index 69c4716..cb896a5 100755
@@ -203,7 +203,7 @@ sub hash_save_array_words {
 sub hash_show_words {
 	my ($hashRef, $prefix) = @_;
 
-	if ($quiet == 0 && keys %$hashRef) {
+	if (keys %$hashRef) {
 		print "\nNOTE: $prefix message types:";
 		foreach my $word (sort keys %$hashRef) {
 			print " $word";

@@ -770,6 +770,9 @@ for my $filename (@ARGV) {
 }
 
 if (!$quiet) {
+	hash_show_words(\%use_type, "Used");
+	hash_show_words(\%ignore_type, "Ignored");
+
 	if ($^V lt 5.10.0) {
 		print << "EOM"

@@ -5644,9 +5647,6 @@ EOM
 		}
 	}
 
-	hash_show_words(\%use_type, "Used");
-	hash_show_words(\%ignore_type, "Ignored");
-
 	if ($clean == 0 && $fix &&
 	    ("@rawlines" ne "@fixed" ||
 	     $#fixed_inserted >= 0 || $#fixed_deleted >= 0)) {